------------------------------------------------------------ revno: 6278 committer: Miika Komu branch nick: hipl timestamp: Fri 2012-02-03 09:14:23 +0200 message: Removed hipfw unit tests Revision 6258 disabled broken unit tests for 32-bit machines but introduced a dependency to libc. The conflicting unit tests are now simply removed. See also bug id #918374 in launchpad. ------------------------------------------------------------ revno: 6277 committer: Stefan G?tz branch nick: hipl timestamp: Wed 2012-02-01 22:06:33 +0100 message: Simplify check by replacing tr/diff combo with grep invocation. Thanks Diego. ------------------------------------------------------------ revno: 6276 committer: Diego Biurrun branch nick: hipl timestamp: Wed 2012-02-01 18:14:20 +0100 message: autobuild: Do not run make with arbitrary parallelism, try to find a compromise. 'make -j' may start too many jobs and make the build host run out of memory. So limit the load value up to which new jobs will get spawned to '6'. Hopefully this is a good enough compromise between parallelism and load. ------------------------------------------------------------ revno: 6275 committer: Diego Biurrun branch nick: hipl timestamp: Wed 2012-02-01 18:11:40 +0100 message: autobuild: Only clean up scratchbox if the scratchbox directory exists. ------------------------------------------------------------ revno: 6274 committer: Diego Biurrun branch nick: hipl timestamp: Wed 2012-02-01 17:21:28 +0100 message: autobuild: Skip OpenWrt and scratchbox checks if the dirs are not available. Now the autobuilder can more easily be run standalone from a vanilla HIPL Bazaar branch/checkout and will not produce errors if the environment does not have OpenWrt and MAEMO in the expected places. ------------------------------------------------------------ revno: 6273 committer: Diego Biurrun branch nick: hipl timestamp: Wed 2012-02-01 16:35:41 +0100 message: autobuild: Extract email address from Bazaar user ID. ------------------------------------------------------------ revno: 6272 committer: Stefan G?tz branch nick: hipl timestamp: Tue 2012-01-31 23:46:32 +0100 message: Let commit guard apply to all files regardless of extension. ------------------------------------------------------------ revno: 6271 committer: Stefan G?tz branch nick: hipl timestamp: Tue 2012-01-31 23:45:16 +0100 message: Break long comments ------------------------------------------------------------ revno: 6270 committer: Stefan G?tz branch nick: hipl timestamp: Tue 2012-01-31 23:44:55 +0100 message: Fix case of 'Bazaar' ------------------------------------------------------------ revno: 6269 committer: Stefan G?tz branch nick: hipl timestamp: Tue 2012-01-31 23:25:15 +0100 message: Remove GNU-isms ------------------------------------------------------------ revno: 6268 committer: Stefan G?tz branch nick: hipl timestamp: Mon 2012-01-30 19:32:37 +0100 message: Support copyright headers marked as comments by python-style """ comment strings. - support multiple copyright header patterns per file extension - add copyright header pattern that matches """ comment strings in python ------------------------------------------------------------ revno: 6267 committer: Stefan G?tz branch nick: hipl timestamp: Mon 2012-01-30 17:52:48 +0100 message: Match copyright header against 'Aalto' instead of ' Aalto ' because non-blank characters have been found to surround 'Aalto' occasionally. ------------------------------------------------------------ revno: 6266 committer: Miika Komu branch nick: hipl timestamp: Mon 2012-01-30 18:34:04 +0200 message: Added MIT license boilerplate to some of the DNS proxy files The license information was missing from the DNS proxy files developed in the project. Please note that I did not use """ style comments for the copyright because they do not pass the bzr hooks. ------------------------------------------------------------ revno: 6265 committer: Stefan G?tz branch nick: hipl timestamp: Mon 2012-01-30 13:28:31 +0100 message: Revert revno:6263 and mark .commitguard directory as to be distributed ------------------------------------------------------------ revno: 6264 committer: Xin Gu branch nick: hipl timestamp: Mon 2012-01-30 13:29:16 +0200 message: Fix loopback HIP_CLOSE msg HMAC failure bug. The bug happens when client and server use the same HIT (so it is loopback). When client sends HIP_CLOSE message to the server, server always fails to verified the HMAC(close.c::hip_close_check_packet()) because the is_loopback variable in the HA is not set which causes it to use a wrong HMAC key. ------------------------------------------------------------ revno: 6263 committer: Stefan G?tz branch nick: hipl timestamp: Mon 2012-01-30 00:21:49 +0100 message: Do not distribute bazaar plugins and related files. Since the distribution tarball is somewhat orthogonal to using bazaar on the HIPL sources, there seems little point in distributing our HIPL bazaar plugins, except via the bazaar repository. ------------------------------------------------------------ revno: 6262 [merge] committer: Stefan G?tz branch nick: hipl timestamp: Sun 2012-01-29 15:41:50 +0100 message: Merge lp:~stefan.goetz/hipl/commitguard-whitespace ------------------------------------------------------------ revno: 6261 [merge] committer: Stefan G?tz branch nick: hipl timestamp: Sun 2012-01-29 15:36:37 +0100 message: Merge lp:~stefan.goetz/hipl/commitguard ------------------------------------------------------------ revno: 6260 [merge] committer: Stefan G?tz branch nick: hipl timestamp: Wed 2012-01-25 21:45:27 +0100 message: Merge lp:~stefan.goetz/hipl/hidb-db, approved by Rene and Diego ------------------------------------------------------------ revno: 6259 committer: Stefan G?tz branch nick: hipl timestamp: Wed 2012-01-25 17:44:14 +0100 message: Compare host IDs across all address bytes instead of comparing only the first few bytes equal to the width of a pointer. ------------------------------------------------------------ revno: 6258 committer: Miika Komu branch nick: hipl timestamp: Wed 2012-01-25 17:43:54 +0200 message: A bug fix to hipfw unit tests on 32-bit machines Fixed bug id #918374 in launchpad. Now two failing hipfw tests are disabled on 32-bit machines. Tested on both 32-bit and 64-bit machines. ------------------------------------------------------------ revno: 6257 committer: Diego Biurrun branch nick: hipl timestamp: Wed 2012-01-25 11:44:48 +0100 message: Rename nsupdate.pl ---> nsupdate. It's more sensible to leave out the unnecessary language extension from the program name. It does not really add information and would have to be changed in the case the program was rewritten some day. ------------------------------------------------------------ revno: 6256 committer: Diego Biurrun branch nick: hipl timestamp: Tue 2012-01-24 18:46:49 +0100 message: hadb: Vastly simplify match_peer_addr(). ------------------------------------------------------------ revno: 6255 committer: Diego Biurrun branch nick: hipl timestamp: Tue 2012-01-24 17:58:57 +0100 message: packaging: Add dependency of hipdnsproxy on hipd. hipdnsproxy reads etc/hip/hosts, which only exists if hipd is installed. ------------------------------------------------------------ revno: 6254 committer: Diego Biurrun branch nick: hipl timestamp: Tue 2012-01-24 15:58:13 +0100 message: debian: Extend package descriptions. ------------------------------------------------------------ revno: 6253 committer: Diego Biurrun branch nick: hipl timestamp: Tue 2012-01-24 15:57:42 +0100 message: debian: Register HIPL documentation with doc-base. ------------------------------------------------------------ revno: 6252 committer: Diego Biurrun branch nick: hipl timestamp: Tue 2012-01-24 15:49:02 +0100 message: debian: Abort on errors during dnsproxy postinst script. ------------------------------------------------------------ revno: 6251 committer: Diego Biurrun branch nick: hipl timestamp: Tue 2012-01-24 13:45:38 +0100 message: hipd: Fix some typos that the DEB package lintian program complained about. ------------------------------------------------------------ revno: 6250 committer: Diego Biurrun branch nick: hipl timestamp: Tue 2012-01-24 13:42:06 +0100 message: Ignore test/check_hipd unit test executable. ------------------------------------------------------------ revno: 6249 committer: Samuel Richter branch nick: hipl timestamp: Fri 2012-01-20 16:34:21 +0100 message: openwrt packaging: mark configuration files as such Now user changes of these files won't get overwritten by a package reinstall. Indenting the filepaths breaks this. ------------------------------------------------------------ revno: 6248 [merge] committer: Stefan G?tz branch nick: hipl timestamp: Fri 2012-01-20 14:04:37 +0100 message: Clean up internal implementation of HIDB: introduce a dedicated container for local-scope identifiers (LSIs) and use it in the HIDB. ------------------------------------------------------------ revno: 6247 committer: Diego Biurrun branch nick: hipl timestamp: Sun 2012-01-15 16:36:14 +0100 message: cosmetics: Drop some unnecessary end of line backslashes from shell commands. ------------------------------------------------------------ revno: 6246 committer: Diego Biurrun branch nick: hipl timestamp: Sat 2012-01-14 16:29:47 +0100 message: cosmetics: K&R formatting from the freshly improved uncrustify configuration ------------------------------------------------------------ revno: 6245 committer: Diego Biurrun branch nick: hipl timestamp: Sat 2012-01-14 16:27:01 +0100 message: uncrustify: Explicitly mark OpenSSL STACK_OF type wrapper macro as such. Otherwise uncrustify misinterprets pointer declarations involving STACK_OF as multiplications and does not format the code in K&R style. ------------------------------------------------------------ revno: 6244 committer: Miika Komu branch nick: hipl timestamp: Sat 2012-01-14 16:25:14 +0200 message: Updated HACKING on uncrustifying Added an example on how to uncrustify the code manually according to the tip from Diego. ------------------------------------------------------------ revno: 6243 committer: Miika Komu branch nick: hipl timestamp: Sat 2012-01-14 16:20:17 +0200 message: Uncrustified code Cleaned up the code base as tipped by Diego: find . -name \*.[ch] | xargs uncrustify -c .uncrustify-0.57.cfg --no-backup --replace ------------------------------------------------------------ revno: 6242 committer: Miika Komu branch nick: hipl timestamp: Fri 2012-01-13 18:25:15 +0200 message: Uncrustifying code bzr hooks caught a number of slipped files with coding policy violations. Crustified only the files that were a problem on one branch; there's probably more to solve. ------------------------------------------------------------ revno: 6241 committer: Diego Biurrun branch nick: hipl timestamp: Fri 2012-01-13 16:37:21 +0100 message: openwrt: Merge two make invocations during package compilation phase. ------------------------------------------------------------ revno: 6240 committer: Diego Biurrun branch nick: hipl timestamp: Thu 2012-01-12 23:52:28 +0100 message: openwrt: Eliminate hipl-common package clutch. The hipl-common package served no purpose apart from collecting dependencies shared between the hipd and hipfw packages, but no longer contained any files. Sharing settings is better achieved by declaring package defaults. ------------------------------------------------------------ revno: 6239 committer: Diego Biurrun branch nick: hipl timestamp: Thu 2012-01-12 22:43:23 +0100 message: openwrt: Drop redundant --sysconfdir from configure command line. OpenWrt already adds --sysconfdir, so no need to repeat it. ------------------------------------------------------------ revno: 6238 committer: Diego Biurrun branch nick: hipl timestamp: Thu 2012-01-12 21:32:09 +0100 message: openwrt: Run 'make install' instead of 'make install-strip'. No other packages do this as part of the OpenWrt build process, so let us rely on OpenWrt as well to strip binaries for us if deemed appropriate. ------------------------------------------------------------ revno: 6237 committer: Diego Biurrun branch nick: hipl timestamp: Thu 2012-01-12 21:23:53 +0100 message: openwrt: Remove file with list of modules to load for hipd/hipfw at startup. Adding such a file to /etc/modules.d is not the correct way to have kernel modules loaded in OpenWrt, there should be package dependencies on the relevant kernel modules instead. ------------------------------------------------------------ revno: 6236 committer: Diego Biurrun branch nick: hipl timestamp: Thu 2012-01-12 14:05:27 +0100 message: openwrt: No longer add -lz to LIBS in configure run. This was a workaround for some weird issue that no longer occurs in the OpenWrt version we now use. HIPL itself does not use zlib anywhere. ------------------------------------------------------------ revno: 6235 [merge] committer: Diego Biurrun branch nick: hipl timestamp: Tue 2012-01-10 18:53:47 +0100 message: Merge lp:~diego-biurrun/hipl/dead_code into lp:hipl Eliminate some dead code from HIPL. ------------------------------------------------------------ revno: 6234 committer: Diego Biurrun branch nick: hipl timestamp: Fri 2012-01-06 20:20:08 +0100 message: certtools: Refactor configuration file reading functions. Add a filename parameter to the open function to allow reading arbitrary configuration files, drop the "cert" from the name as the functions are general and not just useful for reading certificate configuration files. ------------------------------------------------------------ revno: 6233 committer: Miika Komu branch nick: hipl timestamp: Tue 2012-01-10 15:11:25 +0200 message: Updated manual. Added a note to the manual that AppArmor works well with HIPL (where as SElinux is problematic). ------------------------------------------------------------ revno: 6232 committer: Diego Biurrun branch nick: hipl timestamp: Fri 2012-01-06 17:17:23 +0100 message: certtools: Refactor configuration file opening/reading. Do not load a configuration file again when reading sections, hip_cert_open() takes care of that already. Also amend Doxygen documentation to match. ------------------------------------------------------------ revno: 6231 committer: Diego Biurrun branch nick: hipl timestamp: Fri 2012-01-06 16:15:52 +0100 message: certtools: Clean up error handling; eliminate some HIP_IFELs; whitespace. ------------------------------------------------------------ revno: 6230 committer: Diego Biurrun branch nick: hipl timestamp: Fri 2012-01-06 15:38:54 +0100 message: configfilereader: Move some code and documentation from the .h to the .c file. The moved #defines are only used in the .c file and thus belong there. The large Doxygen documentation block is also more at home in the .c file where the bulk of the rest of the Doxygen documentation is. ------------------------------------------------------------ revno: 6229 committer: Diego Biurrun branch nick: hipl timestamp: Fri 2012-01-06 14:19:09 +0100 message: Fix a bunch of typos. ------------------------------------------------------------ revno: 6228 committer: Diego Biurrun branch nick: hipl timestamp: Thu 2012-01-05 17:50:49 +0100 message: hiprelay: Clean up error handling; drop some HIP_IFELs; fix Doxygen comments. ------------------------------------------------------------ revno: 6227 committer: Diego Biurrun branch nick: hipl timestamp: Thu 2012-01-05 16:56:43 +0100 message: conf: cosmetics - merge some lines, drop parentheses, whitespace ------------------------------------------------------------ revno: 6226 committer: Diego Biurrun branch nick: hipl timestamp: Thu 2012-01-05 16:20:15 +0100 message: nsupdate: Move nsupdate.pl and its config file to a separate directory. Previously the nsupdate configuration file was in the hipd directory where it did not belong. ------------------------------------------------------------ revno: 6225 committer: Diego Biurrun branch nick: hipl timestamp: Thu 2012-01-05 14:44:26 +0100 message: build: Move definition of config file names for hipd and hosts out of config.h. This makes the handling of configuration file names consistent and simplifies the build system. ------------------------------------------------------------ revno: 6224 committer: Diego Biurrun branch nick: hipl timestamp: Thu 2012-01-05 14:34:34 +0100 message: Remove unnecessary NULL checks before freeaddrinfo(). ------------------------------------------------------------ revno: 6223 committer: Diego Biurrun branch nick: hipl timestamp: Wed 2012-01-04 19:44:42 +0100 message: Remove leftover reference to removed HIPL_CONFIG_FILE_EX #define. ------------------------------------------------------------ revno: 6222 committer: Diego Biurrun branch nick: hipl timestamp: Wed 2012-01-04 19:34:11 +0100 message: esp_prot_config: Drop redundant "_config" part of esp_prot_config.conf name. ------------------------------------------------------------ revno: 6221 committer: Diego Biurrun branch nick: hipl timestamp: Wed 2012-01-04 19:25:27 +0100 message: esp_prot_config: Drop pointless esp_prot_ prefix from static function. ------------------------------------------------------------ revno: 6220 committer: Diego Biurrun branch nick: hipl timestamp: Wed 2012-01-04 18:43:42 +0100 message: esp_prot_config: Clean up error handling; eliminate HIP_IFEL. ------------------------------------------------------------ revno: 6219 committer: Diego Biurrun branch nick: hipl timestamp: Wed 2012-01-04 16:56:03 +0100 message: hipfw: Also install configuration file for ESP protection extension. ------------------------------------------------------------ revno: 6218 committer: Diego Biurrun branch nick: hipl timestamp: Wed 2012-01-04 16:30:23 +0100 message: hipfw: Use consistent name for ESP protection extension configuration file. All other configuration files in HIPL use a .conf suffix. ------------------------------------------------------------ revno: 6217 committer: Diego Biurrun branch nick: hipl timestamp: Wed 2012-01-04 15:27:00 +0100 message: autobuild: Discard first line of output from "make doxygen". The first line just consists of the command that Make invokes and should not be considered error output. ------------------------------------------------------------ revno: 6216 committer: Diego Biurrun branch nick: hipl timestamp: Wed 2012-01-04 14:14:15 +0100 message: build: Show gcc warnings for strict aliasing violations. Previously those warnings were suppressed, resulting in more issues being added without anybody noticing. Now the warnings are shown without being made into errors. Development can thus continue normally while the issue remains on the radar and will hopefully be fixed eventually. ------------------------------------------------------------ revno: 6215 committer: David Martin branch nick: hipl_other_stuff timestamp: Wed 2012-01-04 12:09:28 +0100 message: Drop received I1 in state I1_SENT when peer HIT is greater. As demanded in RFC 5201 table 3. This fixes a bug where it was not possible to initiate a successful BEX on two machines with each other at the same time. ------------------------------------------------------------ revno: 6214 committer: Diego Biurrun branch nick: hipl timestamp: Sat 2011-12-31 00:20:44 +0100 message: Replace several instances of pointer type punning by proper union punning. Fixes several warnings that appear without -fno-strict-aliasing in CFLAGS like hipd/hadb.c:133: error: dereferencing type-punned pointer will break strict-aliasing rules ------------------------------------------------------------ revno: 6213 committer: Diego Biurrun branch nick: hipl timestamp: Sat 2011-12-31 00:07:49 +0100 message: Simplify logic in sa_entry_hash() / link_entry_hash() to drop some HIP_IFELs. ------------------------------------------------------------ revno: 6212 committer: Diego Biurrun branch nick: hipl timestamp: Fri 2011-12-30 23:27:46 +0100 message: hipconf: Eliminate HIP_IFEL. ------------------------------------------------------------ revno: 6211 committer: Diego Biurrun branch nick: hipl timestamp: Fri 2011-12-30 23:26:46 +0100 message: cosmetics: Adjust some comment lengths and drop a trailing whitespace character. ------------------------------------------------------------ revno: 6210 committer: Diego Biurrun branch nick: trunk timestamp: Sat 2011-12-31 00:10:46 +0100 message: Update Doxygen of sa_entry_hash() / link_entry_hash() return value. ------------------------------------------------------------ revno: 6209 committer: Diego Biurrun branch nick: hipl timestamp: Fri 2011-12-30 20:17:02 +0100 message: nsupdate.conf: delete trailing whitespace ------------------------------------------------------------ revno: 6208 committer: Diego Biurrun branch nick: hipl timestamp: Thu 2011-12-29 16:45:28 +0100 message: autobuild: Adjust doxygen check after recent changes to 'make doxygen'. The check was discarding stdout, which is where doxygen warnings now appear. ------------------------------------------------------------ revno: 6207 committer: David Martin branch nick: hipl_other_stuff timestamp: Thu 2011-12-29 19:52:56 +0100 message: Remove HIP_IFEL in hip_periodic_maintenance(), always return 0 on success. All the HIP_IFEL does is return an error value -> replace it with proper return statements. One semantic change is in case of more than zero open connections in HIP_STATE_CLOSING. Previously the number of open connections was returned even though the documentation states differently. Return zero now in this case. ------------------------------------------------------------ revno: 6206 [merge] committer: David Martin branch nick: merge-test timestamp: Thu 2011-12-29 18:28:12 +0100 message: Merge lp:~martin-lp/hipl/hipl_retransmissions into trunk. This merge fixes and improves the currently partially broken retransmissions in HIPL. In short: - buffer up to three retransmissions in simple round-robin style -> this does not affect regular management packets during BEX but makes it possible to retransmit the locators of the second UPDATE packet - we remove buffered retransmission based on incoming packets from the peer -> hip_update_retransmissions() in input.c takes care of that -> for example an incoming R1 invalidates or acknowledges our buffered I1 retransmission -> it's the same for UPDATE packets. incoming U2 invalidates buffered U1, and U3 invalidates U2 respectively -> the rationale: if we do not get a response from the peer we can assume our or their packet was lost, so we retransmit. A received packet from the peer acts as acknowledgment and we remove the retransmissions. For this reason R2 and U3 packets do not get buffered for retransmission. Their retransmission is triggered by the peers retransmission of I2 or U2 respectively. Merge proposal: https://code.launchpad.net/~martin-lp/hipl/hipl_retransmissions/+merge/87072 ------------------------------------------------------------ revno: 6205 committer: Diego Biurrun branch nick: hipl timestamp: Wed 2011-12-28 16:52:14 +0100 message: hadb: do not dereference a void* argument to derive memory size to set to zero In file included from /usr/include/string.h:643, from hipd/hadb.c:64: In function ?memset?, inlined from ?lsi_assigned? at hipd/hadb.c:1320, inlined from ?hip_generate_peer_lsi? at hipd/hadb.c:1380: /usr/include/bits/string3.h:86: error: call to __builtin___memset_chk will always overflow destination buffer ------------------------------------------------------------ revno: 6204 committer: Diego Biurrun branch nick: hipl timestamp: Wed 2011-12-28 16:27:57 +0100 message: hipfw: remove some duplicate #defines INDEX_HASH_FN and INDEX_HASH_LENGTH were being doubly defined in the same file. ------------------------------------------------------------ revno: 6203 committer: Diego Biurrun branch nick: hipl timestamp: Fri 2011-12-23 02:00:53 +0100 message: openwrt: Create system configuration directory before installing files there. ------------------------------------------------------------ revno: 6202 committer: Diego Biurrun branch nick: hipl timestamp: Fri 2011-12-23 01:05:03 +0100 message: autobuild: Remove HIPL tarballs in OpenWrt download directory before building. This should ensure that no old tarball is used if several are available after a version bump. Also adjust tarball wildcard name for consistency. ------------------------------------------------------------ revno: 6201 committer: Diego Biurrun branch nick: hipl timestamp: Fri 2011-12-23 01:00:24 +0100 message: autobuild: Remove log.txt in case of error after mailing out its content. ------------------------------------------------------------ revno: 6200 committer: Diego Biurrun branch nick: hipl timestamp: Thu 2011-12-22 23:59:18 +0100 message: autobuild: Properly clean up Scratchbox and host Debian packaging. ------------------------------------------------------------ revno: 6199 committer: David Martin branch nick: hipl_other_stuff timestamp: Wed 2011-12-21 11:54:26 +0100 message: Cosmetics: Remove pointless parentheses and comment in handle_retransmission(). ------------------------------------------------------------ revno: 6198 committer: David Martin branch nick: hipl_other_stuff timestamp: Wed 2011-12-21 11:51:45 +0100 message: Drop pointless (time_t *) cast from handle_retransmission(). ------------------------------------------------------------ revno: 6197 committer: David Martin branch nick: hipl_other_stuff timestamp: Fri 2011-12-16 14:37:33 +0100 message: Remove unused / broken update_state variables. The update_state variables defined in state.h and update.h are initially set but never changed. As a consequence update retransmission are currently broken. Get rid of these variables as a fix is being developed on a different branch. This commit does not change hipd behaviour. ------------------------------------------------------------ revno: 6196 committer: David Martin branch nick: hipl_other_stuff timestamp: Fri 2011-12-16 14:24:08 +0100 message: Cosmetics: uncrustify modules/update/hipd/update.h. ------------------------------------------------------------ revno: 6195 [merge] committer: Fahad Aizaz branch nick: hipl timestamp: Thu 2011-12-15 15:39:33 +0100 message: Merging branch lp:~fahad-aizaz/hipl/hipd-hipfw-conf Removing runtime generation of hipfw configuration file. Thus the code to generate hipfw.conf is removed from the HIP source. Instead a default hipfw configuration file is included with HIP source. To distribute and install hipfw configuration file Makefile.am is also modified. Similar modifications for distribution and installation of hipfw configuration file for other distributions (Debian, RPM and OpenWRT) are also incorporated. ------------------------------------------------------------ revno: 6194 committer: Henrik Ziegeldorf branch nick: hipl-vanilla timestamp: Thu 2011-12-15 09:57:23 +0100 message: Act on error return values of registered packet handlers. ------------------------------------------------------------ revno: 6193 committer: Henrik Ziegeldorf branch nick: hipl-vanilla timestamp: Thu 2011-12-15 09:52:48 +0100 message: Alphabetical order of includes. ------------------------------------------------------------ revno: 6192 [merge] committer: Henrik Ziegeldorf branch nick: hipl timestamp: Wed 2011-12-14 14:24:27 +0100 message: Merged branch lp:~henrik-ziegeldorf/hipl/locators-type0-fix ------------------------------------------------------------ revno: 6191 committer: Fahad Aizaz branch nick: hipl timestamp: Mon 2011-12-12 15:33:52 +0100 message: Update to HIP Makefile.am Modifications to handle configuration file in Makefile.am. ------------------------------------------------------------ revno: 6190 committer: Fahad Aizaz branch nick: hipl timestamp: Mon 2011-12-12 15:33:06 +0100 message: Update to OpenWRT package. Neccessary modification for handling the configuration files in OpenWRT package. ------------------------------------------------------------ revno: 6189 committer: Fahad Aizaz branch nick: hipl timestamp: Mon 2011-12-12 15:32:10 +0100 message: RPM spec file update. The 'hipl.spec' file is updated to place the configuration files at the necessary path location during installation via RPM packages. ------------------------------------------------------------ revno: 6188 committer: Fahad Aizaz branch nick: hipl timestamp: Mon 2011-12-12 15:30:43 +0100 message: Removal of code for run-time generation of configuration files. The code for creation of the following configuration files needs to be removed: 1. hipd.conf 2. hosts 3. nsupdate.conf 4. relay.conf ------------------------------------------------------------ revno: 6187 committer: Fahad Aizaz branch nick: hipl timestamp: Mon 2011-12-12 15:28:46 +0100 message: Neccessary changes to Debian package for HIP. Creation of 'etc/hip/' path and placing the configuration files during installation using the pre-build debian binaries. ------------------------------------------------------------ revno: 6186 committer: Fahad Aizaz branch nick: hipl timestamp: Mon 2011-12-12 15:27:05 +0100 message: Stylecheck fix. The stylecheck added a newline. ------------------------------------------------------------ revno: 6185 committer: Fahad Aizaz branch nick: hipl timestamp: Mon 2011-12-12 15:26:13 +0100 message: HIP configuration files. The following configuration files are part of HIP package: 1. hipd.conf 2. hosts 3. nsupdate.conf 4. relay.conf ------------------------------------------------------------ revno: 6184 committer: David Martin branch nick: hipl_other_stuff timestamp: Fri 2011-12-09 10:32:56 +0100 message: Remove needless retransmission buffer sanity checks. Memory for the retransmission buffer is always allocated when a host association is set up in hip_hadb_init_entry(). If the allocation fails the creation of the respective HA fails as well. Deallocation only happens during teardown of the HA in hadb_delete_state(). As a consequence the sanity checks on the retransmission buffer during packet handling are not necessary. Therefore get rid of them. ------------------------------------------------------------ revno: 6183 committer: David Martin branch nick: hipl_other_stuff timestamp: Fri 2011-12-09 10:16:35 +0100 message: Cosmetics: Fix typo in handle_retransmissions() code documentation. ------------------------------------------------------------ revno: 6182 committer: David Martin branch nick: old_trunk timestamp: Wed 2011-12-07 15:56:16 +0100 message: Fix logic errors of for_each_hosts_file_line() error handling in hostsfiles.c. Revision 6166 introduced some logic errors where return values where falsely handled. This fixes it. ------------------------------------------------------------ revno: 6181 committer: Diego Biurrun branch nick: hipl timestamp: Thu 2011-12-01 22:29:13 +0100 message: rpm: add version information to Obsoletes tag This fixes rpmlint warnings about unversioned-explicit-obsoletes. ------------------------------------------------------------ revno: 6180 committer: Diego Biurrun branch nick: hipl timestamp: Thu 2011-12-01 22:23:16 +0100 message: rpm: fix source URL at infrahip.hiit.fi ------------------------------------------------------------ revno: 6179 committer: Diego Biurrun branch nick: hipl timestamp: Thu 2011-12-01 22:09:12 +0100 message: rpm: Drop Packager tag to conform with Fedora policy. A suitable value can be inferred from the local rpmbuild configuration. ------------------------------------------------------------ revno: 6178 committer: Diego Biurrun branch nick: hipl timestamp: Thu 2011-12-01 21:32:25 +0100 message: rpm: Do not start services by default to comply with Fedora packaging policy. ------------------------------------------------------------ revno: 6177 committer: Diego Biurrun branch nick: hipl timestamp: Thu 2011-12-01 21:18:00 +0100 message: rpm: remove apparently unnecessary %defattr directives Permissions are set correctly without them, so drop them for now at least. ------------------------------------------------------------ revno: 6176 committer: Diego Biurrun branch nick: hipl timestamp: Thu 2011-12-01 21:15:28 +0100 message: rpm: Do not strip binaries during Make run; rpm does this automatically. ------------------------------------------------------------ revno: 6175 committer: Diego Biurrun branch nick: hipl timestamp: Thu 2011-12-01 20:48:15 +0100 message: rpm: Drop "--prefix=/usr --sysconfdir=/etc" from %configure macro invocation. These options are added automatically by the RPM build process anyway. ------------------------------------------------------------ revno: 6174 committer: Diego Biurrun branch nick: hipl timestamp: Thu 2011-12-01 20:46:50 +0100 message: rpm: Remove pointless "ExclusiveOS" and "Prefix" tags. ------------------------------------------------------------ revno: 6173 committer: Diego Biurrun branch nick: hipl timestamp: Thu 2011-12-01 20:41:27 +0100 message: rpm: Replace '%config /etc/rc.d/init.d' by the more correct %{_initddir}. ------------------------------------------------------------ revno: 6172 committer: Diego Biurrun branch nick: hipl timestamp: Thu 2011-12-01 19:46:20 +0100 message: rpm: Add BASENAME to dnsproxy init.d file. Without it, no name is printed when hipdnsproxy is started or stopped. ------------------------------------------------------------ revno: 6171 committer: Diego Biurrun branch nick: hipl timestamp: Thu 2011-12-01 19:13:15 +0100 message: rpm: Mention GPLv2 as license, not GPLv2 and MIT. The latter will only confuse people and the license for all of HIPL is GPLv2. ------------------------------------------------------------ revno: 6170 committer: Diego Biurrun branch nick: hipl timestamp: Thu 2011-12-01 14:35:35 +0100 message: doc: remove reference to non-existing prebuilt RPM packages ------------------------------------------------------------ revno: 6169 committer: Diego Biurrun branch nick: hipl timestamp: Thu 2011-12-01 14:34:53 +0100 message: openwrt: use the same package names as for RPM/DEB packages ------------------------------------------------------------ revno: 6168 committer: Diego Biurrun branch nick: hipl timestamp: Thu 2011-12-01 14:30:40 +0100 message: HOWTO: Fix a bunch of spelling and wording errors; add more semantic markup. ------------------------------------------------------------ revno: 6167 committer: Diego Biurrun branch nick: hipl timestamp: Thu 2011-12-01 14:23:21 +0100 message: hostsfiles: fix return argument doxy of hip_map_id_to_ip_from_hosts_files() ------------------------------------------------------------ revno: 6166 committer: Diego Biurrun branch nick: hipl timestamp: Thu 2011-12-01 14:22:59 +0100 message: hostfiles: cleanup error and return value handling Drop pointless variable indirections, eliminate HIP_IFELs and code duplication. ------------------------------------------------------------ revno: 6165 committer: Diego Biurrun branch nick: hipl timestamp: Wed 2011-11-30 14:38:27 +0100 message: Move hip_id_type_match() to the only file it is used and fix the implementation. ------------------------------------------------------------ revno: 6164 fixes bug(s): https://launchpad.net/bugs/894030 committer: Joakim Koskela branch nick: trunk timestamp: Wed 2011-11-30 16:23:27 +0200 message: A bug fix to "del server rvs" handling in hipconf As reported in lp:894030, deleting of rvs should work also without HIT (i.e. with opportunistic mode). This patch fixes the problem. ------------------------------------------------------------ revno: 6163 committer: David Martin branch nick: hipl_other_stuff timestamp: Wed 2011-11-30 14:54:11 +0100 message: Cosmetics: fix stray non-uncrustified lines in modules/update/hipd/update.c. ------------------------------------------------------------ revno: 6162 committer: Miika Komu branch nick: hipl timestamp: Wed 2011-11-30 14:56:30 +0200 message: Fixed a suspicious condition in the registration code. Christof Mroz noticed a no-op in revision 6159. This fixes the condition to something more sensible. ------------------------------------------------------------ revno: 6161 committer: Miika Komu branch nick: hipl timestamp: Tue 2011-11-29 21:23:50 +0200 message: Removed pointless parenthesis As Diego noticed, revision 6159 introduces pointless parentheses around one reference of a variable. Removed. ------------------------------------------------------------ revno: 6160 committer: Miika Komu branch nick: hipl timestamp: Tue 2011-11-29 20:48:14 +0200 message: A compilation fix to revision 6159 Code failed to build with --disable-rvs in revision 6159, fixed. ------------------------------------------------------------ revno: 6159 fixes bug(s): https://launchpad.net/bugs/894029 committer: Miika Komu branch nick: hipl timestamp: Tue 2011-11-29 19:57:48 +0200 message: A bug fix to opportunistic RVS re-registration As reported in bug #894029, opportunistic re-registration fails. This revision fixes the problem in a different way than suggested in the bug id. Namely, the problem fixed directly at the client-side registration code to minimize the impact of the changes. This bug fix complements bug id #592135 in the sense that now we have workaround for both opportunistic and normal registrations. One design criteria for this bug fix was to streamline with #592135, so that when it is eventually solved, the code of this revision can also be removed. I have tested the code successfully with multiple consequtive opp. and normal registrations. ------------------------------------------------------------ revno: 6158 [merge] committer: Henrik Ziegeldorf branch nick: hipl timestamp: Tue 2011-11-29 13:35:55 +0100 message: Merged lp:~henrik-ziegeldorf/hipl/locator-type1-fix into trunk. ------------------------------------------------------------ revno: 6157 committer: Diego Biurrun branch nick: hipl timestamp: Tue 2011-11-29 12:37:54 +0100 message: Give consistent names to all configuration files used within HIPL: firewall_conf ---> hipfw.conf hip_cert.cnf ---> hip_cert.conf hipd_config ---> hipd.conf nsupdate.conf ---> nsupdate.conf relay_config ---> relay.conf ------------------------------------------------------------ revno: 6156 committer: Diego Biurrun branch nick: vanilla timestamp: Mon 2011-11-28 12:19:19 +0100 message: rule_management: Drop stray @file Doxygen directive. ------------------------------------------------------------ revno: 6155 committer: Diego Biurrun branch nick: hipl timestamp: Fri 2011-11-25 18:56:24 +0100 message: Replace "HIP_" prefix in multiple inclusion guards by "HIPL_". The name of the project is HIPL, HIP is just the protocol. ------------------------------------------------------------ revno: 6154 committer: Diego Biurrun branch nick: hipfw timestamp: Fri 2011-11-25 17:40:40 +0100 message: Replace "hip_firewall_" function/variable prefixes by "hipfw_". ------------------------------------------------------------ revno: 6153 committer: Diego Biurrun branch nick: hipfw timestamp: Fri 2011-11-25 14:52:20 +0100 message: Consistently use "hipfw" in filenames for the HIPL firewall. ------------------------------------------------------------ revno: 6152 committer: Diego Biurrun branch nick: hipl timestamp: Fri 2011-11-25 15:15:31 +0100 message: Replace redundant hip_get_firewall_status() by hip_firewall_is_alive(). ------------------------------------------------------------ revno: 6151 committer: Diego Biurrun branch nick: hipl timestamp: Fri 2011-11-25 15:11:11 +0100 message: Remove unused hip_set_firewall_status() prototype. ------------------------------------------------------------ revno: 6150 committer: Diego Biurrun branch nick: hipl timestamp: Tue 2011-11-22 22:30:52 +0100 message: build: do not discard stdout during Doxygen documentation generation Thanks to Samuel Richter for help with some shell trickery. ------------------------------------------------------------ revno: 6149 committer: Diego Biurrun branch nick: hipl timestamp: Tue 2011-11-22 20:15:30 +0100 message: build: pass '-z muldefs' via -Wl option to the linker This is the correct, or at least a more robust, way to pass options to the linker when gcc is used as the linker frontend. This fixes a linking failure on Maemo where the linker had trouble grokking that option otherwise. Idea initially suggested by Christoph Mroz. ------------------------------------------------------------ revno: 6148 committer: Diego Biurrun branch nick: hipl timestamp: Tue 2011-11-22 13:51:33 +0100 message: sync-all: properly clean up before and after execution ------------------------------------------------------------ revno: 6147 committer: Diego Biurrun branch nick: hipl timestamp: Tue 2011-11-22 13:49:52 +0100 message: sync-all: drop bash-specific time measurement around execution loop ------------------------------------------------------------ revno: 6146 committer: Diego Biurrun branch nick: hipl timestamp: Tue 2011-11-22 13:46:56 +0100 message: sync-all: extract into current directory instead of subdir with version in name This allows simplifying the script and the build system. Substituting the HIPL version number into a script template is no longer necessary. ------------------------------------------------------------ revno: 6145 committer: Miika Komu branch nick: hipl timestamp: Tue 2011-11-22 08:52:07 +0200 message: Fixed contradictory statements in the Makefile.am According to Diego, tools/maintainer/sync-all was both included and excluded in Makefile.am from "make dist". Removed the inclusion part. ------------------------------------------------------------ revno: 6144 committer: Miika Komu branch nick: hipl timestamp: Sun 2011-11-20 17:12:13 +0200 message: A small improvement to maintainer script tools/maintainer/sync-all was not obeying correct "make dist" directory naming convention. This commit fixes this. ------------------------------------------------------------ revno: 6143 committer: Diego Biurrun branch nick: centos_hacks timestamp: Fri 2011-11-18 15:35:06 +0100 message: Stop setting the PATH environment variable; also drop an outdated comment This workaround was added for obsolete Fedora versions (9) and should no longer be necessary. Besides, mucking with PATH is a bad idea. ------------------------------------------------------------ revno: 6142 committer: Diego Biurrun branch nick: centos_hacks timestamp: Fri 2011-11-18 15:34:12 +0100 message: build: drop workarounds for CentOS 5.5; the new required baseline is CentOS 6. ------------------------------------------------------------ revno: 6141 committer: Diego Biurrun branch nick: centos_hacks timestamp: Fri 2011-11-18 15:33:04 +0100 message: drop all obsolete patches and related documentation The new baseline we require is CentOS 6. Older systems will no longer be supported by adding patches and workarounds to HIPL. ------------------------------------------------------------ revno: 6140 committer: Diego Biurrun branch nick: hipl timestamp: Fri 2011-11-18 21:05:27 +0100 message: Remove unused sa_eid_t typedef. ------------------------------------------------------------ revno: 6139 committer: Diego Biurrun branch nick: hipl timestamp: Fri 2011-11-18 20:44:33 +0100 message: Replace memset(0) calls by direct zero initializations. ------------------------------------------------------------ revno: 6138 committer: Diego Biurrun branch nick: hipl timestamp: Fri 2011-11-18 15:46:46 +0100 message: Do not ignore hipl-VERSION directories. These directories are remnants from failed build processes and can cause trouble at least for Doxygen building, so ignoring them is counterproductive. ------------------------------------------------------------ revno: 6137 committer: David Martin branch nick: hipl_other_stuff timestamp: Thu 2011-11-17 12:15:47 +0100 message: Add error handling for HA initialization to hip_hadb_create_state(). ------------------------------------------------------------ revno: 6136 committer: David Martin branch nick: hipl_other_stuff timestamp: Thu 2011-11-17 12:12:21 +0100 message: Add error handling for lmod init error to hadb_init_entry(). ------------------------------------------------------------ revno: 6135 committer: David Martin branch nick: hipl_other_stuff timestamp: Thu 2011-11-17 12:05:51 +0100 message: Cosmetics: Complete documentation of hadb_init_entry(). ------------------------------------------------------------ revno: 6134 committer: David Martin branch nick: hipl_typos timestamp: Wed 2011-11-16 17:30:16 +0100 message: Cosmetics: Fix some typos in documentation. ------------------------------------------------------------ revno: 6133 committer: Diego Biurrun branch nick: hipl timestamp: Tue 2011-11-15 22:04:16 +0100 message: Revert previous commit for out-of-tree Doxygen builds; it was wrong. During out-of-tree builds only directories in the actual build directory should be ignored, not ones that happen to be in the source directory by some unlucky coincidence. ------------------------------------------------------------ revno: 6132 committer: Diego Biurrun branch nick: hipl timestamp: Tue 2011-11-15 21:58:50 +0100 message: doxygen: exclude generated dir from list of source files in out-of-tree builds ------------------------------------------------------------ revno: 6131 committer: Diego Biurrun branch nick: hipl timestamp: Tue 2011-11-15 16:40:37 +0100 message: build: Trigger build errors on Doxygen warnings. ------------------------------------------------------------ revno: 6130 committer: Miika Komu branch nick: hipl timestamp: Sun 2011-11-13 20:55:05 +0200 message: Bumped version number up Release 1.0.6 was published, so bumped the version number up. ------------------------------------------------------------ revno: 6129 committer: Miika Komu branch nick: hipl timestamp: Fri 2011-11-11 21:51:19 +0200 message: Another fix to the ARM build Arm build still failed: .. test/firewall/midauth.c:289: error: 'test_hip_challenge_response_opaque_len' undeclared (first use in this function) I hope this is fixed in this commit. I also reduced one ifdef by moving a function in the same file. ------------------------------------------------------------ revno: 6128 committer: Miika Komu branch nick: hipl timestamp: Fri 2011-11-11 20:35:56 +0200 message: Fixed a problem with ARM build Autobuilder failed to build ARM binaries. I hope this commit fixes the problem. I believe the problematic source file had also another compilation issue with missing ifdefs, so I fixed it too. The error from the autobuilder was as follows: branch: trunk revision: 6127 configuration: Scratchbox ARM crosscompile command: /opt/scratchbox/login -d hipl-[0-9.]* make deb compiler output: ./packaging/create-package.sh deb ..... test/firewall/midauth.c:220: warning: 'test_hipfw_midauth_verify_challenge_NULL_ctx' defined but not used ------------------------------------------------------------ revno: 6127 committer: Miika Komu branch nick: hipl timestamp: Fri 2011-11-11 19:15:35 +0200 message: Fixed a problem with "make dist" Three source files were missing from "make dist". I decided to move them to EXTRA_DIST as a compromise because they were not compiled. I assume that they are needed in the future. ------------------------------------------------------------ revno: 6126 committer: Miika Komu branch nick: hipl timestamp: Thu 2011-11-10 23:57:55 +0200 message: Fixed most of "make check" compilation errors for Fedora. A resolution for bug id #838116 was merged but "make check" and "make "alltests" still failed to compile. This commit fixes most of them but one is still left. ------------------------------------------------------------ revno: 6125 committer: Rene Hummen branch nick: trunk timestamp: Thu 2011-11-10 11:59:03 +0100 message: remove midauth compilation flag from the auto-builder ------------------------------------------------------------ revno: 6124 committer: Rene Hummen branch nick: trunk timestamp: Thu 2011-11-10 11:53:21 +0100 message: remove compile-time conditional for midauth and related code This should satisfy the auto-builder. NOTE: Midauth and PISA certificate handling was intertwined in the code whereas it should really be separate. This separation is now enforced by merging the midauth branches. However, PISA functionality is still broken. This will be fixed by the upcoming merge of the PISA branch. Until then, I have removed the conditional code of PISA from the codebase. ------------------------------------------------------------ revno: 6123 [merge] committer: Rene Hummen branch nick: trunk timestamp: Thu 2011-11-10 11:35:47 +0100 message: lp:~hipl-core/hipl/ecdsa-redhat with trunk ------------------------------------------------------------ revno: 6122 [merge] committer: Henrik Ziegeldorf branch nick: hipl timestamp: Wed 2011-11-09 17:28:49 +0100 message: Merged lp:~midauth-pisa-devs/hipl/midauth-firewall ------------------------------------------------------------ revno: 6121 [merge] committer: David Martin branch nick: merge-test timestamp: Wed 2011-11-09 16:37:31 +0100 message: Merge lp:~martin-lp/hipl/hipfwconf into trunk. This merge updates the hipconf API and makes it possible to retrieve the active connections from hipfw. Changes in the hipconf API: - hipconf commands have to include the keyword 'daemon' or 'hipfw' to address the respective process - eg. 'hipconf get ha all' is now 'hipconf daemon get ha all' - other than the daemon process keyword there are no changes to the hipconf commands; config file syntax stays the same as well - active connections from the firewall can be retrieved with 'hipconf firewall get ha all' Merge request: https://code.launchpad.net/~martin-lp/hipl/hipfwconf/+merge/81612 ------------------------------------------------------------ revno: 6120 committer: David Martin branch nick: trunk timestamp: Wed 2011-11-09 16:34:26 +0100 message: Revert r6118: Relaxed uncrustify rules to allow #endif after a function body. Setting the number of newlines after functions to 1 in uncrustify rules enforces it for all functions. The effect: no more blank lines between functions. This commit reverts the change. ------------------------------------------------------------ revno: 6119 committer: Miika Komu branch nick: hipl timestamp: Wed 2011-11-09 08:32:02 +0200 message: Removed some empty lines between function bodies and #endif statements The update to the crustify policy in revision 6118 removed the need to have an empty line between the end of a function body (closing curly bracket) and following #endif (if any present). I grepped the source files for occurrences of this and adjusted according to the new policy. ------------------------------------------------------------ revno: 6118 committer: Miika Komu branch nick: hipl timestamp: Wed 2011-11-09 08:16:43 +0200 message: Relaxed uncrustify rules to allow #endif after a function body The uncrustify configuration now allows #endif after closing of the function body as follows: #ifdef SOMETHING int foo(void) { } #endif /* SOMETHING */ As a side effect, I believe this now allows the following violation (which should be prohibited via manual inspection): int foo(void) { } int bar(void) { } ------------------------------------------------------------ revno: 6117 committer: Henrik Ziegeldorf branch nick: hipl timestamp: Tue 2011-11-08 19:22:33 +0100 message: replace fw_verify_packet with fw_verify_and_store_host_id for U2 and U3. ------------------------------------------------------------ revno: 6116 committer: Henrik Ziegeldorf branch nick: hipl timestamp: Tue 2011-11-08 19:18:20 +0100 message: Added asserts in function fw_verify_and_store_host_id. ------------------------------------------------------------ revno: 6115 committer: Henrik Ziegeldorf branch nick: hipl timestamp: Tue 2011-11-08 19:14:13 +0100 message: Fixed specification of return value of function fw_verify_and_store_host_id. The function returns 0 for valid packets, 1 if signature verification failed and -1 on other errors. ------------------------------------------------------------ revno: 6114 committer: David Martin branch nick: trunk timestamp: Tue 2011-11-08 16:38:40 +0100 message: Revert accidental hipl-daemon dependency change applied with rev. 6113. ------------------------------------------------------------ revno: 6113 committer: David Martin branch nick: trunk timestamp: Tue 2011-11-08 15:19:35 +0100 message: Make hipconf_usage string static as it is local to lib/core/conf.c. ------------------------------------------------------------ revno: 6112 committer: David Martin branch nick: hipl_retransmissions timestamp: Mon 2011-11-07 14:35:42 +0100 message: Cosmetics: Move comment in queue_packet() to where it belongs. ------------------------------------------------------------ revno: 6111 committer: Miika Komu branch nick: hipl timestamp: Fri 2011-11-04 19:41:51 +0200 message: Fixed an annoyance in a maintainer script From bug #795846: The "make syncrepo" target seems to unnecessarily copy also old packages to the repository. Fixed by including the revision number also. ------------------------------------------------------------ revno: 6110 committer: Rene Hummen branch nick: trunk timestamp: Thu 2011-11-03 10:21:12 +0100 message: merge lp:~rene-hummen/hipl/logging This merge updates the logging facilities of HIPL and adds a new log level "LOW". Macros are now mapped to the debug levels as follows: ========================================= | NONE | DIE, ASSERT ------------------------------------------ | LOW | DIE, ASSERT, ERROR ------------------------------------------ | MEDIUM | DIE, ASSERT, ERROR, INFO ------------------------------------------ | ALL | DIE, ASSERT, ERROR, INFO, DEBUG ========================================== Also see merge proposal: https://code.launchpad.net/~rene-hummen/hipl/logging/+merge/81065 ------------------------------------------------------------ revno: 6109 committer: Diego Biurrun branch nick: hipl timestamp: Wed 2011-11-02 11:41:11 +0100 message: INSTALL: Add list of required packages for OpenSUSE. ------------------------------------------------------------ revno: 6108 committer: Diego Biurrun branch nick: hipl timestamp: Wed 2011-11-02 11:39:07 +0100 message: packaging: port package building script to openSUSE ------------------------------------------------------------ revno: 6107 committer: David Martin branch nick: trunk timestamp: Mon 2011-10-31 18:38:04 +0100 message: Cosmetics: Fix some typos in documentation. ------------------------------------------------------------ revno: 6106 committer: Miika Komu branch nick: hipl timestamp: Mon 2011-10-31 18:01:14 +0200 message: Reverted revision 6105 I applied the patch incorrectly and the need for OpenSUSE build instructions should be further discussed before applying. ------------------------------------------------------------ revno: 6105 committer: Miika Komu branch nick: hipl timestamp: Mon 2011-10-31 15:12:12 +0200 message: Building and packaging for OpenSUSE From Diego: I have a notebook that runs OpenSUSE, so I quickly ported the packaging infrastructure. I'm not sure this is worth the future maintenance burden, but I thought I might send it anyway. ------------------------------------------------------------ revno: 6104 committer: Diego Biurrun branch nick: hipl timestamp: Sun 2011-10-30 17:43:57 +0100 message: vimrc: improve whitespace highlighting ------------------------------------------------------------ revno: 6103 committer: Diego Biurrun branch nick: hipl timestamp: Sun 2011-10-30 12:54:44 +0100 message: Drop trailing semicolons from macro declarations. This is more consistent, most macro declarations do not end in semicolons, and avoids issues with some automatic tools like uncrustify. ------------------------------------------------------------ revno: 6102 committer: Diego Biurrun branch nick: hipl timestamp: Sun 2011-10-30 12:41:51 +0100 message: firewall: K&R indentation cosmetics ------------------------------------------------------------ revno: 6101 committer: Diego Biurrun branch nick: hipl timestamp: Sat 2011-10-29 22:14:09 +0200 message: cosmetics: adjust some accidentally introduced indentation messups ------------------------------------------------------------ revno: 6100 committer: Diego Biurrun branch nick: hipl timestamp: Wed 2011-10-26 09:26:59 +0200 message: firewall: Drop inline keyword from get_cache_index(). gcc 4.5.1 fails to inline that function when optimizing for size. Since gcc can generally be trusted about inlining decisions, dropping the inline keyword and letting the compiler decide about inlining appears to be the sensible choice. ------------------------------------------------------------ revno: 6099 committer: Diego Biurrun branch nick: hipl timestamp: Tue 2011-10-25 23:44:47 +0200 message: Drop unnecessary end-of-line backslashes. In many places lines end in backslashes, probably due to the wrong assumption that a newline acts as an argument separator, which it does not in C. ------------------------------------------------------------ revno: 6098 committer: Diego Biurrun branch nick: hipl timestamp: Tue 2011-10-25 23:14:16 +0200 message: Drop pointless hip_ prefixes from static functions. There is no point in prefixing static functions as there is no risk of namespace collisions. Dropping the prefix reduces clutter. ------------------------------------------------------------ revno: 6097 committer: Diego Biurrun branch nick: hipl timestamp: Tue 2011-10-25 22:59:51 +0200 message: Add missing semicolons after macro invocations. ------------------------------------------------------------ revno: 6096 committer: David Martin branch nick: trunk timestamp: Fri 2011-10-21 10:59:25 +0200 message: Fix recurring typo in lib/core/message.c doxygen documentation. ------------------------------------------------------------ revno: 6095 committer: David Martin branch nick: trunk timestamp: Wed 2011-10-19 12:25:15 +0200 message: Cosmetics: remove superfluous parentheses in hip_purge_closing_ha(). ------------------------------------------------------------ revno: 6094 committer: David Martin branch nick: hipl_state-removal timestamp: Wed 2011-10-19 11:51:41 +0200 message: Track connection state in firewall connection tracking. Before, the state variable was only initially set but never actually changed or used. This commit uses it to track the state of the connection. For this reason three new states (R1-SENT, U1-SENT, U2-SENT) are added which are only used by the firewall. State updates happen in the handle functions after successful processing of the respective packets. ------------------------------------------------------------ revno: 6093 committer: Diego Biurrun branch nick: hipl timestamp: Mon 2011-10-17 20:14:10 +0200 message: Fix compilation errors in gcc 4.5/4.6 due to failed inlining with -Os. Newer gcc versions fail to inline a few functions when optimizing for size. Drop the inline keyword from these functions. In the case of hip_state_str() this also required moving the function from a header file to a normal .c file. ------------------------------------------------------------ revno: 6092 committer: Diego Biurrun branch nick: hipl timestamp: Mon 2011-10-17 19:42:36 +0200 message: Remove stray duplicate license statement. ------------------------------------------------------------ revno: 6091 committer: David Martin branch nick: trunk timestamp: Mon 2011-10-17 17:55:02 +0200 message: Include lib/core/state.h where it's required in header files. make checkheaders now makes no trouble no more. ------------------------------------------------------------ revno: 6090 committer: David Martin branch nick: hipl_state-removal timestamp: Mon 2011-10-17 17:22:35 +0200 message: Move hip_state #defines into enum, use enum instead of int in functions. Basically lots and lots of function parameters that needed rewriting. Noteworthy change in hip_state_str() which does not use that weird array construction anymore but a proper switch case and lib/core/state.h where the defines have been moved into the enum. ------------------------------------------------------------ revno: 6089 committer: David Martin branch nick: hipl_state_rename timestamp: Mon 2011-10-17 16:23:19 +0200 message: Rename hip_hastate to hip_ha_state. Changed are both the enum and the variables using it. This way it is more conform with the naming in the rest of the codebase. ------------------------------------------------------------ revno: 6088 committer: Rene Hummen branch nick: trunk timestamp: Thu 2011-10-13 10:56:50 +0200 message: fix long handover delays in case locators are unreachable for responder In some situations, the network stack of the responder cannot deliver HIP UPDATE messages to the signaled locators. In this case, sendto() returns a length != packet_length. Until now, HIPL tried three times to send undeliverable packets with a timeout of 2 seconds each. As the hipd is single-threaded, this caused a delay of 4+ seconds per undeliverable locator. HIPL also implements a retransmission mechanisms (for UPDATEs). Undeliverable packets are handled there as well. Hence, I removed the intrusive special handling for the case where the network stack reports an error. This fixes the problem of overly long handovers. ------------------------------------------------------------ revno: 6087 committer: Rene Hummen branch nick: trunk timestamp: Wed 2011-10-12 11:26:52 +0200 message: fix issue where update causes old ipsec sa not to be removed at responder The altering IPsec SAs requires knowlege about the IP addresses of the peer. During updates, we update the IPs to the new locators. Hence, we need to remove IPsec SAs before resetting the IPs and set up new SAs afterwards. This commit splits removal and setup into two parts. ------------------------------------------------------------ revno: 6086 committer: Rene Hummen branch nick: trunk timestamp: Wed 2011-10-12 11:20:36 +0200 message: add error output for conflicting handle function priorities ------------------------------------------------------------ revno: 6085 committer: Rene Hummen branch nick: trunk timestamp: Wed 2011-10-12 10:36:40 +0200 message: minor beautification of script output ------------------------------------------------------------ revno: 6084 [merge] committer: David Martin branch nick: trunk timestamp: Mon 2011-10-10 16:05:21 +0200 message: Merge n900-build-fix branch revision rev 6083 into trunk. Merge-proposal: https://code.launchpad.net/~martin-lp/hipl/n900-build-fix/+merge/78551 Set hostid unit test timeouts to 120 seconds to fix broken package building for the N900. ------------------------------------------------------------ revno: 6083 committer: David Martin branch nick: trunk timestamp: Mon 2011-10-10 13:37:16 +0200 message: Cosmetics: Spaces in array definition in test/lib/core/hostid.c ------------------------------------------------------------ revno: 6082 committer: Diego Biurrun branch nick: hipl timestamp: Thu 2011-09-01 16:35:54 +0200 message: RPM: drop rpm-build package from BuildRequires list The rpmbuild program is an implied dependency of RPM package building, so it ought to be safe to leave it out of BuildRequires. This allows using the specfile on other RPM-based distributions like openSUSE where rpmbuild is part of the rpm package and no separate rpm-build package exists. ------------------------------------------------------------ revno: 6081 committer: Diego Biurrun branch nick: hipl timestamp: Thu 2011-09-01 16:33:11 +0200 message: Restructure commands used to satisfy optional and required dependencies. Split into lists of packages necessary for building HIPL, those for optional functionality and those required for building binary distribution packages. ------------------------------------------------------------ revno: 6080 committer: Diego Biurrun branch nick: hipl timestamp: Thu 2011-09-01 16:31:03 +0200 message: Bazaar is a build-time dependency of HIPL. ------------------------------------------------------------ revno: 6079 committer: David Martin branch nick: trunk timestamp: Wed 2011-09-21 16:22:17 +0200 message: Move debug RSA key creation announcement before the actual generation. It doesn't make much sense to notify about an upcoming key generation when it is already finished. ------------------------------------------------------------ revno: 6078 committer: Miika Komu branch nick: hipl timestamp: Thu 2011-09-15 23:02:25 +0300 message: Re-enabled "shotgun" extension for hipconf The shotgun extension sends multiple I1/UPDATE messages to find a working address pair. Somebody disabled the extension in hipconf, but just partially. This commit re-enables the shotgun functionality (which seems to working as reported in bug report lp:592177). ------------------------------------------------------------ revno: 6077 fixes bug(s): https://launchpad.net/bugs/845677 committer: Miika Komu branch nick: hipl timestamp: Tue 2011-09-13 11:18:08 +0300 message: Another stab to fix DNS proxy boot-up problems in Ubuntu Natty. Revision 6076 did not do the trick to fix DNS problems when dnsmasq and DNS proxy are running in the same system (#845677). The issue was subtle and seems to reappear randomly. This commit has an additional safe guard (higher priority for init.d) which I hope will fix the problem. I have tested the bug fix both in LTS and Natty. ------------------------------------------------------------ revno: 6076 fixes bug(s): https://launchpad.net/bugs/845677 committer: Miika Komu branch nick: hipl timestamp: Mon 2011-09-12 10:11:02 +0300 message: Changed start-up priority of the DNS proxy in Ubuntu/Debian As bug id #845677 states, I've had some problems during boot in my Ubuntu Natty when both DNS proxy and dnsmasq are installed. The root of the problem seems to be that DNS proxy starts too fast and there's a race condition with dnsmasq. Diego suggested a fix the bug in init.d scripts and it seems to work just fine. ------------------------------------------------------------ revno: 6075 committer: Diego Biurrun branch nick: hipl timestamp: Sun 2011-09-11 13:34:08 +0200 message: debian: reflect dependency on (possibly remotely-mounted) /usr in init scripts The HIPL init scripts depend on /usr to start the HIPL binaries. /usr may be remotely-mounted, so depend on remote filesystems being mounted before running. reference: http://wiki.debian.org/LSBInitScripts ------------------------------------------------------------ revno: 6074 committer: David Martin branch nick: hipl_state-removal timestamp: Wed 2011-09-07 16:44:13 +0200 message: Use /lib/core/ state definitions instead of local ones in conntrack.c. The prior definitions weren't used except for the initial state making the enum rather pointless. As of now the state in connections is still unused but it will be used to track connection information in the future. ------------------------------------------------------------ revno: 6073 committer: David Martin branch nick: hipl_state-removal timestamp: Wed 2011-09-07 15:33:42 +0200 message: Remove unused state attribute from firewall connection tuples. The state exists for both initiator and responder but it's only changed initially on creation and when the connection is closed. It's never read or used in any way. Therefore scrap it. ------------------------------------------------------------ revno: 6072 committer: Henrik Ziegeldorf branch nick: hipl timestamp: Mon 2011-09-05 10:46:53 +0200 message: Added tests for serialization and deserialization of RSA keys. ------------------------------------------------------------ revno: 6071 committer: David Martin branch nick: trunk timestamp: Wed 2011-08-31 13:50:36 +0200 message: conntrack: avoid code duplication in get_tuple_by_hip(). get_tuple_by_hits() performs the same iteration on the list of connection tuples, call this instead of having it twice in the code. ------------------------------------------------------------ revno: 6070 committer: Diego Biurrun branch nick: hipl timestamp: Wed 2011-08-31 13:17:24 +0200 message: conntrack: replace some pointless gotos by direct return ------------------------------------------------------------ revno: 6069 committer: Diego Biurrun branch nick: hipl timestamp: Wed 2011-08-31 12:59:29 +0200 message: conntrack: change if/else cascade to switch statement ------------------------------------------------------------ revno: 6068 committer: Rene Hummen branch nick: trunk timestamp: Fri 2011-08-26 17:48:23 +0200 message: fix autobuilder if update is excluded from build, so should be its dependencies, including midauth. ------------------------------------------------------------ revno: 6067 committer: Diego Biurrun branch nick: hipl timestamp: Fri 2011-08-26 16:59:44 +0200 message: midauth: Fix compilation with --enable-midauth. A #include and a variable initialization were missing from the midauth branch merge, resulting in compilation failures with --enable-midauth. ------------------------------------------------------------ revno: 6066 committer: Diego Biurrun branch nick: hipl timestamp: Thu 2011-08-25 18:17:22 +0200 message: conntrack: simplify handle_update() Change a pointer to pointer function argument to a simple pointer. The argument is always dereferenced before use, effectively turning it into a simple pointer argument. ------------------------------------------------------------ revno: 6065 committer: Diego Biurrun branch nick: hipl timestamp: Thu 2011-08-25 18:15:40 +0200 message: Remove some redundant, write-only variables. ------------------------------------------------------------ revno: 6064 committer: Artturi Karila branch nick: hipl timestamp: Thu 2011-08-25 15:12:27 +0300 message: Don't drop packets with non-local dst HIT if RVS is active Packets with a non-local destination HIT were being dropped in hip_receive_control_packet() before the check for whether they should be relayed. hip_check_i1() (which would only be called after hip_receive_control_packet()) had redundant code doing the same except with a provision for opportunistic I1 packets. I removed the redundancy and changed the code to be executed only if we are not offering RVS or relay service. ------------------------------------------------------------ revno: 6063 committer: David Martin branch nick: trunk timestamp: Mon 2011-08-22 17:15:07 +0200 message: Include string.h in test/*/midauth_builder.c to fix N900 compile issue. The N900 build script now successfully builds again. ------------------------------------------------------------ revno: 6062 [merge] committer: David Martin branch nick: update-merge timestamp: Thu 2011-08-18 12:11:46 +0200 message: Merge update_ack_handling branch revision 6053. Merge proposal: https://code.launchpad.net/~martin-lp/hipl/update_ack_handling/+merge/71328 Accept ACKs for all outstanding Update packets instead of most recent one. Previously only ACKs for the most recent sent Update packet were accepted. This merge introduces a boundary for yet to be acknowledged Update packets which allows to correctly deal with ACKs for more than one outstanding Update packet. This fixes a bug where ACKs were falsely dropped when both hosts initiated an update at the same time. ------------------------------------------------------------ revno: 6061 committer: David Martin branch nick: hipl_startup timestamp: Wed 2011-08-17 11:21:39 +0200 message: Make lmod_get_state_item() more robust. Perform sanity checks on passed parameters and do not pass a possibly negative return value as an unsigned int. ------------------------------------------------------------ revno: 6060 [merge] committer: Rene Hummen branch nick: trunk timestamp: Tue 2011-08-16 09:49:25 +0200 message: merge conntrack-cleanup branch revision 6083 The merge proposal has been discussed at: https://code.launchpad.net/~rene-hummen/hipl/conntrack-cleanup/+merge/71550 ------------------------------------------------------------ revno: 6059 committer: Diego Biurrun branch nick: hipl timestamp: Mon 2011-08-15 16:11:56 +0200 message: doxygen: drop redundant @author, @version and @date tags Bazaar is tracking this information in a more accurate and less error-prone fashion already, no need to manually repeat its job (badly). ------------------------------------------------------------ revno: 6058 committer: Diego Biurrun branch nick: hipl timestamp: Mon 2011-08-15 14:23:14 +0200 message: HACKING: update one Doxygen example to reflect current practice ------------------------------------------------------------ revno: 6057 committer: Diego Biurrun branch nick: hipl timestamp: Mon 2011-08-15 13:28:35 +0200 message: INSTALL: remove duplicate 'check' entries from required packages list ------------------------------------------------------------ revno: 6056 committer: Diego Biurrun branch nick: hipl timestamp: Sun 2011-08-14 23:23:41 +0200 message: autobuild: test existence of OpenWrt directory before copying ------------------------------------------------------------ revno: 6055 committer: Diego Biurrun branch nick: hipl timestamp: Thu 2011-08-11 11:24:50 +0200 message: patches: remove outdated kernel patches, version < 2.6.18 ------------------------------------------------------------ revno: 6054 committer: Miika Komu branch nick: hipl timestamp: Sun 2011-08-14 12:47:03 +0300 message: Updated Debian and Redhat dependencies in INSTALL. Added "check" to optional dependencies. ------------------------------------------------------------ revno: 6053 committer: David Martin branch nick: trunk timestamp: Thu 2011-08-11 15:51:14 +0200 message: Free allocated memory in case of error in hip_update_init_state(). ------------------------------------------------------------ revno: 6052 committer: Diego Biurrun branch nick: HIP_IFE timestamp: Wed 2011-08-10 20:11:13 +0200 message: hipd: eliminate some HIP_IFE(L) abuse; simplify return handling ------------------------------------------------------------ revno: 6051 committer: Diego Biurrun branch nick: hipl timestamp: Wed 2011-08-10 17:03:07 +0200 message: openwrt: generate Makefile from a template by configure to substitute version This saves the trouble of changing HIPL version numbers in multiple places after each release. ------------------------------------------------------------ revno: 6050 committer: Diego Biurrun branch nick: hipl timestamp: Wed 2011-08-10 16:44:58 +0200 message: sync-all: drop version number from temporary directory name The version number keeps changing and this script is simple enough not to need it. Having it generated by configure would thus be overkill. ------------------------------------------------------------ revno: 6049 committer: Diego Biurrun branch nick: hipl timestamp: Wed 2011-08-10 16:29:43 +0200 message: openwrt: cosmetics: drop some unnecessary backslashes ------------------------------------------------------------ revno: 6048 committer: Diego Biurrun branch nick: hipl timestamp: Wed 2011-08-10 15:34:38 +0200 message: user_ipsec_api: move #include to the correct place ------------------------------------------------------------ revno: 6047 committer: Rene Hummen branch nick: trunk timestamp: Wed 2011-08-10 14:13:29 +0200 message: move xml tag to top of file for correct parsing ------------------------------------------------------------ revno: 6046 [merge] committer: Rene Hummen branch nick: trunk timestamp: Tue 2011-08-09 17:25:25 +0200 message: merge re-implements the hipd-related part of draft-heer-hip-middle-auth-02 An extensive merge proposal and discussion can be found at: https://code.launchpad.net/~rene-hummen/hipl/midauth-hipd/+merge/70736 ------------------------------------------------------------ revno: 6045 committer: Diego Biurrun branch nick: hipl timestamp: Mon 2011-08-08 16:37:22 +0200 message: nlink: drop some pointless void* casts ------------------------------------------------------------ revno: 6044 committer: Diego Biurrun branch nick: hipl timestamp: Mon 2011-08-08 16:35:56 +0200 message: builder: clean up return handling Return values directly instead of setting a variable, jumping to a goto label and returning the variable there. ------------------------------------------------------------ revno: 6043 committer: Diego Biurrun branch nick: hipl timestamp: Mon 2011-08-08 15:33:21 +0200 message: cosmetics: fix 'null' vs. 'NULL' typo ------------------------------------------------------------ revno: 6042 committer: Henrik Ziegeldorf branch nick: hipl timestamp: Mon 2011-08-08 14:13:04 +0200 message: Fixed tests for ECC functionality, such that all tests are passed. ------------------------------------------------------------ revno: 6041 committer: Henrik Ziegeldorf branch nick: hipl timestamp: Mon 2011-08-08 13:53:53 +0200 message: Fix incorrect use of sizeof. ------------------------------------------------------------ revno: 6040 [merge] committer: Diego Biurrun branch nick: hipl timestamp: Fri 2011-08-05 13:00:52 +0200 message: Merge demodularization branch that pulls together Makefile.am snippets. ------------------------------------------------------------ revno: 6039 [merge] fixes bug(s): https://launchpad.net/bugs/697220 committer: Stefan G?tz branch nick: hipl timestamp: Thu 2011-08-04 23:12:21 +0200 message: Completely removes the files lib/tool/lutil.{c.h}. They primarily contain a list implementation which is only used for string parsing. This string parsing is actually implemented much better directly via strtok(). This also removes a source of GPL infection. Merge of branch https://code.launchpad.net/~stefan.goetz/hipl/delist Merge proposal https://code.launchpad.net/~stefan.goetz/hipl/delist/+merge/62559 ------------------------------------------------------------ revno: 6038 [merge] committer: Diego Biurrun branch nick: hipl timestamp: Wed 2011-08-03 15:19:21 +0200 message: Merge uncrustify improvements branch. ------------------------------------------------------------ revno: 6037 committer: Miika Komu branch nick: trunk timestamp: Tue 2011-08-02 17:34:30 +0300 message: Added a note on an experimental bzr hook to the HACKING file Stefan G?tz has developed a pre-commit hook for the Copyright. While the pre-commit has not been merged yet, it pops up on the mailing list every now and then. Therefore, I decided to note it on the HACKING instructions and advocate Stefan to merge it! ------------------------------------------------------------ revno: 6036 committer: Diego Biurrun branch nick: vanilla timestamp: Mon 2011-08-01 17:56:06 +0200 message: Drop unnecessary return statements at the end of void functions. ------------------------------------------------------------ revno: 6035 committer: Diego Biurrun branch nick: vanilla timestamp: Mon 2011-08-01 14:34:53 +0200 message: INSTALL: add a short sentence on contributing; mention HACKING ------------------------------------------------------------ revno: 6034 committer: Diego Biurrun branch nick: vanilla timestamp: Fri 2011-07-29 14:55:51 +0200 message: cosmetics: fix some incorrect spacing found while playing with uncrustify ------------------------------------------------------------ revno: 6033 committer: Diego Biurrun branch nick: hipl timestamp: Thu 2011-07-28 20:35:33 +0200 message: stylecheck.py: fix some typos ------------------------------------------------------------ revno: 6032 committer: Diego Biurrun branch nick: hipl timestamp: Thu 2011-07-28 18:29:45 +0200 message: cosmetics: drop some redundant ';' pointed out by uncrustify; merge two lines ------------------------------------------------------------ revno: 6031 committer: Diego Biurrun branch nick: hipl timestamp: Thu 2011-07-28 18:16:31 +0200 message: stylecheck: fix description of this pre-commit hook's dependencies There is nothing GNU in the way diff/patch are used; mention both diff and patch as dependencies; remove some stray trailing whitespace. ------------------------------------------------------------ revno: 6030 committer: Diego Biurrun branch nick: hipl timestamp: Thu 2011-07-28 18:14:21 +0200 message: unit tests: reformat struct declaration in a way that survives uncrustify ------------------------------------------------------------ revno: 6029 committer: Diego Biurrun branch nick: hipl timestamp: Thu 2011-07-28 18:08:40 +0200 message: uncrustify: force END_TEST to be treated as macro-close token This allows uncrustify to deal with the unit test code without completely messing up its formatting. ------------------------------------------------------------ revno: 6028 [merge] committer: Diego Biurrun branch nick: hipl timestamp: Thu 2011-07-21 19:30:23 +0200 message: Merge vestigial locking macros removal branch. ------------------------------------------------------------ revno: 6027 committer: Diego Biurrun branch nick: hipl timestamp: Thu 2011-07-21 19:27:23 +0200 message: build: ignore directory generated by 'make dist' ------------------------------------------------------------ revno: 6026 committer: Diego Biurrun branch nick: hipl timestamp: Thu 2011-07-21 19:26:34 +0200 message: doxygen: exclude directory generated by 'make dist' from list of source files ------------------------------------------------------------ revno: 6025 committer: Rene Hummen branch nick: trunk timestamp: Thu 2011-07-21 14:12:32 +0200 message: replace code with hip_ifel abuse ------------------------------------------------------------ revno: 6024 committer: Diego Biurrun branch nick: hipl timestamp: Thu 2011-07-21 13:28:01 +0200 message: cosmetics: remove some unnecessary parentheses from pointer expressions The struct member selection operators '.' and '->' have higher precedence than the address operator '&'. Remove parentheses made unnecessary by this order in cases where they add no readability or even impair readability. ------------------------------------------------------------ revno: 6023 committer: Diego Biurrun branch nick: hipl timestamp: Thu 2011-07-21 12:15:15 +0200 message: create_ecdsa_key(): bandaid compilation fix for gcc 4.6 The err variable was write-only since the function returns EC_KEY* and not int. Change err variable to type EC_KEY* and return it instead of NULL. ------------------------------------------------------------ revno: 6022 committer: Diego Biurrun branch nick: hipl timestamp: Wed 2011-07-20 15:24:55 +0200 message: build: clean up .bzrignore Restore alphabetical order, remove duplicates, use wildcard for config.foo entries, do not globally ignore .lo and .la files. ------------------------------------------------------------ revno: 6021 committer: Diego Biurrun branch nick: hipl timestamp: Wed 2011-07-20 14:29:47 +0200 message: Fix moduels ---> modules typo. ------------------------------------------------------------ revno: 6020 committer: Rene Hummen branch nick: trunk timestamp: Mon 2011-07-18 21:16:37 +0200 message: remove existing hip state when receiving I2 Note that this patch does not consider retransmissions of I2 packets yet and might result state with the same content to be first removed and then recreated. But at least, we clean-up possibly old state now and allow new connection establishment in case of inconsitent state. ------------------------------------------------------------ revno: 6019 committer: Rene Hummen branch nick: trunk timestamp: Mon 2011-07-18 18:41:13 +0200 message: move internal peer address update before sending of UPDATE This fixes a bug, where clients move behind a new NAT and get a new src ip AND src port. ------------------------------------------------------------ revno: 6018 committer: Rene Hummen branch nick: trunk timestamp: Mon 2011-07-18 18:35:08 +0200 message: add IP src address to locator set first This enables HIPL to first reply to locator that is known to work. ------------------------------------------------------------ revno: 6017 [merge] committer: Henrik Ziegeldorf branch nick: hipl timestamp: Mon 2011-07-18 16:11:03 +0200 message: Merged lp:~hipl-core/hipl/ecc revision 5442. ------------------------------------------------------------ revno: 6016 committer: Rene Hummen branch nick: trunk timestamp: Mon 2011-07-18 14:45:04 +0200 message: remove, rephrase and add conntrack debug output ------------------------------------------------------------ revno: 6015 committer: Miika Komu branch nick: hipl timestamp: Mon 2011-07-18 14:50:01 +0300 message: Documented a workaround for binary building Documented the workaround of the previous revision for CentOS 5.6. ------------------------------------------------------------ revno: 6014 fixes bug(s): https://launchpad.net/bugs/811538 committer: Miika Komu branch nick: hipl timestamp: Sat 2011-07-16 18:05:04 +0300 message: A bug fix to "make bin" on CentOS. As reported in bug id #811538, CentOS 5.6 fails to build due to a missing directory. Fixed. ------------------------------------------------------------ revno: 6013 fixes bug(s): https://launchpad.net/bugs/788578 committer: Miika Komu branch nick: hipl timestamp: Sat 2011-07-16 16:56:57 +0300 message: A tentative fix to a compilation problem in tools/pisacert.c As reported in bug id #788578, pisacert.c fails to compile on various Redhat-based systems. I think this will finally sort out the problem. ------------------------------------------------------------ revno: 6012 committer: Diego Biurrun branch nick: hipl timestamp: Thu 2011-07-14 18:10:49 +0200 message: cert: drop an unnecessary cast ------------------------------------------------------------ revno: 6011 committer: Diego Biurrun branch nick: hipl timestamp: Thu 2011-07-14 18:01:49 +0200 message: hostid: fix a small typo in doxygen documentation ------------------------------------------------------------ revno: 6010 committer: Rene Hummen branch nick: trunk timestamp: Thu 2011-07-14 14:34:34 +0200 message: update Copyright-Header to year of latest change ------------------------------------------------------------ revno: 6009 committer: Rene Hummen branch nick: trunk timestamp: Thu 2011-07-14 14:32:18 +0200 message: add missing doygen to hip_conf_add_id_to_ip_map() ------------------------------------------------------------ revno: 6008 fixes bug(s): https://launchpad.net/bugs/790493 committer: Rene Hummen branch nick: trunk timestamp: Thu 2011-07-14 13:30:16 +0200 message: add handler for ECHO_REQUEST_UNSIGNED parameter in UPDATE packets ------------------------------------------------------------ revno: 6007 committer: Rene Hummen branch nick: trunk timestamp: Thu 2011-07-14 11:32:59 +0200 message: handle missing ECHO_REQUEST parameter gracefully ------------------------------------------------------------ revno: 6006 committer: Henrik Ziegeldorf branch nick: hipl timestamp: Wed 2011-07-13 14:28:28 +0200 message: Check input to verify function to avoid segmentation faults. ------------------------------------------------------------ revno: 6005 committer: Henrik Ziegeldorf branch nick: hipl timestamp: Wed 2011-07-13 14:24:05 +0200 message: Remove unused define. ------------------------------------------------------------ revno: 6004 committer: Henrik Ziegeldorf branch nick: hipl timestamp: Wed 2011-07-13 13:46:36 +0200 message: Improved documentation of hip_host_id_to_hit and hip_private_dsa/rsa_host_id_to_hit. ------------------------------------------------------------ revno: 6003 committer: Henrik Ziegeldorf branch nick: hipl timestamp: Wed 2011-07-13 13:41:26 +0200 message: Removed useless abstractions for hip_host_id_to_it calls. ------------------------------------------------------------ revno: 6002 committer: Henrik Ziegeldorf branch nick: hipl timestamp: Wed 2011-07-13 13:36:20 +0200 message: Use HIP_IFEL for if-err-goto code. ------------------------------------------------------------ revno: 6001 committer: Henrik Ziegeldorf branch nick: hipl timestamp: Wed 2011-07-13 13:28:16 +0200 message: Remove duplicate checks of fp in save_rsa/dsa_private_key. ------------------------------------------------------------ revno: 6000 committer: Henrik Ziegeldorf branch nick: hipl timestamp: Wed 2011-07-13 13:23:24 +0200 message: Remove unused function declarations. ------------------------------------------------------------ revno: 5999 committer: Henrik Ziegeldorf branch nick: hipl timestamp: Wed 2011-07-13 13:19:59 +0200 message: Replaced if-err-goto code with HIP_IFEL in rsa/dsa_to_hip_endpoint ------------------------------------------------------------ revno: 5998 committer: Henrik Ziegeldorf branch nick: hipl timestamp: Wed 2011-07-13 13:12:46 +0200 message: Completed doxygen of function dsa_to_hip_endpoint ------------------------------------------------------------ revno: 5997 committer: Henrik Ziegeldorf branch nick: hipl timestamp: Wed 2011-07-13 13:10:10 +0200 message: Use switch case statement for differentiating cryptographic algorithms. This simplifies adding new algorithms (e.g. ECDSA). ------------------------------------------------------------ revno: 5996 committer: Henrik Ziegeldorf branch nick: hipl timestamp: Wed 2011-07-13 13:06:40 +0200 message: Inserted missing break in switch case statement. ------------------------------------------------------------ revno: 5995 committer: Henrik Ziegeldorf branch nick: hipl timestamp: Wed 2011-07-13 13:05:25 +0200 message: Use hip_get_host_id_algo directly without indirection through variable declaration. ------------------------------------------------------------ revno: 5994 committer: Henrik Ziegeldorf branch nick: hipl timestamp: Wed 2011-07-13 12:58:48 +0200 message: Remove useless comments. ------------------------------------------------------------ revno: 5993 committer: Henrik Ziegeldorf branch nick: hipl timestamp: Tue 2011-07-12 16:13:51 +0200 message: Simplified implementation of function hip_private_host_id_to_hit(). Replaced if/else by switch case statement. Removed cumbersome error handling. ------------------------------------------------------------ revno: 5992 committer: Henrik Ziegeldorf branch nick: hipl timestamp: Tue 2011-07-12 16:04:30 +0200 message: Replace if statement for crypto algorithm differentiation with switch statement and add error case. ------------------------------------------------------------ revno: 5991 committer: Henrik Ziegeldorf branch nick: hipl timestamp: Tue 2011-07-12 16:00:37 +0200 message: Minor improvements of const correctness in rule_management.c ------------------------------------------------------------ revno: 5990 committer: Henrik Ziegeldorf branch nick: hipl timestamp: Tue 2011-07-12 14:28:41 +0200 message: Replaced strlen with sizeof for string defined as macro in save_rsa/dsa_private_key. strlen() equals sizeof() - 1 in these cases. ------------------------------------------------------------ revno: 5989 committer: Diego Biurrun branch nick: hipl timestamp: Fri 2011-07-08 20:18:30 +0200 message: output.c: eliminate an unneeded variable indirection ------------------------------------------------------------ revno: 5988 committer: Diego Biurrun branch nick: hipl timestamp: Fri 2011-07-08 20:17:11 +0200 message: common.h: Put parentheses around #defines that are expressions and not values. Otherwise all hell can break loose if the #defines are evaluated in a place where operator precedence may mess with the intended semantics. ------------------------------------------------------------ revno: 5987 committer: Christoph Viethen branch nick: hipl timestamp: Fri 2011-07-08 19:10:43 +0200 message: Fix a bug in hip_opportunistic_ipv6_to_hit(), introduced in rev. 4843, which caused hip_build_digest() to be erroneously called with "length of pointer to IPv6 address" instead of "length of IPv6 address". This made hip_build_digest() calculate, platform-dependently, a digest of only the first quarter or the first half of the given IPv6 address. (Considering that in our case, most of the time, the IPv6 address in actual fact is an IPv4-mapped IPv6 address (cf. RFC 4291, 2.5.5.2.), where (more than) the first half consists of null bytes, the bug caused hip_build_digest() to always return the same digest no matter what (transformed) IPv4 address had been passed in. Consequently, pseudo HITs as generated for opportunistic base exchanges always were the same, causing trouble e.g. in HADB lookups.) ------------------------------------------------------------ revno: 5986 committer: Diego Biurrun branch nick: hipl timestamp: Fri 2011-07-08 18:28:12 +0200 message: hipconf: Remove outdated reference to a hipconf-related build system bug. ------------------------------------------------------------ revno: 5985 committer: Diego Biurrun branch nick: hipl timestamp: Fri 2011-07-08 18:27:05 +0200 message: doc: Fix wrong instructions for building the HIPL HOWTO. ------------------------------------------------------------ revno: 5984 fixes bug(s): https://launchpad.net/bugs/789319 committer: Miika Komu branch nick: trunk timestamp: Thu 2011-07-07 18:48:26 +0300 message: A bug fix to configuration file reading. Configuration file reading failed to read any lines from configuration file because newline wasn't removed. Fixed. ------------------------------------------------------------ revno: 5983 committer: Henrik Ziegeldorf branch nick: hipl timestamp: Thu 2011-07-07 16:56:25 +0200 message: Check control packet size before sending. Issue a warning if packet size exceeds MTU. ------------------------------------------------------------ revno: 5982 committer: Henrik Ziegeldorf branch nick: hipl timestamp: Thu 2011-07-07 16:23:46 +0200 message: Check packet destination hit when receiving a control packet. Drop packets destined for a hit that does not belong to the receiver. ------------------------------------------------------------ revno: 5981 committer: Henrik Ziegeldorf branch nick: hipl timestamp: Thu 2011-07-07 16:23:05 +0200 message: The error value must be set to non-zero in order to drop invalid loopback packets. ------------------------------------------------------------ revno: 5980 [merge] author: Stefan G?tz committer: Miika Komu branch nick: trunk timestamp: Thu 2011-07-07 16:36:18 +0300 message: Merged lp:hipl/peeraddr ------------------------------------------------------------ revno: 5979 committer: Diego Biurrun branch nick: hipl timestamp: Wed 2011-06-29 22:25:29 +0200 message: build: Add .dir-locals.el to distribution tarball. ------------------------------------------------------------ revno: 5978 committer: Diego Biurrun branch nick: hipl timestamp: Wed 2011-06-29 16:44:02 +0200 message: Add .dir-locals.el file that enforces the HIPL coding style for Emacs users. This works similar to the .vimrc file we already have for Vim users. ------------------------------------------------------------ revno: 5977 committer: Rene Hummen branch nick: trunk timestamp: Fri 2011-06-24 18:56:23 +0200 message: silence configure run by autobuilder for dist checks ------------------------------------------------------------ revno: 5976 committer: Rene Hummen branch nick: trunk timestamp: Fri 2011-06-24 17:16:01 +0200 message: remove remove_connection from debug in remove_connection() ------------------------------------------------------------ revno: 5975 committer: Rene Hummen branch nick: trunk timestamp: Fri 2011-06-24 15:54:52 +0200 message: add error handling for connection insertion by update ------------------------------------------------------------ revno: 5974 committer: Rene Hummen branch nick: trunk timestamp: Fri 2011-06-24 15:53:09 +0200 message: remove insertion of esp_tuple on 1st update The same operations are already performed in insert_connection_from_update(). ------------------------------------------------------------ revno: 5973 committer: Rene Hummen branch nick: trunk timestamp: Fri 2011-06-24 15:50:27 +0200 message: fix regression in esp_tuple_from_esp_info() The conditional depended on new_esp instead of esp_info and the function always returned NULL to the caller signaling an error. ------------------------------------------------------------ revno: 5972 committer: David Martin branch nick: hipl_startup timestamp: Wed 2011-06-22 15:25:54 +0200 message: Cosmetics: do not break "cond ? foo : bar" at colon in hipfw main.c. It looks neater with the full expression including ? on the next line. ------------------------------------------------------------ revno: 5971 committer: David Martin branch nick: hipl_startup timestamp: Tue 2011-06-21 17:12:00 +0200 message: Print warning for conflicting firewall options iff latter are set by user. Instead of printing the misleading warning "Warning: timeouts (-t) have no effect with connection tracking disabled (-F)" everytime the firewall is started with -F, print it only when -t _and_ -F are specified by the user. ------------------------------------------------------------ revno: 5970 committer: Miika Komu branch nick: trunk timestamp: Tue 2011-06-21 17:41:27 +0300 message: Updated a maintainer script. Configuration for building binaries for Fedora and Ubuntu are now up-to-date with the latest distributions. ------------------------------------------------------------ revno: 5969 committer: David Martin branch nick: hipl_init-scripts timestamp: Tue 2011-06-21 14:51:46 +0200 message: Do not exit on iptable flush error in hipfw init script. We are running the scripts with set -e, that means every unchecked command returning an error exits the script. In this case the function to flash the firewall rules prematurely exited the script when the rules had already been flushed. We now check the return value of the flush_iptables() function and print a notice if an error occurs. This commit fixes the error return value of the hipfw in bug 795848. ------------------------------------------------------------ revno: 5968 committer: David Martin branch nick: hipl_init-scripts timestamp: Tue 2011-06-21 14:50:02 +0200 message: Use start-stop-daemon in dnsproxy and hipfw debian init scripts. Both dnsproxy and hipfw init scripts now use the start-stop-daemon in a similar fashion as the hipd. This means: - it is not an error when the daemon is already running and start is called again, print a notice instead - let start-stop-daemon take care of exiting the daemon, it will send a TERM and wait for three seconds before killing it, there is no additional shell script magic necessary to test if the daemon is running This commit fixes the error return value of the dnsproxy in bug 795848. ------------------------------------------------------------ revno: 5967 committer: David Martin branch nick: hipl_init-scripts timestamp: Wed 2011-06-15 14:45:43 +0200 message: Remove needless stdout redirection from openwrt init scripts. Kill does not print anything, there is no need to redirect its output to /dev/null. ------------------------------------------------------------ revno: 5966 committer: Diego Biurrun branch nick: hipl timestamp: Tue 2011-06-14 23:14:52 +0200 message: doxygen: Warn if parameter documentation is missing for a function. ------------------------------------------------------------ revno: 5965 [merge] fixes bug(s): https://launchpad.net/bugs/789327 committer: Stefan G?tz branch nick: hipl timestamp: Sat 2011-06-11 20:46:09 +0200 message: Fix bug #789327: Add missing initialization to 'peer_addr' variable. Revision 5938 erroneously removed code that was necessary to change the value of the peer_addr pointer to an actual peer address. This caused a NULL pointer access and segmentation fault when handling a locator parameter during an UPDATE message. This merges the branch lp:~stefan.goetz/hipl/mobility-bug ------------------------------------------------------------ revno: 5964 fixes bug(s): https://launchpad.net/bugs/790833 committer: Diego Biurrun branch nick: hipl timestamp: Fri 2011-06-10 20:26:38 +0200 message: debian packaging: Make changelog a template file updated during package build. This allows adding a Bazaar revision number to the changelog and thus to the Debian package version without files under revision control getting modified. ------------------------------------------------------------ revno: 5963 committer: Miika Komu branch nick: trunk timestamp: Fri 2011-06-10 08:07:27 +0300 message: Text alignment Aligned the Ubuntu installation line with Fedora in INSTALL. ------------------------------------------------------------ revno: 5962 committer: Miika Komu branch nick: trunk timestamp: Fri 2011-06-10 07:54:09 +0300 message: Updated binary dependency instructions "make bin" had an extra dependency on a clean ubuntu/fedora installation. ------------------------------------------------------------ revno: 5961 committer: Diego Biurrun branch nick: hipl timestamp: Thu 2011-06-09 23:23:26 +0200 message: debian packaging: Integrate Bazaar revision number in package version. ------------------------------------------------------------ revno: 5960 committer: Diego Biurrun branch nick: hipl timestamp: Thu 2011-06-09 21:11:46 +0200 message: cosmetics: Add whitespace after shell output redirection operator. ------------------------------------------------------------ revno: 5959 committer: Diego Biurrun branch nick: hipl timestamp: Thu 2011-06-09 21:04:35 +0200 message: Add a note about the --author parameter of 'bzr commit' to the HACKING guide. ------------------------------------------------------------ revno: 5958 committer: Diego Biurrun branch nick: hipl timestamp: Thu 2011-06-09 19:19:33 +0200 message: conf: Remove empty Doxygen block and docs for a nonexisting function parameter. ------------------------------------------------------------ revno: 5957 committer: Diego Biurrun branch nick: hipl timestamp: Mon 2011-05-30 17:21:28 +0200 message: autobuild: Run diff against /dev/null instead of an empty file. ------------------------------------------------------------ revno: 5956 committer: Diego Biurrun branch nick: hipl timestamp: Mon 2011-05-30 17:20:48 +0200 message: autobuild: Ensure that check_dist_tarball() runs quiet by default. ------------------------------------------------------------ revno: 5955 committer: David Martin branch nick: hipl_init-scripts timestamp: Wed 2011-06-08 18:40:25 +0200 message: Check whether daemon is running in openwrt init scripts. Both hipd and hipfw create a PID file with their process id. Check against it to determine whether we actually have to start or stop the daemon. In case the daemon is already running or stopped print a notice respectively. ------------------------------------------------------------ revno: 5954 committer: David Martin branch nick: hipl_init-scripts timestamp: Wed 2011-06-08 15:32:52 +0200 message: Do not depend on network and local filesystem in debian init script. To avoid having network communication leaked without being handled by hipd or hipfw we should not force it to be started after the network has been established. We are only working on our local filesystem and should not wait for the setup of the remote filesystem either. This commit is a follow up to the review of commit 5952 archived here: http://www.freelists.org/post/hipl-dev/ Branch-hiplcorehipltrunk-Rev-5952-Require-network-and-local -filesystem-to-be-initialized-in-init-scripts ------------------------------------------------------------ revno: 5953 committer: David Martin branch nick: hipl_init-scripts timestamp: Tue 2011-06-07 17:25:35 +0200 message: Print notices when starting / stopping hipd via init script. When hipd is already running or already stopped when calling start or stop in the init script it should print a notice about it and not just report OK. ------------------------------------------------------------ revno: 5952 committer: David Martin branch nick: hipl_init-scripts timestamp: Tue 2011-06-07 16:33:45 +0200 message: Require network and local filesystem to be initialized in init scripts. The HIPL daemons should only be started after the filesystems and the network have been already set up. They should be exited before the filesystems and network gets teared down as well. Documentation on possible boot dependencies can be found here: http://refspecs.freestandards.org/LSB_3.1.0/LSB-Core-generic/ \ LSB-Core-generic/facilname.html ------------------------------------------------------------ revno: 5951 committer: David Martin branch nick: hipl_startup timestamp: Fri 2011-06-03 12:26:16 +0200 message: Rephrase ambiguous error message in hip_xfrm_policy_delete(). If the call to netlink_talk() fails when a policy is to be deleted it does not mean that there has been no associated policy. It can fail for any number of reasons (no socket has been set up, a malformed message was provided etc.). Thus only state that the policy deletion failed. ------------------------------------------------------------ revno: 5950 fixes bug(s): https://launchpad.net/bugs/790679 committer: David Martin branch nick: hipl_startup timestamp: Fri 2011-06-03 11:45:24 +0200 message: Add sanity check against netlink handle and header in netlink_talk(). netlink_talk() should check if it gets a valid netlink handle and message header before it tries to access them as it is not guaranteed that they are properly set up. For example when the initialization fails early and the default policies are nevertheless attempted to be removed on exit. This fixes bug 790679 (https://bugs.launchpad.net/hipl/+bug/790679). ------------------------------------------------------------ revno: 5949 fixes bug(s): https://launchpad.net/bugs/789306 committer: Miika Komu branch nick: trunk timestamp: Tue 2011-05-31 16:40:37 +0300 message: A bug fix from Joakim Koskela to "hipconf add map" failure (bug id 789306) As bug id 789306 reports, "hipconf add map" is defunctional. This patch (provided by Joakim) fixes the problem. Feel free to polish the bug fix directly if there's need for that. ------------------------------------------------------------ revno: 5948 fixes bug(s): https://launchpad.net/bugs/789298 committer: Miika Komu branch nick: trunk timestamp: Tue 2011-05-31 08:19:21 +0300 message: Applied a bug fix from Stefan G?tz to fix "hipconf rst all" crash. Stefan G?tz in #789298: In revno 5938, a hash table disguised as a list was replaced by an array. In one place, I forgot to replace the hash table handling code which was then erroneously invoked on the array which leads to the described crash and bug. ------------------------------------------------------------ revno: 5947 committer: Stefan G?tz branch nick: hipl timestamp: Sat 2011-05-28 13:54:04 +0200 message: Fix the file encoding comment so it correctly states that the file is in UTF-8 ------------------------------------------------------------ revno: 5946 committer: Rene Hummen branch nick: trunk timestamp: Fri 2011-05-27 15:46:44 +0200 message: add script enabling building of HIPL on remote host Detailed setup information can be found within the script itself. ------------------------------------------------------------ revno: 5945 committer: David Martin branch nick: trunk timestamp: Fri 2011-05-27 14:52:21 +0200 message: Do not print errors in killall call of hipd and hipfw init scripts. When hipd or hipfw is not running and killall is called it usually prints a notice that no process was killed. As the killall implementation on the routers has no quiet option redirect stderr to /dev/null instead. ------------------------------------------------------------ revno: 5944 committer: Miika Komu branch nick: trunk timestamp: Thu 2011-05-26 13:38:34 +0300 message: Updated ubuntu-specific instructions on compilation. Added debhelper as a dependency. ------------------------------------------------------------ revno: 5943 committer: Diego Biurrun branch nick: hipl timestamp: Wed 2011-05-25 19:41:59 +0200 message: Eliminate some unnecessary HIP_IFEL instances from lib/core/conf.c. ------------------------------------------------------------ revno: 5942 committer: Diego Biurrun branch nick: hipl timestamp: Thu 2011-05-19 14:05:49 +0200 message: Replace HIP_IFEL instances without condition check by HIP_OUT_ERR. HIP_OUT_ERR is the preferred way to print a message and exit. This also fixes the inverted condition that was never triggered. ------------------------------------------------------------ revno: 5941 committer: David Martin branch nick: trunk timestamp: Wed 2011-05-25 17:26:31 +0200 message: Add restart action to hipfw openwrt init-script. By default the openwrt call stops and starts hipfw when 'restart' is called. As hipfw gets started with the -k option by default it is not exited gracefully. Define the 'restart' call in the init script and sleep for 2 seconds after calling killall on hipfw. This should be sufficient to clear the firewall rules and free any states. ------------------------------------------------------------ revno: 5940 committer: David Martin branch nick: trunk timestamp: Wed 2011-05-25 17:03:42 +0200 message: Allow hipd to exit gracefully in openwrt init-script. When issuing a restart command and hipd is running, sleep for 5 seconds before calling hipd again to allow it to exit gracefully. This simulates the behaviour from the debian init scripts where start-stop-daemon does this automatically. The latter is not available on the routers so we use this workaround. ------------------------------------------------------------ revno: 5939 committer: Stefan G?tz branch nick: hipl timestamp: Tue 2011-05-24 21:36:27 +0200 message: Store commit message in file so it can be retrieved later instead of being lost on a closed terminal. This feature was requested by Diego. ------------------------------------------------------------ revno: 5938 [merge] committer: Stefan G?tz branch nick: hipl timestamp: Mon 2011-05-23 19:02:42 +0200 message: Merge the delist branch. Branch: https://code.launchpad.net/~stefan.goetz/hipl/delist Merge proposal: https://code.launchpad.net/~stefan.goetz/hipl/delist/+merge/60724 Remove some uses of the various linked list implementations from HIPL. ------------------------------------------------------------ revno: 5937 committer: Rene Hummen branch nick: trunk timestamp: Tue 2011-05-17 09:32:01 +0200 message: make autobuilder script executable again ------------------------------------------------------------ revno: 5936 committer: Diego Biurrun branch nick: hipl timestamp: Tue 2011-05-17 01:33:38 +0200 message: build system: Remove misleading comment from Makefile.am. The comment just tries to explain what BUILT_SOURCES is and what issues may arise when using it. That job has already been taken care of by the automake manual, in an infinitely better fashion. ------------------------------------------------------------ revno: 5935 committer: Rene Hummen branch nick: trunk timestamp: Mon 2011-05-16 16:23:23 +0200 message: properly incorporate 'get map' in hipconf moved some code in own functions for improved readability. ------------------------------------------------------------ revno: 5934 committer: Rene Hummen branch nick: trunk timestamp: Mon 2011-05-16 13:39:06 +0200 message: remove hipd restart functionality through hipconf init-scripts are the way to go here. ------------------------------------------------------------ revno: 5933 committer: Rene Hummen branch nick: trunk timestamp: Mon 2011-05-16 13:26:19 +0200 message: remove unused user messages ------------------------------------------------------------ revno: 5932 committer: Rene Hummen branch nick: trunk timestamp: Mon 2011-05-16 13:04:41 +0200 message: remove unused HANDOVER-related functionality from hipconf ------------------------------------------------------------ revno: 5931 committer: Rene Hummen branch nick: trunk timestamp: Mon 2011-05-16 13:00:04 +0200 message: remove write-only variable is_hard_handover ------------------------------------------------------------ revno: 5930 committer: Rene Hummen branch nick: trunk timestamp: Mon 2011-05-16 12:57:36 +0200 message: update hipconf usage string "hipconf del map" is and never was supported. ------------------------------------------------------------ revno: 5929 committer: Rene Hummen branch nick: trunk timestamp: Mon 2011-05-16 12:57:00 +0200 message: remove MHADDR-related functionality from hipconf ------------------------------------------------------------ revno: 5928 committer: Rene Hummen branch nick: trunk timestamp: Mon 2011-05-16 12:54:12 +0200 message: remove write-only variable is_active_mhaddr ------------------------------------------------------------ revno: 5927 committer: Rene Hummen branch nick: trunk timestamp: Mon 2011-05-16 12:41:36 +0200 message: rename hi-related user message types ------------------------------------------------------------ revno: 5926 committer: Rene Hummen branch nick: trunk timestamp: Mon 2011-05-16 12:29:41 +0200 message: move handling of HIP_MSG_ADD_DEL_SERVER into own function ------------------------------------------------------------ revno: 5925 committer: Rene Hummen branch nick: trunk timestamp: Mon 2011-05-16 11:59:00 +0200 message: remove unused user message HIP_MSG_PING ------------------------------------------------------------ revno: 5924 committer: Rene Hummen branch nick: trunk timestamp: Mon 2011-05-16 11:56:09 +0200 message: remove unused user message HIP_MSG_DEL_PEER_MAP_HIT_IP ------------------------------------------------------------ revno: 5923 committer: Rene Hummen branch nick: trunk timestamp: Mon 2011-05-16 11:55:18 +0200 message: remove unused user message HIP_MSG_NULL_OP ------------------------------------------------------------ revno: 5922 committer: Diego Biurrun branch nick: hipl timestamp: Tue 2011-05-03 14:54:05 +0200 message: vimrc: Read in the contents of a separate local customization file. This allows people to specify extra per-project settings or even override the settings from the PISA .vimrc - for whatever reason. ------------------------------------------------------------ revno: 5921 committer: Diego Biurrun branch nick: hipl timestamp: Tue 2011-05-03 14:53:24 +0200 message: vimrc: Set softtabstop instead of tabstop. The tabstop option affects what a literal TAB character is interpreted as, changing that setting disallows entering literal TAB characters, which is unwanted. Setting softtabstop instead makes the TAB key insert spaces, which is the desired behavior. ------------------------------------------------------------ revno: 5920 committer: David Martin branch nick: hipl_startup timestamp: Fri 2011-05-13 11:26:49 +0200 message: Remove reload option from hipl-daemon.init script. The reload option is not supported by us. hipd can not deal with a signal 1 and simply exits upon receiving it. Remove the reload option and treat a force-reload like a restart call instead. ------------------------------------------------------------ revno: 5919 committer: David Martin branch nick: hipl_startup timestamp: Fri 2011-05-13 11:06:36 +0200 message: Use start-stop-daemon to stop hipd in hipl-daemon.init script. We already use start-stop-daemon to start hipd and there is good reason to use it to exit it as well. With the specified --retry 3 option it waits for 3 seconds to allow hipd to terminate gracefully before it simply kills it. This should fix any issues with package installation where hipd was not yet properly exited but already started again and failing to do so. Unlike the kill call start-stop-daemon does actually wait for hipd to terminate. Move starting and exiting of hipd into functions as well to avoid code duplication. ------------------------------------------------------------ revno: 5918 committer: David Martin branch nick: hipl_startup timestamp: Fri 2011-05-13 10:41:16 +0200 message: Fix typo in hipl-daemon.init script. The reload option never had any effect as -name was interpreted as "--name ame" and the --quiet option suppressed the notification that no process was found with that name. ------------------------------------------------------------ revno: 5917 committer: Stefan G?tz branch nick: hipl timestamp: Wed 2011-05-11 00:19:52 +0200 message: Strengthen const correctness of public key functions ------------------------------------------------------------ revno: 5916 committer: Stefan G?tz branch nick: hipl timestamp: Wed 2011-05-11 00:14:13 +0200 message: Strengthen const correctness of hip_precreate_r1() ------------------------------------------------------------ revno: 5915 committer: Stefan G?tz branch nick: hipl timestamp: Wed 2011-05-11 00:13:39 +0200 message: Strengthen const correctness of hip_create_r1() ------------------------------------------------------------ revno: 5914 [merge] committer: Stefan G?tz branch nick: hipl timestamp: Tue 2011-05-10 23:50:21 +0200 message: Merge branch https://code.launchpad.net/~stefan.goetz/hipl/msg-bfr Merge proposal https://code.launchpad.net/~stefan.goetz/hipl/msg-bfr/+merge/59993 ------------------------------------------------------------ revno: 5913 [merge] committer: Stefan G?tz branch nick: hipl timestamp: Tue 2011-05-10 19:36:10 +0200 message: Merge branch https://code.launchpad.net/~stefan.goetz/hipl/lhi-storage Merge proposal https://code.launchpad.net/~stefan.goetz/hipl/lhi-storage/+merge/59992 ------------------------------------------------------------ revno: 5912 committer: David Martin branch nick: hipl_startup timestamp: Fri 2011-05-06 13:54:08 +0200 message: Remove pointless debug print from hip_netdev_event(). ------------------------------------------------------------ revno: 5911 committer: Rene Hummen branch nick: trunk timestamp: Thu 2011-05-05 11:48:40 +0200 message: fix debug output for received packets Previously, src was printed instead of dst. ------------------------------------------------------------ revno: 5910 committer: Rene Hummen branch nick: trunk timestamp: Tue 2011-05-03 14:24:30 +0200 message: remove unnecessary debug output ------------------------------------------------------------ revno: 5909 committer: Rene Hummen branch nick: trunk timestamp: Tue 2011-05-03 13:28:22 +0200 message: fix segfault due to incomplete initialization of esp_tuple The pointer to tuple was only set after the call to update_esp_address(), which in turn tried to access esp_tuple->tuple. Furthermore, this commit removes a redundant call to update_esp_address(). ------------------------------------------------------------ revno: 5908 committer: Rene Hummen branch nick: trunk timestamp: Tue 2011-05-03 12:33:44 +0200 message: only modify preferred addresses after locator update was confirmed ------------------------------------------------------------ revno: 5907 [merge] committer: Stefan G?tz branch nick: trunk timestamp: Mon 2011-05-02 23:30:25 +0200 message: Merge tip of trunk ------------------------------------------------------------ revno: 5906 committer: Stefan G?tz branch nick: trunk timestamp: Mon 2011-05-02 17:52:35 +0200 message: Remove unused function definitions and declarations from HIDB. ------------------------------------------------------------ revno: 5905 committer: Stefan G?tz branch nick: trunk timestamp: Mon 2011-05-02 16:22:21 +0200 message: From 'struct local_host_id', remove the 'lhi' field. It is in wire format and contains unused fields. Replace it with the two fields 'hit' and 'anonymous' which are actually used. ------------------------------------------------------------ revno: 5904 committer: Stefan G?tz branch nick: trunk timestamp: Mon 2011-05-02 16:19:14 +0200 message: Rename 'struct hip_host_id_entry' to the more meaningful 'struct local_host_id' ------------------------------------------------------------ revno: 5903 committer: Stefan G?tz branch nick: trunk timestamp: Mon 2011-05-02 16:17:17 +0200 message: Rename 'struct hip_lhi' to 'struct hip_host_id_local' for consistency with the other 'struct hip_host_id' types and to allow to use the 'lhi' abbreviation more meaningfully. ------------------------------------------------------------ revno: 5902 committer: David Martin branch nick: hipl timestamp: Sun 2011-05-01 14:14:15 +0200 message: Remove needless free() in insert_connection_from_update() error handling. There is no need to call free on connection->reply.hip_tuple->data as it gets allocated last and will never need to be free'd in case of an error. ------------------------------------------------------------ revno: 5901 committer: David Martin branch nick: hipl timestamp: Sun 2011-05-01 14:07:44 +0200 message: Remove needless free() call in update_esp_address() error handling. There is no need to call free() on esp_addr->update_id as it gets allocated at last and will not need to be freed in case of an error. ------------------------------------------------------------ revno: 5900 committer: David Martin branch nick: hipl timestamp: Sun 2011-05-01 14:03:58 +0200 message: Change return value of update_esp_address() from bool to int. The err variable of the HIP_IFEL was set but never used breaking compilation with gcc 4.6. Use it as a return value instead of the bool. Adjust the documentation and the check for return values of callers handle_i2(), handle_r2(), and update_esp_tuple(). This fixes the last of the -Wunused-but-set-variable warnings. ------------------------------------------------------------ revno: 5899 committer: David Martin branch nick: hipl timestamp: Sun 2011-05-01 13:35:49 +0200 message: Return int instead of bool in insert_connection_from_update(). The err variable of the HIP_IFEL is never used breaking compilation with gcc 4.6. Change the return value from bool to int to make use of err and adjust the documentation accordingly. Adjust the check for the return value in handle_update() as well. Note that this revision does NOT compile with gcc 4.6 because of one remaining warning. ------------------------------------------------------------ revno: 5898 committer: David Martin branch nick: hipl timestamp: Sun 2011-05-01 13:14:37 +0200 message: Remove HIP_IFEL from esp_tuple_from_esp_info_locator(). gcc 4.6 introduced the new warning -Wunused-but-set-variable which is activated by default with -Wall. In this case it breaks compilation as the err variable of the HIP_IFEL is set but never used. Remove the HIP_IFEL to fix the warning and get rid of an unnecessary call to free(). Note that this revision does NOT compile with gcc 4.6 as two warnings remain. ------------------------------------------------------------ revno: 5897 committer: Stefan G?tz branch nick: hipl timestamp: Sat 2011-04-30 23:36:17 +0200 message: Stregthen const correctness of hip_sockaddr_is_v6_mapped() ------------------------------------------------------------ revno: 5896 committer: Stefan G?tz branch nick: hipl timestamp: Sat 2011-04-30 23:34:27 +0200 message: Strengthen const correctness of hip_filter_address() ------------------------------------------------------------ revno: 5895 [merge] committer: Stefan G?tz branch nick: hipl timestamp: Sat 2011-04-30 23:30:59 +0200 message: Strengthen const correctness of IS_LSI() macro ------------------------------------------------------------ revno: 5894 committer: David Martin branch nick: hipl_valgrind timestamp: Thu 2011-04-28 19:00:00 +0200 message: Clarify documentation of the state_uninit_functions list. The stored uninitialization functions can be executed with a lmod_uninit_state_items call. ------------------------------------------------------------ revno: 5893 committer: David Martin branch nick: hipl_valgrind timestamp: Thu 2011-04-28 18:55:21 +0200 message: Fix documentation of lmod_run_functions_on_state(). Refer to parameters in the documentation with @c and not with @parameter. ------------------------------------------------------------ revno: 5892 committer: David Martin branch nick: hipl_valgrind timestamp: Thu 2011-04-28 18:45:52 +0200 message: Add and register function to uninitialize an update_state instance. hip_update_uninit_state() frees the memory that was allocated in the update_state instance. Register it as a state_uninit_function so that it gets called on purging of a host association. Add a note that the name used for registering the update_state instance has to be the same in both init and uninit function. This fixes a memory leak as the memory was not free'd before. ------------------------------------------------------------ revno: 5891 committer: David Martin branch nick: hipl_valgrind timestamp: Thu 2011-04-28 17:59:35 +0200 message: Uninitialize modular state items on purging of a host association. This commit introduces lmod_uninit_state_items. It simply calls all registered uninitialization functions on the modular state. It is called when a HA is purged and the modular state instance is deleted. ------------------------------------------------------------ revno: 5890 committer: David Martin branch nick: hipl_valgrind timestamp: Thu 2011-04-28 17:40:54 +0200 message: Refactor lmod_init_state_items() to avoid code duplication. This commit introduces lmod_run_functions_on_state(). So far only lmod_init_state_items() makes use of it but a method that calls uninitialization functions will soon be added and work in the same way on a different list. Having a static function which accepts the respective list as a parameter avoids code duplication. ------------------------------------------------------------ revno: 5889 committer: David Martin branch nick: hipl_valgrind timestamp: Thu 2011-04-28 16:54:35 +0200 message: Add function to free memory allocated for state uninitialization functions. lmod_uninit_state_uninit_functions() frees all memory that was allocated for the linked list of registered modular state uninitialization functions. Add a note stating the existence of this function in lmod_register_state_uninit_function() and call the uninit function on hipd exit. ------------------------------------------------------------ revno: 5888 committer: David Martin branch nick: hipl_valgrind timestamp: Thu 2011-04-28 16:42:04 +0200 message: Add function to register modular state uninitialization functions. This commit introduces a linked list for uninitialization functions for the modular state. Any modular state item that allocates memory should register an uninitialization function that takes care of freeing that memory. Use lmod_register_state_uninit_function() to register such a function. ------------------------------------------------------------ revno: 5887 committer: David Martin branch nick: hipl_valgrind timestamp: Thu 2011-04-28 16:32:19 +0200 message: Remove pointless NULL-check in lmod_register_state_init_function(). Our hip_ll implementation checks for NULL pointers provided as parameters. There is no need to check it explicitly beforehand. ------------------------------------------------------------ revno: 5886 committer: David Martin branch nick: hipl_valgrind timestamp: Thu 2011-04-28 16:28:20 +0200 message: Add const-correctness for lmod_register_state_init_function(). ------------------------------------------------------------ revno: 5885 committer: Rene Hummen branch nick: trunk timestamp: Wed 2011-04-20 13:18:19 +0200 message: fix missing include for scratchbox build ------------------------------------------------------------ revno: 5884 committer: Rene Hummen branch nick: trunk timestamp: Wed 2011-04-20 11:45:30 +0200 message: add missing include for performance measurements ------------------------------------------------------------ revno: 5883 committer: Diego Biurrun branch nick: hipl timestamp: Wed 2011-04-20 11:38:46 +0200 message: Remove unnecessary #ifdefs around a declaration in a header file. ------------------------------------------------------------ revno: 5882 committer: Diego Biurrun branch nick: hipl timestamp: Wed 2011-04-20 11:38:33 +0200 message: Eliminate two more HIP_IFEL instances introduced by puzzle_fixes merge. ------------------------------------------------------------ revno: 5881 committer: Rene Hummen branch nick: trunk timestamp: Wed 2011-04-20 11:18:09 +0200 message: refactor mobility code This commit refactors the mobility update functionality to allow for parameter handle functions to be hooked into the modularization. Midauth functionality depends on this implementation. Specifically, the following steps have been done: - hip_create_update_msg(): split into parameter handling functions - hip_send_update_to_one_peer(): packet type-specific code moved to the corresponding parameter handle functions - hip_handle_first/second/third_update_packet(): split into parameter handling functions Additionally, applicable review comments of the merge proposal (https://code.launchpad.net/~rene-hummen/hipl/mobility-fixes/+merge/57496) have been addressed. ------------------------------------------------------------ revno: 5880 committer: Rene Hummen branch nick: trunk timestamp: Wed 2011-04-20 11:10:18 +0200 message: adapt midauth puzzle functionality to new puzzle API The commit also introduces const-correctness for all functions touched. ------------------------------------------------------------ revno: 5879 committer: Rene Hummen branch nick: trunk timestamp: Tue 2011-04-19 18:22:10 +0200 message: refactor puzzle handling functionality and API This commit merges lp:~rene-hummen/hipl/puzzle-fixes. Solving puzzles and verifying solutions has been refactored and the API for puzzle computation has been changed to prepare for use with the midauth extension. Newly added functionality has been tested with unit tests and on virtual machines. Additionally, the data types for the puzzle and solution values have been changed from uint64_t to uint8_t[8]. Finally, applicable review comments for the merge request (lp:~rene-hummen/hipl/puzzle-fixes/+merge/57446) have been addressed. ------------------------------------------------------------ revno: 5878 committer: Diego Biurrun branch nick: hipl timestamp: Tue 2011-04-19 16:27:00 +0200 message: Fix typo in HIP_OUT_ERR macro. The second argument passed to HIP_IFEL from HIP_OUT_ERR was named "err" instead of "eval". So instead of passing both its arguments to HIP_IFEL, HIP_OUT_ERR passed only one argument, plus a random value that, by unlucky coincidence, happened to be declared in the environment because HIP_IFEL relies on a variable named "err" to exist in its scope. The effect of this fatal mistake is that most functions using HIP_OUT_ERR did return success instead of failure error codes to their callers, since "err" is used as return value and in most cases initialized to the value denoting success. ------------------------------------------------------------ revno: 5877 committer: Henrik Ziegeldorf branch nick: hipl timestamp: Tue 2011-04-19 14:24:30 +0200 message: Fixed segmentation fault in performance module and added null safety check. ------------------------------------------------------------ revno: 5876 committer: Diego Biurrun branch nick: hipl timestamp: Mon 2011-04-18 13:59:17 +0200 message: solve.c: Replace HIP_IFEL instances by if-return error handling. ------------------------------------------------------------ revno: 5875 committer: Diego Biurrun branch nick: hipl timestamp: Thu 2011-04-14 09:47:41 +0200 message: Standardize multiple inclusion guard names in modules subdirectory. ------------------------------------------------------------ revno: 5874 committer: Rene Hummen branch nick: trunk timestamp: Thu 2011-04-14 11:00:07 +0200 message: add assert for locator state during BEX processing ------------------------------------------------------------ revno: 5873 committer: Rene Hummen branch nick: trunk timestamp: Thu 2011-04-14 10:55:31 +0200 message: move R1 locator processing to update module and hook into modularization This removes a further dependency from base functionality to the update module. Furthermore, I moved the new handle function to update_param_handling.c, as there is already another locator handler. These should be unified after merging the mobility-fixes branch. ------------------------------------------------------------ revno: 5872 committer: Diego Biurrun branch nick: hipl timestamp: Thu 2011-04-14 09:23:10 +0200 message: Add missing modularization header. ------------------------------------------------------------ revno: 5871 committer: Diego Biurrun branch nick: hipl timestamp: Thu 2011-04-14 09:16:42 +0200 message: Ignore config.cache; generated during caching 'configure -C' runs. ------------------------------------------------------------ revno: 5870 committer: Rene Hummen branch nick: trunk timestamp: Wed 2011-04-13 15:32:46 +0200 message: fix doxygen comments ------------------------------------------------------------ revno: 5869 committer: Rene Hummen branch nick: trunk timestamp: Wed 2011-04-13 15:28:58 +0200 message: move hip_handle_locator_parameter() to new file also move dependent static functions to the same file and make struct update_state accessible outside update.c. ------------------------------------------------------------ revno: 5868 committer: Rene Hummen branch nick: mobility-fixes timestamp: Wed 2011-04-13 11:30:54 +0200 message: make update_types available to modules depending on update ------------------------------------------------------------ revno: 5867 committer: Rene Hummen branch nick: mobility-fixes timestamp: Wed 2011-04-13 11:15:41 +0200 message: move locator-related functionality to update_locator.c ------------------------------------------------------------ revno: 5866 committer: Rene Hummen branch nick: mobility-fixes timestamp: Wed 2011-04-13 11:01:21 +0200 message: move handle_locator() to update module ------------------------------------------------------------ revno: 5865 committer: Rene Hummen branch nick: trunk timestamp: Wed 2011-04-13 15:17:28 +0200 message: refactor update functions to work on packets instead of parameters This step has been done to prepare for the upcoming update refactoring. ------------------------------------------------------------ revno: 5864 committer: Rene Hummen branch nick: trunk timestamp: Tue 2011-04-12 19:22:25 +0200 message: fix inclusion guards ------------------------------------------------------------ revno: 5863 committer: David Martin branch nick: hipl_valgrind timestamp: Tue 2011-04-12 16:47:35 +0200 message: In make_env() use strcpy() instead of strcat() to copy a string to allocated memory. strcat() uses the null-termination of the destination to decide where to append a string. Using it to write into freshly allocated uninitialised memory results in undefined behaviour as it writes wherever the first \0 occurs. Use strcpy() instead. ------------------------------------------------------------ revno: 5862 committer: David Martin branch nick: hipl_valgrind timestamp: Mon 2011-04-11 17:28:35 +0200 message: On hipd exit free memory allocated for parameter types. hip_exit() now calls lmod_uninit_parameter_types() so that memory allocated for the parameter types will be free'd on exit. ------------------------------------------------------------ revno: 5861 committer: Rene Hummen branch nick: trunk timestamp: Mon 2011-04-11 15:48:11 +0200 message: document cron integration of the auto-builder ------------------------------------------------------------ revno: 5860 committer: Rene Hummen branch nick: trunk timestamp: Mon 2011-04-11 14:56:12 +0200 message: add constness to hip_mac_and_sign_packet() ------------------------------------------------------------ revno: 5859 committer: Rene Hummen branch nick: trunk timestamp: Mon 2011-04-11 14:48:58 +0200 message: fixed return value for failing malloc ------------------------------------------------------------ revno: 5858 committer: Rene Hummen branch nick: trunk timestamp: Fri 2011-04-08 18:53:59 +0200 message: rename update_legacy.{c,h} to update_locator.{c,h} The only code in update_legacy.c is locator related. Furthermore, locator- related functionality is also located in update.c. This prepares moving of locator-related functionality to the renamed file. ------------------------------------------------------------ revno: 5857 committer: Rene Hummen branch nick: trunk timestamp: Fri 2011-04-08 18:49:10 +0200 message: add test/check_lib_tool to bzr ignore list ------------------------------------------------------------ revno: 5856 committer: Rene Hummen branch nick: trunk timestamp: Fri 2011-04-08 18:46:24 +0200 message: split mac and sign function into parameter handler and general function We now have the function with an API to be used directly and one to be used in combination with packet handling. This will be needed by the mobility extension. ------------------------------------------------------------ revno: 5855 committer: Rene Hummen branch nick: trunk timestamp: Tue 2011-02-08 19:41:54 +0100 message: disable triggering of UPDATEs for esp tokens This is fixed in another branch. ------------------------------------------------------------ revno: 5854 fixes bug(s): https://launchpad.net/bugs/754384 committer: Diego Biurrun branch nick: hipl timestamp: Fri 2011-04-08 11:04:39 +0200 message: Fix compilation when libconfig is not available on the system. Some symbols were recently made static, but only used if libconfig was detected during compilation. Surround these symbols by the appropriate #ifdef to protect against the compiler complaining about unused symbols. ------------------------------------------------------------ revno: 5853 committer: Diego Biurrun branch nick: unused_code timestamp: Tue 2011-03-29 21:12:04 +0200 message: Remove unused function hip_del_peer_info(). ------------------------------------------------------------ revno: 5852 committer: Rene Hummen branch nick: trunk timestamp: Fri 2011-04-08 10:47:50 +0200 message: remove write-only variables solved_puzzle and I ------------------------------------------------------------ revno: 5851 committer: Rene Hummen branch nick: trunk timestamp: Thu 2011-04-07 18:58:58 +0200 message: remove pointless changing of byte-order ------------------------------------------------------------ revno: 5850 committer: Rene Hummen branch nick: r1-split timestamp: Thu 2011-04-07 16:55:43 +0200 message: remove unused parameter from hip_produce_keying_material() ------------------------------------------------------------ revno: 5849 author: Christof Mroz committer: Rene Hummen branch nick: midauth-pisa timestamp: Sat 2011-04-02 22:38:36 +0200 message: Move keymat generation code back to its original place. The keymat must be generated before producing any parameters. This was violated by the previous commit but has been restored now. Also added some (related) const qualifiers to ensure that the input packet is not modified, avoiding confusion in subsequently called handler functions. We are striving for modularization in this branch, after all. ------------------------------------------------------------ revno: 5848 committer: Rene Hummen branch nick: r1-split timestamp: Thu 2011-04-07 16:39:26 +0200 message: Split monolithic R1 handler into a number of smaller handlers. This allows for more granular module hooking. The current R1 handler was too monolithic to incorporate midauth as a module, for example. This is mostly needed to ensure the correct parameter order in the packet. This split has originally been done by Christof Mroz. ------------------------------------------------------------ revno: 5847 committer: Rene Hummen branch nick: trunk timestamp: Thu 2011-04-07 15:18:19 +0200 message: remove --enable/--disable-opportunistic from autobuilder options ------------------------------------------------------------ revno: 5846 committer: Rene Hummen branch nick: trunk timestamp: Thu 2011-04-07 15:10:22 +0200 message: fix unused variable issue Some variables are only used with CONFIG_HIP_RVS enabled. Before, these variables were dependent on CONFIG_HIP_OPPORTUNISTIC, which was removed earlier. ------------------------------------------------------------ revno: 5845 committer: Christof Mroz branch nick: hipl timestamp: Wed 2011-04-06 22:46:37 +0200 message: Specify correct year in license boilerplate for newly added files. ------------------------------------------------------------ revno: 5844 committer: Christof Mroz branch nick: hipl timestamp: Wed 2011-04-06 22:27:16 +0200 message: Don't export fixed return value of system(3) mock as a (currently unused) global variable. This can easily be reintroduced when needed later. ------------------------------------------------------------ revno: 5843 committer: Rene Hummen branch nick: trunk timestamp: Wed 2011-04-06 17:52:33 +0200 message: Unit test for IPv4 and UDP checksum routines. These unit-tests have originally been implemented by Christof Mroz. ------------------------------------------------------------ revno: 5842 committer: Rene Hummen branch nick: trunk timestamp: Wed 2011-04-06 17:46:11 +0200 message: Minor refactoring of struct hip_fw_context Make packet type constants globally available as an enum, and remove unused TCP packet type. This change was originally made by Christof Mroz. ------------------------------------------------------------ revno: 5841 committer: Rene Hummen branch nick: trunk timestamp: Wed 2011-04-06 11:07:51 +0200 message: remove configure option "opportunistic" and related ifdefs We have always been running HIPL with the remaining basic opportunistic mode enabled. The functionality didn't cause any trouble (fairly limited code size). So, removing an unnecessary compilation path. ------------------------------------------------------------ revno: 5840 committer: Rene Hummen branch nick: trunk timestamp: Wed 2011-04-06 11:03:16 +0200 message: remove unnecessary include for tcp ------------------------------------------------------------ revno: 5839 committer: Rene Hummen branch nick: trunk timestamp: Wed 2011-04-06 09:47:38 +0200 message: remove constness from esp_tuple pointer The scratchbox environment would not compile otherwise. ------------------------------------------------------------ revno: 5838 committer: Rene Hummen branch nick: trunk timestamp: Wed 2011-04-06 09:45:21 +0200 message: add missing includes Missing cause compiler issues in scratchbox environment. ------------------------------------------------------------ revno: 5837 committer: Diego Biurrun branch nick: unused_code timestamp: Tue 2011-04-05 18:44:22 +0200 message: Mark global variables unused outside of their translation units as static. ------------------------------------------------------------ revno: 5836 committer: Diego Biurrun branch nick: hipl timestamp: Tue 2011-04-05 17:51:10 +0200 message: Mark action_handler function as static, it is unused outside of the file. ------------------------------------------------------------ revno: 5835 committer: Diego Biurrun branch nick: hipl timestamp: Tue 2011-04-05 17:49:54 +0200 message: Mark hip_private_rsa_host_id_to_hit() as static. The function is unused outside of the file it is defined in. ------------------------------------------------------------ revno: 5834 committer: Diego Biurrun branch nick: hipl timestamp: Tue 2011-04-05 17:47:17 +0200 message: Move extern variable declarations for maintenance.c to maintenance.h. ------------------------------------------------------------ revno: 5833 committer: Diego Biurrun branch nick: hipl timestamp: Tue 2011-04-05 16:01:38 +0200 message: Move hip_firewall_is_alive() declaration to maintenance.h, where it belongs. ------------------------------------------------------------ revno: 5832 committer: Diego Biurrun branch nick: hipl timestamp: Tue 2011-04-05 14:46:27 +0200 message: cosmetics: Sort entries in HIPL_HEADER_LOCATIONS differently. ------------------------------------------------------------ revno: 5831 committer: Diego Biurrun branch nick: hipl timestamp: Tue 2011-04-05 14:45:58 +0200 message: Fix copyright year in newly-added file. ------------------------------------------------------------ revno: 5830 committer: Christof Mroz branch nick: hipl timestamp: Tue 2011-04-05 14:00:43 +0200 message: Added missing doxygen parameter documentation. ------------------------------------------------------------ revno: 5829 [merge] committer: Christof Mroz branch nick: hipl timestamp: Tue 2011-04-05 13:25:00 +0200 message: Merged lp:~christof-mroz/hipl/hipfw-esp-speedup branch. ------------------------------------------------------------ revno: 5828 [merge] committer: Christof Mroz branch nick: hipl timestamp: Tue 2011-04-05 13:21:52 +0200 message: Merged lp:~christof-mroz/hipl/hipfw-timeout branch. ------------------------------------------------------------ revno: 5827 [merge] committer: Christof Mroz branch nick: hipl timestamp: Tue 2011-04-05 13:18:51 +0200 message: Merged lp:~christof-mroz/hipl/mock-functions branch. ------------------------------------------------------------ revno: 5826 committer: Rene Hummen branch nick: trunk timestamp: Mon 2011-04-04 21:23:44 +0200 message: fix copy-paste error in auto-builder Replace $VERSION variable with regular expression. ------------------------------------------------------------ revno: 5825 committer: Rene Hummen branch nick: trunk timestamp: Mon 2011-04-04 19:11:09 +0200 message: enable building HIPL for maemo5 directly use our make setup instead of dpkg-buildpackage. ------------------------------------------------------------ revno: 5824 committer: Diego Biurrun branch nick: hipl timestamp: Mon 2011-04-04 16:05:27 +0200 message: Eliminate unnecessary global variables in test programs. ------------------------------------------------------------ revno: 5823 committer: Diego Biurrun branch nick: hipl timestamp: Mon 2011-04-04 16:03:37 +0200 message: Move number_dh_keys global variable into the only scope it is used in. ------------------------------------------------------------ revno: 5822 committer: Diego Biurrun branch nick: hipl timestamp: Mon 2011-04-04 16:01:51 +0200 message: Remove a bunch of unused global variables. ------------------------------------------------------------ revno: 5821 committer: Diego Biurrun branch nick: hipl timestamp: Mon 2011-04-04 15:59:21 +0200 message: Add some required #includes that were previously missed and used implicitly. ------------------------------------------------------------ revno: 5820 committer: Diego Biurrun branch nick: hipl timestamp: Mon 2011-04-04 15:56:55 +0200 message: Eliminate write-only variable load_time. ------------------------------------------------------------ revno: 5819 committer: Diego Biurrun branch nick: hipl timestamp: Mon 2011-04-04 15:53:26 +0200 message: Move esp_prot_transforms declaration to the only place it is used. ------------------------------------------------------------ revno: 5818 committer: Diego Biurrun branch nick: hipl timestamp: Mon 2011-04-04 15:50:32 +0200 message: cosmetics: Reorder #includes to follow coding guidelines. ------------------------------------------------------------ revno: 5817 author: Stefan G?tz committer: Diego Biurrun branch nick: hipl timestamp: Mon 2011-04-04 11:51:05 +0200 message: misc const correctness fixes This was extracted from the hip-ll-extensions branch, courtesy of Stefan G?tz. ------------------------------------------------------------ revno: 5816 committer: Christof Mroz branch nick: hipl timestamp: Mon 2011-04-04 00:32:34 +0200 message: Clarify documentation of update_esp_address(). ------------------------------------------------------------ revno: 5815 committer: Christof Mroz branch nick: hipl timestamp: Mon 2011-04-04 00:28:10 +0200 message: Revert one more inlining of update_esp_address(). Same rationale as detailed in commit log of rev 5814. ------------------------------------------------------------ revno: 5814 committer: Christof Mroz branch nick: hipl timestamp: Sun 2011-04-03 23:28:25 +0200 message: Revert update_esp_address() signature, and replace one inlined instance of it by a function call. This was refactored to eliminate the esp_tuple parameter. But Passing the whole tuple is actually nice: There is one unified hook to catch all address updates per-tuple, e.g. for writing extensions. ------------------------------------------------------------ revno: 5813 fixes bug(s): https://launchpad.net/bugs/724246 committer: Miika Komu branch nick: trunk timestamp: Sat 2011-04-02 11:57:53 +0300 message: Documented an issue related to the DNS proxy. DNS proxy succeeded in injecting HITs from /etc/hip/hosts when invoked with e.g. "host" command. However, the same failed to occur with a normal application such as ssh. Artturi spotted that the issue was not with the DNS proxy itself. After some inspecting, I believe something has changed in libc of Ubuntu Lucid and onwards because there hasn't been virtually any changes in the DNS proxy. The issue can be solved by modifying /etc/nsswitch.conf as I have now documented in HOWTO.xml. See bug id #724246 in launchpad for further information. ------------------------------------------------------------ revno: 5812 [merge] committer: Stefan G?tz branch nick: hipl timestamp: Sat 2011-04-02 03:20:33 +0200 message: Merge lp:~stefan.goetz/hipl/esp-destination-addresses / merge proposal 55640 https://code.launchpad.net/~stefan.goetz/hipl/esp-destination-addresses/+merge/55640 ------------------------------------------------------------ revno: 5811 committer: David Martin branch nick: hipl_valgrind timestamp: Fri 2011-04-01 14:30:35 +0200 message: Cosmetics: reorder comparisons in if-statements in modularization.c. When comparing the return value of a function to an integer, place the latter on the right side of the equation. ------------------------------------------------------------ revno: 5810 committer: Stefan G?tz branch nick: hipl timestamp: Wed 2011-03-30 01:02:26 +0200 message: In insert_connection_from_update(), add NULL-pointer checks to error handler to avoid derefencing NULL pointers. Thanks to Christof for spotting this in rev 5801. ------------------------------------------------------------ revno: 5809 committer: Diego Biurrun branch nick: hipl timestamp: Tue 2011-03-29 23:04:29 +0200 message: Make list_last() static, it is unused outside of its source file. ------------------------------------------------------------ revno: 5808 committer: Diego Biurrun branch nick: hipl timestamp: Tue 2011-03-29 23:03:41 +0200 message: Make hip_reinject_packet() static, it is unused outside of the file. ------------------------------------------------------------ revno: 5807 committer: Diego Biurrun branch nick: hipl timestamp: Tue 2011-03-29 22:46:47 +0200 message: Make hip_dsa_*/hip_rsa_* functions only used within the file static. ------------------------------------------------------------ revno: 5806 committer: Diego Biurrun branch nick: hipl timestamp: Tue 2011-03-29 22:35:53 +0200 message: Make hip_cert_spki_create_cert_sock() static; it is unused outside of the file. ------------------------------------------------------------ revno: 5805 committer: Diego Biurrun branch nick: hipl timestamp: Tue 2011-03-29 22:12:06 +0200 message: Remove unused global variable hip_user_addr from hipd. ------------------------------------------------------------ revno: 5804 committer: Diego Biurrun branch nick: hipl timestamp: Tue 2011-03-29 22:07:55 +0200 message: Move hip_use_userspace_ipsec extern declaration to hipd.h, where it belongs. ------------------------------------------------------------ revno: 5803 committer: Diego Biurrun branch nick: hipl timestamp: Tue 2011-03-29 21:46:16 +0200 message: Make hip_del_pending_request_by_type() static; it is only used within the file. ------------------------------------------------------------ revno: 5802 committer: Diego Biurrun branch nick: hipl timestamp: Tue 2011-03-29 20:12:08 +0200 message: Mark hip_remove_iface_local_hit() as static; it is only used within the file. ------------------------------------------------------------ revno: 5801 committer: Stefan G?tz branch nick: hipl timestamp: Tue 2011-03-29 20:15:45 +0200 message: Add error handling to insert_connection_from_update(). So far, this function assumed that all memory allocations succeed without checking that. This change introduces these checks and makes sure that there are no memory leaks when the function aborts with an error. ------------------------------------------------------------ revno: 5800 committer: Stefan G?tz branch nick: hipl timestamp: Tue 2011-03-29 19:55:57 +0200 message: Add a necessary cast to the list initialization. Without the cast, the code doesn't compile. It's rice cake, baby. ------------------------------------------------------------ revno: 5799 committer: Stefan G?tz branch nick: hipl timestamp: Tue 2011-03-29 18:48:08 +0200 message: Introduce an initializer for 'struct hip_ll'. This allows to initialize a 'struct hip_ll' object statically in addition to the 'hip_ll_init()' function that needs to be called at runtime. ------------------------------------------------------------ revno: 5798 committer: Diego Biurrun branch nick: hipl timestamp: Tue 2011-03-29 17:07:45 +0200 message: Mark hip_get_any_localhost_hit() as static; it is only used within the file. ------------------------------------------------------------ revno: 5797 committer: Diego Biurrun branch nick: hipl timestamp: Tue 2011-03-29 17:05:43 +0200 message: Move declaration for hip_init_cipher() to hipd/dh.h, where it belongs. ------------------------------------------------------------ revno: 5796 committer: Diego Biurrun branch nick: hipl timestamp: Tue 2011-03-29 17:04:59 +0200 message: Remove declaration for nonexisting hip_uninit_cipher() function. ------------------------------------------------------------ revno: 5795 committer: Diego Biurrun branch nick: hipl timestamp: Tue 2011-03-29 17:01:26 +0200 message: Mark hip_opp_get_hadb_entry() as static; it is only used within the file. ------------------------------------------------------------ revno: 5794 committer: Diego Biurrun branch nick: hipl timestamp: Sun 2011-03-27 19:28:34 +0200 message: cosmetics: Remove redundant parentheses around complete expressions. ------------------------------------------------------------ revno: 5793 committer: Diego Biurrun branch nick: hipl timestamp: Fri 2011-03-25 18:51:40 +0100 message: build system: Link against firewall object files instead of #including .c files. If a .c file needs symbols from other .c files then either all of them have to be #included or the object files linked to the unit test; just link them to the unit test right away. This will simplify some firewall unit tests being added in other branches. ------------------------------------------------------------ revno: 5792 committer: Diego Biurrun branch nick: hipl timestamp: Fri 2011-03-25 17:49:07 +0100 message: autobuilder: Disable scratchbox test again until scratchbox is properly set up. ------------------------------------------------------------ revno: 5791 committer: Diego Biurrun branch nick: hipl timestamp: Fri 2011-03-25 17:00:43 +0100 message: test/firewall: Add stdlib.h #include for mkstemp. ------------------------------------------------------------ revno: 5790 [merge] committer: Diego Biurrun branch nick: hipl timestamp: Thu 2011-03-24 20:26:36 +0100 message: Merge c99_declarations branch to get rid of most C++/C99 declarations. ------------------------------------------------------------ revno: 5789 committer: Diego Biurrun branch nick: hipl timestamp: Thu 2011-03-24 20:06:54 +0100 message: Remove unused struct hip_entry_list. ------------------------------------------------------------ revno: 5788 committer: Diego Biurrun branch nick: hipl timestamp: Thu 2011-03-24 18:28:49 +0100 message: cosmetics: Place some '*' differently to make uncrustify happy. ------------------------------------------------------------ revno: 5787 committer: Diego Biurrun branch nick: hipl timestamp: Thu 2011-03-24 16:35:57 +0100 message: Remove some completely pointless debug statements. ------------------------------------------------------------ revno: 5786 committer: Diego Biurrun branch nick: hipl timestamp: Thu 2011-03-24 16:20:27 +0100 message: Remove some completely pointless debug statements. ------------------------------------------------------------ revno: 5785 committer: Diego Biurrun branch nick: hipl timestamp: Thu 2011-03-24 16:15:14 +0100 message: Replace some pointless instances of HIP_IFEL by returns. When HIP_IFEL is just used to return an integer, it makes more sense to avoid the goto and the macro indirection. ------------------------------------------------------------ revno: 5784 committer: Christof Mroz branch nick: hipl timestamp: Thu 2011-03-24 12:35:48 +0100 message: Don't call cleanup routine on assertion. This reverts revision 5779. ------------------------------------------------------------ revno: 5783 committer: Diego Biurrun branch nick: hipl timestamp: Wed 2011-03-23 15:25:28 +0100 message: autobuild: Reenable scratchbox compilation test. Now that the scratchbox environment is set up again, it should work. ------------------------------------------------------------ revno: 5782 committer: Diego Biurrun branch nick: hipl timestamp: Wed 2011-03-23 15:04:01 +0100 message: autobuilder: Fix path to scratchbox environment, which was moved on the server. ------------------------------------------------------------ revno: 5781 committer: David Martin branch nick: hipl_valgrind timestamp: Tue 2011-03-22 15:30:04 +0100 message: Always close the opened file after reading / writing the certificate config. During startup the certificate config file is read with fopen() but only closed again when it is not yet existing. Make sure to close it in any case to free the memory allocated during the access. ------------------------------------------------------------ revno: 5780 [merge] committer: Christof Mroz branch nick: hipl timestamp: Tue 2011-03-22 12:47:58 +0100 message: Merged hipfw-split-main branch. ------------------------------------------------------------ revno: 5779 committer: Christof Mroz branch nick: hipl timestamp: Tue 2011-03-22 11:24:32 +0100 message: Attempt graceful exit on failed assert(), using a SIGABRT handler. ------------------------------------------------------------ revno: 5778 committer: Christof Mroz branch nick: hipl timestamp: Tue 2011-03-22 11:24:09 +0100 message: Handle multiple invocations of signal handler. ------------------------------------------------------------ revno: 5777 committer: David Martin branch nick: hipl_valgrind timestamp: Mon 2011-03-21 18:23:35 +0100 message: Free memory allocated for state initialization functions on hipd exit. During startup memory gets allocated for a linked list holding state initialization functions but it is not free'd again. This commit introduces lmod_uninit_state_init_functions() which frees the allocated memory and is called by hip_exit() on shutdown. ------------------------------------------------------------ revno: 5776 committer: David Martin branch nick: hipl_valgrind timestamp: Mon 2011-03-21 16:09:23 +0100 message: On exit free memory allocated for Diffie-Hellman key generation. Not all memory allocated with DH_new() gets free'd by DH_free(). Calling CRYPTO_cleanup_all_ex_data() in hip_dh_uninit() when exiting hipd takes care of that. ------------------------------------------------------------ revno: 5775 committer: David Martin branch nick: hipl_typos timestamp: Fri 2011-03-18 17:43:03 +0100 message: Cosmetics: fix two typos and correct the placement of a parameter documentation. in hip_produce_keying_material(): the documentation for the parameters should be in the same order as the parameters themselves. ------------------------------------------------------------ revno: 5774 committer: David Martin branch nick: hipl_valgrind timestamp: Fri 2011-03-18 17:33:49 +0100 message: Const-correctness for hip_generate_dh_key(). ------------------------------------------------------------ revno: 5773 committer: David Martin branch nick: hipl_valgrind timestamp: Fri 2011-03-18 16:28:35 +0100 message: Actually return -1 on error in hip_insert_dh() as stated in the documentation. ------------------------------------------------------------ revno: 5772 committer: David Martin branch nick: hipl_valgrind timestamp: Fri 2011-03-18 15:29:24 +0100 message: Do not reset or free DH shared key in hip_handle_r1(). This fixes a memory leak as the reference to the allocated memory was lost by resetting the pointer to NULL. The memory gets free'd during close procedure in hip_del_peer_info_entry(), therefore remove the free() call in hip_handle_r1() and adjust the comment in hip_create_keying_material() to reflect the change. ------------------------------------------------------------ revno: 5771 committer: Rene Hummen branch nick: trunk timestamp: Fri 2011-03-18 13:59:22 +0100 message: change startup option of hipfw on OpenWRT The midauth extensions is currently broken and needs fixing. Furthermore, use the firewall's kill switch in order to have comparable start-up behaviour as hipd. ------------------------------------------------------------ revno: 5770 [merge] committer: Christof Mroz branch nick: hipl timestamp: Fri 2011-03-18 10:13:11 +0100 message: Merged rename-camelcased branch. ------------------------------------------------------------ revno: 5769 committer: Christof Mroz branch nick: hipl timestamp: Thu 2011-03-17 11:21:53 +0100 message: Define a more readable interface to hip_manage_iface_local_hit(). ------------------------------------------------------------ revno: 5768 committer: Christof Mroz branch nick: hipl timestamp: Wed 2011-03-16 21:32:16 +0100 message: Fix const-correctness of hip_manage_iface_local_hit() ------------------------------------------------------------ revno: 5767 committer: Rene Hummen branch nick: trunk timestamp: Wed 2011-03-16 14:15:02 +0100 message: output error message in case hit/lsi resolves to hit/lsi ------------------------------------------------------------ revno: 5766 committer: Rene Hummen branch nick: trunk timestamp: Wed 2011-03-16 13:32:58 +0100 message: fix IS_LSI32 and IS_IPV4_LOOPBACK macros Both macros checked for the wrong addresses on ARM platforms. Specifically, they matched x.y.z.1 and x.y.z.127 respectively. ------------------------------------------------------------ revno: 5765 committer: Christof Mroz branch nick: hipl timestamp: Wed 2011-03-16 13:37:06 +0100 message: Remove all assigned local HITs from the virtual interface on exit. Also refactored hip_add_iface_local_hit() a bit in the process. ------------------------------------------------------------ revno: 5764 committer: Christof Mroz branch nick: hipl timestamp: Tue 2011-03-15 12:17:07 +0100 message: Remove virtual interface address (i.e., the HIT) before assigning it. Because revision 5723 disabled module unloading, the dummy device was shut down but otherwise left in a non-initialized state. In particular, the address (HIT) was kept. So on the next start of hipd, assigning the HIT again did not set up the 2001:10::/28 route correctly. Presumably, to netlink it looked like a no-op, because the address is set to the current value after all. As an added bonus, removing the address probably triggers other side-effects of RTM_NEWADDR that you'd have with a blank interface. ------------------------------------------------------------ revno: 5763 committer: David Martin branch nick: hipl_valgrind timestamp: Mon 2011-03-14 11:40:46 +0100 message: Add two missing consts in modularization.h. Const-correctness of lmod_register_parameter_type() and lmod_register_packet_type() was added in revision 5750 and 5762 but only in modularization.c. This applies the change to modularization.h as well. ------------------------------------------------------------ revno: 5762 committer: David Martin branch nick: hipl_valgrind timestamp: Mon 2011-03-14 10:52:08 +0100 message: Const-correctness for lmod_register_packet_type(). ------------------------------------------------------------ revno: 5761 committer: Christof Mroz branch nick: hipl timestamp: Fri 2011-03-11 12:57:17 +0100 message: Simplify command line string concatenation. ------------------------------------------------------------ revno: 5760 committer: Rene Hummen branch nick: trunk timestamp: Tue 2011-03-08 15:11:08 +0100 message: revert revision 5724 -> renaming of dummy device Aparently, the dummy device dummy0 is created automatically on insertion of the dummy module. The only option to rename the device actually would be to create another device via udev as described here: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=430528 An even better way would be to get rid of the dummy device althogther and to replace it with a tun device. This way we could also get rid of the Linux-specific raw sockets. ------------------------------------------------------------ revno: 5759 committer: Christof Mroz branch nick: hipl timestamp: Fri 2011-03-11 11:18:34 +0100 message: Declare hip_list and esp_list as static. ------------------------------------------------------------ revno: 5758 committer: Christof Mroz branch nick: hipl timestamp: Fri 2011-03-11 11:17:22 +0100 message: Actually do return a negative value on failure, where it is stated in the documentation. ------------------------------------------------------------ revno: 5757 committer: Christof Mroz branch nick: hipl timestamp: Thu 2011-03-10 13:55:26 +0100 message: Emit a more specific debug message. ------------------------------------------------------------ revno: 5756 committer: Christof Mroz branch nick: hipl timestamp: Thu 2011-03-10 12:53:43 +0100 message: Enable doxygen comment for hip_fw_handle_hip_output(). ------------------------------------------------------------ revno: 5755 committer: Christof Mroz branch nick: hipl timestamp: Tue 2011-03-08 17:03:25 +0100 message: Also free list links in free_esp_tuple(). Rather than just the data they contain. ------------------------------------------------------------ revno: 5754 committer: David Martin branch nick: hipl_hipfw timestamp: Mon 2011-03-07 15:48:05 +0100 message: Cosmetics: fix typo in hip_firewall_cache_delete_hldb() debug output. ------------------------------------------------------------ revno: 5753 fixes bug(s): https://launchpad.net/bugs/695328 committer: David Martin branch nick: hipl_hipfw timestamp: Mon 2011-03-07 15:35:25 +0100 message: Check whether firewall cache db was initialised in hip_firewall_cache_delete_hldb(). Before deleting entries from the database make sure that it was actually initialised. This fixes the segfault reported in bug 695328. ------------------------------------------------------------ revno: 5752 committer: David Martin branch nick: hipl_homework timestamp: Sat 2011-03-05 14:53:32 +0100 message: Fix memory leak, check successful registration in lmod_register_parameter_type(). The allocated memory has to be freed in case of an error. Check the return value of hip_ll_add() to make sure the parameter does get registered successfully. ------------------------------------------------------------ revno: 5751 committer: David Martin branch nick: hipl_homework timestamp: Sat 2011-03-05 14:47:39 +0100 message: Fix typos, clarify doxygen doc and error output for lmod_register_parameter_type. Typos: The method registers parameters and not packets. Parameter types get freed by lmod_uninit_parameter_types and not by lmod_uninit_packet_types as stated in the doxygen documentation. Make it clear that the call frees all allocated memory as well. Error output should reflect what went wrong. In this case a missing identifier or an already registered parameter type. ------------------------------------------------------------ revno: 5750 committer: David Martin branch nick: hipl_homework timestamp: Sat 2011-03-05 14:11:49 +0100 message: Const correctness for lmod_register_parameter_type. ------------------------------------------------------------ revno: 5749 committer: David Martin branch nick: hipl_homework timestamp: Sat 2011-03-05 14:06:41 +0100 message: Cosmetics: make error prints in lmod_register_parameter_type a bit more pretty. ------------------------------------------------------------ revno: 5748 committer: Diego Biurrun branch nick: hipl timestamp: Fri 2011-03-04 20:26:22 +0100 message: Use the LHASH_CAST definition from hashtable.h instead of duplicating it. ------------------------------------------------------------ revno: 5747 committer: Diego Biurrun branch nick: hipl timestamp: Fri 2011-03-04 20:25:24 +0100 message: hashtable.h: Remove unnecessary list.h #include. ------------------------------------------------------------ revno: 5746 committer: Diego Biurrun branch nick: hipl timestamp: Fri 2011-03-04 20:23:35 +0100 message: OpenSSL: Add back mistakenly removed LHASH_CAST #define. LHASH_CAST needs to be #defined both when LHASH_OF is available or not, so add an empty #define for the latter case. ------------------------------------------------------------ revno: 5745 committer: Diego Biurrun branch nick: hipl timestamp: Fri 2011-03-04 20:04:49 +0100 message: OpenSSL: Restructure LHASH100_CAST handling. Make the macro a complete cast statement, rename it to LHASH_CAST and skip defining the macro when LHASH_OF is undefined. ------------------------------------------------------------ revno: 5744 committer: Diego Biurrun branch nick: hipl timestamp: Fri 2011-03-04 19:58:28 +0100 message: Remove unnecessary HIPL_OPENSSL_100 macro indirection. HIPL_OPENSSL_100 was semantically the same as LHASH_OF, so use the latter. ------------------------------------------------------------ revno: 5743 committer: Diego Biurrun branch nick: hipl timestamp: Fri 2011-03-04 19:57:52 +0100 message: Remove unused HIPL_OPENSSL_100 #define. ------------------------------------------------------------ revno: 5742 committer: Diego Biurrun branch nick: hipl timestamp: Fri 2011-03-04 19:11:13 +0100 message: doc: Fix a multitude of spelling, wording, formatting and style issues. ------------------------------------------------------------ revno: 5741 committer: Diego Biurrun branch nick: hipl timestamp: Fri 2011-03-04 19:09:59 +0100 message: doc: Fix sections about RPM and Debian packaging to match current behavior. ------------------------------------------------------------ revno: 5740 committer: Diego Biurrun branch nick: hipl timestamp: Fri 2011-03-04 19:08:49 +0100 message: doc: FIX description of the 'make dist' automake target. ------------------------------------------------------------ revno: 5739 committer: Diego Biurrun branch nick: hipl timestamp: Fri 2011-03-04 19:04:21 +0100 message: doc: Adjust path to uncrustify configuration file. ------------------------------------------------------------ revno: 5738 committer: Diego Biurrun branch nick: hipl timestamp: Fri 2011-03-04 19:01:25 +0100 message: doc: Add section about avoiding C system and POSIX namespace pollution. ------------------------------------------------------------ revno: 5737 committer: Diego Biurrun branch nick: hipl timestamp: Fri 2011-03-04 14:28:11 +0100 message: doc: Add section about fixing bzr mistakes and warn against 'bzr uncommit'. To drive the point about 'bzr uncommit' on central, published repositories being evil home, the section comes with a tongue-in-cheek warning about the dire straits awaiting perpetrators :) ------------------------------------------------------------ revno: 5736 committer: Rene Hummen branch nick: trunk timestamp: Thu 2011-03-03 11:20:36 +0100 message: fix setting of dummy interface MTU dummy0 was hard-coded in the string executed as a command. Replaced dummy0 by HIP_HIT_DEV to reflect the renaming of the device. ------------------------------------------------------------ revno: 5735 committer: Rene Hummen branch nick: trunk timestamp: Tue 2011-03-01 19:36:53 +0100 message: mark function parameters as unused ------------------------------------------------------------ revno: 5734 committer: Rene Hummen branch nick: trunk timestamp: Tue 2011-03-01 19:35:26 +0100 message: remove more redundant per-packet output ------------------------------------------------------------ revno: 5733 fixes bug(s): https://launchpad.net/bugs/697564 committer: Rene Hummen branch nick: trunk timestamp: Tue 2011-03-01 19:32:07 +0100 message: check dst hit and controls for _all_ BEX messages ------------------------------------------------------------ revno: 5732 committer: Rene Hummen branch nick: trunk timestamp: Tue 2011-03-01 19:20:34 +0100 message: remove redundant address check hip_hidb_hit_is_our will do the deal. ------------------------------------------------------------ revno: 5731 committer: Rene Hummen branch nick: trunk timestamp: Tue 2011-03-01 19:18:58 +0100 message: remove incorrect comment ------------------------------------------------------------ revno: 5730 committer: Rene Hummen branch nick: trunk timestamp: Tue 2011-03-01 19:18:31 +0100 message: remove redundant comments ------------------------------------------------------------ revno: 5729 committer: Rene Hummen branch nick: trunk timestamp: Tue 2011-03-01 19:16:41 +0100 message: modify misleading comment ------------------------------------------------------------ revno: 5728 committer: Rene Hummen branch nick: trunk timestamp: Tue 2011-03-01 19:12:22 +0100 message: replace int state value with corresponding string NOTE: the packet type will already be shown in the packet dump ------------------------------------------------------------ revno: 5727 committer: Rene Hummen branch nick: trunk timestamp: Tue 2011-03-01 19:10:32 +0100 message: check packet content before printing debug ------------------------------------------------------------ revno: 5726 committer: Rene Hummen branch nick: trunk timestamp: Tue 2011-03-01 19:08:46 +0100 message: change checksum comment to reflect truth ------------------------------------------------------------ revno: 5725 committer: Rene Hummen branch nick: trunk timestamp: Tue 2011-03-01 19:05:59 +0100 message: add HITs from HIP header contents to packet dump ------------------------------------------------------------ revno: 5724 fixes bug(s): https://launchpad.net/bugs/706820 committer: Rene Hummen branch nick: trunk timestamp: Tue 2011-03-01 16:12:42 +0100 message: rename dummy0 interface to hipl0 The rational behind this change is: 1.) dummy0 does not convey the purpose of the device, and 2.) the name does not instill trust in the maturity of HIPL as mentioned by Stefan in the corresponding bug entry. NOTE: The HOWTO does currently not mention retrieving the default HIT from the output of ifconfig and similar applications. Hence, there there is no need of modifying the documentation. ------------------------------------------------------------ revno: 5723 committer: Rene Hummen branch nick: trunk timestamp: Tue 2011-03-01 13:09:37 +0100 message: remove unloading of kernel modules on hipd exit This functionality is removed for several reasons: 1.) other programs started subsequent to hipd might depend on the loaded modules, and 2.) HIPL does currently not support reloading modules on OpenWRT. ------------------------------------------------------------ revno: 5722 committer: Rene Hummen branch nick: trunk timestamp: Tue 2011-03-01 11:02:52 +0100 message: remove enabling of ip forwarding in /proc at firewall startup I removed this for several reasons: 1) It was not disabled at hipfw shutdown. 2) The firewall can also be run on end-hosts, where forwarding is not desired. 3) There might be situations where IP forwarding is unwanted. However, in such case, hipfw could not be executed. NOTE: Enabling of IP forwarding is already mentioned in the HOWTO. ------------------------------------------------------------ revno: 5721 committer: Rene Hummen branch nick: trunk timestamp: Tue 2011-03-01 10:38:45 +0100 message: add missing netinet/in.h includes ------------------------------------------------------------ revno: 5720 committer: David Martin branch nick: hipl_register_socket timestamp: Fri 2011-02-25 16:18:27 +0100 message: Bring back HIP_IFEL error handling for hip_register_socket(). A HIP_IFEL occurrence was removed by myself in an earlier commit. This commit reverts it and adds a second HIP_IFEL check. ------------------------------------------------------------ revno: 5719 committer: David Martin branch nick: hipl_typos timestamp: Fri 2011-02-25 13:40:17 +0100 message: Cosmetics: fix some typos in doxygen documentation. ------------------------------------------------------------ revno: 5718 committer: Diego Biurrun branch nick: rpm timestamp: Thu 2011-02-24 21:17:28 +0100 message: RPM: Exit build with unpackaged files. Now that we have worked around the previously generated warnings we can be strict about this and avoid further issues from slipping in. ------------------------------------------------------------ revno: 5717 committer: Diego Biurrun branch nick: rpm timestamp: Thu 2011-02-24 21:07:57 +0100 message: RPM: Set proper attributes on installed files. This fixes a ton of rpmlint warnings. ------------------------------------------------------------ revno: 5716 committer: Diego Biurrun branch nick: rpm timestamp: Thu 2011-02-24 20:58:50 +0100 message: RPM: Add Python (>= 2.4.3) to BuildRequires. ------------------------------------------------------------ revno: 5715 fixes bug(s): https://launchpad.net/bugs/723117 committer: Diego Biurrun branch nick: rpm timestamp: Thu 2011-02-24 19:33:35 +0100 message: RPM: Remove unused/unwanted files from buildroot after make install. This avoids some rpmbuild warnings about installed but unpackaged files. ------------------------------------------------------------ revno: 5714 committer: Diego Biurrun branch nick: rpm timestamp: Thu 2011-02-24 18:30:52 +0100 message: RPM: Use predefined RPM variables when installing files into system paths. ------------------------------------------------------------ revno: 5713 committer: Diego Biurrun branch nick: rpm timestamp: Thu 2011-02-24 18:29:12 +0100 message: RPM: Use SMP flags set by RPM instead of hardcoding '-j 32' as make parameter. ------------------------------------------------------------ revno: 5712 committer: Diego Biurrun branch nick: rpm timestamp: Thu 2011-02-24 18:25:32 +0100 message: RPM: Fix infrahip HIPL source URL, MIT license name, spelling nits. ------------------------------------------------------------ revno: 5711 committer: Diego Biurrun branch nick: rpm timestamp: Thu 2011-02-24 18:15:37 +0100 message: RPM: Run setup in quiet mode; this avoids a ton of useless debugging output. ------------------------------------------------------------ revno: 5710 committer: Diego Biurrun branch nick: rpm timestamp: Thu 2011-02-24 18:04:22 +0100 message: RPM: Preserve timestamps when installing HIPL init scripts. ------------------------------------------------------------ revno: 5709 committer: Diego Biurrun branch nick: rpm timestamp: Thu 2011-02-24 18:03:57 +0100 message: RPM: Split summary and description fields in individual package stanzas. The summary field should just contain a one-line short description. ------------------------------------------------------------ revno: 5708 committer: Diego Biurrun branch nick: rpm timestamp: Thu 2011-02-24 18:03:11 +0100 message: RPM: Place HIPL packages in the correct package groups/sections. It should be 'System Environment/Daemons' and 'Documentation' for hipl-doc. ------------------------------------------------------------ revno: 5707 committer: Diego Biurrun branch nick: hipl timestamp: Thu 2011-02-24 11:51:06 +0100 message: build system: Fix docdir declaration for CentOS; the hipl/ subdir was missing. ------------------------------------------------------------ revno: 5706 committer: Diego Biurrun branch nick: hipl timestamp: Thu 2011-02-24 10:29:01 +0100 message: build system: Consolidate all CentOS 5.5 hacks in configure.ac. Carrying around CentOS 5.5 hacks in Makefile.am has sideeffects on non-broken platforms, which is unacceptable. Forcing the user to pass flags to configure for CentOS is a burden. Adding workarounds in configure.ac is ugly, because the platform shortcomings are ugly, but causes the least amount of pain. ------------------------------------------------------------ revno: 5705 committer: Diego Biurrun branch nick: hipl timestamp: Thu 2011-02-24 10:24:58 +0100 message: RPM: Remove unnecessary CentOS hack for installing pixmaps directory. HIPL does not require that directory and RPMs build fine without the hack. ------------------------------------------------------------ revno: 5704 committer: David Martin branch nick: hipl_valgrind timestamp: Wed 2011-02-23 17:50:57 +0100 message: Rewrite error handling in hip_register_socket() and catch possible memory leak. Due to the simplicity of hip_register_socket() the HIP_IFEL macro is not necessary. The memory allocated for the socketfd struct should be freed in case of an error to avoid memory leakage. ------------------------------------------------------------ revno: 5703 committer: David Martin branch nick: hipl_valgrind timestamp: Wed 2011-02-23 17:18:19 +0100 message: Add hip_unregister_sockets() to free socket list. The memory allocated by hip_register_sockets() was not freed on exit resulting in a memory leak. This fixes it. ------------------------------------------------------------ revno: 5702 committer: Diego Biurrun branch nick: hipl timestamp: Wed 2011-02-23 17:53:11 +0100 message: Update comment that explains the createion of struct inet6_pktinfo. It is a GNUism that was copied into HIPL and should eventually be removed. ------------------------------------------------------------ revno: 5701 committer: Diego Biurrun branch nick: hipl timestamp: Wed 2011-02-23 17:47:30 +0100 message: Replace u_char BSD type by standard unsigned char. ------------------------------------------------------------ revno: 5700 committer: David Martin branch nick: hipl_valgrind timestamp: Wed 2011-02-23 15:13:59 +0100 message: Add doxygen documentation for hip_register_socket(). ------------------------------------------------------------ revno: 5699 committer: David Martin branch nick: hipl_valgrind timestamp: Wed 2011-02-23 15:03:47 +0100 message: Rename hip_init_sockets() to hip_register_sockets(). Add doxygen documentation. hip_init_sockets() is misleading as the function does not initialise the sockets. Initialisation of the sockets happens in hipd_init(). Instead it registers the sockets with their associated handler functions and it should be named accordingly. Added a doxygen comment as well. ------------------------------------------------------------ revno: 5698 committer: Diego Biurrun branch nick: write-only code timestamp: Wed 2011-02-23 14:30:50 +0100 message: Remove some write-only variables from fw_port_bindings_performance. The return value of the benchmarked functions is now discarded instead of captured in a variable. Stefan and I doublechecked that gcc does not optimize away the function invocations. This avoids a bunch of warnings with -Wunused-but-set-variable in gcc 4.6. ------------------------------------------------------------ revno: 5697 committer: Diego Biurrun branch nick: write-only code timestamp: Tue 2011-02-22 20:26:00 +0100 message: Avoid using a write-only variable in time_clock(). This avoids a warning with -Wunused-but-set-variable in gcc 4.6. ------------------------------------------------------------ revno: 5696 committer: Diego Biurrun branch nick: write-only code timestamp: Tue 2011-02-22 20:24:16 +0100 message: Rewrite error handling in hip_firewall_cache_hadb_match(). Currently error values are set to -1 via HIP_IFEL macros, but in the end NULL is returned in case of error and the error values are ignored. Change the HIP_IFEL instances to set the pointer holding the return value to NULL instead and get rid of the int variable for the error values. This code will not win a beauty contest, but it eliminates the write-only integer variable err, which caused warnings with -Wunused-but-set-variable. ------------------------------------------------------------ revno: 5695 committer: Diego Biurrun branch nick: write-only code timestamp: Tue 2011-02-22 20:23:14 +0100 message: Remove write-only variables from the lib and tools subdirectories. This avoids a bunch of warnings with -Wunused-but-set-variable in gcc 4.6. ------------------------------------------------------------ revno: 5694 committer: Diego Biurrun branch nick: write-only code timestamp: Tue 2011-02-22 20:16:13 +0100 message: Fix return value of hip_ipaddr_modify(). The function was unconditionally returning 0 even though the Doxygen header claimed it returns negative on error. Make it return the error integer variable that is set in error conditions throughout the function instead. ------------------------------------------------------------ revno: 5693 committer: Diego Biurrun branch nick: write-only code timestamp: Tue 2011-02-22 20:12:13 +0100 message: hipd: Remove write-only variables. This avoids a bunch of warnings with -Wunused-but-set-variable in gcc 4.6. ------------------------------------------------------------ revno: 5692 committer: Diego Biurrun branch nick: write-only code timestamp: Tue 2011-02-22 20:09:11 +0100 message: firewall: Remove write-only variables. This avoids a bunch of warnings with -Wunused-but-set-variable in gcc 4.6. ------------------------------------------------------------ revno: 5691 committer: Diego Biurrun branch nick: hipl timestamp: Tue 2011-02-22 20:04:36 +0100 message: whitespace cosmetics ------------------------------------------------------------ revno: 5690 committer: Diego Biurrun branch nick: hipl timestamp: Tue 2011-02-22 19:40:39 +0100 message: Rewrite error handling in hip_create_r1(). Currently error values are set to -1 via HIP_IFEL macros, but in the end NULL is returned in case of error and the error values are ignored. Change the HIP_IFEL instances to set the pointer holding the return value to NULL instead and get rid of the int variable for the error values. This code will not win a beauty contest, but it eliminates the write-only integer variable err, which caused warnings with -Wunused-but-set-variable. ------------------------------------------------------------ revno: 5689 committer: Diego Biurrun branch nick: hipl timestamp: Tue 2011-02-22 19:30:19 +0100 message: doxygen: Fix @return comment for hip_create_r1(). ------------------------------------------------------------ revno: 5688 committer: Diego Biurrun branch nick: hipl timestamp: Tue 2011-02-22 18:10:34 +0100 message: cookie: Replace some goto/HIP_IFE/HIP_IFEL statements by return error handling. ------------------------------------------------------------ revno: 5687 committer: Diego Biurrun branch nick: hipl timestamp: Tue 2011-02-22 16:56:22 +0100 message: hipd does not depend on iptables, hipfw does; update package deps accordingly. ------------------------------------------------------------ revno: 5686 fixes bug(s): https://launchpad.net/bugs/715607 committer: Miika Komu branch nick: trunk timestamp: Tue 2011-02-22 14:50:07 +0200 message: Solved a problem with RPM packaged DNS proxy. Bug id #715607 describes a problem with RPM packaged DNS proxy: The DNS proxy is not using python APIs in way compatible with python 2.7. Can we support both 2.6 and 2.7? hipserver # /etc/init.d/hipdnsproxy start Starting : [ OK ] [root@hipserver hipl]# Traceback (most recent call last): File "/usr/sbin/hipdnsproxy", line 1029, in main(sys.argv) File "/usr/sbin/hipdnsproxy", line 1026, in main gp.doit(args) File "/usr/sbin/hipdnsproxy", line 731, in doit gp.write_local_hits_to_hosts() File "/usr/sbin/hipdnsproxy", line 535, in write_local_hits_to_hosts if not gp.getaddr(hit): File "/usr/sbin/hipdnsproxy", line 410, in getaddr r = h.getaddr(ahn) AttributeError: Hosts instance has no attribute 'getaddr' The problem was that the system had also /usr/sbin/hosts.py which was located before the HIPL version of hosts.py in the module search path. I rolled the DNS proxy path to the front path and it started working again. Tested on Fedora Core 14 and Ubuntu Maverick. If you have a more elegant solution, feel free to contribute. ------------------------------------------------------------ revno: 5685 committer: Diego Biurrun branch nick: hipl timestamp: Mon 2011-02-21 23:37:51 +0100 message: Refactor hip_handle_i1() control flow to work without goto. This eliminates the last instances of the HIP_IFF macro, so delete it. ------------------------------------------------------------ revno: 5684 committer: Diego Biurrun branch nick: hipl timestamp: Mon 2011-02-21 23:20:42 +0100 message: Refactor hip_check_i1() control flow to work without goto. ------------------------------------------------------------ revno: 5683 committer: Diego Biurrun branch nick: hipl timestamp: Mon 2011-02-21 22:43:18 +0100 message: cosmetics: prettyprinting; remove pointless parentheses; kill leftover comment ------------------------------------------------------------ revno: 5682 committer: Diego Biurrun branch nick: hipl timestamp: Mon 2011-02-21 22:13:19 +0100 message: Refactor hip_add_signed_echo_response() / hip_add_unsigned_echo_response(). The functions just differed in two parameters passed to helper functions. Extract the code into a helper function that receives a parameter telling it which packet variant to build. ------------------------------------------------------------ revno: 5681 committer: Diego Biurrun branch nick: hipl timestamp: Mon 2011-02-21 21:27:41 +0100 message: Refactor hip_sign_and_mac_packet() to avoid the use of goto. ------------------------------------------------------------ revno: 5680 committer: Diego Biurrun branch nick: hipl timestamp: Mon 2011-02-21 21:26:33 +0100 message: Refactor hip_hmac2_and_sign() to avoid the use of goto. ------------------------------------------------------------ revno: 5679 committer: Diego Biurrun branch nick: hipl timestamp: Mon 2011-02-21 21:12:10 +0100 message: Do not lie about return values from functions; avoid goto where unnecessary. ------------------------------------------------------------ revno: 5678 committer: Diego Biurrun branch nick: hipl timestamp: Mon 2011-02-21 21:09:30 +0100 message: Merge if-blocks in are_addresses_compatible(). ------------------------------------------------------------ revno: 5677 committer: Diego Biurrun branch nick: hipl timestamp: Mon 2011-02-21 21:03:31 +0100 message: Delete a duplicate error check in hip_send_i2(). ------------------------------------------------------------ revno: 5676 committer: Diego Biurrun branch nick: hipl timestamp: Mon 2011-02-21 21:02:01 +0100 message: Get rid of a variable indirection in hip_map_first_hostname_to_ip_from_hosts(). ------------------------------------------------------------ revno: 5675 committer: Diego Biurrun branch nick: hipl timestamp: Mon 2011-02-21 19:40:59 +0100 message: Refactor make_env() helper function. Merge some error checks, avoid the use of goto and be const correct. ------------------------------------------------------------ revno: 5674 committer: Diego Biurrun branch nick: hipl timestamp: Mon 2011-02-21 19:26:05 +0100 message: Make hip_opp_get_hadb_entry and hip_opp_get_hadb_entry_i1_r1 work without goto. ------------------------------------------------------------ revno: 5673 committer: Diego Biurrun branch nick: hipl timestamp: Mon 2011-02-21 19:10:39 +0100 message: prettyprinting cosmetics ------------------------------------------------------------ revno: 5672 committer: Diego Biurrun branch nick: hipl timestamp: Mon 2011-02-21 18:47:54 +0100 message: Refactor error handling in netlink_talk() to work without goto. ------------------------------------------------------------ revno: 5671 committer: Diego Biurrun branch nick: hipl timestamp: Mon 2011-02-21 18:46:42 +0100 message: Remove pointless continue statement directly after return. ------------------------------------------------------------ revno: 5670 committer: Diego Biurrun branch nick: hipl timestamp: Mon 2011-02-21 17:48:03 +0100 message: Directly initialize struct array idxmap to zero instead of via a for loop. ------------------------------------------------------------ revno: 5669 committer: Diego Biurrun branch nick: hipl timestamp: Mon 2011-02-21 17:46:05 +0100 message: Make hip_iproute_modify() return negative values on error. ------------------------------------------------------------ revno: 5668 committer: Diego Biurrun branch nick: hipl timestamp: Mon 2011-02-21 17:38:40 +0100 message: Fix @return doxygen for hip_netlink_receive(); it does not always return zero. ------------------------------------------------------------ revno: 5667 committer: Diego Biurrun branch nick: hipl timestamp: Mon 2011-02-21 16:42:20 +0100 message: firewall: Refactor hip_firewall_cache_hadb_match(). Merge redundant if-else statements and get rid of two variable indirections. ------------------------------------------------------------ revno: 5666 committer: Diego Biurrun branch nick: hipl timestamp: Mon 2011-02-21 15:06:37 +0100 message: Rewrite hip_cache_create_hl_entry() without the use of HIP_IFEL. This helps avoid a warning with -Wunused-but-set-variable in gcc 4.6. ------------------------------------------------------------ revno: 5665 committer: Diego Biurrun branch nick: hipl timestamp: Mon 2011-02-21 14:51:47 +0100 message: Fix return value of hipfw_handle_relay_to_r2(). The function was unconditionally returning 0, not just on success as the documentation claimed it would do. ------------------------------------------------------------ revno: 5664 committer: Diego Biurrun branch nick: hipl timestamp: Mon 2011-02-21 14:38:58 +0100 message: Give more suitable names to the parameters of ipv{4|6}_addr_copy(). a1 and a2 are completely non-descriptive while dest and src explain everything. ------------------------------------------------------------ revno: 5663 committer: Diego Biurrun branch nick: hipl timestamp: Mon 2011-02-21 14:17:08 +0100 message: Only compile hip_dump_msg() if debug is enabled. This helps avoid warnings with -Wunused-but-set-variable. ------------------------------------------------------------ revno: 5662 committer: Christoph Viethen branch nick: hipl timestamp: Mon 2011-02-21 02:08:35 +0100 message: Minor code cleanup. Oh, and look, a free() was missing ... ------------------------------------------------------------ revno: 5661 committer: Christoph Viethen branch nick: hipl timestamp: Mon 2011-02-21 01:56:27 +0100 message: Correct a few places where the wrong amount of memory gets allocated (too much, typically) - now at least the RSA parts of hip_cert_spki_sign() should be pretty exact in terms of allocated vs. actually needed memory. (Plus slight cosmetics in one place.) ------------------------------------------------------------ revno: 5660 committer: Christoph Viethen branch nick: hipl timestamp: Mon 2011-02-21 01:22:57 +0100 message: Fix crashing bug: EVP_EncodeBlock() happily stomped over memory it wasn't supposed to hit, due to insufficient size of allocated memory. Considering that EVP_EncodeBlock(), since the old SSLeay days, never had any real documentation beyond its source code: added a clear word of warning and made a few places in the code rather obvious, to keep others from falling into the same trap. ------------------------------------------------------------ revno: 5659 committer: Christoph Viethen branch nick: hipl timestamp: Mon 2011-02-21 01:02:48 +0100 message: Fix defective handling of return code from EVP_EncodeBlock(). This function only ever returns the number of bytes which it output, so the only kind of "error" that could happen is if that number is 0. ------------------------------------------------------------ revno: 5658 committer: Diego Biurrun branch nick: hipl timestamp: Sun 2011-02-20 19:43:49 +0100 message: Remove one level of pointless variable indirection in hip_xfrm_policy_modify(). The tmpl struct was declared as a pointer, which then was aliased to a char array of sufficient size to hold the contents of the struct. Get rid of this pointless and confusing indirecton by directly declaring tmpl as a struct and setting its members directly. ------------------------------------------------------------ revno: 5657 committer: Diego Biurrun branch nick: memset timestamp: Sun 2011-02-20 19:07:32 +0100 message: Restore zeroing the retransmission buffer in hip_queue_packet(). While there is no hard evidence that this is strictly necessary, Miika's gut feeling is to err on the safe side and zero the buffer just in case. Trusting Miika's intuition around HIPL is usually a good thing(TM), so zero the buffer. ------------------------------------------------------------ revno: 5656 committer: Diego Biurrun branch nick: memset timestamp: Sun 2011-02-20 18:40:45 +0100 message: Skip redundantly zeroing the peer_hostname member in hip_hadb_add_peer_info(). The containing struct is already initialized to zero. ------------------------------------------------------------ revno: 5655 committer: Diego Biurrun branch nick: memset timestamp: Sun 2011-02-20 18:34:15 +0100 message: Skip redundantly zeroing the timestamp member in hip_add_address_to_list(). The timestamp member is part of struct netdev_address, which was already allocated with calloc and thus has all members zeroed. ------------------------------------------------------------ revno: 5654 committer: Diego Biurrun branch nick: memset timestamp: Sun 2011-02-20 18:25:58 +0100 message: Replace instances of memset(0) by zero initializations. Now that we have found a way to avoid warnings with zero initializations they are a cleaner way of making sure that structures are zeroed. ------------------------------------------------------------ revno: 5653 committer: Diego Biurrun branch nick: memset timestamp: Sun 2011-02-20 17:31:14 +0100 message: Restore initialization of req structure in hip_xfrm_policy_modify() to zero. This should (hopefully) fix the breakage introduced by the memset(0) removals in r5623. Sending pings between HIP hosts works again now. ------------------------------------------------------------ revno: 5652 committer: Diego Biurrun branch nick: hipl timestamp: Fri 2011-02-18 17:56:59 +0100 message: build system: Add header files in the test directory to the list of headers. This guarantees that these headers show up in the dist tarball and get compiled by the 'checkheaders' target. ------------------------------------------------------------ revno: 5651 committer: Diego Biurrun branch nick: hipl timestamp: Fri 2011-02-18 17:36:21 +0100 message: packaging: Drop -rpm suffix from HIPL specfile name. Now that the spec file is only used for RPM systems and not for Debian-based systems, it is no longer necessary to carry the suffix in the name. ------------------------------------------------------------ revno: 5650 committer: Diego Biurrun branch nick: hipl timestamp: Fri 2011-02-18 16:16:12 +0100 message: Remove two outdated comments that referred to the long-gone blind mode. ------------------------------------------------------------ revno: 5649 committer: Diego Biurrun branch nick: unit_tests timestamp: Fri 2011-02-18 15:39:38 +0100 message: tests: Replace forward declarations for unit tests by proper header files. Previously unit test functions were handled through forward declarations in order to avoid adding one header file for each file that contained unit tests. Adding one general header file for unit tests to each unit test subdirectory avoids the header file clutter without ugly forward declaration hacks. ------------------------------------------------------------ revno: 5648 committer: Diego Biurrun branch nick: hipl timestamp: Fri 2011-02-18 12:19:05 +0100 message: build system: Really ensure that version.h is created before compiling headers. ------------------------------------------------------------ revno: 5647 committer: Diego Biurrun branch nick: hipl timestamp: Fri 2011-02-18 11:23:51 +0100 message: hipd: Explicitly initialize variable in static storage to zero. The C standard guarantees that variables in static storage get initialized to zero, but to keep with the intentional programming paradigm it is preferable to make this implicit guarantee explicit. ------------------------------------------------------------ revno: 5646 committer: Diego Biurrun branch nick: hipl timestamp: Tue 2011-02-15 19:41:01 +0100 message: Restore some more zeroing of memory as the result of Miika's review. ------------------------------------------------------------ revno: 5645 committer: Samuel Richter branch nick: hipl timestamp: Tue 2011-02-15 18:48:50 +0100 message: fix hipdnsproxy debian package debhelper automatically tries to configure the DNS python module if python-support is installed. This is done by dh_pysupport, but since our 'make install' already does all the work right, it just breaks things. dh_pysupport is now disabled with an empty override_dh_pysupport rule. ------------------------------------------------------------ revno: 5644 committer: Diego Biurrun branch nick: hipl timestamp: Tue 2011-02-15 18:19:38 +0100 message: Restore some instances of memory zeroing, as discussed with Miika. ------------------------------------------------------------ revno: 5643 committer: Diego Biurrun branch nick: hipl timestamp: Tue 2011-02-15 16:29:01 +0100 message: doc: Reword and fix the Bazaar section of HACKING. ------------------------------------------------------------ revno: 5642 committer: Diego Biurrun branch nick: hipl timestamp: Tue 2011-02-15 16:13:18 +0100 message: doc: Fix a bunch of typos and grammar errors. ------------------------------------------------------------ revno: 5641 committer: Diego Biurrun branch nick: hipl timestamp: Tue 2011-02-15 16:01:16 +0100 message: doc: Remove a stray reference to blind mode, which was removed. ------------------------------------------------------------ revno: 5640 committer: Diego Biurrun branch nick: hipl timestamp: Tue 2011-02-15 15:24:23 +0100 message: whitespace cosmetics: Consistently format sections in HACKING document. ------------------------------------------------------------ revno: 5639 committer: Diego Biurrun branch nick: hipl timestamp: Tue 2011-02-15 14:59:16 +0100 message: lib: Simplify string prefixing in hip_conf_handle_load(). Thanks to Stefan G?tz for the idea and initial implementation. ------------------------------------------------------------ revno: 5638 committer: Diego Biurrun branch nick: hipl timestamp: Tue 2011-02-15 14:44:30 +0100 message: Clean up hip_netdev_white_list_add(). Remove a pointless cast and assignment; make function parameter const correct. ------------------------------------------------------------ revno: 5637 committer: Diego Biurrun branch nick: hipl timestamp: Tue 2011-02-15 14:37:28 +0100 message: doxygen: Document return value of hip_netdev_white_list_add(). ------------------------------------------------------------ revno: 5636 fixes bug(s): https://launchpad.net/bugs/718614 committer: Diego Biurrun branch nick: bzero timestamp: Mon 2011-02-14 20:26:24 +0100 message: hipd: Drop an instance of unnecessary memory zeroing with bzero(). ------------------------------------------------------------ revno: 5635 committer: Diego Biurrun branch nick: gethostname timestamp: Tue 2011-02-15 11:42:49 +0100 message: Fix error handling of gethostname(). The instance of gethostname in lib/core/hostid.c was handled differently than the other instances in HIPL and negating the result of the function invocation rendered the check ineffective anyway. ------------------------------------------------------------ revno: 5634 committer: Diego Biurrun branch nick: gethostname timestamp: Tue 2011-02-15 11:40:01 +0100 message: Simplify the string length passed to gethostname(). It should just use the length of the character array, which is simpler than the current construction and does not waste a byte. ------------------------------------------------------------ revno: 5633 committer: Diego Biurrun branch nick: hipl timestamp: Tue 2011-02-15 11:10:19 +0100 message: build system: Ensure that version.h is created before compiling header files. ------------------------------------------------------------ revno: 5632 committer: Diego Biurrun branch nick: hipl timestamp: Tue 2011-02-15 10:48:23 +0100 message: Remove secret member from struct netdev_address. According to Samu it was part of the OpenDHT rm-message code that was removed a while ago. ------------------------------------------------------------ revno: 5631 committer: Diego Biurrun branch nick: bzero timestamp: Mon 2011-02-14 20:23:52 +0100 message: firewall: Replace bzero() invocation by memset(0). bzero() is deprecated, memset(0) should be used instead. ------------------------------------------------------------ revno: 5630 committer: Diego Biurrun branch nick: bzero timestamp: Mon 2011-02-14 20:22:40 +0100 message: Replace bzero() invocations by zero initializations. bzero() is deprecated, so this is doubly good. ------------------------------------------------------------ revno: 5629 committer: Diego Biurrun branch nick: bzero timestamp: Mon 2011-02-14 20:20:39 +0100 message: maintenance.c: Remove pointless hip_fw_addr variable indirection. ------------------------------------------------------------ revno: 5628 committer: Diego Biurrun branch nick: bzero timestamp: Mon 2011-02-14 20:17:33 +0100 message: cookie.c: Remove write-only all_zero_hit variables. ------------------------------------------------------------ revno: 5627 committer: Diego Biurrun branch nick: hipl timestamp: Mon 2011-02-14 19:49:10 +0100 message: Fix the names of some multiple inclusion guards. The multiple inclusion guards should be derived from filename and path. ------------------------------------------------------------ revno: 5626 committer: Diego Biurrun branch nick: hipl timestamp: Mon 2011-02-14 19:40:02 +0100 message: doxygen: Drop unnecessary '*' from function parameter names. ------------------------------------------------------------ revno: 5625 committer: Diego Biurrun branch nick: hipl timestamp: Mon 2011-02-14 19:19:39 +0100 message: Update links to bug tracker and revision control browser on Launchpad. ------------------------------------------------------------ revno: 5624 committer: Diego Biurrun branch nick: memset timestamp: Mon 2011-02-14 18:49:31 +0100 message: Remove more instances of unnecessary zeroing of memory. ------------------------------------------------------------ revno: 5623 committer: Diego Biurrun branch nick: memset timestamp: Mon 2011-02-14 18:49:12 +0100 message: lib: Get rid of some unnecessary zeroing of memory. ------------------------------------------------------------ revno: 5622 committer: Diego Biurrun branch nick: memset timestamp: Mon 2011-02-14 18:48:42 +0100 message: hipd: Get rid of some unnecessary zeroing of memory. ------------------------------------------------------------ revno: 5621 committer: Diego Biurrun branch nick: memset timestamp: Mon 2011-02-14 18:40:30 +0100 message: Replace some memset(0) invocations by zero initializations. ------------------------------------------------------------ revno: 5620 committer: Diego Biurrun branch nick: memset timestamp: Mon 2011-02-14 18:35:06 +0100 message: Convert some instances of malloc() + memset(0) to calloc(). ------------------------------------------------------------ revno: 5619 committer: Diego Biurrun branch nick: hipl timestamp: Mon 2011-02-14 15:26:51 +0100 message: configfilereader: Refactor some redundant return statements. In hip_cvl_add() 'return 0' statements were present in all branches of an if/else block as well as directly below the block. ------------------------------------------------------------ revno: 5618 committer: Diego Biurrun branch nick: hipl timestamp: Mon 2011-02-14 09:44:19 +0100 message: cosmetics: Remove all trailing whitespace. ------------------------------------------------------------ revno: 5617 committer: Diego Biurrun branch nick: hipl timestamp: Sun 2011-02-13 22:16:14 +0100 message: cosmetics: Shorten some lines for better readability. ------------------------------------------------------------ revno: 5616 committer: Diego Biurrun branch nick: hipl timestamp: Sun 2011-02-13 17:43:30 +0100 message: build system: Test availability of tcase_add_exit_test macro in check.h. This allows getting rid of some brittle version #ifdeffery. ------------------------------------------------------------ revno: 5615 committer: Artturi Karila branch nick: hipl timestamp: Thu 2011-02-10 13:07:59 +0200 message: Corrected Doxygen comment for firewall_init_filter_traffic() The function doesn't have a return value. ------------------------------------------------------------ revno: 5614 committer: Artturi Karila branch nick: hipl timestamp: Thu 2011-02-10 12:52:04 +0200 message: Restore firewall traffic filtering state on ESP relay uninit Added an uninit function for the filter_traffic ruleset and code to call it when ESP relay is turned off if traffic filtering was initially disabled. ------------------------------------------------------------ revno: 5613 committer: Diego Biurrun branch nick: hipl timestamp: Wed 2011-02-09 10:26:55 +0100 message: build: Remove generated files in the debian/ directory from dist tarball. Files that configure generates from templates need to be manually removed. ------------------------------------------------------------ revno: 5612 committer: Diego Biurrun branch nick: hipl timestamp: Wed 2011-02-09 10:23:01 +0100 message: build: Add reminder comment about removing configure-generated files. All the files that configure generates should not be in the distribution tarball. Since autotools only takes care of the standard files it generates all the others that are generated from template files in HIPL need to be taken care of manually in the dist-hook in Makefile.am. ------------------------------------------------------------ revno: 5611 committer: Diego Biurrun branch nick: hipl timestamp: Tue 2011-02-08 19:27:35 +0100 message: packaging: Delete build-maemo.sh script, it's job is now done by 'make deb'. ------------------------------------------------------------ revno: 5610 fixes bug(s): https://launchpad.net/bugs/592168 committer: Diego Biurrun branch nick: hipl timestamp: Tue 2011-02-08 18:55:52 +0100 message: Debian packaging: Do not hardcode Python version. The Debian packaging infrastructure for the DNS proxy contained hardcoded paths for Python libraries, which would fail on distributions that do not have Python 2.6. Replace those hardcoded values by templates from which autoconf generates similar files that contain the correct Python path for the build host. This fixes Debian package building on Maemo 5. ------------------------------------------------------------ revno: 5609 committer: Diego Biurrun branch nick: hipl timestamp: Tue 2011-02-08 18:36:55 +0100 message: packaging: Add Maemo variant to the Debian case in create-package.sh. Maemo is a Debian-based system, but behaves slightly differently. ------------------------------------------------------------ revno: 5608 committer: Diego Biurrun branch nick: hipl timestamp: Tue 2011-02-08 18:16:08 +0100 message: Debian packaging: Do not clean tree after building Debian packages. Not cleaning the tree after a build is more convenient because a distclean is performed, which also removes Makefiles and similar things. The original reason to clean the tree after a Debian package build was sideeffects on the autobuilder. This can be worked around by testing package building last there. ------------------------------------------------------------ revno: 5607 committer: David Martin branch nick: hipl timestamp: Tue 2011-02-08 15:08:47 +0100 message: Cosmetics: Fixed three typos in Doxygen documentation and error prints. ------------------------------------------------------------ revno: 5606 committer: Diego Biurrun branch nick: hipl timestamp: Tue 2011-02-08 12:55:24 +0100 message: HOWTO: Add IDs to Maemo subsections, fix two small typos. Some versions of xmlto were complaining about missing IDs. ------------------------------------------------------------ revno: 5605 committer: Diego Biurrun branch nick: hipl timestamp: Tue 2011-02-08 10:19:07 +0100 message: cosmetics: Add some whitespace for readability. ------------------------------------------------------------ revno: 5604 committer: Diego Biurrun branch nick: hipl timestamp: Mon 2011-02-07 20:08:44 +0100 message: HOWTO: Fix a few misc typos. ------------------------------------------------------------ revno: 5603 committer: Miika Komu branch nick: trunk timestamp: Mon 2011-02-07 20:29:07 +0200 message: Updated comments in lib/core/conf.c. Replaced old bug id reference 880 with the corresponding description. ------------------------------------------------------------ revno: 5602 committer: Miika Komu branch nick: trunk timestamp: Mon 2011-02-07 20:20:46 +0200 message: Updated comments in the DNS proxy. Replaced old bug id reference 737 with a comment explaining the bug id. ------------------------------------------------------------ revno: 5601 committer: Miika Komu branch nick: trunk timestamp: Mon 2011-02-07 20:17:32 +0200 message: Updated comments in the DNS proxy. Replaced old bug id reference 909 with a comment explaining the bug id. ------------------------------------------------------------ revno: 5600 committer: Rene Hummen branch nick: trunk timestamp: Mon 2011-02-07 11:11:28 +0100 message: fix building of unit-tests in scratchbox environment This required to ifdef a few test, as the construct is not supported by the old check version shipped with scratchbox. ------------------------------------------------------------ revno: 5599 committer: Rene Hummen branch nick: trunk timestamp: Mon 2011-02-07 11:06:42 +0100 message: remove directory traversal in maemo packaging scripts ------------------------------------------------------------ revno: 5598 committer: Rene Hummen branch nick: trunk timestamp: Mon 2011-02-07 10:30:50 +0100 message: fix incorrect packet type identifier size Packet types are uint8_t values with leading 0. HIPL allowed registering packet types with sizeof(uint16_t). ------------------------------------------------------------ revno: 5597 committer: Miika Komu branch nick: trunk timestamp: Mon 2011-02-07 11:18:30 +0200 message: Updated default options for hipd in the binary packages. As noted in bug id 713552, the -N option should be the default for hipd in the binary packages (rpm, deb, openwrt). Feel free to change if you disagree. ------------------------------------------------------------ revno: 5596 committer: Miika Komu branch nick: trunk timestamp: Mon 2011-02-07 11:15:42 +0200 message: Improved documentation of a command line option. As noted in bug id 713552, the N-option for hipd is fuzzy. Tried to improve this, feel free to wordsmith further if you have better suggestions. ------------------------------------------------------------ revno: 5595 committer: Henrik Ziegeldorf branch nick: hipl timestamp: Sun 2011-02-06 11:49:28 +0100 message: Documented arguments of HIP_OUT_ERR. ------------------------------------------------------------ revno: 5594 [merge] committer: Henrik Ziegeldorf branch nick: hipl timestamp: Sun 2011-02-06 11:08:14 +0100 message: Merged branch lp:~henrik-ziegeldorf/hipl/HIP_EAE. ------------------------------------------------------------ revno: 5593 fixes bug(s): https://launchpad.net/bugs/619332 committer: Miika Komu branch nick: trunk timestamp: Sun 2011-02-06 11:03:39 +0200 message: Broadcast mechanism is now optional (bug id 619332). Broadcasting of I1 packet can be now separately enabled when needed. By default it is off as discussed in the bug id. I tested that this feature is still working. I also disambiguated "shotgun" from broadcasting in hipd/netdev.c as also described in the bug id. ------------------------------------------------------------ revno: 5592 committer: Samu Varjonen branch nick: hipl timestamp: Sat 2011-02-05 18:04:26 +0200 message: Changed a debug statement to say what actually happens. ------------------------------------------------------------ revno: 5591 committer: Rene Hummen branch nick: trunk timestamp: Fri 2011-02-04 15:44:37 +0100 message: remove some but not all unused parameter type definitions ------------------------------------------------------------ revno: 5590 committer: Rene Hummen branch nick: trunk timestamp: Fri 2011-02-04 15:28:59 +0100 message: remove unused packet type definitions ------------------------------------------------------------ revno: 5589 [merge] committer: Rene Hummen branch nick: trunk timestamp: Fri 2011-02-04 14:47:07 +0100 message: merge trunk revision 5586 ------------------------------------------------------------ revno: 5588 committer: Rene Hummen branch nick: trunk timestamp: Fri 2011-02-04 14:42:23 +0100 message: add hooks for checking and outputting packet and param information ------------------------------------------------------------ revno: 5587 committer: Rene Hummen branch nick: trunk timestamp: Fri 2011-02-04 14:41:24 +0100 message: allow for modular packet and parameter checks This commit prepares flexible adding of packets and parameters at hipd start-up. ------------------------------------------------------------ revno: 5586 committer: Rene Hummen branch nick: trunk timestamp: Fri 2011-02-04 14:08:11 +0100 message: add registration of parameter types to modularization ------------------------------------------------------------ revno: 5585 committer: Samu Varjonen branch nick: hipl timestamp: Fri 2011-02-04 14:22:18 +0200 message: Removed pointles comments from builder.c. ------------------------------------------------------------ revno: 5584 committer: Samu Varjonen branch nick: hipl timestamp: Fri 2011-02-04 14:01:46 +0200 message: Added a missing Doxygen header for handle_locator. ------------------------------------------------------------ revno: 5583 committer: Henrik Ziegeldorf branch nick: hipl timestamp: Thu 2011-02-03 15:36:53 +0100 message: Corrected use of HIP_IFEL. ------------------------------------------------------------ revno: 5582 committer: Samu Varjonen branch nick: hipl timestamp: Thu 2011-02-03 13:58:26 +0200 message: Fixed the incorrect building of host_id in hip_build_host_id_and_signature, wrong function was used to build the host id. ------------------------------------------------------------ revno: 5581 committer: Diego Biurrun branch nick: hipl timestamp: Mon 2011-01-31 21:21:37 +0100 message: Simplify an if-condition in hip_build_host_id_from_param(). ------------------------------------------------------------ revno: 5580 committer: Diego Biurrun branch nick: hipl timestamp: Mon 2011-01-31 21:20:45 +0100 message: const correctness for hip_build_{host_id_from_param|param_host_id} declarations ------------------------------------------------------------ revno: 5579 committer: Diego Biurrun branch nick: hipl timestamp: Mon 2011-01-31 21:17:10 +0100 message: Fix return value comments for hip_build_{host_id_from_param|param_host_id}. ------------------------------------------------------------ revno: 5578 committer: Diego Biurrun branch nick: hipl timestamp: Mon 2011-01-31 20:54:26 +0100 message: misc cosmetics: prettyprinting, drop pointless parentheses ------------------------------------------------------------ revno: 5577 committer: Diego Biurrun branch nick: hipl timestamp: Mon 2011-01-31 20:53:21 +0100 message: Zero more variables directly at declaration instead of through memset(). ------------------------------------------------------------ revno: 5576 committer: Diego Biurrun branch nick: hipl timestamp: Mon 2011-01-31 19:09:08 +0100 message: cosmetics: Fix some typos, (un)break some lines, drop some parentheses. ------------------------------------------------------------ revno: 5575 committer: Diego Biurrun branch nick: hipl timestamp: Mon 2011-01-31 15:57:40 +0100 message: Zero variables directly at declaration instead of through memset(). ------------------------------------------------------------ revno: 5574 committer: Diego Biurrun branch nick: memset timestamp: Tue 2011-01-18 18:38:24 +0100 message: Do not zero struct members that were already initialized to 0. ------------------------------------------------------------ revno: 5573 committer: Diego Biurrun branch nick: hipl timestamp: Mon 2011-01-31 14:53:06 +0100 message: Restore freeing of pointers in anchor_db_uninit(), mistakenly removed in r5566. ------------------------------------------------------------ revno: 5572 committer: David Martin branch nick: hipl timestamp: Mon 2011-01-31 14:12:07 +0100 message: Use strdup() instead of malloc() and strncpy() in lmod_register_packet_type(). ------------------------------------------------------------ revno: 5571 committer: Diego Biurrun branch nick: malloc timestamp: Wed 2011-01-12 20:37:34 +0100 message: Add -Wno-missing-field-initializers to global CFLAGS. With -Wmissing-field-initializers, which is enabled by -Wextra, gcc complains when initializing structs to zero with '= { 0 }', which is a perfeclty legal way to initialize structures to all-zero values in C. ------------------------------------------------------------ revno: 5570 committer: Diego Biurrun branch nick: malloc timestamp: Wed 2011-01-12 15:47:55 +0100 message: esp_prot_transforms is in static storage, no need to initialize it to 0. The C standard guarantees that the compiler initializes static storage to 0. ------------------------------------------------------------ revno: 5569 committer: Diego Biurrun branch nick: malloc timestamp: Wed 2011-01-12 18:05:55 +0100 message: Do not memset static variables to zero. The C standard guarantees that the compiler initializes static storage to 0. ------------------------------------------------------------ revno: 5568 committer: Diego Biurrun branch nick: malloc timestamp: Wed 2011-01-12 18:20:24 +0100 message: Do not memset the global esp_prot_conntrack_tfms variable to zero. The C standard guarantees that objects declared with file scope are initialized to 0. ------------------------------------------------------------ revno: 5567 committer: Diego Biurrun branch nick: malloc timestamp: Wed 2011-01-12 20:43:19 +0100 message: Remove pointless anchor_db_init() function. The function just initializes variables in static storage to 0, which is already guaranteed by the C standard. ------------------------------------------------------------ revno: 5566 committer: Diego Biurrun branch nick: malloc timestamp: Wed 2011-01-12 20:44:55 +0100 message: Do not manually zero all members of anchor_db on uninit. ------------------------------------------------------------ revno: 5565 committer: Diego Biurrun branch nick: memset timestamp: Tue 2011-01-18 17:51:17 +0100 message: Remove completely pointless nulling of variables that are never used. ------------------------------------------------------------ revno: 5564 committer: Diego Biurrun branch nick: hip_ifel timestamp: Mon 2011-01-31 12:50:15 +0100 message: Fix hip_scan_retransmissions to return a negative value in case of error. This is what the documentation of the function claimed but did not do, probably due to a typo. ------------------------------------------------------------ revno: 5563 committer: David Martin branch nick: hipl timestamp: Thu 2011-01-27 14:32:40 +0100 message: Respect null-termination of strings in lmod_register_packet_type(). strlen() does not include the terminating \0 of strings. Therefore count an additional byte for memory allocation. ------------------------------------------------------------ revno: 5562 committer: Rene Hummen branch nick: trunk timestamp: Tue 2011-01-25 13:37:23 +0100 message: fix packaging for the maemo platform HIPL packaging has been updated to debhelper7. This is not available natively in the Scratchbox target for the N900. This commit implements a work-around that allows to use the manually installed debhelper7 to package HIPL. ------------------------------------------------------------ revno: 5561 committer: Samu Varjonen branch nick: hipl timestamp: Fri 2011-01-21 15:22:09 +0200 message: FIX: Bug #697561 In hip_hadb_find_byhits hit1 is now hit_local, hit2 is now hit_remote and the debug lines "HIT1..." and "HIT2..." fixed accordingly. ------------------------------------------------------------ revno: 5560 committer: Samu Varjonen branch nick: hipl timestamp: Fri 2011-01-21 15:08:21 +0200 message: FIX: Bug #697563 Removed the "Returning NULL" from the hip_get_hostid_entry_by_lhi_and_algo. Added the missing '1's in hip_relay_handle_relay_from. Moved the printing of the dst_ip in hip_send_r1 couple lines further where the variable has some meaningfull contents. ------------------------------------------------------------ revno: 5559 committer: Diego Biurrun branch nick: hipl timestamp: Thu 2011-01-20 15:14:44 +0100 message: Only set docdir if the variable is unset. This fixes passing a custom documentation path to configure with --docdir. ------------------------------------------------------------ revno: 5558 fixes bug(s): https://launchpad.net/bugs/703934 committer: Rene Hummen branch nick: trunk timestamp: Wed 2011-01-19 16:25:29 +0100 message: fix conditional that causes hipfw to close on startup Only if the -e option was passed to hipfw, the initialization of its extensions would succeed. Fixed wrong conditional. ------------------------------------------------------------ revno: 5557 committer: Rene Hummen branch nick: trunk timestamp: Wed 2011-01-19 16:03:52 +0100 message: remove defines related to opportunistic mode These are now unused as oppdb and oppipdb have been removed. ------------------------------------------------------------ revno: 5556 committer: Rene Hummen branch nick: trunk timestamp: Wed 2011-01-19 16:02:00 +0100 message: remove message types related to opportunistic mode These are now unused as oppdb and oppipdb have been removed. ------------------------------------------------------------ revno: 5555 committer: Rene Hummen branch nick: trunk timestamp: Wed 2011-01-19 16:00:54 +0100 message: remove oppdb and oppipdb ------------------------------------------------------------ revno: 5554 committer: Rene Hummen branch nick: trunk timestamp: Wed 2011-01-19 15:56:25 +0100 message: remove oppdb and oppipdb usage from user.c I moved functionality that provides opportunistic BEX for RVS to user.c. This functionality is still required and will remain in the codebase. ------------------------------------------------------------ revno: 5553 committer: Rene Hummen branch nick: trunk timestamp: Wed 2011-01-19 15:51:24 +0100 message: remove oppdb and oppipdb usage from input.c I moved functionality that provides opportunistic BEX to RVS to a new file opp_mode.c. This functionality is still required and will remain in the codebase. ------------------------------------------------------------ revno: 5552 committer: Rene Hummen branch nick: trunk timestamp: Wed 2011-01-19 15:20:47 +0100 message: remove opportunistic mode from hipconf interface ------------------------------------------------------------ revno: 5551 committer: Rene Hummen branch nick: trunk timestamp: Wed 2011-01-19 15:14:04 +0100 message: remove opportunistic mode-related messages from builder.c ------------------------------------------------------------ revno: 5550 committer: Rene Hummen branch nick: trunk timestamp: Wed 2011-01-19 14:59:19 +0100 message: remove usage of oppdb from hadb.c ------------------------------------------------------------ revno: 5549 committer: Rene Hummen branch nick: trunk timestamp: Wed 2011-01-19 14:57:15 +0100 message: remove usage of oppdb and oppipdb from init.c ------------------------------------------------------------ revno: 5548 committer: Rene Hummen branch nick: trunk timestamp: Wed 2011-01-19 14:55:32 +0100 message: remove usage of oppdb from maintenance ------------------------------------------------------------ revno: 5547 committer: Rene Hummen branch nick: trunk timestamp: Wed 2011-01-19 14:51:22 +0100 message: remove usage of oppipdb in close ------------------------------------------------------------ revno: 5546 committer: Rene Hummen branch nick: trunk timestamp: Wed 2011-01-19 14:49:43 +0100 message: remove non-required header inclusion hipd/oppipdb.h is not needed for locator processing ------------------------------------------------------------ revno: 5545 committer: Diego Biurrun branch nick: hipl timestamp: Tue 2011-01-18 12:27:49 +0100 message: Remove unnecessary empty initialization of TESTS/check_PROGRAMS Make variables. ------------------------------------------------------------ revno: 5544 committer: Diego Biurrun branch nick: hipl timestamp: Tue 2011-01-18 12:16:27 +0100 message: Add "alltests" target that depends on all compilation and test targets. This should help catching easily-avoidable mistakes before the autobuilder. ------------------------------------------------------------ revno: 5543 committer: Diego Biurrun branch nick: hipl timestamp: Tue 2011-01-18 11:15:00 +0100 message: Silence header compilation rules similar to C file compilation rules. Now .ho file generation will generate the same output verbosity as compiling straight .c files, depending on whether or not the V Make variable is set. ------------------------------------------------------------ revno: 5542 committer: Rene Hummen branch nick: trunk timestamp: Mon 2011-01-17 22:34:11 +0100 message: remove references to opportunistic mode from HOWTO ------------------------------------------------------------ revno: 5541 committer: Rene Hummen branch nick: trunk timestamp: Mon 2011-01-17 22:31:06 +0100 message: remove unused functions hip_firewall_cache_db_del_entry() and hip_firewall_cache_update_entry() were only used by sysopp mode. ------------------------------------------------------------ revno: 5540 committer: Rene Hummen branch nick: trunk timestamp: Mon 2011-01-17 22:29:56 +0100 message: remove sysopp mode ------------------------------------------------------------ revno: 5539 committer: Rene Hummen branch nick: trunk timestamp: Mon 2011-01-17 22:27:00 +0100 message: add missing safe guard around lsi mode ------------------------------------------------------------ revno: 5538 committer: Rene Hummen branch nick: trunk timestamp: Mon 2011-01-17 22:24:32 +0100 message: remove unrequired conditional There is need to distinguish between data packet mode and userspace ipsec. Data packet mode has been removed. Also clarify return value. ------------------------------------------------------------ revno: 5537 committer: Rene Hummen branch nick: trunk timestamp: Mon 2011-01-17 22:23:29 +0100 message: remove unnecessary debug output ------------------------------------------------------------ revno: 5536 committer: Rene Hummen branch nick: trunk timestamp: Mon 2011-01-17 22:22:40 +0100 message: remove ip_hdr_len variable indirection ------------------------------------------------------------ revno: 5535 committer: Rene Hummen branch nick: trunk timestamp: Mon 2011-01-17 22:17:00 +0100 message: clean-up firewall - remove handling of TCP as special case (was required for sysopp) - remove redundant code (register single handler for different packe types instead of duplicating code) - split doxygen comments for handler functions ------------------------------------------------------------ revno: 5534 committer: Rene Hummen branch nick: trunk timestamp: Mon 2011-01-17 21:51:54 +0100 message: remove sysopp mode from firewall and firewall_control ------------------------------------------------------------ revno: 5533 committer: Rene Hummen branch nick: trunk timestamp: Mon 2011-01-17 21:21:16 +0100 message: fix alignment issue of dhgen[] initialization uncrustify would align it differently on each run. ------------------------------------------------------------ revno: 5532 committer: Rene Hummen branch nick: trunk timestamp: Mon 2011-01-17 21:19:28 +0100 message: remove unused parameter dst_hit from hip_send_i1_pkt() ------------------------------------------------------------ revno: 5531 committer: Rene Hummen branch nick: trunk timestamp: Mon 2011-01-17 21:07:20 +0100 message: fix tag in doxygen comment that confuses uncrustify The star in front of the 
 tag causes uncrustify to add another
  star each time it parses the file.
------------------------------------------------------------
revno: 5530
committer: Rene Hummen 
branch nick: trunk
timestamp: Mon 2011-01-17 21:06:52 +0100
message:
  fix missing brace in #define
------------------------------------------------------------
revno: 5529
committer: Rene Hummen 
branch nick: trunk
timestamp: Mon 2011-01-17 21:01:07 +0100
message:
  make hip_cache_create_hl_entry() static
  
  hip_cache_create_hl_entry() is now only used in cache.c
------------------------------------------------------------
revno: 5528
committer: Rene Hummen 
branch nick: trunk
timestamp: Mon 2011-01-17 15:17:59 +0100
message:
  remove obsolete parameter "update" from doxygen comment
------------------------------------------------------------
revno: 5527
committer: Samu Varjonen 
branch nick: hipl
timestamp: Mon 2011-01-17 14:27:45 +0200
message:
  Fixes BUG ID:700959 which was marked as a duplicate of 695328. 
  The -Aid flags do not cause a segmentation fault anymore.
------------------------------------------------------------
revno: 5526
committer: Rene Hummen 
branch nick: trunk
timestamp: Mon 2011-01-17 13:09:48 +0100
message:
  fix and unify handling of IPsec SAs and SPs
  
  - unify setup and update of IPsec SAs and SPs by using
    hip_create_or_update_security_associations_and_sp()
  - remove redundant code
  - add const correctness
  - remove updating of SAs and SPs, as IPsec state is removed before
    update and as it was used incorrectly (SP update during BEX) before
  
  NOTE: These changes have been reviewed at
        https://code.launchpad.net/~hipl-core/hipl/ipsec-cleanup/+merge/46144.
------------------------------------------------------------
revno: 5525
fixes bug(s): https://launchpad.net/bugs/699730
committer: Rene Hummen 
branch nick: ipsec-cleanup
timestamp: Thu 2011-01-13 16:35:29 +0100
message:
  fix IPsec SAs not to be removed on connection CLOSE
  
  Only IPsec SPs were deleted when removing a host association. However,
  SAs remained in the kernel-space IPsec setup. Now, related SAs will be
  removed when a connection is closed.
------------------------------------------------------------
revno: 5524
committer: Rene Hummen 
branch nick: hipl
timestamp: Mon 2011-01-17 11:28:14 +0100
message:
  use hip_del_peer_info_entry() instead of hip_del_peer_info()
  
  hip_del_peer_info() looks up the hadb entry based on src and dst HIT
  and subsequently calls hip_del_peer_info_entry(). We don't need to
  look up the entry, when it is already known!
------------------------------------------------------------
revno: 5523
committer: Rene Hummen 
branch nick: hipl
timestamp: Mon 2011-01-17 10:53:56 +0100
message:
  fix includes
  
  lib/core/statistics.c uses the POSIX int types defined in stdint.h, e.g.
  uint64_t.
------------------------------------------------------------
revno: 5522
committer: Stefan G?tz 
branch nick: hipl
timestamp: Sat 2011-01-15 10:14:09 +0100
message:
  Documentation: document the status, policy, and rationale around the
  uncrustify code beautifier in HIPL.
  Sprinkle HACKING with hints towards the existence of the stylecheck
  pre-commit hook.
------------------------------------------------------------
revno: 5521
committer: Henrik Ziegeldorf 
branch nick: hipl
timestamp: Fri 2011-01-14 18:31:32 +0100
message:
  Refactored functions hip_get_dsa_public_key, hip_get_dsa_public_key, hip_get_public_key and hip_add_host_id.
  
  Changes
   + Give callers power over memory handling.
   + Updated doxygen.
   + Crustified remaining code.
------------------------------------------------------------
revno: 5520
committer: Henrik Ziegeldorf 
branch nick: hipl
timestamp: Fri 2011-01-14 18:01:00 +0100
message:
  Const correctness for functions load_dsa_file() and load_rsa_file().
------------------------------------------------------------
revno: 5519
committer: Henrik Ziegeldorf 
branch nick: hipl
timestamp: Fri 2011-01-14 17:45:57 +0100
message:
  Replaced multi-cased if statement with switch statement and added default case for error handling. (This is a step towards HIPv2 and support for further crypto algorithms).
------------------------------------------------------------
revno: 5518
committer: Diego Biurrun 
branch nick: hipl
timestamp: Fri 2011-01-14 16:53:02 +0100
message:
  cosmetics: Improve some less than ideal linebreaks in function invocations.
------------------------------------------------------------
revno: 5517
committer: Diego Biurrun 
branch nick: hipl
timestamp: Fri 2011-01-14 16:05:51 +0100
message:
  Remove reference to non-existing wrap_db.c file.
------------------------------------------------------------
revno: 5516
committer: Stefan G?tz 
branch nick: hipl
timestamp: Thu 2011-01-13 14:55:53 +0100
message:
  Style: marked string arrays with 'static' and 'const' qualifiers to
  increase const correctness and improve data encapsulation.
  Uppercase'd variable names to reflect their const'ness.
------------------------------------------------------------
revno: 5515
committer: Stefan G?tz 
branch nick: hipl
timestamp: Thu 2011-01-13 14:47:25 +0100
message:
  Whitespace cleanup: align string array so that uncrustify does not re-format
  it and keeps it as is.
------------------------------------------------------------
revno: 5514
committer: Diego Biurrun 
branch nick: hipl
timestamp: Thu 2011-01-13 14:41:47 +0100
message:
  Remove unused, write-only variable from hip_serialize_host_id_action().
------------------------------------------------------------
revno: 5513
committer: Diego Biurrun 
branch nick: hipl
timestamp: Thu 2011-01-13 13:59:31 +0100
message:
  cosmetics: Drop useless parentheses; prettyprinting.
------------------------------------------------------------
revno: 5512
committer: Diego Biurrun 
branch nick: hipl
timestamp: Thu 2011-01-13 13:49:20 +0100
message:
  Move hosts_file_line structure to the only place it is used.
------------------------------------------------------------
revno: 5511
committer: Diego Biurrun 
branch nick: demodularization
timestamp: Thu 2011-01-13 10:45:20 +0100
message:
  Restructure module build process.
  
  Instead of building separate libraries for each module, add all module sources
  so the list of hipd sources. This simplifies the build system and speeds up
  the build process slightly.
------------------------------------------------------------
revno: 5510
committer: Diego Biurrun 
branch nick: hipl
timestamp: Thu 2011-01-13 10:37:30 +0100
message:
  Adjust two paths that still referenced libhipcore/.
------------------------------------------------------------
revno: 5509
fixes bug(s): https://launchpad.net/bugs/690198 https://launchpad.net/bugs/701828
committer: Henrik Ziegeldorf 
branch nick: hipl
timestamp: Thu 2011-01-13 10:32:39 +0100
message:
  Fixed function hip_get_dsa_public_key().
  
  This function was missing an actual memcpy (or similar) which would set the contents in the output argument. 
  The result from this bug was, that neither the host id algorithm, nor the hostname was copied to the new host id structure. 
  
  This revision fixes the bugs by copying the key_rr header, key_rr data and hostname.
  Note: The function hip_get_rsa_public_key(), which implements the same functionality for rsa, can serve as a reference for reviewing this revision.
------------------------------------------------------------
revno: 5508
committer: Diego Biurrun 
branch nick: hipl
timestamp: Wed 2011-01-12 14:06:31 +0100
message:
  Remove empty HIP_LOCK_* and HIP_UNLOCK_* macros.
  
  Since no real locking was implemented, these macros just obfuscate the
  code for no gain.
------------------------------------------------------------
revno: 5507
committer: Diego Biurrun 
branch nick: hipl
timestamp: Wed 2011-01-12 23:26:25 +0100
message:
  Remove initialize-only, unused variable dst6_lsi in hip_netdev_trigger_bex().
------------------------------------------------------------
revno: 5506
committer: Diego Biurrun 
branch nick: hipl
timestamp: Wed 2011-01-12 22:30:41 +0100
message:
  Remove pointless hitr variable indirection in hip_handle_user_msg().
  
  The hitr variable is memset to zero and then a pointer to the zeroed structure
  is passed to hip_map_id_to_addr(), which gives the same result as directly
  passing NULL to that function.
------------------------------------------------------------
revno: 5505
committer: Diego Biurrun 
branch nick: hipl
timestamp: Wed 2011-01-12 21:13:14 +0100
message:
  Remove unused variable cert_str_pem in hip_cert_x509v3_handle_request_to_sign().
------------------------------------------------------------
revno: 5504
committer: Diego Biurrun 
branch nick: malloc
timestamp: Wed 2011-01-12 20:45:47 +0100
message:
  const correctness for some configfilereader functions
------------------------------------------------------------
revno: 5503
committer: Diego Biurrun 
branch nick: hipl
timestamp: Wed 2011-01-12 20:21:54 +0100
message:
  cosmetics: Add missing #endif comment.
------------------------------------------------------------
revno: 5502
committer: Diego Biurrun 
branch nick: hipl
timestamp: Wed 2011-01-12 18:53:40 +0100
message:
  Restructure calloc calls to follow the function signature more closely.
  
  calloc gets the number of elements and the size of each element as parameters,
  so when initializing multiple elements, follow calloc's signature instead of
  initializing one big element of size number_of_elements * size_of_element.
------------------------------------------------------------
revno: 5501
committer: Diego Biurrun 
branch nick: hipl
timestamp: Wed 2011-01-12 17:43:46 +0100
message:
  Set default packet type after zeroing packet content in hip_fw_init_context().
------------------------------------------------------------
revno: 5500
committer: Rene Hummen 
branch nick: hipl
timestamp: Wed 2011-01-12 15:03:38 +0100
message:
  fix issue, where IPsec security policies and security association do not match
  
  IP addresses, HITs and IPsec SA/SP direction did not match in case of
  UPDATEs.
------------------------------------------------------------
revno: 5499
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2011-01-10 16:13:47 +0100
message:
  Refactor some code duplication between HIP_INFO_* and HIP_DEBUG_* macros.
------------------------------------------------------------
revno: 5498
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2011-01-10 14:31:48 +0100
message:
  cosmetics: vertical alignment prettyprinting
------------------------------------------------------------
revno: 5497
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2011-01-10 14:00:30 +0100
message:
  Get rid of pointless HIP_CREATE_FILE macro indirection.
------------------------------------------------------------
revno: 5496
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2011-01-10 13:58:29 +0100
message:
  Remove unused USER_HIPD #define and get rid of USER_NOBODY indirection.
------------------------------------------------------------
revno: 5495
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2011-01-10 13:18:26 +0100
message:
  Get rid of pointless FLUSH_HA_INFO_DB macro indirection.
------------------------------------------------------------
revno: 5494
committer: Diego Biurrun 
branch nick: hipl
timestamp: Wed 2011-01-12 13:39:54 +0100
message:
  Remove outdated and misleading comments from struct hash_chain.
------------------------------------------------------------
revno: 5493
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2011-01-10 16:12:37 +0100
message:
  Deduplicate ARRAY_SIZE macros instances and move to common.h.
------------------------------------------------------------
revno: 5492
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2011-01-10 15:00:29 +0100
message:
  Move HIP_MAX_DSA_KEY_LEN to protodefs.h, next to HIP_MAX_RSA_KEY_LEN.
------------------------------------------------------------
revno: 5491
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2011-01-10 14:52:33 +0100
message:
  cosmetics: slightly more elegant MAX_HASH_LENGTH #define construction
------------------------------------------------------------
revno: 5490
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2011-01-10 14:46:54 +0100
message:
  Remove duplicated INET6_ADDRSTRLEN #define, which already is in netinet/in.h.
------------------------------------------------------------
revno: 5489
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2011-01-10 14:39:07 +0100
message:
  Move MAX_ESP_PADDING/ESP_PACKET_SIZE to the only place they are used.
------------------------------------------------------------
revno: 5488
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2011-01-10 14:34:58 +0100
message:
  Move EHIP #define to the only place it is used.
------------------------------------------------------------
revno: 5487
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2011-01-10 14:28:10 +0100
message:
  Move HIP_*_PACKET_* #defines to the only place they are used.
------------------------------------------------------------
revno: 5486
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2011-01-10 14:21:46 +0100
message:
  Move HIP_CERT_INIT_DAYS #define to the only place it is used.
------------------------------------------------------------
revno: 5485
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2011-01-10 14:12:17 +0100
message:
  Move HIP_R1TABLESIZE to the only place it is used.
------------------------------------------------------------
revno: 5484
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2011-01-10 14:04:53 +0100
message:
  Get rid of pointless HIP_DEFAULT_COOKIE_K macro indirection.
------------------------------------------------------------
revno: 5483
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2011-01-10 14:10:36 +0100
message:
  Move DEBUG_PREFIX_MAX/DEBUG_MSG_MAX_LEN to the only place they are used.
------------------------------------------------------------
revno: 5482
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2011-01-07 18:25:26 +0100
message:
  Get rid of pointless SYSLOG_OPT macro indirection.
  
  The macro was only used in one place and not simplifying anything.
------------------------------------------------------------
revno: 5481
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2011-01-10 13:07:32 +0100
message:
  Move HIP_LEN_PAD macro to the only place it is used.
------------------------------------------------------------
revno: 5480
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2011-01-10 13:03:16 +0100
message:
  Move HIP_MAX_ICMP_PACKET #define to the only place it is used.
------------------------------------------------------------
revno: 5479
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2011-01-10 13:02:09 +0100
message:
  Move HIP_DSA_SIG_SIZE #define to the only place it is used.
------------------------------------------------------------
revno: 5478
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2011-01-10 13:00:38 +0100
message:
  Move HCSTORE_MAX_HCHAINS_PER_ITEM #define to the only place it is used.
------------------------------------------------------------
revno: 5477
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2011-01-10 12:59:06 +0100
message:
  Move INDEX_HASH_FN/INDEX_HASH_LENGTH #defines to the only place they are used.
------------------------------------------------------------
revno: 5476
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2011-01-10 12:57:17 +0100
message:
  Move HIP_DEFAULT_MSG_TIMEOUT #define to the only place it is used.
------------------------------------------------------------
revno: 5475
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2011-01-10 12:54:10 +0100
message:
  Move BUFSIZE #define closer to where it is used.
------------------------------------------------------------
revno: 5474
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2011-01-07 18:24:48 +0100
message:
  Move MAX_ITEM_LEN to the only place it is used.
------------------------------------------------------------
revno: 5473
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2011-01-10 14:44:10 +0100
message:
  Remove unused ESP_PADDING #defines.
------------------------------------------------------------
revno: 5472
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2011-01-10 14:33:18 +0100
message:
  Remove unused EHADDRINFO #define.
------------------------------------------------------------
revno: 5471
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2011-01-10 14:29:43 +0100
message:
  Remove unused #define HIPD_NL_GROUP.
------------------------------------------------------------
revno: 5470
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2011-01-10 14:08:07 +0100
message:
  Remove unused HIP_MAX_COOKIE_INFO #define.
------------------------------------------------------------
revno: 5469
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2011-01-10 14:03:43 +0100
message:
  Remove unused HIP_PUZZLE_MAX_LIFETIME #define.
------------------------------------------------------------
revno: 5468
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2011-01-10 13:16:35 +0100
message:
  Remove unused HIP_MSG_* #defines.
------------------------------------------------------------
revno: 5467
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2011-01-10 13:15:34 +0100
message:
  Remove unused HIP_OPPDB_SIZE #define.
------------------------------------------------------------
revno: 5466
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2011-01-10 13:14:37 +0100
message:
  Remove unused MIN_NODES #define.
------------------------------------------------------------
revno: 5465
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2011-01-10 12:53:26 +0100
message:
  Remove unused PROTO_STRING_MAX #define.
------------------------------------------------------------
revno: 5464
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2011-01-07 19:32:48 +0100
message:
  Remove unused macros HIP_HADB_SIZE and HIP_MAX_HAS.
------------------------------------------------------------
revno: 5463
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2011-01-07 18:55:09 +0100
message:
  Remove unused macro HIP_OPTION_KIND.
------------------------------------------------------------
revno: 5462
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2011-01-07 18:54:38 +0100
message:
  Remove unused macro HIP_TMP_FNAME_TEMPLATE.
------------------------------------------------------------
revno: 5461
committer: Diego Biurrun 
branch nick: hipl
timestamp: Wed 2011-01-12 13:06:33 +0100
message:
  Replace more instances of malloc + memset(0) with calloc().
------------------------------------------------------------
revno: 5460
committer: Diego Biurrun 
branch nick: hipl
timestamp: Wed 2011-01-12 12:58:50 +0100
message:
  cosmetics: Remove unnecessary parentheses in HIP_IFE* if-conditionals.
------------------------------------------------------------
revno: 5459
committer: Samu Varjonen 
branch nick: hipl
timestamp: Wed 2011-01-12 13:55:24 +0200
message:
  In hip_cert_spki_create_cert_sock replaced the calls to hip_in6_ntop 
  with inet_ntop because the hip_in6_ntop produces non-RFC3849-compliant 
  IPv6 addresses.
------------------------------------------------------------
revno: 5458
committer: Diego Biurrun 
branch nick: hipl
timestamp: Wed 2011-01-12 12:24:25 +0100
message:
  Remove a useless set of block braces around a HIP_IFEL statement.
------------------------------------------------------------
revno: 5457
committer: Diego Biurrun 
branch nick: hipl
timestamp: Wed 2011-01-12 12:13:13 +0100
message:
  Remove outdated @todo comment about a non-existing compiler warning.
------------------------------------------------------------
revno: 5456
committer: Diego Biurrun 
branch nick: hipl
timestamp: Wed 2011-01-12 11:57:02 +0100
message:
  Fix wrong condition in check if certificate issuer name was correctly loaded.
  
  '=' was used instead of '==', so instead of a NULL a NULL assignment was done,
  which always succeeds, thus rendering the check void. The gcc warning about
  this suspicious assignment was wrongly silenced through parentheses.
------------------------------------------------------------
revno: 5455
committer: Stefan G?tz 
branch nick: hipl
timestamp: Wed 2011-01-12 10:52:45 +0100
message:
  Distribute the script and configuration files for the stylecheck pre-commit
  hook with the HIPL tar ball. This is to satisfy the policy of distributing
  everything from the repository that doesn't hurt in the tar ball.
------------------------------------------------------------
revno: 5454
fixes bug(s): https://launchpad.net/bugs/701035
committer: Rene Hummen 
branch nick: hipl
timestamp: Wed 2011-01-12 10:42:39 +0100
message:
  fix 8 byte instead of 4 byte seq and ack parameter values
  
  SEQ and ACK are defined to be 4 byte values (+ 4 byte parameter header) in
  RFC 5201. Both parameters had an overall length of length of 8 bytes for
  the value and 4 bytes for the header (= 12 bytes). The reason was that
  hip_calc_param_len() expects to be called with the size of the value and
  not the size of the complete TLV. Hence, the TL part has to be substracted
  from both hip_seq and hip_ack structs before calling this function.
  Otherwise, the 4 byte value will be sent on the wire padded by 4 byte of
  memory following the struct.
  The issue has been fixed now by substracting the TL length. Furthermore,
  all other functions using hip_calc_param_len() have been checked to pass
  the correct length on function call.
------------------------------------------------------------
revno: 5453
committer: Samu Varjonen 
branch nick: hipl
timestamp: Wed 2011-01-12 11:33:29 +0200
message:
  Removed the section Data packet support from the doc/HOWTO.xml
  as it is not currently supported and it was under incorrect 
  section.
------------------------------------------------------------
revno: 5452
committer: Henrik Ziegeldorf 
branch nick: hipl
timestamp: Tue 2011-01-11 16:38:42 +0100
message:
  Load keys from file hi_file instead of standard files (rsa/dsa_filenamebase).
  
  This fixes revision 5426, which unintentionally disabled user supplied host identities.
------------------------------------------------------------
revno: 5451
committer: Henrik Ziegeldorf 
branch nick: hipl
timestamp: Tue 2011-01-11 16:31:03 +0100
message:
  Removed a piece of ECC code that was falsely committed into trunk.
------------------------------------------------------------
revno: 5450 [merge]
committer: Stefan G?tz 
branch nick: hipl
timestamp: Tue 2011-01-11 15:36:36 +0100
message:
  Merge of branch lp:~stefan.goetz/hipl/style-check-hook-review:
  
  1) a pre-commit hook for bazaar that aborts a commit if the code to be
     committed does not adhere to the HIPL style guide lines.
  
  2) all HIPL code has been automatically beautified so that the pre-commit
     hook only complains about newly introduced style violations.
------------------------------------------------------------
revno: 5449
committer: Rene Hummen 
branch nick: hipl
timestamp: Tue 2011-01-11 13:40:27 +0100
message:
  modify semantics of deleting IPsec SAs
  
  SAs are now only removed through xfrm, if we know to have set an SA
  before.
------------------------------------------------------------
revno: 5448
committer: Henrik Ziegeldorf 
branch nick: trunk_branch
timestamp: Mon 2011-01-10 19:06:59 +0100
message:
  Updated doxygen of function hip_any_key_to_hit() to fit function signature.
------------------------------------------------------------
revno: 5447
committer: Rene Hummen 
branch nick: hipl
timestamp: Mon 2011-01-10 18:51:29 +0100
message:
  refactor the creation and processing of I1, I2 and R2 packets
  
  - removed code that set (local) variables which were never used
  - moved the setup of IPsec SAs into a separate function and removed code duplication
  - moved code for hmacing and signing into a separate function
  - moved echo parameter creation into separate function
  - moved RVS code into separate functions
  
  These changes have been developed in /~hipl-core/hipl/bex-cleanup and
  the proposal to merge has been approved.
------------------------------------------------------------
revno: 5446
committer: Henrik Ziegeldorf 
branch nick: trunk_branch
timestamp: Mon 2011-01-10 18:28:21 +0100
message:
  Removed pointless casts. Use HIP_HI_DSA/RSA instead of integers 0 or 1.
------------------------------------------------------------
revno: 5445
committer: Henrik Ziegeldorf 
branch nick: trunk_branch
timestamp: Mon 2011-01-10 18:26:01 +0100
message:
  Remove pointless cast of void * to DSA *.
------------------------------------------------------------
revno: 5444
committer: Henrik Ziegeldorf 
branch nick: trunk_branch
timestamp: Mon 2011-01-10 18:21:42 +0100
message:
  More const correctness for crypto.c
------------------------------------------------------------
revno: 5443
committer: Henrik Ziegeldorf 
branch nick: trunk_branch
timestamp: Mon 2011-01-10 18:13:32 +0100
message:
  Check for the rsa key we have just created, not for the dsa key.
------------------------------------------------------------
revno: 5442
committer: Henrik Ziegeldorf 
branch nick: trunk_branch
timestamp: Mon 2011-01-10 18:12:52 +0100
message:
  Refactored hip_any_key_to_hit() and used it in hostid.c instead of all the rsa/dsa specific key_to_hit functions.
------------------------------------------------------------
revno: 5441
committer: Henrik Ziegeldorf 
branch nick: trunk_branch
timestamp: Mon 2011-01-10 18:08:00 +0100
message:
  Const correctness for the xxx_to_endpoint functions in builder.c
------------------------------------------------------------
revno: 5440
committer: Henrik Ziegeldorf 
branch nick: trunk_branch
timestamp: Mon 2011-01-10 18:05:54 +0100
message:
  Added tests in host_id builder functions for null arguments and invalid sizes for keys and hostnames.
------------------------------------------------------------
revno: 5439
committer: Henrik Ziegeldorf 
branch nick: trunk_branch
timestamp: Mon 2011-01-10 16:37:57 +0100
message:
  Replaced multi-cased if statements with switch-case statements. Replaced setting of sign function with inline ifs by switch-case statements to allow for new algorithms. Added const correctness for some funcitons.
------------------------------------------------------------
revno: 5438
committer: Henrik Ziegeldorf 
branch nick: trunk_branch
timestamp: Mon 2011-01-10 16:35:17 +0100
message:
  Replaced multi-cased if statements with switch-case statements. Replaced setting of sign function with inline ifs by switch-case statements to allow for new algorithms.
------------------------------------------------------------
revno: 5437
committer: Henrik Ziegeldorf 
branch nick: trunk_branch
timestamp: Mon 2011-01-10 16:30:42 +0100
message:
  Step towards HIPv2: Replace setting of signature function by inline if with switch case statement that allows for easy adding of other algorithms.
------------------------------------------------------------
revno: 5436
committer: Henrik Ziegeldorf 
branch nick: trunk_branch
timestamp: Mon 2011-01-10 16:29:09 +0100
message:
  Removed two function declarations from cert.h. These functions are neither implemented nor called.
------------------------------------------------------------
revno: 5435
committer: Henrik Ziegeldorf 
branch nick: trunk_branch
timestamp: Mon 2011-01-10 16:28:21 +0100
message:
  Replaced multi-cased if statements with switch-case statements in cert.c. This is a step towards ECC or HIPv2 in general.
------------------------------------------------------------
revno: 5434
committer: Henrik Ziegeldorf 
branch nick: trunk_branch
timestamp: Mon 2011-01-10 16:23:36 +0100
message:
   Refactored key loader functions and function parse_hit() in rule_management.c, which alone calls these functions.
    
    Changes
     - Caller of key loader function gets control over memory management.
     - RSA_new, DSA_new and EC_KEY_new are not necessary because PEM_read_xxx_PUBKEY handles this.
     - Do not allocate memory for calls to xxx_to_dns_key_rr(..) because these functions handle the memory allocation themselves.
       In fact this should be refactored, too.
     - Improved error handling for key loader functions.
     - Improved debugging output of parse_hit().
     - Updated documentation.
------------------------------------------------------------
revno: 5433
committer: Diego Biurrun 
branch nick: calloc
timestamp: Sun 2011-01-09 23:18:11 +0100
message:
  Allocate zeroed memory directly with calloc instead of with malloc + memset.
------------------------------------------------------------
revno: 5432
committer: Henrik Ziegeldorf 
branch nick: trunk_branch
timestamp: Mon 2011-01-10 16:18:18 +0100
message:
  Replaced multi-cased if statement with switch-case statement. This is a step towards ECC or HIPv2 in general.
------------------------------------------------------------
revno: 5431
committer: Henrik Ziegeldorf 
branch nick: trunk_branch
timestamp: Mon 2011-01-10 16:14:59 +0100
message:
  Moved increment of file counter to more sensible location, i.e. directly after a new file is opened.
------------------------------------------------------------
revno: 5430
committer: Henrik Ziegeldorf 
branch nick: trunk_branch
timestamp: Mon 2011-01-10 16:12:22 +0100
message:
  Const correctness, proper grammer and punctuation for save, create and load functions in crypto.h. Removed two declarations of functions that are neither implemented nor used.
------------------------------------------------------------
revno: 5429
committer: Henrik Ziegeldorf 
branch nick: trunk_branch
timestamp: Mon 2011-01-10 15:57:49 +0100
message:
  Const correctness for all functions in hostid.h.
------------------------------------------------------------
revno: 5428
committer: Henrik Ziegeldorf 
branch nick: trunk_branch
timestamp: Mon 2011-01-10 15:45:49 +0100
message:
  Const correctness for function hip_serialize_host_id_action().
------------------------------------------------------------
revno: 5427
committer: Henrik Ziegeldorf 
branch nick: trunk_branch
timestamp: Mon 2011-01-10 15:44:16 +0100
message:
  Include HIPL_SYSCONFDIR in the definition of DEFAULT_HOST_DSA/RSA_KEY_FILE_BASE.
------------------------------------------------------------
revno: 5426
committer: Henrik Ziegeldorf 
branch nick: trunk_branch
timestamp: Mon 2011-01-10 15:41:26 +0100
message:
  Removed the whole code for filenamebase generation. Filenamebases are fixed and need not be constructed dynamically at runtime.
------------------------------------------------------------
revno: 5425
committer: Henrik Ziegeldorf 
branch nick: hipl
timestamp: Mon 2011-01-10 15:34:52 +0100
message:
  Partially revert wrongly removed casts from r5419; fixes base exchange.
  
  When doing pointer arithmetics cast removal is dangerous!
------------------------------------------------------------
revno: 5424
committer: Samu Varjonen 
branch nick: hipl
timestamp: Mon 2011-01-10 12:14:22 +0200
message:
  "authed" to "authenticated" in hipfw usage().
------------------------------------------------------------
revno: 5423
committer: Henrik Ziegeldorf 
branch nick: hipl
timestamp: Mon 2011-01-10 09:58:44 +0100
message:
  Corrected debugging output in function load_dsa_file(). A DSA key is read here, not an RSA key.
------------------------------------------------------------
revno: 5422
committer: Diego Biurrun 
branch nick: calloc
timestamp: Sun 2011-01-09 23:14:32 +0100
message:
  cosmetics: Remove unncessary parentheses around arithmetic expressions.
------------------------------------------------------------
revno: 5421
committer: Diego Biurrun 
branch nick: calloc
timestamp: Sun 2011-01-09 23:06:27 +0100
message:
  Remove a large number of unnecessary casts in hipd/cert.c.
------------------------------------------------------------
revno: 5420
committer: Diego Biurrun 
branch nick: calloc
timestamp: Sun 2011-01-09 21:47:32 +0100
message:
  cosmetics: Remove some unnecessary parentheses around arithmetic expressions.
------------------------------------------------------------
revno: 5419
committer: Diego Biurrun 
branch nick: memmove
timestamp: Sun 2011-01-09 15:59:33 +0100
message:
  Remove pointless casts of memmove/memset void* arguments.
  
  A void* pointer is compatible with any pointer type in C.
------------------------------------------------------------
revno: 5418
committer: Diego Biurrun 
branch nick: hipl
timestamp: Fri 2011-01-07 17:53:52 +0100
message:
  Give HIP_IF* macro parameter used as if-condition a more suitable name.
  
  "func" hints at a function, not a condition, so "cond" is much better.
------------------------------------------------------------
revno: 5417
committer: Diego Biurrun 
branch nick: hipl
timestamp: Fri 2011-01-07 17:52:28 +0100
message:
  Remove unused macro HIP_IFEB.
------------------------------------------------------------
revno: 5416
committer: Diego Biurrun 
branch nick: hipl
timestamp: Fri 2011-01-07 17:46:17 +0100
message:
  Remove unused macro HIP_IFEBL.
------------------------------------------------------------
revno: 5415
committer: Diego Biurrun 
branch nick: hipl
timestamp: Fri 2011-01-07 19:36:00 +0100
message:
  cosmetics: Fix multiple inclusion guards to follow standard naming convention.
------------------------------------------------------------
revno: 5414
committer: Diego Biurrun 
branch nick: hipl
timestamp: Fri 2011-01-07 17:15:14 +0100
message:
  Drop pointless _t suffixes from hip_transform_suite_t/hip_controls_t typedefs.
  
  The _t namespace is reserved for POSIX.
------------------------------------------------------------
revno: 5413
committer: Diego Biurrun 
branch nick: hipl
timestamp: Fri 2011-01-07 17:09:23 +0100
message:
  Drop pointless _type_t/_t suffixes from hip_tlv_type_t/hip_tlv_len_t typedefs.
  
  The _t namespace is reserved for POSIX.
------------------------------------------------------------
revno: 5412
committer: Diego Biurrun 
branch nick: hipl
timestamp: Fri 2011-01-07 16:45:25 +0100
message:
  Drop pointless _t suffix from hip_hdr_err_t typedef.
  
  The _t namespace is reserved for POSIX.
------------------------------------------------------------
revno: 5411
committer: Diego Biurrun 
branch nick: hipl
timestamp: Fri 2011-01-07 16:43:01 +0100
message:
  Drop pointless _t suffixes from se_family_t/se_length_t/se_hip_flags_t typedefs.
  
  The _t namespace is reserved for POSIX.
------------------------------------------------------------
revno: 5410
committer: Diego Biurrun 
branch nick: hipl
timestamp: Fri 2011-01-07 16:36:39 +0100
message:
  Drop pointless _t suffix from hip_hdr_len_t typedef.
  
  The _t namespace is reserved for POSIX.
------------------------------------------------------------
revno: 5409
committer: Diego Biurrun 
branch nick: hipl
timestamp: Fri 2011-01-07 16:31:35 +0100
message:
  Drop pointless _type_t suffix from hip_hdr_type_t typedef.
  
  The _t namespace is reserved for POSIX.
------------------------------------------------------------
revno: 5408
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2011-01-07 16:26:32 +0100
message:
  Get rid of one pointless variable indirection in hip_peek_recv_total_len().
------------------------------------------------------------
revno: 5407
committer: Diego Biurrun 
branch nick: hipl
timestamp: Fri 2011-01-07 15:46:07 +0100
message:
  Drop hip_list_t typedef and _t namespace suffix.
  
  The _t namespace is reserved for POSIX; typedefs are evil.
------------------------------------------------------------
revno: 5406
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2011-01-03 16:40:09 +0100
message:
  Remove pointless read_rules() wrapper around get_rule_list().
------------------------------------------------------------
revno: 5405
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2011-01-03 15:53:51 +0100
message:
  Remove pointless hip_cert_free_conf() wrapper around NCONF_free(conf).
------------------------------------------------------------
revno: 5404
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2011-01-03 15:43:03 +0100
message:
  Remove pointless hip_free_dh() wrapper around DH_free().
------------------------------------------------------------
revno: 5403
fixes bug(s): https://launchpad.net/bugs/691410
committer: Miika Komu 
branch nick: trunk
timestamp: Thu 2011-01-06 22:13:43 +0200
message:
  Removed incorrect initialization in firewall.
  
  Bug #691410:
  
  firewall_init_filter_traffic() should be called instead of 
  hip_fw_init_esp_prot_conntrack().
------------------------------------------------------------
revno: 5402
committer: Miika Komu 
branch nick: trunk
timestamp: Thu 2011-01-06 21:50:27 +0200
message:
  Corrected a small typo in the manual.
  
  I hope I understood the note on hipl-dev right.
------------------------------------------------------------
revno: 5401
committer: Rene Hummen 
branch nick: hipl
timestamp: Thu 2011-01-06 19:03:18 +0100
message:
  refactor updating ipsec security association
  
  The code for updating IPsec SAs and SPs have been moved into separate
  functions and have been hooked into packet handling. This allows to
  remove kernelspace SA updating and replace it, e.g., by userspace SA
  updating.
------------------------------------------------------------
revno: 5400
committer: Rene Hummen 
branch nick: hipl
timestamp: Thu 2011-01-06 18:53:24 +0100
message:
  add initialization messages for the heartbeat extension
------------------------------------------------------------
revno: 5399
committer: Rene Hummen 
branch nick: hipl
timestamp: Thu 2011-01-06 18:44:11 +0100
message:
  add missing doxygen comments for parameters packet_type and ha_state
------------------------------------------------------------
revno: 5398
committer: Rene Hummen 
branch nick: hipl
timestamp: Thu 2011-01-06 18:40:03 +0100
message:
  replaced stdint by stdlib
  
  stdlib is required for the definition of NULL
------------------------------------------------------------
revno: 5397
committer: Rene Hummen 
branch nick: hipl
timestamp: Thu 2011-01-06 18:27:07 +0100
message:
  removed unnecessary include
  
  hadb does not call a function related to userspace ipsec.
------------------------------------------------------------
revno: 5396
committer: Rene Hummen 
branch nick: hipl
timestamp: Thu 2011-01-06 18:21:44 +0100
message:
  add functionality to unregister packet handle functions
  
  This is required in case a module replaces the functionality of another
  module (i.e., userspace ipsec replaces hooks for kernelspace ipsec). 
------------------------------------------------------------
revno: 5395
committer: Rene Hummen 
branch nick: hipl
timestamp: Thu 2011-01-06 18:08:00 +0100
message:
  added missing include
  
  malloc requires stdlib
------------------------------------------------------------
revno: 5394
committer: Rene Hummen 
branch nick: hipl
timestamp: Thu 2011-01-06 18:05:42 +0100
message:
  corrected type of num_parallel_hchains
  
  num_parallel_hchains is an int not long. This corrects the wire-format of
  num_parallel_hchains in user-messages.
------------------------------------------------------------
revno: 5393
committer: Rene Hummen 
branch nick: hipl
timestamp: Thu 2011-01-06 18:03:31 +0100
message:
  added missing include
  
  malloc requires stdlib
------------------------------------------------------------
revno: 5392
committer: Rene Hummen 
branch nick: hipl
timestamp: Thu 2011-01-06 12:35:51 +0100
message:
  added missing include
  
  hip_esp_protection was missing from firewall.h
------------------------------------------------------------
revno: 5391
committer: Rene Hummen 
branch nick: hipl
timestamp: Thu 2011-01-06 12:30:37 +0100
message:
  esp token protection is now disabled by default
  
  esp token filtering was always active when traffic filtering took
  place in the hipfw. Now, esp token filtering needs to be enabled at 
  the commandline during hipfw startup. The "-e" parameter is reused for
  this purpose.
  
  NOTE: End-hosts now have to specify "-ei" in order to run the esp
  token protection extension.
------------------------------------------------------------
revno: 5390
committer: Miika Komu 
branch nick: trunk
timestamp: Wed 2011-01-05 16:01:28 +0200
message:
  Updated installation instructions in the manual.
  
  Added a reminder about the /etc/hip vs. /usr/local/etc/hip changes.
------------------------------------------------------------
revno: 5389
committer: Miika Komu 
branch nick: trunk
timestamp: Wed 2011-01-05 15:55:22 +0200
message:
  Updated installation instructions in the manual.
  
  "make bin" selects whether to build rpm or deb package.
------------------------------------------------------------
revno: 5388
committer: Stefan G?tz 
branch nick: hipl
timestamp: Wed 2011-01-05 14:40:14 +0100
message:
  Remove useless macro indirection for default contents of hipd config file.
  Fold individual strings into a single format string, the way that fprintf()
  is normally used.
  The motivation for this change is that uncrustify does not handle the old
  macro-based code very gracefully.
  With this change, the code is more intuitive and one of the few problem
  cases in HIPL for uncrustify is removed.
------------------------------------------------------------
revno: 5387
committer: Diego Biurrun 
branch nick: hipl
timestamp: Tue 2011-01-04 20:39:28 +0100
message:
  Drop unnecessary lib/core path prefixes from #includes in lib/core.
------------------------------------------------------------
revno: 5386
committer: Diego Biurrun 
branch nick: hipl
timestamp: Tue 2011-01-04 20:31:17 +0100
message:
  Remove hipd #includes from lib/core/crypto.h.
  
  There must not be circular dependencies between hipd and lib/core.
------------------------------------------------------------
revno: 5385
committer: Diego Biurrun 
branch nick: hipl
timestamp: Tue 2011-01-04 20:29:36 +0100
message:
  Move hip_host_id_entry struct to hipd/hidb.h, where it belongs.
  
  The structure is not used outside of hipd and was apparently only kept in
  lib/core due to some weird compiler errors that no longer appear.
------------------------------------------------------------
revno: 5384
committer: Diego Biurrun 
branch nick: hipl
timestamp: Tue 2011-01-04 20:22:24 +0100
message:
  Move hip_host_id_entry_to_hit_info() function to the only place it is used.
------------------------------------------------------------
revno: 5383
committer: Diego Biurrun 
branch nick: hipl
timestamp: Tue 2011-01-04 19:56:17 +0100
message:
  Do not cast the variable addr to 'struct in_addr *', which already is its type.
------------------------------------------------------------
revno: 5382
committer: Diego Biurrun 
branch nick: hipl
timestamp: Tue 2011-01-04 19:45:04 +0100
message:
  Do not cast the return value of hip_cast_sa_addr(), which returns void*.
------------------------------------------------------------
revno: 5381
committer: Diego Biurrun 
branch nick: hipl
timestamp: Tue 2011-01-04 19:40:14 +0100
message:
  Drop all casts on the result of the list_find macro.
  
  Without the casts, no warnings are generated and the md5sums of the compiled
  .o files do not change, so it should be safe to remove them.
------------------------------------------------------------
revno: 5380
committer: Diego Biurrun 
branch nick: hipl
timestamp: Tue 2011-01-04 19:32:00 +0100
message:
  Drop all casts on the result of the list_entry macro.
  
  Without the casts, no warnings are generated and the md5sums of the compiled
  .o files do not change, so it should be safe to remove them.
------------------------------------------------------------
revno: 5379
committer: Diego Biurrun 
branch nick: hipl
timestamp: Tue 2011-01-04 19:13:58 +0100
message:
  Do not cast the return value of hip_ll_get(), which returns void*.
  
  void* is compatible with any pointer type in C.
------------------------------------------------------------
revno: 5378
committer: Diego Biurrun 
branch nick: hipl
timestamp: Tue 2011-01-04 18:41:10 +0100
message:
  Avoid two pointless casts of a variable to its own type.
------------------------------------------------------------
revno: 5377
committer: Diego Biurrun 
branch nick: hipl
timestamp: Tue 2011-01-04 18:39:53 +0100
message:
  Remove a handful of void* variable casts.
  
  void* denotes an opaque pointer in C and is compatible with any other pointer.
------------------------------------------------------------
revno: 5376
committer: Diego Biurrun 
branch nick: hipl
timestamp: Tue 2011-01-04 18:37:40 +0100
message:
  Remove pointless do_gettimeofday macro.
  
  The only two uses of this macro were in one function in hadb.c, besides
  just calling gettimeofday with NULL as second parameter does not warrant
  introducing a macro.
------------------------------------------------------------
revno: 5375
committer: Diego Biurrun 
branch nick: hipl
timestamp: Tue 2011-01-04 18:33:32 +0100
message:
  Drop _t namespace suffix from hip_fw_handler function pointer typedef.
  
  The _t namespace is reserved for POSIX and should not be invaded.
  This change entailed renaming the hip_fw_handler array, whose name was
  shadowing that of the function pointer declaration.
------------------------------------------------------------
revno: 5374
committer: Diego Biurrun 
branch nick: hipl
timestamp: Tue 2011-01-04 18:31:39 +0100
message:
  Drop anchor_db struct typedef and _t namespace suffix.
  
  The _t namespace is reserved for POSIX; typedefs are evil.
------------------------------------------------------------
revno: 5373
committer: Diego Biurrun 
branch nick: hipl
timestamp: Tue 2011-01-04 18:26:22 +0100
message:
  Drop registration struct typedef and _t namespace suffix.
  
  The _t namespace is reserved for POSIX; typedefs are evil.
------------------------------------------------------------
revno: 5372
committer: Diego Biurrun 
branch nick: hipl
timestamp: Tue 2011-01-04 18:21:26 +0100
message:
  Drop oppdb struct typedefs and _t namespace suffixes.
  
  The _t namespace is reserved for POSIX; typedefs are evil.
------------------------------------------------------------
revno: 5371
committer: Diego Biurrun 
branch nick: hipl
timestamp: Tue 2011-01-04 18:07:21 +0100
message:
  Drop hiprelay struct and enum typedefs and _t namespace suffixes.
  
  The _t namespace is reserved for POSIX; typedefs are evil.
------------------------------------------------------------
revno: 5370
committer: Diego Biurrun 
branch nick: hipl
timestamp: Tue 2011-01-04 17:50:29 +0100
message:
  Drop configfilereader struct typedefs and _t namespace suffixes.
  
  The _t namespace is reserved for POSIX; typedefs are evil.
------------------------------------------------------------
revno: 5369
committer: Diego Biurrun 
branch nick: hipl
timestamp: Tue 2011-01-04 17:29:43 +0100
message:
  Drop nlink struct typedef and _t namespace suffix.
  
  The _t namespace is reserved for POSIX; typedefs are evil.
------------------------------------------------------------
revno: 5368
committer: Diego Biurrun 
branch nick: hipl
timestamp: Tue 2011-01-04 17:22:49 +0100
message:
  Drop performance struct typedef and _t namespace suffix.
  
  The _t namespace is reserved for POSIX; typedefs are evil.
------------------------------------------------------------
revno: 5367
author: Stefan G?tz 
committer: Diego Biurrun 
branch nick: hipl
timestamp: Tue 2011-01-04 17:14:19 +0100
message:
  Simplify a series of connection structure assignments.
  
  This will make a future uncrustify run simpler as it was choking on this code.
------------------------------------------------------------
revno: 5366
committer: Diego Biurrun 
branch nick: hipl
timestamp: Tue 2011-01-04 17:09:56 +0100
message:
  Get rid of one pointless variable indirection as noticed by Stefan G?tz.
------------------------------------------------------------
revno: 5365
committer: Diego Biurrun 
branch nick: hipl
timestamp: Tue 2011-01-04 15:49:14 +0100
message:
  Drop hip_link_entry struct typedef and _t namespace suffix.
  
  The _t namespace is reserved for POSIX; typedefs are evil.
------------------------------------------------------------
revno: 5364
committer: Diego Biurrun 
branch nick: hipl
timestamp: Tue 2011-01-04 15:48:50 +0100
message:
  Drop esp_prot_conntrack_tfm struct typedef and _t namespace suffix.
  
  The _t namespace is reserved for POSIX; typedefs are evil.
------------------------------------------------------------
revno: 5363
committer: Diego Biurrun 
branch nick: hipl
timestamp: Tue 2011-01-04 15:32:37 +0100
message:
  Drop esp_cumulative_item struct typedefs and _t namespace suffixes.
  
  The _t namespace is reserved for POSIX; typedefs are evil.
------------------------------------------------------------
revno: 5362
committer: Diego Biurrun 
branch nick: hipl
timestamp: Tue 2011-01-04 15:23:17 +0100
message:
  Drop hip_sa_entry struct typedefs and _t namespace suffixes.
  
  The _t namespace is reserved for POSIX; typedefs are evil.
------------------------------------------------------------
revno: 5361
committer: Diego Biurrun 
branch nick: hipl
timestamp: Tue 2011-01-04 15:10:46 +0100
message:
  Drop typedef and _t namespace suffix from struct hip_fw_context.
  
  The _t namespace is reserved for POSIX; typedefs are evil.
------------------------------------------------------------
revno: 5360
committer: Diego Biurrun 
branch nick: hipl
timestamp: Tue 2011-01-04 15:03:54 +0100
message:
  Drop esp_prot_api.h typedefs and _t namespace suffixes.
  
  The _t namespace is reserved for POSIX; typedefs are evil.
------------------------------------------------------------
revno: 5359
committer: Diego Biurrun 
branch nick: hipl
timestamp: Tue 2011-01-04 14:57:31 +0100
message:
  Drop firewall cache typedefs and _t namespace suffixes.
  
  The _t namespace is reserved for POSIX; typedefs are evil.
------------------------------------------------------------
revno: 5358
committer: Diego Biurrun 
branch nick: hipl
timestamp: Tue 2011-01-04 14:45:27 +0100
message:
  Avoid two more casts of void* pointer variables.
  
  void* pointers are compatible with any other type in C.
------------------------------------------------------------
revno: 5357
committer: Diego Biurrun 
branch nick: hipl
timestamp: Tue 2011-01-04 14:40:13 +0100
message:
  Drop remaining hashchain typedefs and _t namespace suffixes.
  
  The _t namespace is reserved for POSIX; typedefs are evil.
------------------------------------------------------------
revno: 5356
committer: Diego Biurrun 
branch nick: hipl
timestamp: Tue 2011-01-04 14:24:28 +0100
message:
  Drop _t prefix from hip_filter function pointer.
  
  The _t namespace is reserved for POSIX.
------------------------------------------------------------
revno: 5355
committer: Diego Biurrun 
branch nick: hipl
timestamp: Tue 2011-01-04 14:22:16 +0100
message:
  Drop typedefs for structures from lutil.h; typedefs on structs are evil.
------------------------------------------------------------
revno: 5354
committer: Diego Biurrun 
branch nick: hipl
timestamp: Tue 2011-01-04 13:16:00 +0100
message:
  Declare hostname array as char type instead of casting when using the variable.
------------------------------------------------------------
revno: 5353
committer: Diego Biurrun 
branch nick: hipl
timestamp: Tue 2011-01-04 13:15:20 +0100
message:
  Do not redundantly cast variable to its own type.
------------------------------------------------------------
revno: 5352
committer: Diego Biurrun 
branch nick: hipl
timestamp: Tue 2011-01-04 13:11:37 +0100
message:
  Do not cast variables that have type void*.
  
  In C void* denotes an opaque pointer type and is compatible with any other
  pointer type.  Thus there is no need for casting void* pointers in C.
------------------------------------------------------------
revno: 5351
committer: Diego Biurrun 
branch nick: hipl
timestamp: Tue 2011-01-04 13:06:30 +0100
message:
  Do not pointlessly cast the return value of create_bex_store_update_msg().
  
  create_bex_store_update_msg() returns 'struct hip_common *' so there is no
  point in casting the return value to the exact same type.
------------------------------------------------------------
revno: 5350
committer: Diego Biurrun 
branch nick: hipl
timestamp: Tue 2011-01-04 13:04:26 +0100
message:
  cosmetics: Reformat some weirdly indented comments, break a long line.
------------------------------------------------------------
revno: 5349
committer: Diego Biurrun 
branch nick: hipl
timestamp: Mon 2011-01-03 20:36:44 +0100
message:
  Drop pointless protodefs.h struct typedefs and _t namespace suffixes.
  
  The _t namespace is reserved for POSIX; typedefs are evil.
------------------------------------------------------------
revno: 5348
committer: Diego Biurrun 
branch nick: hipl
timestamp: Mon 2011-01-03 19:05:08 +0100
message:
  Drop debug typedefs and _t namespace suffixes.
  
  The _t namespace is reserved for POSIX; typedefs are evil.
------------------------------------------------------------
revno: 5347
committer: Diego Biurrun 
branch nick: hipl
timestamp: Mon 2011-01-03 19:02:42 +0100
message:
  Drop state typedefs and _t namespace suffixes.
  
  The _t namespace is reserved for POSIX; typedefs are evil.
------------------------------------------------------------
revno: 5346
committer: Diego Biurrun 
branch nick: hipl
timestamp: Mon 2011-01-03 18:56:09 +0100
message:
  Drop builder typedefs and _t namespace suffixes.
  
  The _t namespace is reserved for POSIX; typedefs are evil.
------------------------------------------------------------
revno: 5345
committer: Diego Biurrun 
branch nick: hipl
timestamp: Mon 2011-01-03 18:26:48 +0100
message:
  Drop hashtree typedefs and _t namespace suffixes.
  
  The _t namespace is reserved for POSIX; typedefs are evil.
------------------------------------------------------------
revno: 5344
committer: Diego Biurrun 
branch nick: hipl
timestamp: Mon 2011-01-03 18:24:19 +0100
message:
  Drop hashchain_store typedefs and _t namespace suffixes.
  
  The _t namespace is reserved for POSIX; typedefs are evil.
------------------------------------------------------------
revno: 5343
committer: Diego Biurrun 
branch nick: hipl
timestamp: Mon 2011-01-03 18:17:17 +0100
message:
  Drop prefix.h _t namespace suffix, which is reserved by POSIX.
------------------------------------------------------------
revno: 5342
committer: Diego Biurrun 
branch nick: hipl
timestamp: Mon 2011-01-03 18:03:05 +0100
message:
  Drop hashchain typedefs and _t namespace suffixes.
  
  The _t namespace is reserved for POSIX; typedefs are evil.
  This required renaming some variables because they were shadowing the
  global hash_function declaration.
------------------------------------------------------------
revno: 5341
committer: Diego Biurrun 
branch nick: hipl
timestamp: Mon 2011-01-03 17:19:22 +0100
message:
  Drop linkedlist typedefs and _t namespace suffixes.
  
  The _t namespace is reserved for POSIX; typedefs are evil.
------------------------------------------------------------
revno: 5340
committer: Diego Biurrun 
branch nick: hipl
timestamp: Mon 2011-01-03 16:59:55 +0100
message:
  Replace statistics_data_t typedef by struct statistics_data.
  
  The _t namespace is reserved for POSIX and typedefs are evil.
------------------------------------------------------------
revno: 5339
committer: Diego Biurrun 
branch nick: hipl
timestamp: Tue 2011-01-04 12:53:22 +0100
message:
  cosmetics: Remove unused, commented-out global variable declaration.
------------------------------------------------------------
revno: 5338
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2011-01-03 15:10:09 +0100
message:
  Fold generating documentation for the web into bzr-update-hipl.
  
  This saves some code duplication as now only a single script deals with
  updating the HIPL website.
------------------------------------------------------------
revno: 5337
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2011-01-03 15:06:54 +0100
message:
  Create standard versioned tarballs and unpack to versioned subdirectories.
  
  This is the customary way to package software and it help with metabuildsystems
  like OpenWrt that expect to deal with versioned software tarballs.
------------------------------------------------------------
revno: 5336
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2011-01-03 14:57:36 +0100
message:
  Remove unused OUTPUT_FILE variable.
------------------------------------------------------------
revno: 5335
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2011-01-03 14:55:24 +0100
message:
  Generate tarball ChangeLog directly in the tarball directory.
------------------------------------------------------------
revno: 5334
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2011-01-03 14:50:22 +0100
message:
  Run 'bzr checkout' in quiet mode in scripts.
------------------------------------------------------------
revno: 5333
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2011-01-03 14:49:14 +0100
message:
  Remove reference to non-existing /p/bin directory in PATH.
------------------------------------------------------------
revno: 5332
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2011-01-03 14:48:45 +0100
message:
  Refresh comments in bzr-update-hipl.
------------------------------------------------------------
revno: 5331
committer: Miika Komu 
branch nick: trunk
timestamp: Mon 2011-01-03 14:11:23 +0200
message:
  Fixes on sync-all maintainer script.
  
  Adjust sync-all according to Diego's changes to maintainer scripts. 
  Tarball path is now hipl-1.0.6 instead of trunk.
------------------------------------------------------------
revno: 5330
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-12-31 14:39:01 +0100
message:
  Add references to OpenSSL to files explaining HIPL licensing.
  
  This is required by the OpenSSL license, paragraph 6).
------------------------------------------------------------
revno: 5329
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-12-31 13:30:21 +0100
message:
  uncrustify: Remove spaces inside function parentheses.
------------------------------------------------------------
revno: 5328
committer: Diego Biurrun 
branch nick: trunk
timestamp: Thu 2010-12-30 23:55:10 +0100
message:
  Let dpkg-buildpackage clean the source tree after finishing.
  
  For some obscure reason the source tree was otherwise left in a state that
  made the autobuilder choke with downright bizarre error messages when it
  reconfigured the tree and ran make again after Debian packages had been
  built without cleaning up afterwards.
------------------------------------------------------------
revno: 5327
committer: Diego Biurrun 
branch nick: hipl
timestamp: Thu 2010-12-30 23:38:32 +0100
message:
  Run unit tests before building binary distribution packages.
  
  The unit tests can only be run from a configured tree. Since building binary
  distribution packages can possibly clean the tree, it's safer to run the
  unit tests before building distribution packages.
------------------------------------------------------------
revno: 5326
committer: Diego Biurrun 
branch nick: hipl
timestamp: Thu 2010-12-30 22:49:52 +0100
message:
  Fix previous commit that reorganized variable initialization.
  
  No members of the p structure should be assigned to variables before p
  has been initialized.
------------------------------------------------------------
revno: 5325
committer: Diego Biurrun 
branch nick: hipl
timestamp: Thu 2010-12-30 21:13:00 +0100
message:
  Add license statements to the shell and Python scripts that still lack them.
------------------------------------------------------------
revno: 5324
fixes bug(s): https://launchpad.net/bugs/686100
committer: Diego Biurrun 
branch nick: hipl
timestamp: Thu 2010-12-30 19:47:03 +0100
message:
  Make hip_handle_exec_app() API more const correct.
  
  This fixes the following warning on Fedora 14 with gcc 4.5.1:
  hipd/hipd.c: In function ?main?:
  hipd/hipd.c:484:9: error: new qualifiers in middle of multi-level non-const cast are unsafe
------------------------------------------------------------
revno: 5323
committer: Diego Biurrun 
branch nick: hipl
timestamp: Thu 2010-12-30 18:26:34 +0100
message:
  Reorganize variable initialization to avoid an unnecessary cast in d2i_X509().
  
  This fixes the following warning on Fedora 14 with gcc 4.5.1:
  hipd/cert.c: In function ?hip_cert_x509v3_handle_request_to_verify?:
  hipd/cert.c:980:5: error: new qualifiers in middle of multi-level non-const cast are unsafe
------------------------------------------------------------
revno: 5322
committer: Diego Biurrun 
branch nick: hipl
timestamp: Thu 2010-12-30 18:23:43 +0100
message:
  Add 'make' to list of build dependencies and reorder them for clarity.
------------------------------------------------------------
revno: 5321
committer: Diego Biurrun 
branch nick: hipl
timestamp: Thu 2010-12-30 17:00:12 +0100
message:
  Fix various const-correctness issues in functions in lib/core/conf.c.
  
  This fixes the following warning on Fedora 14 with gcc 4.5.1:
  lib/core/conf.c: In function ?hip_do_hipconf?:
  lib/core/conf.c:2675:9: error: new qualifiers in middle of multi-level non-const cast are unsafe
  lib/core/conf.c:2677:9: error: new qualifiers in middle of multi-level non-const cast are unsafe
------------------------------------------------------------
revno: 5320
committer: Diego Biurrun 
branch nick: hipl
timestamp: Thu 2010-12-30 16:10:34 +0100
message:
  Initialize lsi variable in hip_handle_add_local_hi().
  
  This fixes the following warning on Fedora 14:
  hipd/hidb.c:537:15: error: ?lsi.s_addr? may be used uninitialized in this function
------------------------------------------------------------
revno: 5319
committer: Diego Biurrun 
branch nick: hipl
timestamp: Thu 2010-12-30 14:19:26 +0100
message:
  Remove pointless casts of realloc return value.
  
  realloc() returns void*, so casting the return value is unnecessary.
------------------------------------------------------------
revno: 5318
committer: Diego Biurrun 
branch nick: packaging_new
timestamp: Tue 2010-12-28 19:55:47 +0100
message:
  Refactor part of the RPM build functions now that Debian building was split off.
------------------------------------------------------------
revno: 5317
committer: Diego Biurrun 
branch nick: packaging_new
timestamp: Tue 2010-12-28 19:47:10 +0100
message:
  Replace debbuild-based Debian packaging infrastructure by native one.
  
  The native Debian packaging infrastructure now also produces split packages
  and is the natural way to build packages on Debian-based systems. Thus there
  is no more reason to keep the hackish debbuild-based alternative around.
------------------------------------------------------------
revno: 5316
committer: Diego Biurrun 
branch nick: packaging_new
timestamp: Tue 2010-12-28 18:11:47 +0100
message:
  Get rid of pointless NAME variable indirection.
------------------------------------------------------------
revno: 5315
committer: Diego Biurrun 
branch nick: packaging_new
timestamp: Tue 2010-12-28 18:05:10 +0100
message:
  Remove unused DISTRO variables.
------------------------------------------------------------
revno: 5314
committer: Rene Hummen 
branch nick: hipl
timestamp: Tue 2010-12-28 19:21:49 +0100
message:
  remove user-message type HIP_MSG_FW_FLUSH_SYS_OPP_HIP and related functionality
  
  The message was sent for updates, but was never processed at the
  receiver-side.
------------------------------------------------------------
revno: 5313
committer: Rene Hummen 
branch nick: hipl
timestamp: Tue 2010-12-28 18:18:29 +0100
message:
  add missing line breaks in debug output
------------------------------------------------------------
revno: 5312
committer: Diego Biurrun 
branch nick: packaging_new
timestamp: Tue 2010-12-28 17:53:40 +0100
message:
  Split monolithic native Debian packages similar to the RPM packages.
  
  The native Debian packaging infrastructure in HIPL used to build a monolithic
  binary package instead of split packages like the debbuild-based hackish Debian
  packages created from a slightly adapted RPM spec file. Now that the native
  Debian packages are split as desired, the debbuild-based infrastructure can be
  dropped.
  
  Initial work done by Samuel Richter with lots of fixes and extensions from me.
------------------------------------------------------------
revno: 5311
committer: Henrik Ziegeldorf 
branch nick: hipl
timestamp: Tue 2010-12-28 17:19:46 +0100
message:
  Corrected copy paste errors in doxygen of function handle_update(). 
  
  This function receives an UPDATE packet (and corresponding tupel) as parameter, not an R2 packet.
------------------------------------------------------------
revno: 5310
committer: Diego Biurrun 
branch nick: packaging_new
timestamp: Tue 2010-12-28 16:57:51 +0100
message:
  debian: Replace copyright boilerplate by a short notice + reference to COPYING.
------------------------------------------------------------
revno: 5309
committer: Diego Biurrun 
branch nick: packaging_new
timestamp: Tue 2010-12-28 16:30:00 +0100
message:
  Add force-reload parameter to dnsproxy and hipfw init scripts.
  
  This is required by Debian policy and fixes a lintian warning.
  For now, 'force-reload' is just an alias for 'restart'.
------------------------------------------------------------
revno: 5308
committer: Diego Biurrun 
branch nick: packaging_new
timestamp: Tue 2010-12-28 16:26:43 +0100
message:
  misc cosmetic changes for all Debian and Fedora init scripts
  
  Consistently use 4 space indentation, $() syntax instead of ``, consistent
  brace and empty line placement, vertical alignment for greater readability
  and a handful of similar cosmetic consistency changes.
------------------------------------------------------------
revno: 5307
committer: Diego Biurrun 
branch nick: hipl
timestamp: Mon 2010-12-27 19:17:07 +0100
message:
  Fix "Usage:" lines for all Debian and Fedora init scripts.
  
  The parameters given in the "Usage:" lines did not match the script options.
  Sometimes too few, sometimes too many available options were listed.
------------------------------------------------------------
revno: 5306
committer: Diego Biurrun 
branch nick: hipl
timestamp: Mon 2010-12-27 19:05:42 +0100
message:
  debian: Fix typo in log_action_msg function name.
------------------------------------------------------------
revno: 5305
committer: Diego Biurrun 
branch nick: hipl
timestamp: Mon 2010-12-27 18:28:12 +0100
message:
  Replace duplicated Debian init scripts by symlinks.
  
  We currently have identical Debian initscripts in both the debian and packaging
  subdirectories.  The ones in the Debian directory are copies of the ones in the
  packaging subdirectory, but do not share the history with them.  In order to
  preserve history the initscripts are moved within the revision control system
  to their new location in the debian subdirectory and symlinks to the new
  location placed in their stead.
------------------------------------------------------------
revno: 5304
committer: Rene Hummen 
branch nick: hipl
timestamp: Mon 2010-12-27 15:49:17 +0100
message:
  added tools/eclipse-K-R-style.xml to EXTRA_DIST
  
  make distcheck was complaining about missing files
------------------------------------------------------------
revno: 5303
committer: Rene Hummen 
branch nick: hipl
timestamp: Mon 2010-12-27 15:44:02 +0100
message:
  removed unnecessary variable statefulFiltering
  
  the variable initialized to 1, set to 1 after reading the rule file
  (always) and tested for 1 in a conditional.
------------------------------------------------------------
revno: 5302
committer: Rene Hummen 
branch nick: hipl
timestamp: Mon 2010-12-27 15:37:12 +0100
message:
  make firewall_init_filter_traffic() check for activation itself
  
  Already existing init-functions check the corresponding extension
  settings themselves. Changed firewall_init_filter_traffic() to follow
  these semantics.
------------------------------------------------------------
revno: 5301
committer: Rene Hummen 
branch nick: hipl
timestamp: Mon 2010-12-27 14:36:41 +0100
message:
  added K&R code style for eclipse
  
  This is a slightly modified version of the built-in K&R code style
  template of eclipse (e.g., indentation with spaces). Still, this style
  still requires further tweaking as eclipse sometimes produces output
  that is not conform with our code style.
------------------------------------------------------------
revno: 5300
committer: Rene Hummen 
branch nick: hipl
timestamp: Mon 2010-12-27 14:23:51 +0100
message:
  clarified source code documentation with doxygen in HACKING
  
  As pointed out by Samu, it was inclear whether to put doxygen
  comments in the c-source or the c-header file. Generally, doxygen
  comments belong into the c-source file.
------------------------------------------------------------
revno: 5299
committer: Rene Hummen 
branch nick: hipl
timestamp: Mon 2010-12-27 14:08:26 +0100
message:
  cosmetics: fixed K&R style and indentation
------------------------------------------------------------
revno: 5298
committer: Rene Hummen 
branch nick: hipl
timestamp: Mon 2010-12-27 14:06:49 +0100
message:
  re-added arpa/inet.h to includes
  
  arpa/inet.h is required by ntohl
------------------------------------------------------------
revno: 5297
committer: Artturi Karila 
branch nick: hipl
timestamp: Thu 2010-12-23 18:44:46 +0200
message:
  Fixed lifetime validity check on "hipconf add server"
------------------------------------------------------------
revno: 5296
committer: Artturi Karila 
branch nick: hipl
timestamp: Thu 2010-12-23 18:30:04 +0200
message:
  Firewall: still allow HIP traffic when ESP relay overrides -F flag
  
  Also only call the init functions if necessary.
------------------------------------------------------------
revno: 5295
committer: Artturi Karila 
branch nick: hipl
timestamp: Thu 2010-12-23 18:18:22 +0200
message:
  Initialize connection tracking when starting ESP relay
  
  Moved traffic filtering rules to a separate function so they can be added when
  starting the ESP relay if the -F flag was given at startup.
  
  Also moved ESP relay init/uninit functions down to avoid forward declarations.
------------------------------------------------------------
revno: 5294
committer: Miika Komu 
branch nick: trunk
timestamp: Wed 2010-12-22 09:46:16 +0200
message:
  Updated .emacs instructions for code indentation.
  
  Samu said the existing instructions did not work for him.
------------------------------------------------------------
revno: 5293
committer: Andrius Bentkus 
branch nick: hipl
timestamp: Sun 2010-12-19 17:33:08 +0100
message:
  Fix missing configuration header inclusion.
  
  Revision 4832, by some refered as the grand #include cleanup - part VIII, removed the inclusion of "config.h" in debug.h.
  debug.h defines the preprocessor CONFIG_HIP_DEBUG which is used in debug.h to implement different behaviour with #ifdef.
  
  The the absence of the config.h did not introduce any compilation errors, since the macro syntax was still valid (#ifdef CONFIG_HIP_DEBUG), but introduced an unwanted change in behaviour of the programm. Please pay attention next time if you remove "config.h" and make sure that the there are no macros in use defined in "config.h".
------------------------------------------------------------
revno: 5292
committer: David Martin 
branch nick: hipl
timestamp: Fri 2010-12-17 18:40:25 +0100
message:
  Stop hipfw from disabling IPv6 forwarding.
  
  Until now the firewall set /proc/sys/net/ipv6/conf/all/forwarding to 0 in firewall_init_extensions().
  I did test hipl with an all-IPv6 setup on three virtual machines. Traffic was routed via the middle machine. Running hipfw on the forwarding machine prohibited any traffic between the outer machines as IPv6 forwarding got disabled.
  As documentation said to remove it and no further specificiations for its need were given I simply removed it.
------------------------------------------------------------
revno: 5291
committer: Miika Komu 
branch nick: trunk
timestamp: Wed 2010-12-15 15:53:01 +0200
message:
  Updated INSTALL file
  
  Two developers (excluding me) stumbled to the /usr/local/etc/hip change, 
  so I decided to make an explicit note about this to the INSTALL file.
------------------------------------------------------------
revno: 5290
committer: Diego Biurrun 
branch nick: hipl
timestamp: Mon 2010-12-13 22:24:26 +0100
message:
  cosmetics: Fix another typo in the Doxygen comments.
------------------------------------------------------------
revno: 5289
committer: Diego Biurrun 
branch nick: hipl
timestamp: Mon 2010-12-13 22:15:07 +0100
message:
  cosmetics: Fix a typo, reformat a line; sync with the hipfw-performance branch.
------------------------------------------------------------
revno: 5288
committer: Diego Biurrun 
branch nick: hipl
timestamp: Mon 2010-12-13 22:12:34 +0100
message:
  cosmetics: Unindent some macros for consistency with the rest of the codebase.
------------------------------------------------------------
revno: 5287
committer: Diego Biurrun 
branch nick: hipl
timestamp: Mon 2010-12-13 21:46:38 +0100
message:
  Replace forward declaration for get_tuple_by_hits() by proper #include.
------------------------------------------------------------
revno: 5286
committer: Diego Biurrun 
branch nick: hipl
timestamp: Mon 2010-12-13 20:20:12 +0100
message:
  Properly mark list_length() and list_first() as static.
  
  The functions are not used outside of dlist.c and there is no point in
  having them declared in a header file.
------------------------------------------------------------
revno: 5285
committer: Diego Biurrun 
branch nick: hipl
timestamp: Mon 2010-12-13 20:18:20 +0100
message:
  cosmetics: Move list_first() closer to where it is being used.
------------------------------------------------------------
revno: 5284
committer: Diego Biurrun 
branch nick: hipl
timestamp: Mon 2010-12-13 20:12:18 +0100
message:
  Remove pointless cast of {input|output|forward}_rules to struct dlist *.
  
  The variables are of the type they are being cast to; the cast is useless.
------------------------------------------------------------
revno: 5283
committer: Diego Biurrun 
branch nick: hipl
timestamp: Mon 2010-12-13 20:09:27 +0100
message:
  Get rid of typedefs for struct dlist and struct slist.
  
  The typedef just obfuscates the real type and serves no useful purpose.
  If in doubt, typedefs should be avoided, so this one is removed.
------------------------------------------------------------
revno: 5282
committer: Diego Biurrun 
branch nick: hipl
timestamp: Mon 2010-12-13 19:47:14 +0100
message:
  whitespace cosmetics: Make some #endif comments look a bit less cramped.
------------------------------------------------------------
revno: 5281
committer: Diego Biurrun 
branch nick: hipl
timestamp: Mon 2010-12-13 19:41:43 +0100
message:
  Avoid pointless cast of the return value of read_rules.
  
  read_rules() already returns the type that its return value is being cast to.
------------------------------------------------------------
revno: 5280
committer: Diego Biurrun 
branch nick: hipl
timestamp: Mon 2010-12-13 19:39:00 +0100
message:
  Rename _DList/_SList structs to dlist/slist.
  
  Identifiers starting with _ and uppercase letters are reserved for the system.
  Besides, CamelCase is to be avoided in HIPL.
------------------------------------------------------------
revno: 5279
committer: Diego Biurrun 
branch nick: hipl
timestamp: Mon 2010-12-13 19:24:57 +0100
message:
  Remove unnecessary casts of the arguments of RSA_free/DSA_free.
------------------------------------------------------------
revno: 5278
committer: Diego Biurrun 
branch nick: hipl
timestamp: Mon 2010-12-13 19:23:30 +0100
message:
  cosmetics: Rename hipList/espList variables to hip_list/esp_list.
  
  CamelCase is against the HIPL coding style, so the new version is preferable.
------------------------------------------------------------
revno: 5277
committer: Diego Biurrun 
branch nick: hipl
timestamp: Mon 2010-12-13 19:21:47 +0100
message:
  cosmetics: Fix two small typos.
------------------------------------------------------------
revno: 5276
committer: Diego Biurrun 
branch nick: hipl
timestamp: Mon 2010-12-13 19:12:40 +0100
message:
  Get rid of senseless NULL pointer casts.
------------------------------------------------------------
revno: 5275
committer: Diego Biurrun 
branch nick: hipl
timestamp: Mon 2010-12-13 19:10:48 +0100
message:
  Avoid pointless void* casts of data member of the SList DList structure.
------------------------------------------------------------
revno: 5274
committer: Diego Biurrun 
branch nick: hipl
timestamp: Mon 2010-12-13 16:16:48 +0100
message:
  whitespace cosmetics: Remove tabs and trailing whitespace.
------------------------------------------------------------
revno: 5273
committer: Diego Biurrun 
branch nick: hipl
timestamp: Fri 2010-12-10 18:19:51 +0100
message:
  Remove one pointless variable indirection.
------------------------------------------------------------
revno: 5272
committer: Rene Hummen 
branch nick: hipl
timestamp: Fri 2010-12-10 17:35:07 +0100
message:
  revert revision 5255
  
  I committed a modification on how HITs were resolved locally. While my
  intentions were good, the changes were harming current resolving
  mechanisms. The changes should have been committed to a separate branch
  and discussed before merging with trunk.
  I'll give these changes some further thought and polish lookup in an own
  branch called locid-fixes.
------------------------------------------------------------
revno: 5271
committer: Rene Hummen 
branch nick: hipl
timestamp: Fri 2010-12-10 17:14:49 +0100
message:
  fixed hip_build_host_id_from_param parameter documentation
  
  the autobuilder was complained about 'param' not to be found
------------------------------------------------------------
revno: 5270
committer: Rene Hummen 
branch nick: hipl
timestamp: Fri 2010-12-10 10:15:11 +0100
message:
  fixed compilation errors in revision 5269
  
  removed ; and added missing ) as well as renamed missing instance of
  param
------------------------------------------------------------
revno: 5269
committer: Rene Hummen 
branch nick: hipl
timestamp: Fri 2010-12-10 09:50:38 +0100
message:
  addressed comments on revisions 5262 and 5263
  
  fixed long lines, renamed param to wire_host_id, substracted
  hip_common header.
  
  NOTE: I did not look into refactoring as suggested by Diego.
------------------------------------------------------------
revno: 5268
committer: Diego Biurrun 
branch nick: hipl
timestamp: Thu 2010-12-09 22:34:35 +0100
message:
  Remove recursive firewall_defines.h inclusion.
------------------------------------------------------------
revno: 5267
committer: Diego Biurrun 
branch nick: hipl
timestamp: Thu 2010-12-09 18:17:55 +0100
message:
  openwrt: Remove local dummy network device patch and all references to it.
  
  It was merged to the Backfire branch in the OpenWrt Subversion repo as r24388.
------------------------------------------------------------
revno: 5266
fixes bug(s): https://launchpad.net/bugs/645364
committer: Diego Biurrun 
branch nick: hipl
timestamp: Thu 2010-12-09 13:26:46 +0100
message:
  doc: Add OpenWrt section with current build instructions.
------------------------------------------------------------
revno: 5265
committer: Diego Biurrun 
branch nick: hipl
timestamp: Tue 2010-12-07 23:48:31 +0100
message:
  doc: Remove outdated OpenWrt section; will be updated shortly.
------------------------------------------------------------
revno: 5264
committer: Diego Biurrun 
branch nick: hipl
timestamp: Thu 2010-12-09 11:53:12 +0100
message:
  cosmetics: prettyprint some lines for better readability
------------------------------------------------------------
revno: 5263
committer: Henrik Ziegeldorf 
branch nick: hipl
timestamp: Wed 2010-12-08 19:40:04 +0100
message:
  Hooked in functions for compressing/decompressing host identites in every function that receives messages with host id parameter (i.e. I2, R1, R2 Hmac generation).
  
  This revision fixes bug 612029.
------------------------------------------------------------
revno: 5262
committer: Henrik Ziegeldorf 
branch nick: hipl
timestamp: Wed 2010-12-08 19:30:17 +0100
message:
  Added functions to convert between compressed (on the wire) format and uncompressed (internal) format of host identities.
  
  These two functions are needed to fix bug 612029. 
  Internally host identities are handled within a struct that reserves place for 4096 bit rsa keys and 64 byte hostnames.
  For transmission on the wire unused space should not be sent thus we need to compress the host identity before sending it as a message parameter on the wire.
  This is done by funciton hip_build_param_host_id.
  
  When receiving a message that contains a host_id parameter we need to decompress it to the internal format. This is done my function hip_build_host_id_from_param.
------------------------------------------------------------
revno: 5261
committer: Diego Biurrun 
branch nick: hipl
timestamp: Tue 2010-12-07 23:59:28 +0100
message:
  openwrt: Update HIPL download URL.
------------------------------------------------------------
revno: 5260
committer: Diego Biurrun 
branch nick: hipl
timestamp: Tue 2010-12-07 21:43:33 +0100
message:
  openwrt: Add patch required to build HIPL on the backfire OpenWrt release.
------------------------------------------------------------
revno: 5259
committer: Diego Biurrun 
branch nick: hipl
timestamp: Tue 2010-12-07 20:50:02 +0100
message:
  openwrt: Revert r5213 - removal of kmod-ipsec from list of hipd depends.
  
  The "error" this was supposed to fix was caused by a missing OpenWrt patch.
------------------------------------------------------------
revno: 5258
committer: Diego Biurrun 
branch nick: hipl
timestamp: Tue 2010-12-07 18:48:47 +0100
message:
  Get rid of unnecessary void* casts of the return value of hip_cast_sa_addr().
------------------------------------------------------------
revno: 5257
committer: Diego Biurrun 
branch nick: hipl
timestamp: Tue 2010-12-07 18:48:13 +0100
message:
  misc whitespace cosmetics; drop a set of unnecessary parentheses
------------------------------------------------------------
revno: 5256
committer: Miika Komu 
branch nick: trunk
timestamp: Tue 2010-12-07 23:32:02 +0200
message:
  Fixed some of my own mistakes in 5246.
  
  * Indentation
  * Hostname now correct
  * Home instead of tilde
------------------------------------------------------------
revno: 5255
committer: Rene Hummen 
branch nick: hipl
timestamp: Tue 2010-12-07 13:59:08 +0100
message:
  replace hit->ip mapping mechanism by system defaults
  
  Instead of parsing /etc/hosts ourselves, we now use getaddrinfo in order
  to retrieve the ip for a given hit. This enables standard DNS lookups,
  in case hip/hosts specifies a valid hostname for a hit. As a fallback,
  getaddrinfo will still parse and use information provided in /etc/hosts.
  
  Furthermore, this commit removes any manual lookups in /etc/hosts, as
  HIP-specific information should be maintained in hip/hosts.
------------------------------------------------------------
revno: 5254
committer: Diego Biurrun 
branch nick: hipl
timestamp: Tue 2010-12-07 00:51:01 +0100
message:
  Separate package lists in the Debian spec file by commas.
  
  For some weird reason the debbuild utility chokes on the spec file and
  concatenates package lists into one long string when using spaces as
  delimiters.  This would of course result in broken packages.
------------------------------------------------------------
revno: 5253
committer: Diego Biurrun 
branch nick: hipl
timestamp: Mon 2010-12-06 22:14:13 +0100
message:
  autobuilder: Add binary distribution package test.
------------------------------------------------------------
revno: 5252
committer: Diego Biurrun 
branch nick: hipl
timestamp: Mon 2010-12-06 21:57:51 +0100
message:
  Copy the tarball created by make dist instead of moving it around.
  
  (Re)moving the tarball has weird sideeffects in the autobuilder where
  some tests expect to find a dist tarball in the root of the source tree.
------------------------------------------------------------
revno: 5251
committer: Diego Biurrun 
branch nick: hipl
timestamp: Mon 2010-12-06 21:00:14 +0100
message:
  Remove NULL checks before htree_free/hchain_free; the functions survive NULL.
------------------------------------------------------------
revno: 5250
committer: Diego Biurrun 
branch nick: hipl
timestamp: Mon 2010-12-06 20:58:46 +0100
message:
  Remove an unnecessary NULL check before free() in example code.
------------------------------------------------------------
revno: 5249
committer: Diego Biurrun 
branch nick: hipl
timestamp: Mon 2010-12-06 20:57:47 +0100
message:
  Remove NULL checks before OpenSSL *_free() functions; they are NULL-tolerant.
------------------------------------------------------------
revno: 5248
committer: Diego Biurrun 
branch nick: hipl
timestamp: Mon 2010-12-06 20:41:51 +0100
message:
  Get rid of void* casts for {active|next}_hash_items members of hip_sa_entry_t.
------------------------------------------------------------
revno: 5247
committer: Diego Biurrun 
branch nick: hipl
timestamp: Mon 2010-12-06 19:11:30 +0100
message:
  Clarify comment about unit test target prerequisites.
------------------------------------------------------------
revno: 5246
committer: Miika Komu 
branch nick: trunk
timestamp: Mon 2010-12-06 17:28:59 +0200
message:
  Further improvements to the sync-all script.
  
  I fixed a bug in the sync-all script:
  
  ssh halko mkdir /home/hipl/.hipl.syncall.tmp.dir cd /home/hipl/.hipl.syncall.tmp.dir rm -rf trunk rm hipl.tar.gz wget http://hipl.hiit.fi/hipl/hipl.tar.gz '&&' tar xvzf hipl.tar.gz '&&' cd trunk '&&' autoreconf --install '&&' ./configure '&&' make bin syncrepo
  mkdir: invalid option -- 'r'
  
  Seems like it was missing semicolons. Decided to use && instead to check 
  for successful completion. Few other improvements:
  
  * I also decided to use $HOME instead of tilde in the script.
  * One of the hosts was mistyped.
------------------------------------------------------------
revno: 5245
committer: Diego Biurrun 
branch nick: hipl
timestamp: Mon 2010-12-06 14:06:33 +0100
message:
  OpenWrt: Drop redundant kmod-ip6tables package dependency.
  
  This is already covered through the ip6tables dependency, which in
  turn depends on kmod-ip6tables.
------------------------------------------------------------
revno: 5244
committer: Miika Komu 
branch nick: trunk
timestamp: Mon 2010-12-06 03:43:32 +0200
message:
  Fixed a bug in sync-all maintainer script.
  
  The temporary directory should be created.
------------------------------------------------------------
revno: 5243
committer: Miika Komu 
branch nick: trunk
timestamp: Thu 2010-12-02 16:51:18 +0200
message:
  Fixed a problem with sync-all maintainer script
  
  Fixed a problem reported by Diego: A successful ping was a precondition 
  for making the ssh connection. Now the "condition" is a successful echo 
  command, so the ssh connection is made no matter if the host is up or 
  not...
  
  I decided that the initial ping was unnecessary, so I removed it.
------------------------------------------------------------
revno: 5242
committer: Miika Komu 
branch nick: trunk
timestamp: Thu 2010-12-02 09:16:57 +0200
message:
  Removed an outdated comment.
  
  Removed an outdated comment from builder.c as noticed by Samu.
------------------------------------------------------------
revno: 5241
committer: Samuel Richter 
branch nick: hipl
timestamp: Wed 2010-12-01 17:03:25 +0100
message:
  add missing initscripts
------------------------------------------------------------
revno: 5240
committer: Samuel Richter 
branch nick: hipl
timestamp: Wed 2010-12-01 17:00:54 +0100
message:
  remove hardcoded revision number
------------------------------------------------------------
revno: 5239
committer: Miika Komu 
branch nick: trunk
timestamp: Wed 2010-12-01 17:32:25 +0200
message:
  Changed version number for packets for interprocess communications.
  
  The packet builder functionality is reused for both network and 
  internal-process communications. The packet version number separates 
  external and internal packets from each other. This is important also 
  because we allow longer packet lengths for internal packets.
  
  Internal packets were typed as HIPv2 packets and the value is now 
  reserved really for HIPv2. To avoid future compatibility issues with 
  HIPv2, I rolled the value for internal packets to 0x10.
------------------------------------------------------------
revno: 5238
committer: Miika Komu 
branch nick: trunk
timestamp: Wed 2010-12-01 00:03:10 +0200
message:
  Fixes to update-html-code script.
  
  The script was not functional anymore due to changes in building. Works again.
------------------------------------------------------------
revno: 5237
committer: Miika Komu 
branch nick: trunk
timestamp: Tue 2010-11-30 23:54:35 +0200
message:
  Fixed on sync-all maintainer script
  
  According to suggestion from Diego:
  - The ping is repeated, once for all hosts in succession, then for each
    host before connecting to it.  This seems pretty redundant to me.
  
  - A temporary directory is created in a world-writable location, /tmp,
    with a predictable name.  This is a security hole.  Does this need
    explanation or am I preaching to the choir?
  
  Removed also the unnecessary sudo.
------------------------------------------------------------
revno: 5236
committer: Miika Komu 
branch nick: trunk
timestamp: Tue 2010-11-30 23:40:39 +0200
message:
  Fixes on update-html-howto maintainer script.
  
  Suggestion from Diego to update-html-howto:
  Cannot work as it tries to run 'make' in the doc/ subdirectory, which
  is no longer supported since ages.  Is this script unused or just
  failing silently?  This should be fixed or removed.
------------------------------------------------------------
revno: 5235
committer: Miika Komu 
branch nick: trunk
timestamp: Tue 2010-11-30 23:15:50 +0200
message:
  Removed scptar
  
  Scptar tool was not used anywhere, so I removed it according Diego's 
  suggestion.
------------------------------------------------------------
revno: 5234
committer: Miika Komu 
branch nick: trunk
timestamp: Tue 2010-11-30 23:03:59 +0200
message:
  Reverted previous commit.
  
  Should read all of emails before applying any changes :)
------------------------------------------------------------
revno: 5233
committer: Miika Komu 
branch nick: trunk
timestamp: Tue 2010-11-30 23:01:59 +0200
message:
  Optimized bzr-update-hipl
  
  Bzr checkout should be faster with --lightweight according to Diego.
------------------------------------------------------------
revno: 5232
committer: Diego Biurrun 
branch nick: hipl
timestamp: Tue 2010-11-30 19:06:28 +0100
message:
  OpenWrt: Remove libconfig CPPFLAGS workaround.
  
  The OpenWrt developers have committed my patch to get rid of the braindead
  libconfig.h location which did not match the one used by libconfig proper.
  
  The workaround is unnecessary for both trunk and the backfire release, which
  share the package feed.  Get the updated package via 'scripts/feeds update'.
  
  see: https://dev.openwrt.org/ticket/8334
------------------------------------------------------------
revno: 5231
committer: Diego Biurrun 
branch nick: hipl
timestamp: Tue 2010-11-30 16:50:45 +0100
message:
  Use a more sensible variable name to refer to the trunk HIPL branch.
------------------------------------------------------------
revno: 5230
committer: Diego Biurrun 
branch nick: hipl
timestamp: Tue 2010-11-30 16:48:14 +0100
message:
  Use 'mkdir -p' instead of checking for the existence of a directory beforehand.
------------------------------------------------------------
revno: 5229
committer: Miika Komu 
branch nick: trunk
timestamp: Tue 2010-11-30 17:23:28 +0200
message:
  Updated bzr-update-hipl	maintainer script
  
  Diego suggested to few changes on the mailing list:
  
  * Creating the changelog in /tmp with a predictable name is a security
    hole.  Just create it in $TMP_DIR instead.
  * Just do this in one go: bzr checkout lp:hipl $BRANCH
------------------------------------------------------------
revno: 5228
committer: Diego Biurrun 
branch nick: hipl
timestamp: Tue 2010-11-30 16:18:04 +0100
message:
  misc cosmetics: K&R, whitespace, indentation, useless (), dead debug message
------------------------------------------------------------
revno: 5227
committer: Diego Biurrun 
branch nick: hipl
timestamp: Tue 2010-11-30 16:03:33 +0100
message:
  Add a short FIXME comment to an obscure commented-out block of disabled code.
------------------------------------------------------------
revno: 5226
committer: Diego Biurrun 
branch nick: hipl
timestamp: Tue 2010-11-30 15:59:04 +0100
message:
  autobuilder: Add a compilation target optimizing for size (-Os).
------------------------------------------------------------
revno: 5225
committer: Diego Biurrun 
branch nick: free
timestamp: Tue 2010-11-30 15:50:30 +0100
message:
  Remove unnecessary NULL checks before free() invocations on pointers.
  
  free() can handle NULL pointers just fine, it is even required by the standard
  and not just OK by accident.  Quoting from the POSIX spec:
  
    The free() function shall cause the space pointed to by ptr to be
    deallocated; that is, made available for further allocation. If ptr
    is a null pointer, no action shall occur.
  
  This time around only checks directly before free() invocations were changed
  and the diff was doublechecked by the able eyes of Stefan G?tz.
------------------------------------------------------------
revno: 5224
committer: Diego Biurrun 
branch nick: hipl
timestamp: Tue 2010-11-30 15:40:39 +0100
message:
  De-inline hip_lp_next and move it from the .h file to the .c file.
  
  The inlined function was causing trouble when compiling with -Os:
  firewall/port_bindings.c: In function ?hip_port_bindings_get?:
  firewall/line_parser.h:97: error: inlining failed in call to ?hip_lp_next?: optimizing for size and code size would grow
  firewall/port_bindings.c:352: error: called from here
  firewall/line_parser.h:97: error: inlining failed in call to ?hip_lp_next?: optimizing for size and code size would grow
  firewall/port_bindings.c:371: error: called from here
  
  Since we need to build with -Os at least for OpenWrt, deinlining this
  function appears to be the most sensible compromise.
------------------------------------------------------------
revno: 5223
committer: Diego Biurrun 
branch nick: hipl
timestamp: Tue 2010-11-30 13:50:51 +0100
message:
  Remove a non-crucial debug message that causes issues when compiling with -Os.
  
  hipd/input.c: In function ?hip_handle_r1?:
  ./lib/core/debug.h:418: error: inlining failed in call to ?hip_state_str?: optimizing for size and code size would grow
------------------------------------------------------------
revno: 5222
committer: Diego Biurrun 
branch nick: hipl
timestamp: Tue 2010-11-30 11:53:14 +0100
message:
  Remove unused HIP_IFCS macro; it is small and of doubtful utility.
------------------------------------------------------------
revno: 5221
committer: Diego Biurrun 
branch nick: hipl
timestamp: Tue 2010-11-30 11:48:49 +0100
message:
  Replace HIP_IFCS macro by simple if/else construct.
  
  A macro to implement a simple if/else condition as a pseudofunction is a
  very suspicious construct to begin with and in this case, it caused the
  following compilation failure when optimizing for size (-Os):
  
  modules/update/hipd/update.c: In function ?hip_check_update_freshness?:
  modules/update/hipd/update.c:152: error: inlining failed in call to ?hip_update_get_out_id?: optimizing for size and code size would grow
  modules/update/hipd/update.c:1040: error: called from here
  modules/update/hipd/update.c:152: error: inlining failed in call to ?hip_update_get_out_id?: optimizing for size and code size would grow
  modules/update/hipd/update.c:1070: error: called from here
  modules/update/hipd/update.c:152: error: inlining failed in call to ?hip_update_get_out_id?: optimizing for size and code size would grow
  modules/update/hipd/update.c:1072: error: called from here
------------------------------------------------------------
revno: 5220
committer: Diego Biurrun 
branch nick: hipl
timestamp: Tue 2010-11-30 11:47:41 +0100
message:
  Remove pointless forward declaration for static inline functions in headers.
------------------------------------------------------------
revno: 5219
committer: Diego Biurrun 
branch nick: hipl
timestamp: Tue 2010-11-30 11:35:59 +0100
message:
  vertical alignment cosmetics taken from the hipfw performance branch.
------------------------------------------------------------
revno: 5218
committer: Diego Biurrun 
branch nick: hipl
timestamp: Tue 2010-11-30 11:34:37 +0100
message:
  Doxygenize two struct member comments; taken from the hipfw-performance branch.
------------------------------------------------------------
revno: 5217
committer: Diego Biurrun 
branch nick: hipl
timestamp: Tue 2010-11-30 11:33:47 +0100
message:
  Add two @see Doxygen references from the hipfw-performance branch.
------------------------------------------------------------
revno: 5216
committer: Diego Biurrun 
branch nick: hipl
timestamp: Tue 2010-11-30 10:53:48 +0100
message:
  Reflect the renamed OpenWrt packaging directory in the autobuilder.
------------------------------------------------------------
revno: 5215
committer: Diego Biurrun 
branch nick: hipl
timestamp: Tue 2010-11-30 10:48:11 +0100
message:
  cosmetics: Place goto labels in column 0.
------------------------------------------------------------
revno: 5214
committer: Diego Biurrun 
branch nick: hipl
timestamp: Mon 2010-11-29 20:17:08 +0100
message:
  Mark hipl-common OpenWrt package as BUILDONLY.
  
  hipl-common is just an internal dependency and need not show up
  in 'make menuconfig'.
------------------------------------------------------------
revno: 5213
committer: Diego Biurrun 
branch nick: hipl
timestamp: Mon 2010-11-29 20:08:08 +0100
message:
  OpenWrt: Remove kmod-ipsec from list of hipd depends.
  
  Somehow hipd does not show up in 'make menuconfig', presumably due to a
  missing dependency, when kmod-ipsec is listed in hipd's dependencies.
  Since both kmod-ipsec4 and kmod-ipsec6 remain in hipd's dependency list
  and both depend on kmod-ipsed themselves this should cause no harm.
------------------------------------------------------------
revno: 5212
committer: Diego Biurrun 
branch nick: hipl
timestamp: Mon 2010-11-29 19:47:55 +0100
message:
  OpenWrt: Remove commented-out modules from hipfw DEPENDS list.
------------------------------------------------------------
revno: 5211
committer: Diego Biurrun 
branch nick: hipl
timestamp: Mon 2010-11-29 19:38:24 +0100
message:
  hipfw, not hipd, depends on libconfig; reflect this in the OpenWrt Makefile.
------------------------------------------------------------
revno: 5210
committer: Diego Biurrun 
branch nick: hipl
timestamp: Mon 2010-11-29 19:32:32 +0100
message:
  Drop '+' from hipl-common entry in hipd/hipfw dependency listing.
  
  The leading '+' is used to denote external package dependencies which
  are not defined in the same Makefile.
------------------------------------------------------------
revno: 5209
committer: Diego Biurrun 
branch nick: hipl
timestamp: Mon 2010-11-29 19:29:51 +0100
message:
  Rename "package" OpenWrt infrastructure directory to "hipl".
  
  In the OpenWrt source tree, packaging directories bear the name of the
  program they contain, so this makes more sense and saves one renaming.
------------------------------------------------------------
revno: 5208
committer: Rene Hummen 
branch nick: hipl
timestamp: Mon 2010-11-29 18:19:59 +0100
message:
  major re-work of mobility handling
  
  I have split up functions into smaller blocks and regrouped
  functionality to better reflect handling operations in case of mobility.
  This also required rewriting parts of the existing code.
  
  Note that this commit does only focus on receiving updates, but does not
  make changes to outbound packets. It neither changes locator handling.
  These will be worked on in subsequent commits.
------------------------------------------------------------
revno: 5207
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2010-11-29 17:52:27 +0100
message:
  Disable -O3 test in the autobuilder until the issues are fixed.
------------------------------------------------------------
revno: 5206
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2010-11-29 17:16:47 +0100
message:
  Drop pointless (and harmful) typedef from pseudo_v6 struct.
------------------------------------------------------------
revno: 5205
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2010-11-29 17:13:31 +0100
message:
  cosmetics: Drop some useless parentheses, vertically align one = sign.
------------------------------------------------------------
revno: 5204
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2010-11-29 17:07:54 +0100
message:
  whitespace and line length cosmetics
------------------------------------------------------------
revno: 5203
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2010-11-29 13:09:22 +0100
message:
  Remove stats.pl and friends; they are unused.
------------------------------------------------------------
revno: 5202
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2010-11-29 12:58:57 +0100
message:
  Make sure that the executables created by configure have executable permission.
  
  Apparently autotools does not figure that out on its own, you have to invoke
  the chmod manually for each file.  Notice that I tried avoiding multiple
  AC_CONFIG_FILES and chmod invocations, but autotools balked and barfed and
  was generally loathsome, so don't waste your time trying to improve this.
------------------------------------------------------------
revno: 5201
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2010-11-29 11:21:43 +0100
message:
  cosmetics: Skip unnecessary empty setting of VERSION variable.
------------------------------------------------------------
revno: 5200
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2010-11-29 11:20:45 +0100
message:
  cosmetics: whitespace prettyprinting
------------------------------------------------------------
revno: 5199
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2010-11-29 11:14:28 +0100
message:
  Limit the number of processes spawned during package building to 32.
  
  Running an unlimited 'make -j' triggers the OOM killer on a virtual machine
  with 512MB of RAM.  Limiting the number of spawned processes to 32 avoids
  this while still running in a highly parallel fashion.
------------------------------------------------------------
revno: 5198
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2010-11-29 10:26:01 +0100
message:
  Add missing copyright/license statement to nsupdate.pl.
------------------------------------------------------------
revno: 5197
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2010-11-29 10:21:08 +0100
message:
  Remove unnecessary Socket6 and IO::Socket::INET6 from list of Per dependencies.
------------------------------------------------------------
revno: 5196
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2010-11-29 10:03:16 +0100
message:
  Add missing / to $(addprefix ) invocation in dist-hook target.
  
  This fixes the non-working removal of configure-generated files from
  the doc/ subdirectory of the dist tarball.
------------------------------------------------------------
revno: 5195
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2010-11-29 10:00:51 +0100
message:
  cosmetics: Remove pointless (and sometimes misleading) #include comments.
------------------------------------------------------------
revno: 5194
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2010-11-29 09:58:13 +0100
message:
  Add arpa/inet.h #include for htonl/htons/ntohl/ntohs.
------------------------------------------------------------
revno: 5193
committer: Miika Komu 
branch nick: trunk
timestamp: Sun 2010-11-28 23:07:00 +0200
message:
  Updated sync-all script.
  
  Upgraded OS of the old virtual machines and this is now reflected in the 
  sync-all script which automatizes binary building at hipl.hiit.fi.
------------------------------------------------------------
revno: 5192
committer: Miika Komu 
branch nick: trunk
timestamp: Fri 2010-11-26 23:27:47 +0200
message:
  Updated maintainer script
  
  Rationalized naming convention of variables. Corrected bzr repository 
  address when fetching new it for the first time and fixed a missing
  directory change.
------------------------------------------------------------
revno: 5191
committer: Miika Komu 
branch nick: trunk
timestamp: Fri 2010-11-26 22:14:54 +0200
message:
  Updated the maintainer script for publishing the manual in the web.
  
  The manual publishes at hipl.hiit.fi basically assumes people are using 
  the binaries, so it makes sense to claim /etc/hip instead of 
  /usr/local/etc/hip. This revision enforces /etc/hip in the published 
  manual.
------------------------------------------------------------
revno: 5190
committer: Miika Komu 
branch nick: trunk
timestamp: Fri 2010-11-26 21:54:28 +0200
message:
  Updated manual on DNS proxy.
  
  Added some details on DNS proxy to the manual and improved the wording.
------------------------------------------------------------
revno: 5189
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-11-26 18:24:31 +0100
message:
  Remove all files that configure generates from the distribution tarball.
------------------------------------------------------------
revno: 5188
committer: Rene Hummen 
branch nick: hipl
timestamp: Fri 2010-11-26 18:11:04 +0100
message:
  updated debian packaging to be conform with ubuntu ppa
  
  tested and works
------------------------------------------------------------
revno: 5187
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-11-26 14:52:57 +0100
message:
  Mark hipl-daemon package as obsoleting hipl-minimal.
  
  Now no dangling hipl-minimal package is left behind on package upgrade.
------------------------------------------------------------
revno: 5186
committer: Diego Biurrun 
branch nick: packaging
timestamp: Tue 2010-11-23 21:39:50 +0100
message:
  Synchronize cosmetical differences between the deb and rpm spec files.
------------------------------------------------------------
revno: 5185
committer: Diego Biurrun 
branch nick: packaging
timestamp: Tue 2010-11-23 21:02:20 +0100
message:
  Move the pax build-time dependency for debbuild to the .deb specfile.
  
  This is a more suitable place and generates a sensible error message
  if pax is not installed.
------------------------------------------------------------
revno: 5184
committer: Diego Biurrun 
branch nick: packaging
timestamp: Tue 2010-11-23 21:33:51 +0100
message:
  Do not install the COPYING file in the hipl-doc .deb package.
  
  This is not done in the hipl-doc RPM package.
------------------------------------------------------------
revno: 5183
committer: Diego Biurrun 
branch nick: packaging
timestamp: Tue 2010-11-23 21:06:21 +0100
message:
  Only the firewall depends on libconfig, so move the dependency to that package.
------------------------------------------------------------
revno: 5182
committer: Diego Biurrun 
branch nick: trunk
timestamp: Tue 2010-11-23 20:48:35 +0100
message:
  Clean up build and runtime dependency descriptions in INSTALL and spec files.
  
  HIPL does not depend on libcap or on a C++ compiler.
  Doxygen is not necessary to build Debian packages, but dpkg-dev is.
  Add libconfig and libcheck to list of (optional) build dependencies in INSTALL.
------------------------------------------------------------
revno: 5181
committer: Diego Biurrun 
branch nick: trunk
timestamp: Tue 2010-11-23 20:43:41 +0100
message:
  Do not manually install Python support files in the spec files.
  
  'make install' already takes care of this, the work is redundant.
------------------------------------------------------------
revno: 5180
committer: Diego Biurrun 
branch nick: trunk
timestamp: Tue 2010-11-23 20:40:59 +0100
message:
  Install Python libraries for hipdnsproxy/hipdnskeyparse into subdirectories.
  
  This is cleaner as it clutters the system directories less and avoids name
  clashes; some of our internal Python libs have very generic names.
------------------------------------------------------------
revno: 5179
committer: Diego Biurrun 
branch nick: trunk
timestamp: Tue 2010-11-23 20:28:50 +0100
message:
  Remove hipl-lib package.
  
  It no longer serves a useful purpose now that we build statically by default.
------------------------------------------------------------
revno: 5178
committer: Diego Biurrun 
branch nick: packaging2
timestamp: Tue 2010-11-16 14:50:25 +0100
message:
  cosmetics: misc comment cleanups, whitespace shell syntax changes
------------------------------------------------------------
revno: 5177
committer: Diego Biurrun 
branch nick: packaging2
timestamp: Tue 2010-11-16 14:44:09 +0100
message:
  Improve wording and grammar in RPM description field.
------------------------------------------------------------
revno: 5176
committer: Diego Biurrun 
branch nick: packaging
timestamp: Fri 2010-11-19 23:19:38 +0100
message:
  Install stripped binaries on OpenWrt.
  
  We already do this on other platforms and it makes even more sense for
  embedded platforms which are usually the targets for OpenWrt.
------------------------------------------------------------
revno: 5175
committer: Diego Biurrun 
branch nick: packaging
timestamp: Fri 2010-11-19 23:15:36 +0100
message:
  Do not build shared libraries by default on OpenWrt.
  
  This is the default for all other platforms and the libraries are not so
  big that it is worth the complication.
------------------------------------------------------------
revno: 5174
committer: Diego Biurrun 
branch nick: packaging
timestamp: Tue 2010-11-23 17:45:06 +0100
message:
  Add Python libraries to the dnsproxy Debian package.
  
  The hipdnsproxy and hipdnskeyparse binaries were installed without the
  required libraries, rendering the binaries non-functional.
------------------------------------------------------------
revno: 5173 [merge]
committer: Rene Hummen 
branch nick: hipl
timestamp: Tue 2010-11-23 15:50:25 +0100
message:
  merged lp:~hipl-core/hipl/mobility-fixes revision 5183
------------------------------------------------------------
revno: 5172
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2010-11-22 19:30:04 +0100
message:
  Remove some misplaced @file Doxygen commands from license boilerplates.
------------------------------------------------------------
revno: 5171
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2010-11-22 19:21:46 +0100
message:
  cosmetics: Add some empty lines to separate system and local #includes.
------------------------------------------------------------
revno: 5170
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2010-11-22 18:28:01 +0100
message:
  Create check_firewall and check_lib_core binaries in the test subdirectory.
  
  All other test binaries reside there and it's better not to clutter the root.
------------------------------------------------------------
revno: 5169
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-11-19 23:31:19 +0100
message:
  Use pythondir instead of pyexecdir automake variable.
  
  In practice both variables point to the same location, but the former
  should be slightly more correct than the latter.
------------------------------------------------------------
revno: 5168
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-11-19 23:13:31 +0100
message:
  cosmetics: Use line breaks in AC_CONFIG_FILES list for better readability.
------------------------------------------------------------
revno: 5167
committer: Andrius Bentkus 
branch nick: trunk
timestamp: Fri 2010-11-19 17:10:03 +0100
message:
  Use filename as inclusion guard constant.
------------------------------------------------------------
revno: 5166
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-11-19 15:43:35 +0100
message:
  The hipl-daemon deb package should supersede the hipl-tools deb package.
------------------------------------------------------------
revno: 5165
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-11-19 15:32:22 +0100
message:
  whitespace cosmetics: indentation and K&R style changes
------------------------------------------------------------
revno: 5164
committer: Miika Komu 
branch nick: trunk
timestamp: Wed 2010-11-17 06:57:15 +0200
message:
  Updated doc/HACKING code example on freeing memory.
  
  According to revision 5156, NULL checks for free() are optional.
------------------------------------------------------------
revno: 5163
committer: Diego Biurrun 
branch nick: trunk
timestamp: Tue 2010-11-16 15:38:02 +0100
message:
  Give VCS-neutral names to C variables containing Bazaar metadata.
  
  Some developers prefer to work with git as a VCS client, this change reflects
  that fact.  Furthermore, should HIPL change VCS systems one day, then there
  will be one less adjustment to make.
------------------------------------------------------------
revno: 5162
author: Stefan G?tz 
committer: Diego Biurrun 
branch nick: fw-cache-port-cleanup
timestamp: Mon 2010-11-15 22:37:09 +0100
message:
  Initialize variable to NULL upon declaration to avoid compiler warning/error about unitialized access.
------------------------------------------------------------
revno: 5161
author: Stefan G?tz 
committer: Diego Biurrun 
branch nick: fw-cache-port-cleanup
timestamp: Mon 2010-11-15 22:31:26 +0100
message:
  Removed _inline header files and moved the inline functions into their regular counterparts.
  This makes 'make checkheaders' succeed again.
------------------------------------------------------------
revno: 5160
author: Stefan G?tz 
committer: Diego Biurrun 
branch nick: fw-cache-port-cleanup
timestamp: Mon 2010-11-15 22:21:47 +0100
message:
  Fixed missing function documentation.
------------------------------------------------------------
revno: 5159
committer: Diego Biurrun 
branch nick: packaging2
timestamp: Tue 2010-11-16 14:40:30 +0100
message:
  Remove duplicate xmlto entry from BuildRequires.
------------------------------------------------------------
revno: 5158
committer: Diego Biurrun 
branch nick: packaging2
timestamp: Tue 2010-11-16 14:18:03 +0100
message:
  Remove 'minimal' RPM/DEB package.
  
  The package just depended on the daemon package and thus served no purpose.
------------------------------------------------------------
revno: 5157
committer: Diego Biurrun 
branch nick: packaging2
timestamp: Tue 2010-11-16 13:50:47 +0100
message:
  Merge hipl-tools package into hipl-daemon package.
  
  The contents of the hipl-tools package are only useful in connection with
  hipd.  Furthermore, the current aim is to reduce the number of packages,
  so it makes sense to just add the tools to the daemon package.
------------------------------------------------------------
revno: 5156
committer: Diego Biurrun 
branch nick: trunk
timestamp: Tue 2010-11-16 11:41:03 +0100
message:
  Move CentOS CPPFLAGS hack to a more suitable place.
  
  It's not good to clutter the specfile with platform-specific workarounds.
  Instead, keep the workarounds in the script that controls building the
  packages for specific platforms.
------------------------------------------------------------
revno: 5155
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2010-11-15 14:39:24 +0100
message:
  Remove pointless void* casts of memcpy/memcmp arguments.
  
  memcpy/memcmp take (const) void* arguments, but void* is compatible with
  any pointer type in C, so there is no need to cast the arguments.
------------------------------------------------------------
revno: 5154
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2010-11-15 14:38:47 +0100
message:
  Remove some pointless void* casts.
  
  void* is compatible with any pointer type.
------------------------------------------------------------
revno: 5153
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2010-11-15 14:37:13 +0100
message:
  cosmetics: Fix packte vs. packet typo.
------------------------------------------------------------
revno: 5152
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2010-11-15 13:40:48 +0100
message:
  cosmetics: Fix some indentation mishaps.
------------------------------------------------------------
revno: 5151 [merge]
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-11-12 18:49:42 +0100
message:
  Merge firewall cache port cleanup branch from Stefan G?tz; minor fixes from me.
------------------------------------------------------------
revno: 5150
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-11-12 17:42:54 +0100
message:
  Move modularization source files into lib/core.
  
  This is the only suitable place for them now that there is no separate
  library for the modularization feature.
------------------------------------------------------------
revno: 5149
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-11-12 17:31:19 +0100
message:
  Merge modularization library into libhipcore.
  
  The modularization feature is not optional, so it makes no sense to place
  it in a separate library.
------------------------------------------------------------
revno: 5148
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-11-12 17:25:40 +0100
message:
  Add standard license boilerplate to build system files.
------------------------------------------------------------
revno: 5147
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-11-12 16:50:17 +0100
message:
  Remove completely unsused and near-empty --enable-demo configure option.
------------------------------------------------------------
revno: 5146
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-11-12 16:49:05 +0100
message:
  cosmetics: Fix demon --> daemon typo.
------------------------------------------------------------
revno: 5145
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-11-12 16:47:12 +0100
message:
  Quote paths in process_modules.py invocation; they might contain spaces.
------------------------------------------------------------
revno: 5144
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-11-12 16:41:41 +0100
message:
  cosmetics: Move the nomodules option to the configure options section.
------------------------------------------------------------
revno: 5143
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-11-12 16:39:06 +0100
message:
  cosmetics: Fix a bunch of typos, add some more whitespace for readability.
------------------------------------------------------------
revno: 5142
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-11-12 16:15:18 +0100
message:
  Drop unnecessary trailing commas from autoconf macros.
  
  It is possible to pass less than the full number of arguments to autoconf
  macros. In this case, defaults will be used. Leaving the left out arguments
  empty achieves the same thing. Since we just leave out unused arguments
  everywhere else, drop the trailing commas from a few macro invocations.
------------------------------------------------------------
revno: 5141
committer: Miika Komu 
branch nick: trunk
timestamp: Wed 2010-11-10 10:25:44 +0200
message:
  Updated information on imported code in COPYING.
  
  Pydns is not GPL as noted by Stefan G?tz.
------------------------------------------------------------
revno: 5140
committer: Miika Komu 
branch nick: trunk
timestamp: Tue 2010-11-09 11:07:47 +0200
message:
  Added instructions on how to configure a debug build.
  
  See the related discussion in:
  
  https://bugs.launchpad.net/hipl/+bug/626719
------------------------------------------------------------
revno: 5139
committer: Miika Komu 
branch nick: trunk
timestamp: Tue 2010-11-09 10:58:14 +0200
message:
  Removed some outdated comments for HACKING.
  
  No need to debug kernel anymore.
------------------------------------------------------------
revno: 5138
committer: Artturi Karila 
branch nick: trunk
timestamp: Mon 2010-11-08 16:06:09 +0200
message:
  Fixed issue with dnsproxy treating LSIs as locators
  
  LSIs from hosts files were being cached as IPv4 addresses and mapped to HITs as
  such. Added a check to prevent this.
------------------------------------------------------------
revno: 5137
committer: Rene Hummen 
branch nick: trunk
timestamp: Mon 2010-11-08 14:34:20 +0100
message:
  removed mailer script
  
  it is unused and seems to be not required in the future, as hipl-dev
  serves email-notifications.
------------------------------------------------------------
revno: 5136 [merge]
committer: Miika Komu 
branch nick: trunk
timestamp: Sun 2010-11-07 03:49:38 +0200
message:
  Fixed problems with "hipconf add map"
  
  hipconf add map failed to work when LSI was given.
------------------------------------------------------------
revno: 5135 [merge]
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-11-05 16:32:23 +0100
message:
  autobuilder: Run unit tests; compile w/o and w/ full optimizations. 
------------------------------------------------------------
revno: 5134
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-11-05 15:17:19 +0100
message:
  Install stripped binaries into RPM/DEB packages.
  
  For our use cases, people requiring debug symbols will likely work with the
  sources directly and compile their own HIPL binaries. So it makes more sense
  to save installation footprint and keep our packages small by default.
------------------------------------------------------------
revno: 5133 [merge]
committer: Rene Hummen 
branch nick: trunk
timestamp: Tue 2010-11-02 11:18:52 +0100
message:
  merged lp:~stefan.goetz/hipl/dh-key-generation-fixes revision 5133
------------------------------------------------------------
revno: 5132
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-10-29 14:51:08 +0200
message:
  Templatize all non-C files that contain hardcoded references to config files.
  
  Now that the configuration file path is no longer hardcoded to /etc/hip,
  references in throughout the code need to be adapted. C code extracts the
  right value from config.h, for other files configure needs to substitute
  the right values into a template file.
------------------------------------------------------------
revno: 5131
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-10-29 14:07:19 +0200
message:
  Switch the Bazaar metadata dependencies of version.h to a more appropriate file.
  
  .bzr/branch/last-revision is not available in lightweight checkouts, so that
  there version.h does not get updated after Bazaar commits or updates.
  Meanwhile .bzr/checkout/dirstate is present in lightweight checkouts as well
  as full checkouts and changes with every Bazaar commit/update.
------------------------------------------------------------
revno: 5130
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-10-29 14:05:42 +0200
message:
  Reword awkward comment about reenabling logging.
------------------------------------------------------------
revno: 5129
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-10-29 14:04:21 +0200
message:
  cosmetics: Add spaces around pipes for better readability.
------------------------------------------------------------
revno: 5128
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-10-29 13:42:59 +0200
message:
  Remove two previously overlooked references to Bamboo, which was removed.
------------------------------------------------------------
revno: 5127
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-10-29 13:37:09 +0200
message:
  Remove unused variable.
------------------------------------------------------------
revno: 5126
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-10-29 13:31:40 +0200
message:
  Default sysconfdir to /etc, which is expected of OpenWrt packages.
------------------------------------------------------------
revno: 5125
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-10-29 13:30:05 +0200
message:
  whitespace cleanup: remove tabs and trailing whitespace
------------------------------------------------------------
revno: 5124
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-10-29 12:52:36 +0200
message:
  Rename PACKAGING_DIR variable to SRCDIR_PACKAGING.
  The former is easily confused with other variables.
------------------------------------------------------------
revno: 5123
committer: Diego Biurrun 
branch nick: trunk
timestamp: Wed 2010-10-27 13:27:48 +0200
message:
  Add some missing #includes for system headers.
------------------------------------------------------------
revno: 5122
committer: Diego Biurrun 
branch nick: hipl
timestamp: Wed 2010-10-27 13:26:17 +0200
message:
  Employ slightly more correct OpenWrt make target invocation syntax.
------------------------------------------------------------
revno: 5121
committer: Diego Biurrun 
branch nick: trunk
timestamp: Wed 2010-10-27 13:17:58 +0200
message:
  Run 'make -j' without limiting the number of created processes.
  
  Tests have shown this to perform as well as make invocations with a limited
  number of parallel processes. Not limiting the number has the benefit of
  never choosing too few parallel processes.
------------------------------------------------------------
revno: 5120
committer: Diego Biurrun 
branch nick: trunk
timestamp: Wed 2010-10-27 13:15:24 +0200
message:
  All binary package targets depend on version.h.
------------------------------------------------------------
revno: 5119
committer: Diego Biurrun 
branch nick: trunk
timestamp: Wed 2010-10-27 13:11:20 +0200
message:
  Avoid "index" as variable name, use "idx" instead.
  
  If BSD functions are exposed in system headers, the index() function is
  exposed and can get shadowed by similarly named variables.
------------------------------------------------------------
revno: 5118
committer: Diego Biurrun 
branch nick: trunk
timestamp: Wed 2010-10-27 12:55:36 +0200
message:
  Use symbolic names for Debian-based, numeric names for RedHat-based distros.
  This is the expected convention for each distro family and was mistakenly
  changed during one of the last commits.
------------------------------------------------------------
revno: 5117
committer: Miika Komu 
branch nick: trunk
timestamp: Tue 2010-10-26 23:30:16 +0300
message:
  Updated spec files.
  
  Dropped an unnecessary constraint from parallel building in deb and rpm 
  binary packaging as discussed by Stefan G?tz and Diego Biurrun.
------------------------------------------------------------
revno: 5116
committer: Miika Komu 
branch nick: trunk
timestamp: Tue 2010-10-26 21:52:56 +0300
message:
  Removed HIP proxy from the manual.
  
  HIP proxy is not supported anymore, so I removed the related 
  documentation from the manual.
------------------------------------------------------------
revno: 5115
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2010-10-25 21:27:37 +0200
message:
  Skip installing files that 'make install' already installed.
------------------------------------------------------------
revno: 5114
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2010-10-25 21:11:46 +0200
message:
  cosmetics: reorder install lines
------------------------------------------------------------
revno: 5113
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2010-10-25 21:09:38 +0200
message:
  Do not (re)create directories that 'make install' already created.
------------------------------------------------------------
revno: 5112
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2010-10-25 20:18:50 +0200
message:
  Synchronize some cosmetic differences between RPM and DEB spec files.
------------------------------------------------------------
revno: 5111
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2010-10-25 20:13:18 +0200
message:
  Add missing HOWTO pictures to binary DEB/RPM packages.
------------------------------------------------------------
revno: 5110
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2010-10-25 19:27:44 +0200
message:
  Expose the syncrepo_deb and syncrepo_rpm packaging commands in the Makefile.
------------------------------------------------------------
revno: 5109
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2010-10-25 19:13:10 +0200
message:
  Check for the availability of pax at the beginning of the script.
  This avoids running expensive compiles before erroring out anyway.
------------------------------------------------------------
revno: 5108
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2010-10-25 19:10:02 +0200
message:
  Move the decision which commands to run for which distro to a single place.
  
  Setting variables with command defaults by distro allows dropping this
  decision from the argument parsing code. This is simpler since all distro
  setting are now done in one and only one place.
------------------------------------------------------------
revno: 5107
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2010-10-25 18:30:41 +0200
message:
  Explicitly set target architecture when building RPM packages.
  
  rpmbuild places RPMs in subdirectories by architecture. Unfortunately the
  name of this directory varies slightly by distribution. While on CentOS 5.5
  "i386" is used, for Fedora Core 11 it is "i586". Since createrepo looked for
  RPMs only in "i386", index creation failed for Fedora Core 11.
  
  Passing the desired architecture name explicitly on the command line solves
  the problem; index files get created as expected.
------------------------------------------------------------
revno: 5106
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2010-10-25 18:16:37 +0200
message:
  Remove directory creation hacks; they are no longer necessary.
  
  This has been tested to work on CentOS 5.5 and Fedora Core 11.
------------------------------------------------------------
revno: 5105
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2010-10-25 18:09:03 +0200
message:
  Create PKG_DIR before createrepo uses it; otherwise the command fails.
------------------------------------------------------------
revno: 5104
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2010-10-25 17:41:58 +0200
message:
  Remove unnecessary RPM metadata directory creation command.
  The createrepo command does the mkdir on its own.
------------------------------------------------------------
revno: 5103
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2010-10-25 17:39:43 +0200
message:
  Create RPM repo metadata in the directory where the RPMs are stored.
------------------------------------------------------------
revno: 5102
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2010-10-25 17:14:27 +0200
message:
  Set _topdir macro to override standard RPM build path.
  
  RPMs get built in /usr/src/RPM by default or alternatively in whatever
  place _topdir specifies. Setting this variable allows packages to be
  created in the same place that all other parts of HIPL get built.
------------------------------------------------------------
revno: 5101
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2010-10-25 17:13:02 +0200
message:
  cosmetics: Give more suitable names to some variables.
------------------------------------------------------------
revno: 5100
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2010-10-25 16:07:33 +0200
message:
  Add support for out-of-source builds.
------------------------------------------------------------
revno: 5099
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2010-10-25 11:53:33 +0200
message:
  Get rid of single-use TARBALL variable.
------------------------------------------------------------
revno: 5098
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2010-10-25 11:39:03 +0200
message:
  Drop setting PYTHON environment variables for create-package.sh.
------------------------------------------------------------
revno: 5097
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2010-10-25 11:29:29 +0200
message:
  Remove increl make target.
  
  It no longer exists as a function in create_package.sh, so it's pointless.
------------------------------------------------------------
revno: 5096
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2010-10-25 11:16:45 +0200
message:
  Remove binary package build directories on 'make clean'.
------------------------------------------------------------
revno: 5095 [merge]
committer: Rene Hummen 
branch nick: trunk
timestamp: Mon 2010-10-25 09:45:23 +0200
message:
  merged lp:~stefan.goetz/hipl/unittests revision 5012
------------------------------------------------------------
revno: 5094
committer: Rene Hummen 
branch nick: trunk
timestamp: Sun 2010-10-24 22:59:36 +0200
message:
  disabled auto-building in scratchbox
  
  the scratchbox environment is currently broken due to changes to our
  infrastructure and needs to be fixed. once this has been done, we
  can re-enable the auto-builder for scratchbox again.
------------------------------------------------------------
revno: 5093
committer: Miika Komu 
branch nick: trunk
timestamp: Sun 2010-10-24 22:32:18 +0300
message:
  Reconfigured maintainer script.
  
  The active configuration of virtual hosts for building binary packages 
  changed.
------------------------------------------------------------
revno: 5092
committer: Miika Komu 
branch nick: trunk
timestamp: Sun 2010-10-24 22:24:15 +0300
message:
  Updated HIPL dependencies on Ubuntu.
  
  Some missing packages for building the binary packages on Ubuntu.
------------------------------------------------------------
revno: 5091 [merge]
committer: Rene Hummen 
branch nick: trunk
timestamp: Sun 2010-10-24 19:46:20 +0200
message:
  merged lp:~stefan.goetz/hipl/lib-core-fixes revision 5007
------------------------------------------------------------
revno: 5090
committer: Diego Biurrun 
branch nick: trunk
timestamp: Sat 2010-10-23 18:14:05 +0200
message:
  Simplify .deb packages index file creation.
  
  Instead of changing directories back and forth and invoking sed in
  between, directly adjust paths with sed as required.
------------------------------------------------------------
revno: 5089
committer: Diego Biurrun 
branch nick: trunk
timestamp: Sat 2010-10-23 18:06:45 +0200
message:
  Eliminate duplicate "ubuntu" path component in Debian repository path.
------------------------------------------------------------
revno: 5088
committer: Diego Biurrun 
branch nick: trunk
timestamp: Sat 2010-10-23 17:56:09 +0200
message:
  The package index file should be created in the build directory.
------------------------------------------------------------
revno: 5087
committer: Diego Biurrun 
branch nick: trunk
timestamp: Sat 2010-10-23 17:40:42 +0200
message:
  cosmetics: Remove commented-out command variants.
------------------------------------------------------------
revno: 5086
committer: Diego Biurrun 
branch nick: trunk
timestamp: Sat 2010-10-23 17:35:41 +0200
message:
  Simplify sed substitution expressions by using delimiters different from '/'.
  
  sed understands more than just '/' as substitution expression delimiter.
  Especially for path substitutions it makes sense to use another one since
  this avoids ugly and unreadable escaping of / in paths.
------------------------------------------------------------
revno: 5085
committer: Diego Biurrun 
branch nick: trunk
timestamp: Sat 2010-10-23 17:24:50 +0200
message:
  Move the PKG_WEB_DIR intermediate variable to the only place it is used.
------------------------------------------------------------
revno: 5084
committer: Diego Biurrun 
branch nick: trunk
timestamp: Sat 2010-10-23 17:04:29 +0200
message:
  Improve pax availability check.
  
  Just checking for /usr/bin/pax misses many possible pax instances.
------------------------------------------------------------
revno: 5083
committer: Diego Biurrun 
branch nick: trunk
timestamp: Sat 2010-10-23 16:58:16 +0200
message:
  whitespace cosmetics
------------------------------------------------------------
revno: 5082
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-10-22 19:19:18 +0200
message:
  cosmetics: Move syncrepo()-related variables into the function.
------------------------------------------------------------
revno: 5081
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-10-22 19:15:40 +0200
message:
  Directly create the spec file in the place where it shall end up in.
------------------------------------------------------------
revno: 5080
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-10-22 19:10:39 +0200
message:
  Drop unused variable OPT_CHANGELOG.
------------------------------------------------------------
revno: 5079
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-10-22 19:09:25 +0200
message:
  Drop pointless SPECFILE_DIR variable.
------------------------------------------------------------
revno: 5078
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-10-22 19:08:06 +0200
message:
  Drop unused variable REPO_GROUP.
------------------------------------------------------------
revno: 5077
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-10-22 19:06:45 +0200
message:
  Drop variable indirection for rsync options.
------------------------------------------------------------
revno: 5076
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-10-22 19:02:37 +0200
message:
  Move PKG_INDEX variable to a place where its components are available.
------------------------------------------------------------
revno: 5075
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-10-22 18:58:25 +0200
message:
  Rename PKGEXE variable to PKG_EXE.
  
  Both variants of the name were used, but only one was being set.
------------------------------------------------------------
revno: 5074
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-10-22 18:49:31 +0200
message:
  Remove pointless warning about ~/debbuild.
------------------------------------------------------------
revno: 5073
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-10-22 18:33:12 +0200
message:
  Reduce output verbosity during tarball extraction step.
------------------------------------------------------------
revno: 5072
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-10-22 18:26:09 +0200
message:
  Extract revision number from version.h.
  
  The current methods of extracting it are fragile and/or require Bazaar.
  Since this script if configure has been invoked, we can rely on version.h
  being available when it is run.
------------------------------------------------------------
revno: 5071
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-10-22 18:21:42 +0200
message:
  Do not overwrite a user's ~/.rpmmacros file; this is evil.
------------------------------------------------------------
revno: 5070
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-10-22 18:18:39 +0200
message:
  Refactor tarball movement to the common packaging code.
------------------------------------------------------------
revno: 5069
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-10-22 18:14:21 +0200
message:
  Factorize build subdirectory creation into the common package creation code.
------------------------------------------------------------
revno: 5068
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-10-22 18:11:47 +0200
message:
  Use a single build directory variable with a value according to distribution.
  
  This will allow some further refactoring of common package build code.
------------------------------------------------------------
revno: 5067
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-10-22 18:05:43 +0200
message:
  Drop printing list of created .rpm files to the console before quitting.
------------------------------------------------------------
revno: 5066
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-10-22 18:03:07 +0200
message:
  Build RPM packages in ./rpmbuild instead of /tmp/rpmbuild.
  
  Temporary files with fixed (or even predictable) names are a security hole.
  Apart from that, building in the local directory works just as well and
  makes the RPM build process more similar to the DEB build process.
------------------------------------------------------------
revno: 5065
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-10-22 17:56:25 +0200
message:
  Move RPMDIR cleanup to a more suitable place.
------------------------------------------------------------
revno: 5064
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-10-22 17:41:20 +0200
message:
  Mark shell script as executable.
------------------------------------------------------------
revno: 5063
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-10-22 17:32:59 +0200
message:
  Drop unnecessary 'all' target from make invocation in HIPL spec file.
------------------------------------------------------------
revno: 5062
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-10-22 17:28:15 +0200
message:
  whitespace cosmetics
------------------------------------------------------------
revno: 5061
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-10-22 17:18:50 +0200
message:
  Reduce excessive debbuild verbosity.
------------------------------------------------------------
revno: 5060
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-10-22 16:58:30 +0200
message:
  Replace 'bzr log' + cut magic with 'bzr revno'.
------------------------------------------------------------
revno: 5059
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-10-22 16:56:38 +0200
message:
  Use angular brackets in usage message to denote required parameters.
------------------------------------------------------------
revno: 5058
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-10-22 16:55:48 +0200
message:
  Add syncrepo_deb and syncrepo_rpm functions to sync independent of distro.
------------------------------------------------------------
revno: 5057
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-10-22 16:52:03 +0200
message:
  Move distro decisions from the syncrepo function into the parameter parsing.
  Now all distro decisions are collected in a single place.
------------------------------------------------------------
revno: 5056
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-10-22 16:42:30 +0200
message:
  Remove obscure ~/.debmacros test in build_deb().
  This directory has never been heard of outside of HIPL.
------------------------------------------------------------
revno: 5055
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-10-22 16:39:56 +0200
message:
  Factorize the common parts of RPM/DEB building into build_package().
------------------------------------------------------------
revno: 5054
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-10-22 16:34:14 +0200
message:
  cosmetics: Move some functions around to structure them more sensibly.
------------------------------------------------------------
revno: 5053
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-10-22 16:33:28 +0200
message:
  Get rid of one pointless variable indirection.
------------------------------------------------------------
revno: 5052
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-10-22 16:32:09 +0200
message:
  Error out with wrong or missing command line parameters.
------------------------------------------------------------
revno: 5051
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-10-22 16:29:00 +0200
message:
  Simplify parameter parsing and determining what action to perform.
------------------------------------------------------------
revno: 5050
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-10-22 16:26:00 +0200
message:
  cosmetics: Drop some unnecessary backslashes to continue lines after pipes.
------------------------------------------------------------
revno: 5049
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-10-22 16:22:41 +0200
message:
  Simplify directory creation instances with 'mkdir -p'.
  
  mkdir does not fail on an existing directory when using the '-p' option,
  so there is no need to test for the existence of the directory beforehand.
------------------------------------------------------------
revno: 5048
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-10-22 16:22:08 +0200
message:
  whitespace cosmetics
------------------------------------------------------------
revno: 5047
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-10-22 16:10:20 +0200
message:
  Drop redundant distribution checks; one distro test is enough.
------------------------------------------------------------
revno: 5046
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-10-22 16:04:53 +0200
message:
  Move 'make dist' step into the RPM/DEB construction functions.
------------------------------------------------------------
revno: 5045
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-10-22 16:01:19 +0200
message:
  Remove completely pointless printing of architecture name to the console.
------------------------------------------------------------
revno: 5044
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-10-22 16:00:28 +0200
message:
  Move cleanup of Debian directory to Debian package creation function.
------------------------------------------------------------
revno: 5043
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-10-22 15:58:18 +0200
message:
  Remove pointless and commented-out sudo support.
------------------------------------------------------------
revno: 5042
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-10-22 15:57:34 +0200
message:
  Remove pointless empty variable initializations.
------------------------------------------------------------
revno: 5041
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-10-22 15:55:00 +0200
message:
  Remove unittests README file.
  
  It only contains trivial information and breaks the autobuilder since it is not
  part of the dist tarball.  As the contained information is readily available in
  other places and just describes standard autotools features, deleting the file
  appears to be the most sensible solution to the problem.
------------------------------------------------------------
revno: 5040
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-10-22 15:50:20 +0200
message:
  cosmetics: Group specfile creation commands together.
------------------------------------------------------------
revno: 5039
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-10-22 15:49:04 +0200
message:
  Move DISTRO_RELEASE variable to a more suitable place.
------------------------------------------------------------
revno: 5038
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-10-22 15:47:40 +0200
message:
  Move some variables to a more suitable place.
------------------------------------------------------------
revno: 5037
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-10-22 15:45:30 +0200
message:
  Remove nonsensical and unused here-document.
------------------------------------------------------------
revno: 5036
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-10-22 15:35:42 +0200
message:
  Refactor specfile creation from RPM/DEB template files.
  Introduce a variable to decide which template file to use depending on
  the distro; then use that variable in a single cat invocation.
------------------------------------------------------------
revno: 5035
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-10-22 15:31:31 +0200
message:
  cosmetics: Move variable declarations closer to where they are used.
  This will allow refactoring some duplicate variable settings.
------------------------------------------------------------
revno: 5034
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-10-22 15:29:28 +0200
message:
  Remove nonsensical ls invocation; it just adds pointless verbosity.
------------------------------------------------------------
revno: 5033
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-10-22 15:21:50 +0200
message:
  Suppress output from 'make dist'.
------------------------------------------------------------
revno: 5032
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-10-22 12:41:25 +0200
message:
  Remove commented-out calls to non-existing functions.
------------------------------------------------------------
revno: 5031
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-10-22 12:38:11 +0200
message:
  Remove one pointless void* cast.
------------------------------------------------------------
revno: 5030 [merge]
committer: Rene Hummen 
branch nick: trunk
timestamp: Wed 2010-10-20 16:04:59 +0200
message:
  merged lp:~stefan.goetz/hipl/unittests revision 5008
------------------------------------------------------------
revno: 5029
committer: Andrius Bentkus 
branch nick: hipl
timestamp: Wed 2010-10-20 05:38:26 +0200
message:
  Remove useless typedef for hip_tlv_common_t.
------------------------------------------------------------
revno: 5028
committer: Miika Komu 
branch nick: trunk
timestamp: Tue 2010-10-19 10:32:16 +0300
message:
  Proper sysconf directory for Fedora and Ubuntu builds.
  
  Revision 4979 introduced stricter sysconf directory restrictions. This 
  commit changes the sysconf directory back to the original /etc (instead 
  of /usr/etc).
------------------------------------------------------------
revno: 5027
committer: Diego Biurrun 
branch nick: trunk
timestamp: Tue 2010-10-19 05:09:20 +0200
message:
  cosmetics: Move around function declarations (once again).
------------------------------------------------------------
revno: 5026
committer: Diego Biurrun 
branch nick: trunk
timestamp: Tue 2010-10-19 05:01:28 +0200
message:
  Introduce static wrappers for OpenSSL IMPLEMENT_LHASH macros.
  
  The IMPLEMENT_LHASH macros define non-static wrapper functions, but we
  need static variants of those functions. Since just writing 'static' in
  front of the macro confuses Doxygen, the addition of the static keyword
  is wrapped in another macro.
------------------------------------------------------------
revno: 5025
committer: Diego Biurrun 
branch nick: trunk
timestamp: Tue 2010-10-19 04:59:35 +0200
message:
  Remove overly verbose and outdated comment from hip_init_hadb().
------------------------------------------------------------
revno: 5024
committer: Diego Biurrun 
branch nick: trunk
timestamp: Tue 2010-10-19 04:38:50 +0200
message:
  Introduce HIP_HASHTABLE_TYPE typedef and use it to avoid OpenSSL ifdeffery.
  
  hip_ht_init() and hip_linked_list_init() have a different return type
  depending on whether OpenSSL 1.0 is available or not. The HIP_HASHTABLE_TYPE
  typedef abstracts this type so that it is not necessary to duplicate the
  function definitions/declarations that only differ in return type.
------------------------------------------------------------
revno: 5023
committer: Diego Biurrun 
branch nick: trunk
timestamp: Tue 2010-10-19 04:29:00 +0200
message:
  Get rid of pointless hip_ht_common typedef; it is just a redirection.
------------------------------------------------------------
revno: 5022
committer: Diego Biurrun 
branch nick: trunk
timestamp: Tue 2010-10-19 04:17:51 +0200
message:
  cosmetics: Group all function declarations together.
------------------------------------------------------------
revno: 5021
committer: Diego Biurrun 
branch nick: trunk
timestamp: Tue 2010-10-19 03:41:45 +0200
message:
  Do not cast the return value of hit_ht_init to the type the function return.
------------------------------------------------------------
revno: 5020
committer: Diego Biurrun 
branch nick: hipl
timestamp: Mon 2010-10-18 22:24:43 +0200
message:
  Move UNUSED macro before type declaration in parameter list.
  
  This should keep Doxygen from choking on the function declaration.
------------------------------------------------------------
revno: 5019
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2010-10-18 19:44:31 +0200
message:
  Move remaining license boilerplates out of Doxygen comment sections.
    
  The license boilerplate is the same for (almost) all files and only
  clutters the Doxygen documentation if it gets repeated for each file.
  Now the license boilerplate is separated from Doxygen comment blocks
  and moved into a separate block with standard C comments.
------------------------------------------------------------
revno: 5018
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2010-10-18 19:31:53 +0200
message:
  whitespace cosmetics
------------------------------------------------------------
revno: 5017
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2010-10-18 19:06:20 +0200
message:
  Remove duplicate @author Doxygen tags.
  
  Doxygen does not print per-function author information, so it makes no
  sense to list the same author multiple times in a file.
------------------------------------------------------------
revno: 5016
committer: Samuel Richter 
branch nick: hipl
timestamp: Mon 2010-10-18 17:02:43 +0000
message:
  Remove superfluous CFLAGS.
------------------------------------------------------------
revno: 5015
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2010-10-18 18:59:51 +0200
message:
  Switch all Doxygen over to @-syntax instead of \-syntax.
  
  The former is more commonly used throughout HIPL, now it is consistent.
------------------------------------------------------------
revno: 5014
committer: Samuel Richter 
branch nick: hipl
timestamp: Mon 2010-10-18 16:57:27 +0000
message:
  Fix creation of install directories.
------------------------------------------------------------
revno: 5013
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2010-10-18 18:49:30 +0200
message:
  Remove pointless Doxygen note refering to a license header.
------------------------------------------------------------
revno: 5012
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2010-10-18 18:48:52 +0200
message:
  cosmetics: Make GPL references under lib/tool/ uniform.
------------------------------------------------------------
revno: 5011
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2010-10-18 18:47:28 +0200
message:
  doxygen.h is not GPLed, do not claim that it is.
------------------------------------------------------------
revno: 5010
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2010-10-18 18:16:10 +0200
message:
  Do not combine @file with a filename in examples; uniformly format Doxygen.
------------------------------------------------------------
revno: 5009
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2010-10-18 18:13:00 +0200
message:
  Remove '..' from Doxygen comments, they create warnings when running doxygen.
------------------------------------------------------------
revno: 5008
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2010-10-18 18:11:28 +0200
message:
  Doxygenize top-level file documentation.
------------------------------------------------------------
revno: 5007
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2010-10-18 18:05:37 +0200
message:
  Fix Doxygen documentation of hip_check_userspace_param_type().
  
  UNUSED is a macro and not the parameter name, pass the parameter name
  to @param instead.
------------------------------------------------------------
revno: 5006
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2010-10-18 17:59:03 +0200
message:
  Remove unnecessary and harmful filename from @file Doxygen command.
------------------------------------------------------------
revno: 5005
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-10-15 17:29:14 +0200
message:
  Move license boilerplates out of Doxygen comment sections.
  
  The license boilerplate is the same for (almost) all files and only
  clutters the Doxygen documentation if it gets repeated for each file.
  Now the license boilerplate is separated from Doxygen comment blocks
  and moved into a separate block with standard C comments.
------------------------------------------------------------
revno: 5004
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-10-15 17:26:44 +0200
message:
  Remove duplicated license boilerplate.
------------------------------------------------------------
revno: 5003
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-10-15 17:20:41 +0200
message:
  Use @ syntax for Doxygen commands like in the rest of HIPL.
------------------------------------------------------------
revno: 5002
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-10-15 17:19:54 +0200
message:
  Remove pointless filename from @file Doxygen command.
------------------------------------------------------------
revno: 5001
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-10-15 17:17:22 +0200
message:
  Add missing license boilerplate.
------------------------------------------------------------
revno: 5000
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-10-15 17:01:56 +0200
message:
  Remove GPL notice from firewall/user_ipsec_esp.h.
  
  The file just contains a few #includes and function declarations, but no
  code at all. It is therefore completely trivial and not copyrightable.
  In any case the file had the HIPL MIT license boilerplate in it already.
------------------------------------------------------------
revno: 4999
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-10-15 16:34:33 +0200
message:
  Remove more pointless "this is a header" comments from header files.
------------------------------------------------------------
revno: 4998
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-10-15 16:10:02 +0200
message:
  K&R coding style cosmetics in example code
------------------------------------------------------------
revno: 4997
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-10-15 16:05:03 +0200
message:
  Remove pointless "this is a header file" comments from header files.
------------------------------------------------------------
revno: 4996
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-10-15 15:47:57 +0200
message:
  Do not cast the return value of base64_encode() to the same value it returns.
------------------------------------------------------------
revno: 4995
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-10-15 15:45:38 +0200
message:
  coding style and whitespace cosmetics
------------------------------------------------------------
revno: 4994
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-10-15 15:38:31 +0200
message:
  Do not create directories that are not used by any HIPL package.
------------------------------------------------------------
revno: 4993
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-10-15 15:37:10 +0200
message:
  Move creation of dirs used by both hipd and hipfw to the hipl-common package.
------------------------------------------------------------
revno: 4992
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-10-15 15:34:29 +0200
message:
  Remove unnecessary and unused PKG_BRANCHNAME variable.
------------------------------------------------------------
revno: 4991
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-10-15 15:33:42 +0200
message:
  whitespace and coding style cosmetics
------------------------------------------------------------
revno: 4990
committer: Miika Komu 
branch nick: trunk
timestamp: Tue 2010-10-12 08:21:09 +0300
message:
  CentOS RPM build works again.
  
  Applied a workaround from Diego to fix RPM building for CentOS. This (or 
  something similar) to make the "make bin" target work on CentOS.
  
  While the bug fix is not perfect, I have tested that it works on CentOS 
  and Fedora. If you have further improvements, please commit and ask me 
  to test.
  
  See also bug id #620327 in launchpad and the following link for more 
  information:
  
  http://fedoraproject.org/wiki/Packaging/DistTag
  
  The "rhel", "rhl" and "el" tags do not seem to work with CentOS.
------------------------------------------------------------
revno: 4989
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2010-10-11 19:47:43 +0200
message:
  whitespace/prettyprinting cosmetics
------------------------------------------------------------
revno: 4988
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2010-10-11 19:00:58 +0200
message:
  Document workaround to get HIPL to compile on CentOS 5.5.
------------------------------------------------------------
revno: 4987
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2010-10-11 17:46:33 +0200
message:
  Merge hipproxy OpenWrt package into the hipd package.
  
  The hipdnsproxy tool is only useful for hipd and not big enough to
  warrant moving it into a separate package.
------------------------------------------------------------
revno: 4986
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2010-10-11 17:42:01 +0200
message:
  Merge hipconf and hipd OpenWrt package.
  
  The hipconf tool is tiny and only useful to configure hipd, so it makes
  no sense to create a separate package for it.
------------------------------------------------------------
revno: 4985
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2010-10-11 17:40:10 +0200
message:
  Do not install static libraries into /usr/lib in OpenWrt package.
  
  Static libraries are only useful when installed in development packages,
  which is not the case here.
------------------------------------------------------------
revno: 4984
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2010-10-11 17:31:44 +0200
message:
  Fix typo in hipd OpenWrt package description.
------------------------------------------------------------
revno: 4983
committer: Christof Mroz 
branch nick: hipl
timestamp: Thu 2010-10-07 18:10:00 +0200
message:
  HACKING: How to mark up arguments, global variables and functions in doxygen.
  
  Taken from
  - globals, functions:
  http://www.stack.nl/~dimitri/doxygen/autolink.html
  - arguments:
  http://www.stack.nl/~dimitri/doxygen/commands.html#cmda
------------------------------------------------------------
revno: 4982
committer: Christoph Viethen 
branch nick: hipl
timestamp: Thu 2010-10-07 17:24:37 +0200
message:
  Add a socket parameter to hip_cert_spki_create_cert, renaming the function
  (and keeping the old one for compatibility - for now). Enables creation of
  programs which relinquish their superuser privileges right after obtaining
  a socket with local port no. < 1024, using it at a later time to
  request a certificate from hipd.
------------------------------------------------------------
revno: 4981
committer: Andrius.Bentkus@rwth-aachen.de
branch nick: master
timestamp: Wed 2010-10-06 16:22:16 +0200
message:
  Use uniform formatting, pretty printing.
------------------------------------------------------------
revno: 4980
committer: Andrius.Bentkus@rwth-aachen.de
branch nick: master
timestamp: Wed 2010-10-06 16:17:56 +0200
message:
  Fix bug when last character of rsa and dsa filenames (when using default configuration) are cut off.
  
  Second parameter of snprintf should always be the size of the available buffer.
------------------------------------------------------------
revno: 4979
committer: Diego Biurrun 
branch nick: trunk
timestamp: Tue 2010-10-05 18:45:22 +0200
message:
  Do not default SYSCONFDIR to /etc.
  
  /etc is reserved for system packages.  When compiling for /usr/local, like
  HIPL does by default, config files should be placed below /usr/local/etc.
------------------------------------------------------------
revno: 4978
committer: Diego Biurrun 
branch nick: trunk
timestamp: Tue 2010-10-05 18:40:01 +0200
message:
  Change the way we set the system configuration directory to a subdir of /etc.
  
  This is copied from PISA and simplifies upcoming changes.
------------------------------------------------------------
revno: 4977
committer: Diego Biurrun 
branch nick: trunk
timestamp: Tue 2010-10-05 18:27:10 +0200
message:
  Restore missing '/' in HIPL_HOSTS_FILE/HIPL_CONFIG_FILE #defines.
------------------------------------------------------------
revno: 4976
committer: Diego Biurrun 
branch nick: trunk
timestamp: Tue 2010-10-05 18:18:02 +0200
message:
  Replace hardcoded /etc/hip instances by HIPL_SYSCONFDIR.
------------------------------------------------------------
revno: 4975
committer: Diego Biurrun 
branch nick: trunk
timestamp: Tue 2010-10-05 18:09:41 +0200
message:
  cosmetics: fix indentation, break some overly long lines
------------------------------------------------------------
revno: 4974
committer: Diego Biurrun 
branch nick: trunk
timestamp: Tue 2010-10-05 17:11:14 +0200
message:
  Drop trailing '/' from HIPL_SYSCONFDIR definition.
  
  In the places where the #define is used, no '/' is expected and a
  duplicate '/' is added to composed strings.
------------------------------------------------------------
revno: 4973
committer: Diego Biurrun 
branch nick: trunk
timestamp: Tue 2010-10-05 17:09:27 +0200
message:
  Drop superfluous '+1' from dsa/rsa file name base length calculation.
------------------------------------------------------------
revno: 4972
committer: Diego Biurrun 
branch nick: trunk
timestamp: Tue 2010-10-05 17:07:08 +0200
message:
  Drop superfluous '/' from RSA key file path composition.
  
  HIPL_SYSCONFDIR already ends in a '/', no need to duplicate it.
------------------------------------------------------------
revno: 4971
committer: Diego Biurrun 
branch nick: trunk
timestamp: Tue 2010-10-05 16:44:04 +0200
message:
  Remove unused global variable create_configs_and_exit.
------------------------------------------------------------
revno: 4970
committer: Diego Biurrun 
branch nick: trunk
timestamp: Tue 2010-10-05 15:02:31 +0200
message:
  cosmetics: Drop unnecessary {} and align some '='.
------------------------------------------------------------
revno: 4969
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-10-01 20:00:52 +0200
message:
  Add Section and Priority fields to control file.
  
  This provides more useful metadata and avoids dpkg-buildpackage warnings.
------------------------------------------------------------
revno: 4968
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-10-01 19:59:52 +0200
message:
  Remove TODO comment regarding libhipcore, libhipconf and libhiptool.
  
  These libraries have now all been merged into libhipcore.
------------------------------------------------------------
revno: 4967
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-10-01 18:44:09 +0200
message:
  Remove long-gone --disable-gcc-warn from configure flags.
------------------------------------------------------------
revno: 4966
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-10-01 17:54:32 +0200
message:
  Move some code around to avoid a forward declaration.
------------------------------------------------------------
revno: 4965
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-10-01 17:30:25 +0200
message:
  Add comments that explain why the script is broken as-is.
------------------------------------------------------------
revno: 4964
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-10-01 17:25:10 +0200
message:
  Exit if changing to the checkout directory fails.
------------------------------------------------------------
revno: 4963
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-10-01 17:24:44 +0200
message:
  Simplify email body creation.
------------------------------------------------------------
revno: 4962
fixes bug(s): https://launchpad.net/bugs/612026
committer: Rene Hummen 
branch nick: trunk
timestamp: Thu 2010-09-30 14:07:52 +0200
message:
  replaced magic numbers in controls field by defines
------------------------------------------------------------
revno: 4961 [merge]
committer: Rene Hummen 
branch nick: trunk
timestamp: Wed 2010-09-29 15:14:49 +0200
message:
  merged lp:~stefan.goetz/hipl/hash_table_comparisons revision 4936
------------------------------------------------------------
revno: 4960
committer: Rene Hummen 
branch nick: trunk
timestamp: Wed 2010-09-29 15:12:01 +0200
message:
  autobuilder now also compiles rvs and opportunistic mode for max coverage
------------------------------------------------------------
revno: 4959
committer: Diego Biurrun 
branch nick: trunk
timestamp: Tue 2010-09-28 19:06:28 +0200
message:
  Improve autobuilder selfdocumentation.
------------------------------------------------------------
revno: 4958
committer: Diego Biurrun 
branch nick: trunk
timestamp: Tue 2010-09-28 18:30:04 +0200
message:
  Mention that the autobuilder relies on an externally updated shared repository.
------------------------------------------------------------
revno: 4957
committer: Diego Biurrun 
branch nick: trunk
timestamp: Tue 2010-09-28 18:20:57 +0200
message:
  Explain what the compile() function does; whitespace adjustments.
------------------------------------------------------------
revno: 4956
committer: Diego Biurrun 
branch nick: trunk
timestamp: Tue 2010-09-28 18:11:08 +0200
message:
  Rename check_dist() to check_dist_tarball().
  
  The new name better expresses what the function actually does.
------------------------------------------------------------
revno: 4955
committer: Diego Biurrun 
branch nick: trunk
timestamp: Tue 2010-09-28 18:10:11 +0200
message:
  Add a comment that explains what 'make distcheck' does.
------------------------------------------------------------
revno: 4954
committer: Diego Biurrun 
branch nick: trunk
timestamp: Tue 2010-09-28 18:06:30 +0200
message:
  Explain the sed commands in 'check_dist'.
------------------------------------------------------------
revno: 4953
committer: Diego Biurrun 
branch nick: trunk
timestamp: Tue 2010-09-28 18:02:57 +0200
message:
  Remove Bazaar commit hook sources.
  
  Now that we are on launchpad, they are no longer used.
------------------------------------------------------------
revno: 4952
committer: Diego Biurrun 
branch nick: trunk
timestamp: Tue 2010-09-28 15:36:50 +0200
message:
  whitespace coding style cosmetics
------------------------------------------------------------
revno: 4951
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2010-09-27 19:14:31 +0200
message:
  Check for Doxygen warnings in the autobuilder.
------------------------------------------------------------
revno: 4950
committer: Samuel Richter 
branch nick: hipl
timestamp: Mon 2010-09-27 18:07:20 +0200
message:
  update openwrt makefile to compile with recent openwrt
------------------------------------------------------------
revno: 4949
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2010-09-27 17:58:51 +0200
message:
  Have Doxygen expand macros during preprocessing, but skip the STACK_OF macro.
  
  This removes the last set of Doxygen warnings.
------------------------------------------------------------
revno: 4948 [merge]
committer: Rene Hummen 
branch nick: trunk
timestamp: Mon 2010-09-27 17:39:40 +0200
message:
  merged lp:~stefan.goetz/hipl/hash_table_comparisons revision 4935
  
  You can find additional discussion about this merge at:
  https://code.launchpad.net/~stefan.goetz/hipl/hash_table_comparisons/+merge/36660
------------------------------------------------------------
revno: 4947
committer: Rene Hummen 
branch nick: trunk
timestamp: Mon 2010-09-27 17:38:03 +0200
message:
  removed dead code
  
  header contained function definition without implementation.
------------------------------------------------------------
revno: 4946
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2010-09-27 17:30:50 +0200
message:
  Fold static keyword into IMPLEMENT_LHASH_* macro definitions.
  
  This avoids writing 'static' before each macro invocation and makes the
  macros less bizarre.  Doxygen also no longer chokes when encountering them.
------------------------------------------------------------
revno: 4945
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2010-09-27 17:08:36 +0200
message:
  Remove misleading Doxygen comments that also generate warnings.
------------------------------------------------------------
revno: 4944
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2010-09-27 16:15:51 +0200
message:
  Document two undocumented function parameters.
------------------------------------------------------------
revno: 4943
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2010-09-27 16:10:44 +0200
message:
  Remove completely bogus parameter documentation for the functions
  hip_relay_handle_relay_to() and hip_relay_handle_relay_to_in_client().
------------------------------------------------------------
revno: 4942
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2010-09-27 15:46:23 +0200
message:
  Remove documentation for non-existing parameter of hip_handle_user_msg().
------------------------------------------------------------
revno: 4941
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2010-09-27 15:35:37 +0200
message:
  Fix incorrect Doxygen command usage.
  
  When referring to function parameters, their names cannot just be prefixed
  with '@' since that character is used to denote Doxygen commands.  '@foo'
  is not a reference to the parameter 'foo', but the Doxygen command 'foo'.
  Use @a instead to mark references to function parameters as such.
------------------------------------------------------------
revno: 4940
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2010-09-27 14:50:13 +0200
message:
  Clarify how system and local #includes should be handled.
------------------------------------------------------------
revno: 4939
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2010-09-27 14:45:23 +0200
message:
  Clarify part about line length in coding style section.
------------------------------------------------------------
revno: 4938
committer: Miika Komu 
branch nick: trunk
timestamp: Sat 2010-09-25 21:30:26 +0300
message:
  Removed an unnecessary brace from the copyright clause.
  
  For some weird reason, there was a extra brace after the Aalto 
  University in the copyright clause. Fixed in all files.
------------------------------------------------------------
revno: 4937
fixes bug(s): https://launchpad.net/bugs/592197
committer: Rene Hummen 
branch nick: trunk
timestamp: Wed 2010-09-22 17:11:52 +0200
message:
  added last missing doxygen comment
------------------------------------------------------------
revno: 4936
committer: Miika Komu 
branch nick: trunk
timestamp: Wed 2010-09-22 18:09:06 +0300
message:
  Fixed a segfault in using the RVS.
  
  RVS segfaulted because the code in hip_relay_handle_relay_from() 
  referenced a NULL pointer. The bug does not affect the relay code.
------------------------------------------------------------
revno: 4935
committer: Miika Komu 
branch nick: trunk
timestamp: Wed 2010-09-22 17:58:34 +0300
message:
  Updated HACKING on bzr usage with launchpad.
  
  Rene suggested that:
  
      bzr commit --fixes lp:#BUG_ID#
  
  when fixing bugs. This will mark the bug as fixed automatically and
  should add a reference to the fix to the bug tracker. Especially, the
  later information is valuable for tracking whether a bug has been fixed
  in a new release.
------------------------------------------------------------
revno: 4934 [merge]
committer: Rene Hummen 
branch nick: trunk
timestamp: Tue 2010-09-21 13:42:14 +0200
message:
  merged lp:~stefan.goetz/hipl/swacch_narayani revision 4935
------------------------------------------------------------
revno: 4933
committer: Rene Hummen 
branch nick: trunk
timestamp: Mon 2010-09-20 16:29:13 +0200
message:
  refactoring of hip_hexdump functionality
  
  Patch as discussed on hipl-dev and contributed by Stefan G?tz.
------------------------------------------------------------
revno: 4932
committer: Christof Mroz 
branch nick: trunk
timestamp: Mon 2010-09-13 22:11:23 +0200
message:
  Fix "if(" to "if (", alignment and brace placement.
------------------------------------------------------------
revno: 4931
committer: Miika Komu 
branch nick: trunk
timestamp: Mon 2010-09-13 18:53:22 +0300
message:
  Fixed a compilation error occurring with --disable-rvs
  
  hipd/input.c: In function ???hip_receive_udp_control_packet???:
  hipd/input.c:654: error: incompatible types when assigning to type ???struct in6_addr??? from type ???struct in6_addr *???
------------------------------------------------------------
revno: 4930 [merge]
committer: Christof Mroz 
branch nick: trunk
timestamp: Mon 2010-09-13 16:03:31 +0200
message:
  Indentation and style cleanups.
------------------------------------------------------------
revno: 4929 [merge]
committer: Christof Mroz 
branch nick: trunk
timestamp: Mon 2010-09-13 16:02:38 +0200
message:
  Cleaned up hipfw startup.
  
  Avoid memleaks and NULL dereference.
  Remove die() since it's not used anymore.
------------------------------------------------------------
revno: 4928 [merge]
committer: Christof Mroz 
branch nick: trunk
timestamp: Mon 2010-09-13 16:01:31 +0200
message:
  Sanitize packet context handling (hip_packet_context)
  
  This elaborates on commit 4908.
  hip_packet_context's fields are statically allocated now, save for the
  message buffers which are allocated eactly once and then reused. The
  context is correctly reset after each packet now.
  
  hip_port_pair_t used to be typedef'd to struct hip_stateless_info.
  The only instance of the latter was in hip_packet_context, so it was
  purged in favor of the less-misleading struct hip_portpair_t.
------------------------------------------------------------
revno: 4927 [merge]
committer: Christof Mroz 
branch nick: trunk
timestamp: Mon 2010-09-13 15:59:36 +0200
message:
  Removed superfluous typedef. Some const, cosmetic and doc changes.
------------------------------------------------------------
revno: 4926
committer: Christof Mroz 
branch nick: trunk
timestamp: Mon 2010-09-06 13:51:23 +0200
message:
  Avoid possible NULL dereference.
------------------------------------------------------------
revno: 4925
committer: Rene Hummen 
branch nick: trunk
timestamp: Fri 2010-09-03 18:21:16 +0200
message:
  fixed unnecessary update right after bex
  
  heartbeat state was not initialized.
------------------------------------------------------------
revno: 4924
committer: Christof Mroz 
branch nick: trunk
timestamp: Thu 2010-09-02 21:33:25 +0200
message:
  Remove pointless temporary in read_rule_file().
------------------------------------------------------------
revno: 4923
committer: Christof Mroz 
branch nick: trunk
timestamp: Thu 2010-09-02 21:16:32 +0200
message:
  Allow empty lines in hipfw config. Cleaned up config reader.
------------------------------------------------------------
revno: 4922
committer: Rene Hummen 
branch nick: trunk
timestamp: Thu 2010-09-02 20:20:43 +0200
message:
  fixed ./configure --disable-firewall failing to build
  
  unused parameter due to conditional compilation.
------------------------------------------------------------
revno: 4921
committer: Rene Hummen 
branch nick: trunk
timestamp: Tue 2010-08-31 11:27:03 +0200
message:
  added documentation on manually triggering updates
------------------------------------------------------------
revno: 4920
committer: Christof Mroz 
branch nick: trunk
timestamp: Mon 2010-08-30 10:28:41 +0200
message:
  Fix revision 4915: indentation, add missing ntohs(), remove temporary variables.
------------------------------------------------------------
revno: 4919
committer: Christof Mroz 
branch nick: trunk
timestamp: Sun 2010-08-29 18:24:14 +0200
message:
  Don't unneccesarily repeat function name in doxygen comments.
  
  As requested by Miika:
  
  Subject: Re: [Hipl-core] [Branch ~hipl-core/hipl/trunk] Rev 4916: Comment typo.
  Date: Thu, 26 Aug 2010 10:29:00 +0300
  From: Miika Komu 
  To: hipl-core@lists.launchpad.net
   
  On 08/25/2010 07:50 PM, noreply@launchpad.net wrote:
   
  Hi,
   
  I would actually suggest to remove the unnecessary function names from
  all doxygen comments. It looks silly in doxygen and has really no
  purpose . Also, forgetting to update the duplicate name does not cause
  any doxygen warning whatsoever.
   
  http://hipl.hiit.fi/hipl/doxygen/
   
  === modified file 'hipd/close.c'
  --- hipd/close.c        2010-08-19 09:32:20 +0000
  +++ hipd/close.c        2010-08-25 16:48:22 +0000
  @@ -347,7 +347,7 @@
   }
   
   /**
  - * hip_close_create_response
  + * hip_close_send_response
    *
    * Send a before generated CLOSE_ACK packet.
    *
------------------------------------------------------------
revno: 4918
committer: Miika Komu 
branch nick: trunk
timestamp: Sun 2010-08-29 14:26:22 +0300
message:
  Removed obsolete comments regarding kernel from doc/HACKING.
  
  We don't have any kernel code anymore. Note that there is a separate
  section on the use of our indentation style with emacs.
------------------------------------------------------------
revno: 4917
committer: Mircea Gherzan 
branch nick: trunk
timestamp: Thu 2010-08-26 16:12:39 +0200
message:
  Add the mailing script for commit notification.
------------------------------------------------------------
revno: 4916
committer: Christof Mroz 
branch nick: trunk
timestamp: Wed 2010-08-25 18:48:22 +0200
message:
  Comment typo.
------------------------------------------------------------
revno: 4915 [merge]
committer: Christof Mroz 
branch nick: trunk
timestamp: Wed 2010-08-25 18:46:44 +0200
message:
  More verbose debug messages.
------------------------------------------------------------
revno: 4914
committer: Rene Hummen 
branch nick: trunk
timestamp: Wed 2010-08-25 13:43:43 +0200
message:
  fixed inconsistency in hipconf regarding manual-update
  
  hipconf would require passing of an interface as an additional parameter.
  however, this information is not process in hipd afterwards. Therefore,
  I removed the second parameter to the hipconf call.
------------------------------------------------------------
revno: 4913
committer: Rene Hummen 
branch nick: trunk
timestamp: Wed 2010-08-25 11:06:43 +0200
message:
  removed remaining code for data_packet extension
  
  This extension was removed before, however, incomplete. Especially hipd
  and hipconf still had pieces of code relating to the extension. I also
  changed the parameter list of one function as a parameter was unused
  after the code deletion.
------------------------------------------------------------
revno: 4912
committer: Miika Komu 
branch nick: trunk
timestamp: Tue 2010-08-24 20:20:54 +0300
message:
  Fixed doxygen warnings in hipd/netdev.c.
  
  /home/hipl/trunk/hipd/netdev.c:754: Warning: argument 'src_hit' of command @param is not found in the argument list of hip_netdev_trigger_bex(const hip_hit_t *src_hit_in, const hip_hit_t *dst_hit_in, const hip_lsi_t *src_lsi_in, const hip_lsi_t *dst_lsi_in, const struct in6_addr *src_addr_in, const struct in6_addr *dst_addr_in)
  /home/hipl/trunk/hipd/netdev.c:754: Warning: argument 'dst_hit' of command @param is not found in the argument list of hip_netdev_trigger_bex(const hip_hit_t *src_hit_in, const hip_hit_t *dst_hit_in, const hip_lsi_t *src_lsi_in, const hip_lsi_t *dst_lsi_in, const struct in6_addr *src_addr_in, const struct in6_addr *dst_addr_in)
  /home/hipl/trunk/hipd/netdev.c:754: Warning: argument 'src_lsi' of command @param is not found in the argument list of hip_netdev_trigger_bex(const hip_hit_t *src_hit_in, const hip_hit_t *dst_hit_in, const hip_lsi_t *src_lsi_in, const hip_lsi_t *dst_lsi_in, const struct in6_addr *src_addr_in, const struct in6_addr *dst_addr_in)
  /home/hipl/trunk/hipd/netdev.c:754: Warning: argument 'dst_lsi' of command @param is not found in the argument list of hip_netdev_trigger_bex(const hip_hit_t *src_hit_in, const hip_hit_t *dst_hit_in, const hip_lsi_t *src_lsi_in, const hip_lsi_t *dst_lsi_in, const struct in6_addr *src_addr_in, const struct in6_addr *dst_addr_in)
  /home/hipl/trunk/hipd/netdev.c:754: Warning: argument 'src_addr' of command @param is not found in the argument list of hip_netdev_trigger_bex(const hip_hit_t *src_hit_in, const hip_hit_t *dst_hit_in, const hip_lsi_t *src_lsi_in, const hip_lsi_t *dst_lsi_in, const struct in6_addr *src_addr_in, const struct in6_addr *dst_addr_in)
  /home/hipl/trunk/hipd/netdev.c:754: Warning: argument 'dst_addr' of command @param is not found in the argument list of hip_netdev_trigger_bex(const hip_hit_t *src_hit_in, const hip_hit_t *dst_hit_in, const hip_lsi_t *src_lsi_in, const hip_lsi_t *dst_lsi_in, const struct in6_addr *src_addr_in, const struct in6_addr *dst_addr_in)
  /home/hipl/trunk/hipd/netdev.c:754: Warning: The following parameters of hip_netdev_trigger_bex(const hip_hit_t *src_hit_in, const hip_hit_t *dst_hit_in, const hip_lsi_t *src_lsi_in, const hip_lsi_t *dst_lsi_in, const struct in6_addr *src_addr_in, const struct in6_addr *dst_addr_in) are not documented:
    parameter 'src_hit_in'
    parameter 'dst_hit_in'
    parameter 'src_lsi_in'
    parameter 'dst_lsi_in'
    parameter 'src_addr_in'
    parameter 'dst_addr_in'
------------------------------------------------------------
revno: 4911
committer: Miika Komu 
branch nick: trunk
timestamp: Tue 2010-08-24 20:14:01 +0300
message:
  Fixed compilation errors occuring on Fedora 13.
  
  lib/core/filemanip.c: In function check_and_create_dir:
  lib/core/filemanip.c:149: error: implicit declaration of function stat
  lib/core/filemanip.c:151: error: implicit declaration of function mkdir
  lib/core/filemanip.c: In function change_key_file_perm:
  lib/core/filemanip.c:186: error: implicit declaration of function chmod
  
  hipd/init.c: In function hip_create_file_unless_exists
  hipd/init.c:146: error: implicit declaration of function stat
------------------------------------------------------------
revno: 4910
committer: Christoph Viethen 
branch nick: trunk
timestamp: Mon 2010-08-23 14:52:59 +0200
message:
  Changed "INSTALL" to indicate that HIPL is now hosted on
  Launchpad, giving the new command line(s) needed for
  checkout.
------------------------------------------------------------
revno: 4909
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-08-20 18:38:55 +0200
message:
  misc prettyprinting cosmetics
------------------------------------------------------------
revno: 4908
committer: Christof Mroz 
branch nick: trunk
timestamp: Fri 2010-08-20 16:59:41 +0200
message:
  Clear ctx->error to 0 prior to processing each socket.
  
  Maybe that's the wrong place to patch so here's some background info.
  
  I stumbled upon this while testing hipd via two VMs, i.e. running hipd on
  both of them and ping6-ing the respective HITs. On some machines it worked
  right away but on two setups it didn't because R2 packets were perfectly
  received (i.e. HIT-to-IP resolution worked) but not processed. Turns out
  ctx->error was set to -1 before any processing even took place, so of
  course the packet was dropped at hip_run_handle_functions. As far as I can
  tell, even though ctx is bound per-packet it's a stack-allocated struct in
  hipd_main that's reused all the time so it must be cleared at one point or
  another.
  
  Well anyway, this patch solved my problems so far.
------------------------------------------------------------
revno: 4907
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-08-20 16:34:13 +0200
message:
  cosmetics: Remove tabs and trailing whitespace.
------------------------------------------------------------
revno: 4906
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-08-20 16:18:57 +0200
message:
  Employ single quotes in shell command argument to avoid escaping double quotes.
------------------------------------------------------------
revno: 4905
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-08-20 16:14:41 +0200
message:
  Redirect the output of 'bzr version-info' to a file instead of using echo.
------------------------------------------------------------
revno: 4904
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-08-20 16:11:31 +0200
message:
  Drop unnecessary empty lines from version.h.
------------------------------------------------------------
revno: 4903
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-08-20 13:14:25 +0200
message:
  Remove some unnecessary '!= NULL' expressions in if/while conditionals.
------------------------------------------------------------
revno: 4902
committer: Andrius.Bentkus@rwth-aachen.de
branch nick: version
timestamp: Thu 2010-08-19 20:18:57 +0200
message:
  Typo fix.
------------------------------------------------------------
revno: 4901
committer: Andrius.Bentkus@rwth-aachen.de
branch nick: version
timestamp: Thu 2010-08-19 18:26:27 +0200
message:
  Add build date in version information.
------------------------------------------------------------
revno: 4900
committer: Artturi Karila 
branch nick: trunk
timestamp: Thu 2010-08-19 13:43:06 +0300
message:
  Fixed compilation with --enable-midauth
  
  This was broken in r4898.
------------------------------------------------------------
revno: 4899
committer: Artturi Karila 
branch nick: trunk
timestamp: Thu 2010-08-19 12:40:48 +0300
message:
  Set 'cast discards qualifiers' to be treated as an error
  
  Removed the now obsolete --enable-gcc-warn option.
------------------------------------------------------------
revno: 4898
committer: Artturi Karila 
branch nick: trunk
timestamp: Thu 2010-08-19 12:32:20 +0300
message:
  Fixed 'cast discards qualifiers' warnings in hip_get_next_param()
  
  Since the message to iterate through is passed as a const pointer, the return
  value must be const as well. Fixing this necessitated a large number of
  additional const declarations. I added *_readwrite() versions of the functions
  also used in ways that require a non-const return.
------------------------------------------------------------
revno: 4897
committer: Diego Biurrun 
branch nick: trunk
timestamp: Wed 2010-08-18 19:57:40 +0200
message:
  Do not cast the result of hip_get_next_param() to (struct hip_tlv_common *).
  
  hip_get_next_param() returns (struct hip_tlv_common *) already.
------------------------------------------------------------
revno: 4896
committer: Diego Biurrun 
branch nick: trunk
timestamp: Wed 2010-08-18 19:47:04 +0200
message:
  Drop unnecessary '!= NULL' checks in if/while conditions.
------------------------------------------------------------
revno: 4895
committer: Diego Biurrun 
branch nick: trunk
timestamp: Wed 2010-08-18 18:59:20 +0200
message:
  Document -V option in firewall help output.
------------------------------------------------------------
revno: 4894
committer: Diego Biurrun 
branch nick: trunk
timestamp: Wed 2010-08-18 18:54:41 +0200
message:
  Document -V option in help output.
------------------------------------------------------------
revno: 4893
committer: Diego Biurrun 
branch nick: trunk
timestamp: Wed 2010-08-18 18:37:11 +0200
message:
  whitespace cosmetics: fix function indentation
------------------------------------------------------------
revno: 4892
committer: Diego Biurrun 
branch nick: trunk
timestamp: Wed 2010-08-18 18:34:37 +0200
message:
  Drop pointless void* casts from hip_get_param*() functions.
  
  The functions return void*, so there is no need to cast their return value.
------------------------------------------------------------
revno: 4891
committer: Diego Biurrun 
branch nick: trunk
timestamp: Wed 2010-08-18 18:30:31 +0200
message:
  Drop pointless void* casts from hip_get_param*() functions - hipd directory.
  
  The functions return void*, so there is no need to cast their return value.
------------------------------------------------------------
revno: 4890
committer: Diego Biurrun 
branch nick: trunk
timestamp: Wed 2010-08-18 18:21:16 +0200
message:
  whitespace cosmetics
------------------------------------------------------------
revno: 4889
committer: Diego Biurrun 
branch nick: trunk
timestamp: Wed 2010-08-18 18:14:20 +0200
message:
  Drop pointless void* casts from hip_get_param*() functions - firewall directory.
------------------------------------------------------------
revno: 4888
committer: Diego Biurrun 
branch nick: trunk
timestamp: Wed 2010-08-18 17:49:37 +0200
message:
  Remove reference to non-existing function hip_get_param_object().
------------------------------------------------------------
revno: 4887
committer: Diego Biurrun 
branch nick: trunk
timestamp: Wed 2010-08-18 15:12:07 +0200
message:
  Remove reference to removed directory lib/opphip.
------------------------------------------------------------
revno: 4886
committer: Diego Biurrun 
branch nick: trunk
timestamp: Wed 2010-08-18 15:05:50 +0200
message:
  Enable silent build rules if supported by the automake version being used.
------------------------------------------------------------
revno: 4885
committer: Andrius.Bentkus@rwth-aachen.de
branch nick: struct
timestamp: Tue 2010-08-17 19:23:18 +0200
message:
  Replace all occurences of "in6_addr_t" with "struct in6_addr_t"
------------------------------------------------------------
revno: 4884
committer: Miika Komu 
branch nick: trunk
timestamp: Thu 2010-08-12 15:07:54 +0300
message:
  Solved problems in loading network modules on Fedora.
  
  Unlike the crypto modules, it appears that network modules are not 
  visible as built-in modules. Suppressed errors of unavailable network 
  modules because at least I couldn't find out whether xfrm_user is 
  built-in or not in Fedora.
  
  If you don't like this fix, please test and contribute a better way to 
  deal with this. I can provide access to a test server if needed. The -m 
  option is not a better way because it ignores loading of modules 
  altogether.
------------------------------------------------------------
revno: 4883
committer: Artturi Karila 
branch nick: trunk
timestamp: Tue 2010-08-10 11:21:47 +0300
message:
  Fixed 'cast discards qualifiers' warning in conf.c
  
  Copy the contents of argv to a new array in hip_handle_exec_app() so that it can be called with a const char ** argv from an action handler function.
------------------------------------------------------------
revno: 4882
committer: Artturi Karila 
branch nick: trunk
timestamp: Tue 2010-08-10 10:26:42 +0300
message:
  Fixed 'cast discards qualifiers' warnings in nsupdate.c
  
  execve() doesn't take const char *, so we can't pass it a string literal.
------------------------------------------------------------
revno: 4881
committer: Artturi Karila 
branch nick: trunk
timestamp: Tue 2010-08-10 10:24:52 +0300
message:
  Fixed 'cast discards qualifiers' warnings in cert.c
  
  X509V3_EXT_conf() doesn't take const char *, so we can't pass it string literals.
------------------------------------------------------------
revno: 4880
committer: Artturi Karila 
branch nick: trunk
timestamp: Mon 2010-08-02 10:51:03 +0300
message:
  Set anonymous bit to 0 in outgoing CLOSE_ACK
  
  Also changed hip_close_ack_check_packet() to accept only packets with no control bits set.
------------------------------------------------------------
revno: 4879
committer: Artturi Karila 
branch nick: trunk
timestamp: Mon 2010-08-02 10:20:22 +0300
message:
  Corrected memcpy size in verify()
------------------------------------------------------------
revno: 4878
committer: Artturi Karila 
branch nick: trunk
timestamp: Fri 2010-07-30 15:41:09 +0300
message:
  Fixed 'cast discards qualifiers' warning in nsupdate.c
------------------------------------------------------------
revno: 4877
committer: Artturi Karila 
branch nick: trunk
timestamp: Thu 2010-07-29 16:41:29 +0300
message:
  Fixed 'cast discards qualifiers' warnings in prefix.h
  
  hip_cast_sa_addr() has to take a non-const argument so it can return a non-const pointer to the correct part of the structure.
------------------------------------------------------------
revno: 4876
committer: Artturi Karila 
branch nick: trunk
timestamp: Thu 2010-07-29 16:27:02 +0300
message:
  Fixed 'cast discards qualifiers' warnings in builder.c
  
  Un-consted parameters to functions used in ways that require the return value, based on that parameter, to be non-const.
------------------------------------------------------------
revno: 4875
committer: Artturi Karila 
branch nick: trunk
timestamp: Thu 2010-07-29 14:56:40 +0300
message:
  Fixed 'cast discards qualifiers' warnings in hiprelay.c
------------------------------------------------------------
revno: 4874
committer: Artturi Karila 
branch nick: trunk
timestamp: Thu 2010-07-29 13:40:44 +0300
message:
  Fixed 'cast discards qualifiers' warnings in hidb.c
------------------------------------------------------------
revno: 4873
committer: Artturi Karila 
branch nick: trunk
timestamp: Thu 2010-07-29 13:28:57 +0300
message:
  Fixed 'cast discards qualifiers' warning in netdev.c
------------------------------------------------------------
revno: 4872
committer: Artturi Karila 
branch nick: trunk
timestamp: Thu 2010-07-29 12:58:39 +0300
message:
  Fixed 'cast discards qualifiers' warnings in hostsfiles.c
------------------------------------------------------------
revno: 4871
committer: Artturi Karila 
branch nick: trunk
timestamp: Thu 2010-07-29 12:53:52 +0300
message:
  Fixed 'cast discards qualifiers' warnings in hostid.c
------------------------------------------------------------
revno: 4870
committer: Artturi Karila 
branch nick: trunk
timestamp: Thu 2010-07-29 12:45:26 +0300
message:
  Fixed 'cast discards qualifiers' warnings in debug.c
------------------------------------------------------------
revno: 4869
committer: Artturi Karila 
branch nick: trunk
timestamp: Thu 2010-07-29 12:28:13 +0300
message:
  Fixed 'cast discards qualifiers' warning in hadb.c
------------------------------------------------------------
revno: 4868
committer: Artturi Karila 
branch nick: trunk
timestamp: Thu 2010-07-29 12:21:55 +0300
message:
  Fixed 'cast discards qualifiers' warnings in hit_to_ip.c
  
  The second argument to hip_get_hit_to_ip_hostname() was erroneously marked const.
------------------------------------------------------------
revno: 4867
committer: Artturi Karila 
branch nick: trunk
timestamp: Thu 2010-07-29 12:12:24 +0300
message:
  Fixed 'cast discards qualifiers' warnings in user_ipsec_hipd_msg.c
------------------------------------------------------------
revno: 4866
committer: Artturi Karila 
branch nick: trunk
timestamp: Thu 2010-07-29 12:11:04 +0300
message:
  Fixed 'cast discards qualifiers' warnings in oppdb.c
------------------------------------------------------------
revno: 4865
committer: Artturi Karila 
branch nick: trunk
timestamp: Thu 2010-07-29 12:07:47 +0300
message:
  Fixed 'cast discards qualifiers' warning in oppipdb.c
------------------------------------------------------------
revno: 4864
committer: Artturi Karila 
branch nick: trunk
timestamp: Thu 2010-07-29 11:51:54 +0300
message:
  Fixed 'cast discards qualifiers' warning in cache_port.c
------------------------------------------------------------
revno: 4863
committer: Artturi Karila 
branch nick: trunk
timestamp: Thu 2010-07-29 11:42:46 +0300
message:
  Fixed 'cast discards qualifiers' warnings in esp_prot_api.c
  
  Also corrected indentation.
------------------------------------------------------------
revno: 4862
committer: Artturi Karila 
branch nick: trunk
timestamp: Thu 2010-07-29 11:31:12 +0300
message:
  Fixed 'cast discards qualifiers' warnings in conntrack.c
------------------------------------------------------------
revno: 4861
committer: Artturi Karila 
branch nick: trunk
timestamp: Thu 2010-07-29 11:11:40 +0300
message:
  Fixed 'cast discards qualifiers' warnings in lsi.c
------------------------------------------------------------
revno: 4860
committer: Miika Komu 
branch nick: trunk
timestamp: Wed 2010-07-28 15:34:55 +0300
message:
  Changed linux capability version to "generic" version.
  
  For portability as suggested by Diego on the mailing list.
------------------------------------------------------------
revno: 4859
committer: Miika Komu 
branch nick: trunk
timestamp: Mon 2010-07-26 20:23:13 +0300
message:
  A bug fix on CentOS 5.5 compilation.
  
  Played it safe with the patch. I did not use _LINUX_CAPABILITY_VERSION 
  because it now maps to _1 but can map to _2 in the future. The second 
  API may require some other changes.
  
  Note that the complete code does not still compile on CentOS 5.5.
------------------------------------------------------------
revno: 4858
committer: Miika Komu 
branch nick: trunk
timestamp: Sat 2010-07-24 19:18:00 +0300
message:
  Updated manual.
  
  Added missing iptables rules for LSIs and heartbeat in the "firewall 
  holes for HIP" section of the manual.
------------------------------------------------------------
revno: 4857
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2010-07-19 18:15:46 +0200
message:
  Add const to variable and cast to avoid the warning:
  firewall/cache.c:266: warning: cast discards qualifiers from pointer target type
------------------------------------------------------------
revno: 4856
committer: Diego Biurrun 
branch nick: trunk
timestamp: Mon 2010-07-19 18:00:22 +0200
message:
  Add const to return type of addr_to_numeric() and drop return type cast.
  
  firewall/helpers.c: In function ?addr_to_numeric?:
  firewall/helpers.c:56: warning: cast discards qualifiers from pointer target type
------------------------------------------------------------
revno: 4855
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-07-16 20:57:18 +0200
message:
  Add const to a variable declaration to avoid two casts.
------------------------------------------------------------
revno: 4854
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-07-16 20:56:20 +0200
message:
  Do not pointlessly cast void* function parameters to void*.
------------------------------------------------------------
revno: 4853
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-07-16 20:55:04 +0200
message:
  Do not pointlessly cast the return value of functions.
------------------------------------------------------------
revno: 4852
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-07-16 20:53:21 +0200
message:
  Avoid pointless double casts with intermediate void* cast.
------------------------------------------------------------
revno: 4851
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-07-16 20:20:56 +0200
message:
  Do not pointlessly cast function parameters that accept void* to void*.
------------------------------------------------------------
revno: 4850
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-07-16 20:17:47 +0200
message:
  Remove a large amount of completely pointless casts.
  
  - Do not cast the return values of functions to the value they return.
  - Do not cast function parameters of type void* to void*.
------------------------------------------------------------
revno: 4849
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-07-16 20:00:53 +0200
message:
  Remove a large amount of completely pointless casts.
  
  - Do not cast the return values of functions to the value they return.
  - Do not cast function parameters to void*.
  - Do not cast variables to the type they already have.
------------------------------------------------------------
revno: 4848
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-07-16 19:49:20 +0200
message:
  Remove pointless double casts; an intermediate cast to void* is unnecessary.
------------------------------------------------------------
revno: 4847
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-07-16 19:39:09 +0200
message:
  Add back mistakenly removed _BSD_SOURCE #define; it is needed for 'struct ip'.
------------------------------------------------------------
revno: 4846
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-07-16 19:37:23 +0200
message:
  Get rid of a large amount of pointless casts.
------------------------------------------------------------
revno: 4845
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-07-16 19:19:52 +0200
message:
  Do not pointlessly cast the return value of sk_CONF_VALUE_value to void*.
------------------------------------------------------------
revno: 4844
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-07-16 18:47:21 +0200
message:
  Use intermediate variables instead of casts for pointer comparison, fixes:
  lib/core/builder.c:740: warning: cast discards qualifiers from pointer target type
------------------------------------------------------------
revno: 4843
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-07-16 18:02:48 +0200
message:
  Get rid of some pointless casts to avoid the warnings:
  lib/core/prefix.c:220: warning: cast discards qualifiers from pointer target type
  lib/core/prefix.c:301: warning: cast discards qualifiers from pointer target type
------------------------------------------------------------
revno: 4842
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-07-16 17:51:52 +0200
message:
  Add const to a cast to avoid the warning:
  lib/core/hostid.c:272: warning: cast discards qualifiers from pointer target type
------------------------------------------------------------
revno: 4841
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-07-16 17:44:00 +0200
message:
  Add some consts, avoid a pointless void* cast to kill warnings of the sort:
  lib/core/builder.c:745: warning: cast discards qualifiers from pointer target type
  lib/core/builder.c:747: warning: cast discards qualifiers from pointer target type
  lib/core/builder.c:1313: warning: cast discards qualifiers from pointer target type
  lib/core/builder.c:1416: warning: cast discards qualifiers from pointer target type
  lib/core/builder.c:3875: warning: cast discards qualifiers from pointer target type
------------------------------------------------------------
revno: 4840
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-07-16 17:26:47 +0200
message:
  Add const qualifiers to casts to avoid the warnings:
  lib/core/debug.c:415: warning: cast discards qualifiers from pointer target type
  lib/core/debug.c:497: warning: cast discards qualifiers from pointer target type
  lib/core/debug.c:502: warning: cast discards qualifiers from pointer target type
------------------------------------------------------------
revno: 4839
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-07-16 17:26:02 +0200
message:
  Add const qualifier to cast to avoid the warning:
  lib/core/hit.c:107: warning: cast discards qualifiers from pointer target type
------------------------------------------------------------
revno: 4838
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-07-16 16:57:13 +0200
message:
  Get rid of some void* casts to avoid the warnings:
  lib/core/hostsfiles.c:221: warning: cast discards qualifiers from pointer target type
  lib/core/hostsfiles.c:246: warning: cast discards qualifiers from pointer target type
------------------------------------------------------------
revno: 4837
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-07-16 16:50:44 +0200
message:
  Add missing openssl/safestack.h #include, whitespace adjustments.
------------------------------------------------------------
revno: 4836
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-07-16 16:42:09 +0200
message:
  Add const keyword to cast to avoid the warning:
  lib/core/hashtable.c:62: warning: cast discards qualifiers from pointer target type
------------------------------------------------------------
revno: 4835
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-07-16 16:38:00 +0200
message:
  Drop unnecessary '#define _BSD_SOURCE'.
------------------------------------------------------------
revno: 4834
committer: Diego Biurrun 
branch nick: trunk
timestamp: Fri 2010-07-16 16:33:39 +0200
message:
  Drop pointless void* cast, add const to a cast to fix:
  lib/tool/checksum.c:189: warning: cast discards qualifiers from pointer target type
  lib/tool/checksum.c:198: warning: cast discards qualifiers from pointer target type
------------------------------------------------------------
revno: 4833
committer: Diego Biurrun 
branch nick: trunk
timestamp: Wed 2010-07-14 18:07:06 +0200
message:
  the grand #include cleanup - part IX: lib/core directory - .h files (rest)
     
  Add required headers, remove unnecessary headers, reorder #includes.
------------------------------------------------------------
revno: 4832
committer: Diego Biurrun 
branch nick: trunk
timestamp: Wed 2010-07-14 18:01:50 +0200
message:
  the grand #include cleanup - part VIII: lib/core directory - .h files (parts)
    
  Add required headers, remove unnecessary headers, reorder #includes.
------------------------------------------------------------
revno: 4831
committer: Diego Biurrun 
branch nick: trunk
timestamp: Wed 2010-07-14 17:58:20 +0200
message:
  the grand #include cleanup - part VII: lib/core directory - .c files
  
  Add required headers, remove unnecessary headers, reorder #includes.
------------------------------------------------------------
revno: 4830
committer: Diego Biurrun 
branch nick: trunk
timestamp: Wed 2010-07-14 17:49:59 +0200
message:
  Add missing prefix.h #include.
------------------------------------------------------------
revno: 4829
committer: Diego Biurrun 
branch nick: trunk
timestamp: Wed 2010-07-14 16:09:30 +0200
message:
  Restore HIPL_OPENSSL_100 indirection removed in r4388.
  
  For some as-of-yet unfathomable reason this is causing problems.
------------------------------------------------------------
revno: 4828
committer: Diego Biurrun 
branch nick: trunk
timestamp: Wed 2010-07-07 18:48:07 +0200
message:
  Some more #include cleanup for the firewall directory.
------------------------------------------------------------
revno: 4827
committer: Diego Biurrun 
branch nick: trunk
timestamp: Wed 2010-07-07 18:42:17 +0200
message:
  the grand #include cleanup - part VI: hipd directory
  
  Add required headers, remove unnecessary headers, reorder #includes.
------------------------------------------------------------
revno: 4826
committer: Diego Biurrun 
branch nick: trunk
timestamp: Wed 2010-07-07 18:36:30 +0200
message:
  Add missing cookie.h #include.
------------------------------------------------------------
revno: 4825
committer: Diego Biurrun 
branch nick: trunk
timestamp: Wed 2010-07-07 18:22:48 +0200
message:
  the grand #include cleanup - part V: modules directory
  
  Add required headers, remove unnecessary headers, reorder #includes.
------------------------------------------------------------
revno: 4824
committer: Diego Biurrun 
branch nick: trunk
timestamp: Wed 2010-07-07 18:03:48 +0200
message:
  Add a few missing #includes.
------------------------------------------------------------
revno: 4823
committer: Diego Biurrun 
branch nick: trunk
timestamp: Wed 2010-07-07 17:52:51 +0200
message:
  Move hadb_hit extern declaration to hadb.h where it belongs.
------------------------------------------------------------
revno: 4822
committer: Diego Biurrun 
branch nick: trunk
timestamp: Wed 2010-07-07 17:09:59 +0200
message:
  Remove unnecessary #ifdefs around harmless pisa.h #include.
------------------------------------------------------------
revno: 4821
committer: Miika Komu 
branch nick: trunk
timestamp: Wed 2010-07-07 17:45:06 +0300
message:
  Clarified licensing conditions.
------------------------------------------------------------
revno: 4820
committer: Artturi Karila 
branch nick: trunk
timestamp: Wed 2010-07-07 16:10:04 +0300
message:
  Removed obsolete firewalldb defines from icomm.h
------------------------------------------------------------
revno: 4819
committer: Artturi Karila 
branch nick: trunk
timestamp: Wed 2010-07-07 13:24:39 +0300
message:
  Fixed "Unexpected character" doxygen errors
  
  The quotes were causing errors on some systems (eg hipl.hiit.fi). Just escaping them did not fix the problem.
------------------------------------------------------------
revno: 4818
committer: Artturi Karila 
branch nick: trunk
timestamp: Wed 2010-07-07 12:37:49 +0300
message:
  Fixed doxygen warnings in esp_prot_config.c without libconfig
  
  Moved the documentation for esp_prot_wrap_config_lookup_int() so it wouldn't be applied to the next function instead.
------------------------------------------------------------
revno: 4817
committer: Artturi Karila 
branch nick: trunk
timestamp: Wed 2010-07-07 12:15:40 +0300
message:
  Restored doc/doxy/ to .bzrignore
------------------------------------------------------------
revno: 4816
committer: Artturi Karila 
branch nick: trunk
timestamp: Tue 2010-07-06 11:49:31 +0300
message:
  Fixed make doxygen warnings in hipd/pisa.h
  
  Caused by documenting (void) as a parameter in pisa.c
------------------------------------------------------------
revno: 4815
committer: Artturi Karila 
branch nick: trunk
timestamp: Tue 2010-07-06 11:48:39 +0300
message:
  Fixed make doxygen warnings in hipd/cookie.c
  
  A parameter was undocumented.
------------------------------------------------------------
revno: 4814
committer: Artturi Karila 
branch nick: trunk
timestamp: Tue 2010-07-06 11:47:55 +0300
message:
  Fixed make doxygen warnings in hipd/close.c
  
  A parameter was undocumented.
------------------------------------------------------------
revno: 4813
committer: Artturi Karila 
branch nick: trunk
timestamp: Tue 2010-07-06 11:47:03 +0300
message:
  Fixed make doxygen warnings in firewall/user_ipsec_fw_msg.c
  
  An obsolete parameters was still documented.
------------------------------------------------------------
revno: 4812
committer: Artturi Karila 
branch nick: trunk
timestamp: Tue 2010-07-06 11:46:10 +0300
message:
  Fixed make doxygen warnings in firewall/user_ipsec_esp.c
  
  Obsolete parameters were still documented.
------------------------------------------------------------
revno: 4811
committer: Artturi Karila 
branch nick: trunk
timestamp: Tue 2010-07-06 11:45:00 +0300
message:
  Fixed make doxygen warnings in firewall/sysopp.c
  
  A parameter was undocumented.
------------------------------------------------------------
revno: 4810
committer: Artturi Karila 
branch nick: trunk
timestamp: Tue 2010-07-06 11:44:06 +0300
message:
  Fixed make doxygen warnings in firewall/esp_prot_config.c
  
  A parameter was undocumented.
------------------------------------------------------------
revno: 4809
committer: Artturi Karila 
branch nick: trunk
timestamp: Tue 2010-07-06 11:43:09 +0300
message:
  Fixed make doxygen warnings in firewall/cache.c
  
  The parameter list for hip_firewall_cache_set_bex_state() was wrong.
------------------------------------------------------------
revno: 4808
committer: Artturi Karila 
branch nick: trunk
timestamp: Tue 2010-07-06 11:41:59 +0300
message:
  Fixed make doxygen warnings in lib/core/protodefs.h
  
  The group hip_tlv was not terminated. Also moved struct sockaddr_hip to out of the group.
------------------------------------------------------------
revno: 4807
committer: Artturi Karila 
branch nick: trunk
timestamp: Mon 2010-07-05 14:21:50 +0300
message:
  Removed code introduced in r4608
  
  This was a kludge to make peers switch to direct communication after relayed base exchange. It's not useful for NAT traversal and was interfering with full-relay functionality.
------------------------------------------------------------
revno: 4806
committer: Artturi Karila 
branch nick: trunk
timestamp: Mon 2010-07-05 14:14:21 +0300
message:
  Restored full-relay registration
  
  Restored code from r4608.
------------------------------------------------------------
revno: 4805
committer: Artturi Karila 
branch nick: trunk
timestamp: Mon 2010-07-05 11:34:50 +0300
message:
  Style fixes in output.c
  
  Corrected some whitespace, removed superfluous comments, condensed two #ifdef blocks into one.
------------------------------------------------------------
revno: 4804
committer: Artturi Karila 
branch nick: trunk
timestamp: Mon 2010-07-05 11:04:49 +0300
message:
  Restored relay functionality
  
  Restored code from r4608 and integrated it into the current packet handling. Modified relay code that was left in but not previously doing what it should.
------------------------------------------------------------
revno: 4803
committer: Miika Komu 
branch nick: trunk
timestamp: Sun 2010-07-04 20:54:18 +0300
message:
  Changed HIPL licensing from GPLv2 to MIT (Expat).
  
  Modified COPYING file accordingly.
------------------------------------------------------------
revno: 4802
committer: Miika Komu 
branch nick: trunk
timestamp: Sun 2010-07-04 17:21:07 +0300
message:
  Re-explained a resolved bug id (#874) verbally.
  
  Bug id 874 does not exist in the bugzilla of launchpad.
------------------------------------------------------------
revno: 4801
committer: Miika Komu 
branch nick: trunk
timestamp: Sun 2010-07-04 17:13:16 +0300
message:
  Re-explained a resolved bug id (#604) verbally.
  
  Bug id 604 does not exist in the bugzilla of launchpad.
------------------------------------------------------------
revno: 4800
committer: Miika Komu 
branch nick: trunk
timestamp: Sun 2010-07-04 14:35:17 +0300
message:
  Re-explained a resolved bug id (#212) verbally.
  
  Bug id 212 does not exist in the bugzilla of launchpad.
------------------------------------------------------------
revno: 4799
committer: Miika Komu 
branch nick: trunk
timestamp: Sun 2010-07-04 14:13:02 +0300
message:
  Re-explained a resolved bug id (#893) verbally.
  
  Bug id 893 does not exist in the bugzilla of launchpad.
------------------------------------------------------------
revno: 4798
committer: Miika Komu 
branch nick: trunk
timestamp: Sun 2010-07-04 14:07:40 +0300
message:
  Re-explained a resolved bug id (#782) verbally.
  
  Bug id 782 does not exist in the bugzilla of launchpad.
------------------------------------------------------------
revno: 4797
committer: Miika Komu 
branch nick: trunk
timestamp: Sun 2010-07-04 13:59:04 +0300
message:
  Re-explained a resolved bug id (#806) verbally.
  
  Bug id 806 does not exist in the bugzilla of launchpad.
------------------------------------------------------------
revno: 4796
committer: Miika Komu 
branch nick: trunk
timestamp: Sun 2010-07-04 13:50:23 +0300
message:
  Removed outdated bug id reference 175 and a related comment.
  
  Bug id 175 was in the kernel and has been fixed. The related comment was 
  about default algorithm which is explained in bug id 592127.
------------------------------------------------------------
revno: 4795
committer: Miika Komu 
branch nick: trunk
timestamp: Sun 2010-07-04 13:45:50 +0300
message:
  Explained resolved bug id reference 880 in the code.
  
  The bug has been closed but still referenced in the code. Added 
  explanation in the code. Note that the bug 592135 in launchpad 
  cross-references the changed part of the code.
------------------------------------------------------------
revno: 4794
committer: Miika Komu 
branch nick: trunk
timestamp: Fri 2010-07-02 17:01:11 +0300
message:
  Converted an open bug id reference in hiprelay.c to a new one.
------------------------------------------------------------
revno: 4793
committer: Artturi Karila 
branch nick: trunk
timestamp: Fri 2010-07-02 12:07:57 +0300
message:
  Corrected include guards to match current file paths
------------------------------------------------------------
revno: 4792
committer: Artturi Karila 
branch nick: trunk
timestamp: Fri 2010-07-02 11:44:53 +0300
message:
  .bzrignore cleanup
  
  Removed duplicate, outdated and pointless entries.
------------------------------------------------------------
revno: 4791
committer: Artturi Karila 
branch nick: trunk
timestamp: Fri 2010-07-02 11:08:43 +0300
message:
  Changed lmod.h include guard to match the filename
------------------------------------------------------------
revno: 4790
committer: Artturi Karila 
branch nick: trunk
timestamp: Fri 2010-07-02 11:04:51 +0300
message:
  Removed declarations of nonexistent functions in firewall.h
  
  hip_fw_init_opptcp() and hip_fw_uninit_opptcp() have been removed from firewall.c.
------------------------------------------------------------
revno: 4789
committer: Artturi Karila 
branch nick: trunk
timestamp: Fri 2010-07-02 10:59:01 +0300
message:
  Removed vestigial proxy code
------------------------------------------------------------
revno: 4788
committer: Artturi Karila 
branch nick: trunk
timestamp: Fri 2010-07-02 10:43:21 +0300
message:
  Style fixes in firewall.c
  
  Corrected some whitespace and braces.
------------------------------------------------------------
revno: 4787
committer: Rene Hummen 
branch nick: trunk
timestamp: Thu 2010-07-01 18:25:12 +0200
message:
  fixed segfault when bex is triggered externally without providing LSIs
  
  This was introduced by adding unconditional debug output in revision 4777.
------------------------------------------------------------
revno: 4786
committer: Miika Komu 
branch nick: trunk
timestamp: Thu 2010-07-01 11:25:20 +0300
message:
  Converted a number of open bug id references to new ones.
  
  More to follow when I get old bugzilla running again.
------------------------------------------------------------
revno: 4785
committer: Miika Komu 
branch nick: trunk
timestamp: Wed 2010-06-30 14:49:50 +0300
message:
  A bug fix to autoreconf handling for the latest CentOS (5.5).
  
  [hipl@hellfire trunk]$ autoreconf --install
  You should update your `aclocal.m4' by running aclocal.
  libtoolize: `config.guess' exists: use `--force' to overwrite
  libtoolize: `config.sub' exists: use `--force' to overwrite
  libtoolize: `ltmain.sh' exists: use `--force' to overwrite
  Makefile.am:217: `nodist_doc_DATA' is used but `docdir' is undefined
  autoreconf: automake failed with exit status: 1
  [hipl@hellfire trunk]$ autoreconf --version
  autoreconf (GNU Autoconf) 2.59
  ..
  [hipl@hellfire trunk]$ automake --version
  automake (GNU automake) 1.9.6
  ..
  [hipl@hellfire trunk]$ lsb_release -a
  LSB Version:	:core-3.1-ia32:core-3.1-noarch:graphics-3.1-ia32:graphics-3.1-noarch
  Distributor ID:	CentOS
  Description:	CentOS release 5.5 (Final)
  Release:	5.5
  Codename:	Final
------------------------------------------------------------
revno: 4784
committer: Miika Komu 
branch nick: trunk
timestamp: Wed 2010-06-30 14:24:04 +0300
message:
  Changed server domain name for the binary repositories.
------------------------------------------------------------
revno: 4783
committer: Artturi Karila 
branch nick: trunk
timestamp: Tue 2010-06-29 10:38:02 +0300
message:
  Fixed EDESTADDRREQ in hip_sendto_firewall()
  
  The function set the correct fields on a local sockaddr_in6 variable instead of the global one it tried to send to. Changed it to use the global hip_firewall_addr and moved the initialization to startup time.
------------------------------------------------------------
revno: 4782
committer: Artturi Karila 
branch nick: trunk
timestamp: Mon 2010-06-28 12:06:48 +0300
message:
  Added parentheses for clarity in hip_opp_get_peer_hit()
------------------------------------------------------------
revno: 4781
committer: Artturi Karila 
branch nick: trunk
timestamp: Mon 2010-06-28 11:54:15 +0300
message:
  Fixed hipconf add hi default
  
  Corrected the file name construction for loading default keys. Fixed adding of DSA keys and changed it to happen in two steps like for RSA, since only one hip_endpoint struct can be sent to the daemon at a time.
------------------------------------------------------------
revno: 4780
committer: Artturi Karila 
branch nick: trunk
timestamp: Thu 2010-06-24 10:55:42 +0300
message:
  Removed firewalldb.c
  
  Extended cache.c to cover the functionality of firewalldb.c and updated LSI and system-based opportunistic code to use the new calls. Removed now unused functions.
------------------------------------------------------------
revno: 4779
committer: Artturi Karila 
branch nick: trunk
timestamp: Thu 2010-06-24 10:43:39 +0300
message:
  Fixed false error in hip_opp_get_peer_hit()
  
  hip_sendto_user() returns the number of bytes sent on success. Changed the function description to reflect reality.
------------------------------------------------------------
revno: 4778
committer: Artturi Karila 
branch nick: trunk
timestamp: Thu 2010-06-24 09:59:04 +0300
message:
  Marked second argument hip_ht_find() const
  
  This allows us to avoid silly casts to non-const.
------------------------------------------------------------
revno: 4777
committer: Artturi Karila 
branch nick: trunk
timestamp: Wed 2010-06-23 16:59:14 +0300
message:
  Improved handling of HIP_MSG_TRIGGER_BEX
  
  The code formerly converted LSIs to in6_addr and back and sent an all-zero HIT to the daemon. Removed these unnecessary operations.
------------------------------------------------------------
revno: 4776
committer: Artturi Karila 
branch nick: trunk
timestamp: Wed 2010-06-23 16:07:24 +0300
message:
  Moved packet reinjection code from firewalldb.c to new file
  
  firewalldb.c will be removed in favor of cache.c. Since packet reinjection is not within the scope of any existing file, I created the new reinject.c.
------------------------------------------------------------
revno: 4775
committer: Artturi Karila 
branch nick: trunk
timestamp: Tue 2010-06-22 15:02:00 +0300
message:
  Fix to system-based opportunistic mode
  
  Packets were not being sent to the right handling function with LSI support disabled.
------------------------------------------------------------
revno: 4774
committer: Artturi Karila 
branch nick: trunk
timestamp: Thu 2010-06-17 13:21:51 +0300
message:
  Restored system-based opportunistic mode functionality
  
  Restored code from r4608 and modified it to work with the current code.
------------------------------------------------------------
revno: 4773
committer: Artturi Karila 
branch nick: trunk
timestamp: Wed 2010-06-16 16:10:52 +0300
message:
  Opportunistic service registration fix
  
  The incoming R1 was not being handled correctly for opportunistic mode connections. Restored unused code and code from r4608 and integrated it into the current packet handling.
------------------------------------------------------------
revno: 4772
committer: Miika Komu 
branch nick: trunk
timestamp: Wed 2010-06-16 09:02:11 +0300
message:
  A bug fix to UDP port numbering.
  
  The following problem occurred because UDP port numbers in context structure were not initialized:
  
  [hipl@hipl ~]$ hipconf get ha all
  Sending user message 22 to HIPD on socket 3
  Sent 40 bytes
  Waiting to receive daemon info.
  232 bytes received from HIP daemon
  HA is I2-SENT
   Shotgun mode is off.
   Local HIT: 2001:0019:c0ff:5d7e:d547:ec9b:37c3:44c6
   Peer  HIT: 2001:001a:2a72:f01c:d98e:311c:c76a:57c4
   Local LSI: 1.0.0.1
   Peer  LSI: 1.0.0.2
   Local IP: 193.167.187.129
   Local NAT traversal UDP port: 41904
   Peer  IP: 193.167.187.149
   Peer  NAT traversal UDP port: 79
   Peer  hostname:
------------------------------------------------------------
revno: 4771
committer: Miika Komu 
branch nick: trunk
timestamp: Tue 2010-06-15 22:28:13 +0300
message:
  Kernel module loading is not enforced anymore.
  
  Just gives a warning now.
------------------------------------------------------------
revno: 4770
committer: Miika Komu 
branch nick: trunk
timestamp: Tue 2010-06-15 22:19:18 +0300
message:
  Reverted patch 4769. xfrm_user kernel module seems necessary.
  
  It appears that vanilla Fedora 11 and 12 kernel has xfrm_user built in. 
  I'll test Fedora 13 when we have the virtual server infrastructure up 
  again. This leaves assumptions in patch 4766 invalid. I would recommend 
  loose loading of modules instead of strict. Otherwise e.g. our test 
  infrastructure (all running Fedora) does not work.
------------------------------------------------------------
revno: 4769
committer: Miika Komu 
branch nick: trunk
timestamp: Tue 2010-06-15 19:52:06 +0300
message:
  A bug fix to hipd initialization.
  
  Strict kernel module loading was introduce in revision 4766. It was not 
  tested at all:
  
  info(hipd/hipd.c:313@hipd_main): hipd pid=1811 starting
  error(hipd/init.c:357@hip_probe_kernel_modules): Unable to load xfrm_user!
  error(hipd/init.c:997@hipd_init): Unable to load the required kernel modules!
  error(hipd/hipd.c:317@hipd_main): hipd_init() failed!
  Mem overflow (core dumped)
  [root@fedor trunk]# cat /etc/redhat-release 
  Fedora release 12 (Constantine)
  
  Removed loading of xfrm_user in the initialization and it started 
  working. I hope this does not break any legacy kernels.
------------------------------------------------------------
revno: 4768
committer: Miika Komu 
branch nick: trunk
timestamp: Tue 2010-06-15 15:07:18 +0300
message:
  Indenting for wireshark README.
------------------------------------------------------------
revno: 4767
committer: Miika Komu 
branch nick: trunk
timestamp: Tue 2010-06-15 15:06:16 +0300
message:
  Updated wireshark README.
  
  HIP wireshark patches are unnecessary from 1.3.6 onwards.
------------------------------------------------------------
revno: 4766
committer: Mircea Gherzan 
branch nick: trunk
timestamp: Tue 2010-06-15 13:26:14 +0200
message:
  hipd: enforce strict behaviour on net module probing.
  Since the list of remaining modules is fairly "exotic" for
  most end-users and distributions, one does not expect them
  to be "built-in". Therefore, a modprobe failure is simply
  a proof that those modules are missing.
------------------------------------------------------------
revno: 4765
committer: Artturi Karila 
branch nick: trunk
timestamp: Tue 2010-06-15 14:09:03 +0300
message:
  registration.c cleanup
  
  Removed unnecessary line breaks and casts from void *. Corrected an instance of weird indentation.
------------------------------------------------------------
revno: 4764
committer: Mircea Gherzan 
branch nick: trunk
timestamp: Tue 2010-06-15 13:04:15 +0200
message:
  Fix a comment typo.
------------------------------------------------------------
revno: 4763
committer: Mircea Gherzan 
branch nick: trunk
timestamp: Tue 2010-06-15 12:55:55 +0200
message:
  Remove two kernel modules from the list.
  "Normal" tunneling (IPIP, 4in6, etc)  is not needed for
  the moment, as long as BEET mode is in place.
------------------------------------------------------------
revno: 4762
committer: Artturi Karila 
branch nick: trunk
timestamp: Tue 2010-06-15 13:41:42 +0300
message:
  Fixed indentation in add_ipv4_header() and add_ipv6_header()
------------------------------------------------------------
revno: 4761
committer: Artturi Karila 
branch nick: trunk
timestamp: Tue 2010-06-15 13:37:13 +0300
message:
  Fixed indentation in hip_reinject_packet()
------------------------------------------------------------
revno: 4760
committer: Artturi Karila 
branch nick: trunk
timestamp: Tue 2010-06-15 13:33:37 +0300
message:
  Fixed indentation in hip_oppdb_entry_clean_up()
------------------------------------------------------------
revno: 4759
committer: Artturi Karila 
branch nick: trunk
timestamp: Tue 2010-06-15 13:30:00 +0300
message:
  Fixed identation in hip_map_id_to_ip_from_hosts_files()
------------------------------------------------------------
revno: 4758
committer: Artturi Karila 
branch nick: trunk
timestamp: Tue 2010-06-15 13:27:36 +0300
message:
  Removed unnecessary comment from debug.c
------------------------------------------------------------
revno: 4757
committer: Miika Komu 
branch nick: trunk
timestamp: Mon 2010-06-14 20:32:04 +0300
message:
  A bug fix to receiving of IPv6 control packets.
  
  Seems like receiving of IPv6 control packets got broken at some point. 
  Error handling was wrong. Tested and works now.
------------------------------------------------------------
revno: 4756
committer: Artturi Karila 
branch nick: trunk
timestamp: Fri 2010-06-11 11:51:37 +0300
message:
  Removed forward declarations from lmod.c
------------------------------------------------------------
revno: 4755
committer: Artturi Karila 
branch nick: trunk
timestamp: Fri 2010-06-11 11:37:31 +0300
message:
  Removed forward declarations from lib/
  
  Moved functions within the file  where necessary.
------------------------------------------------------------
revno: 4754
committer: Artturi Karila 
branch nick: trunk
timestamp: Fri 2010-06-11 11:14:53 +0300
message:
  Removed forward declarations from firewall/
  
  Moved functions within the file  where necessary.
------------------------------------------------------------
revno: 4753
committer: Artturi Karila 
branch nick: trunk
timestamp: Fri 2010-06-11 11:05:59 +0300
message:
  Removed forward declarations from hipd/
  
  Moved functions within the file  where necessary.
------------------------------------------------------------
revno: 4752
committer: Artturi Karila 
branch nick: trunk
timestamp: Fri 2010-06-11 10:21:22 +0300
message:
  Fixed compilation without libconfig
  
  cfg was unused without HAVE_LIBCONFIG
------------------------------------------------------------
revno: 4751
committer: Mircea Gherzan 
branch nick: trunk
timestamp: Thu 2010-06-10 17:09:06 +0200
message:
  firewall: use kill(2) in the die() routine.
  Thou shalt not call signal handlers directly.
------------------------------------------------------------
revno: 4750 [merge]
committer: Rene Hummen 
branch nick: trunk
timestamp: Thu 2010-06-10 15:36:26 +0200
message:
  merged to launchpad's trunk
------------------------------------------------------------
revno: 4749
committer: Mircea Gherzan 
branch nick: trunk
timestamp: Wed 2010-06-09 19:16:05 +0200
message:
  lib: core: rename common_defines.h to common.h
------------------------------------------------------------
revno: 4748
committer: Mircea Gherzan 
branch nick: trunk
timestamp: Wed 2010-06-09 19:00:38 +0200
message:
  Add a marking for parameters used only by DEBUG code.
------------------------------------------------------------
revno: 4747
committer: Mircea Gherzan 
branch nick: trunk
timestamp: Wed 2010-06-09 17:28:30 +0200
message:
  Add markings for parameters used only in specific configs.
  For OPPORTUNISTIC and RVS, that is. When the respective 
  feature is enabled, the macro is "compiled-out". When the
  feature is disabled, the macro resolves to an UNUSED one.
------------------------------------------------------------
revno: 4746
committer: Mircea Gherzan 
branch nick: trunk
timestamp: Wed 2010-06-09 16:23:53 +0200
message:
  firewall: mark/remove unused parameters in PISA code.
------------------------------------------------------------
revno: 4745
committer: Mircea Gherzan 
branch nick: trunk
timestamp: Wed 2010-06-09 16:13:53 +0200
message:
  firewall: fix a signed/unsigned comparison in midauth code.
------------------------------------------------------------
revno: 4744
committer: Mircea Gherzan 
branch nick: trunk
timestamp: Wed 2010-06-09 16:05:14 +0200
message:
  midauth: mark/remove unused parameters.
------------------------------------------------------------
revno: 4743
committer: Mircea Gherzan 
branch nick: trunk
timestamp: Wed 2010-06-09 15:50:19 +0200
message:
  Add inlining warnings to the compiler flags.
  On sane, non-embedded platforms the default config does not
  yield such warnings.
------------------------------------------------------------
revno: 4742
committer: Mircea Gherzan 
branch nick: trunk
timestamp: Wed 2010-06-09 15:43:54 +0200
message:
  Add the extra warnings to the compiler flags.
------------------------------------------------------------
revno: 4741
committer: Mircea Gherzan 
branch nick: trunk
timestamp: Wed 2010-06-09 15:41:52 +0200
message:
  firewall: mark/remove the last unused parameters.
------------------------------------------------------------
revno: 4740
committer: Mircea Gherzan 
branch nick: trunk
timestamp: Wed 2010-06-09 15:25:36 +0200
message:
  firewall: fix the last signedness issues.
------------------------------------------------------------
revno: 4739
committer: Mircea Gherzan 
branch nick: trunk
timestamp: Wed 2010-06-09 15:16:09 +0200
message:
  firewall: fix some signedness issues.
------------------------------------------------------------
revno: 4738
committer: Mircea Gherzan 
branch nick: trunk
timestamp: Wed 2010-06-09 15:13:23 +0200
message:
  firewall: mark/remove some more unused parameters.
------------------------------------------------------------
revno: 4737
committer: Mircea Gherzan 
branch nick: trunk
timestamp: Wed 2010-06-09 13:54:05 +0200
message:
  hipd: fix another faulty initialization to zero.
------------------------------------------------------------
revno: 4736
committer: Mircea Gherzan 
branch nick: trunk
timestamp: Wed 2010-06-09 13:45:06 +0200
message:
  hipd: mark/remove some more unused parameters.
------------------------------------------------------------
revno: 4735
committer: Mircea Gherzan 
branch nick: trunk
timestamp: Wed 2010-06-09 12:11:04 +0200
message:
  hipd: fix two more signedness issues.
------------------------------------------------------------
revno: 4734
committer: Mircea Gherzan 
branch nick: trunk
timestamp: Wed 2010-06-09 12:00:07 +0200
message:
  hipd: conditionally compile packet loss simulation code.
  In the case of _zero_ packet loss probability, the compiler
  will figure out a comparison of random(3) against zero and 
  will generate a warning. 
------------------------------------------------------------
revno: 4733
committer: Mircea Gherzan 
branch nick: trunk
timestamp: Wed 2010-06-09 11:55:23 +0200
message:
  hipd: mark/remove some more unused parameters.
------------------------------------------------------------
revno: 4732
committer: Mircea Gherzan 
branch nick: trunk
timestamp: Wed 2010-06-09 11:31:12 +0200
message:
  hipd: fix some signedness issues.
------------------------------------------------------------
revno: 4731
committer: Mircea Gherzan 
branch nick: trunk
timestamp: Wed 2010-06-09 11:27:57 +0200
message:
  hipd: remove/mark more unused variables.
------------------------------------------------------------
revno: 4730
committer: Artturi Karila 
branch nick: trunk
timestamp: Wed 2010-06-09 11:34:27 +0300
message:
  lib/core/ header cleanup
  
  Removed unused defines.
------------------------------------------------------------
revno: 4729
committer: Mircea Gherzan 
branch nick: trunk
timestamp: Wed 2010-06-09 01:31:25 +0200
message:
  hipd: update some invocations to fit new signatures.
------------------------------------------------------------
revno: 4728
committer: Mircea Gherzan 
branch nick: trunk
timestamp: Wed 2010-06-09 01:20:28 +0200
message:
  hipd: replace a faulty initializer with memset.
------------------------------------------------------------
revno: 4727
committer: Mircea Gherzan 
branch nick: trunk
timestamp: Wed 2010-06-09 01:18:38 +0200
message:
  hipd: remove zero-initializers for global structures.
  Those variables are stored in the BSS.
------------------------------------------------------------
revno: 4726
committer: Mircea Gherzan 
branch nick: trunk
timestamp: Wed 2010-06-09 01:10:07 +0200
message:
  hipd: mark/remove some unused parameters.
------------------------------------------------------------
revno: 4725
committer: Mircea Gherzan 
branch nick: trunk
timestamp: Wed 2010-06-09 00:53:10 +0200
message:
  hipd: change a variable type from size_t to int.
  The size_t is an unsigned one, and using it for a variable that
  * takes the (possibly negative) retval of a call AND
  * is compared to zero
  makes no sense.
------------------------------------------------------------
revno: 4724
committer: Mircea Gherzan 
branch nick: trunk
timestamp: Wed 2010-06-09 00:18:46 +0200
message:
  hipd: remove forward declarations in cookie code.
------------------------------------------------------------
revno: 4723
committer: Mircea Gherzan 
branch nick: trunk
timestamp: Wed 2010-06-09 00:10:30 +0200
message:
  hipd: update xfrm-related calls.
  Some routines have one less parameter since rev 4716.
------------------------------------------------------------
revno: 4722
committer: Mircea Gherzan 
branch nick: trunk
timestamp: Tue 2010-06-08 23:33:52 +0200
message:
  test: fall back to no-parameter main().
  In this case, both argc and argv were unused.
------------------------------------------------------------
revno: 4721
committer: Mircea Gherzan 
branch nick: trunk
timestamp: Tue 2010-06-08 22:46:25 +0200
message:
  update: fix more unused parameters.
------------------------------------------------------------
revno: 4720
committer: Mircea Gherzan 
branch nick: trunk
timestamp: Tue 2010-06-08 22:16:03 +0200
message:
  update: fix keyword ordering in variable declaration.
------------------------------------------------------------
revno: 4719
committer: Mircea Gherzan 
branch nick: trunk
timestamp: Tue 2010-06-08 22:13:43 +0200
message:
  heartbeat_update: mark an unused parameter as such.
------------------------------------------------------------
revno: 4718
committer: Mircea Gherzan 
branch nick: trunk
timestamp: Tue 2010-06-08 22:06:12 +0200
message:
  heartbeat: mark unused parameters as such.
------------------------------------------------------------
revno: 4717
committer: Mircea Gherzan 
branch nick: trunk
timestamp: Tue 2010-06-08 21:56:57 +0200
message:
  lib: tool: fix signedness issues in xfrmapi code.
------------------------------------------------------------
revno: 4716
committer: Mircea Gherzan 
branch nick: trunk
timestamp: Tue 2010-06-08 21:54:28 +0200
message:
  lib: tool: remove unused parameters in xfrmapi code.
------------------------------------------------------------
revno: 4715
committer: Mircea Gherzan 
branch nick: trunk
timestamp: Tue 2010-06-08 19:06:33 +0200
message:
  lib: tool: fix build issues introduced in rev 4714.
  The xfrm_algo_parse() invocations were still retaining the 
  extra (unused) parameter.
------------------------------------------------------------
revno: 4714 [merge]
committer: Mircea Gherzan 
branch nick: trunk
timestamp: Tue 2010-06-08 16:48:16 +0200
message:
  lib: tool: fix more warning-related issues.
  * remove unused parameters
  * signedness
------------------------------------------------------------
revno: 4713
committer: Miika Komu 
branch nick: trunk
timestamp: Tue 2010-06-08 14:06:27 +0300
message:
  A bug fix to create-package.
  
  Ubuntu binary package path was formed incorrectly.
------------------------------------------------------------
revno: 4712
committer: Artturi Karila 
branch nick: trunk
timestamp: Tue 2010-06-08 10:28:34 +0300
message:
  Header cleanup in firewall/
  
  Removed unused items, static'ed functions not in external use.
------------------------------------------------------------
revno: 4711
committer: Artturi Karila 
branch nick: trunk
timestamp: Fri 2010-06-04 15:18:01 +0300
message:
  Restored registration code
  
  The REG_REQUEST parameter was not being included in I2. Restored code from r4608 to make registration work again.
------------------------------------------------------------
revno: 4710
committer: Samu Varjonen 
branch nick: trunk
timestamp: Fri 2010-06-04 11:43:21 +0300
message:
  Improved the doxygen comment for the hip_build_param_cert.
------------------------------------------------------------
revno: 4709
committer: Artturi Karila 
branch nick: trunk
timestamp: Thu 2010-06-03 15:43:56 +0300
message:
  Fixed loop on deletion from oppdb
  
  hip_oppdb_entry_clean_up() and hip_del_peer_info_entry() were calling each other before deleting the entry. Changed it to delete the hadb entry first.
------------------------------------------------------------
revno: 4708
committer: Artturi Karila 
branch nick: trunk
timestamp: Thu 2010-06-03 13:29:21 +0300
message:
  HITs in /etc/hosts fix
  
  Corrected hip_map_id_to_ip_from_hosts_files() to look for the HIT also in /etc/hosts.
------------------------------------------------------------
revno: 4707
committer: Artturi Karila 
branch nick: trunk
timestamp: Thu 2010-06-03 10:46:27 +0300
message:
  message.h cleanup
  
  Removed declarations of nonexistent functions.
------------------------------------------------------------
revno: 4706
committer: Artturi Karila 
branch nick: trunk
timestamp: Thu 2010-06-03 09:40:51 +0300
message:
  Fixed compilation with --disable-debug
  
  hip_param_type_name() was being called only from within a HIP_DEBUG() macro. Added #ifdef and moved it in front of the function calling it to make the forward declaration unnecessary.
------------------------------------------------------------
revno: 4705
committer: Rene Hummen 
branch nick: trunk
timestamp: Wed 2010-06-02 13:35:16 +0200
message:
  another go at fixing 4699
------------------------------------------------------------
revno: 4704
committer: Artturi Karila 
branch nick: trunk
timestamp: Wed 2010-06-02 14:27:31 +0300
message:
  firewall_defines.h cleanup
  
  Removed unused struct.
------------------------------------------------------------
revno: 4703
committer: Artturi Karila 
branch nick: trunk
timestamp: Wed 2010-06-02 14:14:17 +0300
message:
  esp_prot_conntrack.h cleanup
  
  Moved internal-use struct to esp_prot_conntrack.c.
------------------------------------------------------------
revno: 4702
committer: Artturi Karila 
branch nick: trunk
timestamp: Wed 2010-06-02 13:41:37 +0300
message:
  debug.h cleanup
  
  Moved defines only used locally to debug.c.
------------------------------------------------------------
revno: 4701
committer: Rene Hummen 
branch nick: trunk
timestamp: Wed 2010-06-02 11:44:06 +0200
message:
  fixing commit 4699
------------------------------------------------------------
revno: 4700
committer: Artturi Karila 
branch nick: trunk
timestamp: Wed 2010-06-02 12:13:24 +0300
message:
  Fix to my last commit
  
  Moved firewall_cache_hl_t typedef to firewall/cache.h.
------------------------------------------------------------
revno: 4699
committer: Rene Hummen 
branch nick: trunk
timestamp: Wed 2010-06-02 10:46:09 +0200
message:
  bzrhooks should not be shipped in the dist-file
  
  bzrhooks contains scripts that are used for the maintenance of hipl in
  respect to bzr. Thus, in my opinion, they should not be in the dist-file
  and should be excluded from the dist completeness test.
------------------------------------------------------------
revno: 4698
committer: Artturi Karila 
branch nick: trunk
timestamp: Wed 2010-06-02 11:12:55 +0300
message:
  icomm.h cleanup
  
  Moved defines used only by the firewall to firewall.
------------------------------------------------------------
revno: 4697
committer: Artturi Karila 
branch nick: trunk
timestamp: Wed 2010